Hi Vladislav,

Honestly, initially I had thought of using MySqlServerSidePreparedstatement.
But after discussion with Georg, I understood it was an overhead.
Even when discussed during code review with Massimo we decided to add the useserverprepstmts feature using MySqlPreparedStatement and not to use MySqlServerSidePreparedstatement.
Because this class just had a prepare and close and not a clear idea why this class was created and almost all methods are empty.

We are not removing client side prepared statement feature, both client and server side prepared statement are there and will be used  as per the needs.I am just trying to add a useserverprepstmts feature usingMySqlPreparedStatement and will be activated from the jdbc url i.e jdbc:mysql://localhost:3306/test?useServerPrepStmts=true.
If useServerPrepStmts is not used client side prepared statements will be used.

Regards
Puneet.



On Sat, Jun 7, 2014 at 3:02 PM, Vladislav Vaintroub <wlad@montyprogram.com> wrote:


> -----Original Message-----
> From: Maria-developers [mailto:maria-developers-
> bounces+wlad=montyprogram.com@lists.launchpad.net] On Behalf Of
> Puneet Dewan
> Sent: Donnerstag, 5. Juni 2014 07:43
> To: maria-developers@lists.launchpad.net
> Subject: [Maria-developers] Java Connector Coding till 5th June

Hi Puneet,

> 7.Then I saw that there is a class MySqlServerSidePreparedStatement.java,
>
> Initially I coded the prepareStatement() ,close(),and execute() in that class
> seperately.
>
> But after (Code review) discussion with Massimo, we donot need to use that
> class.

I'm curious. What were the  arguments for not using this class? That class MySqlServerSidePreparedStatement.java was created for exactly the purpose of implementing server-side prepared statements (user could choose implementation based on parameter, e.g userServerPrepStmts like in Connector/J).

If the idea is that people do not need client-side prepared statements, and server-side the only correct way to go, this is,  based on my experience, incorrect.  Often, people would want parametrized statements without the overhead of P_S (prepare, execute, close).

> Instead use MySqlPreparedStatement.java to do the same work.So made
> changes accordingly.