Hello Sergei! Sir I am stuck at one problem. Consider the case create table t1 (abc blob unique, xyz int unique); /* Insert data */ update t1 set abc = 33 where xyz =23; This is not working because xyz = 23 will require index scan and at the time of ha_update_row the inited != NONE and if inited != NONE then ha_index_read_idx_map would fail so how can I update row in case of blob unique ? In this case I think the only option left is sequential scan but that will defeat the purpose of blob unique. Regards sachin On Thu, Jul 28, 2016 at 1:10 PM, Sergei Golubchik <serg@mariadb.org> wrote:
Hi, Sachin!
On Jul 27, Sergei Golubchik wrote:
Please review branch https://github.com/SachinSetiya/server/tree/unique_index_where
Sure. Will do.
Sorry. Correction :(
I'm on vacations two weeks in August, 9th to 22nd. And I have an awful lot to do for 10.2. Naturally I won't work on 10.2 on vacations, but I will take my laptop with me and I will answer your questions and review your code. Which also means that I'd better use every minute before vacations to work on 10.2, you see...
So, I'll review you patch in a couple of weeks. Until then I can only answer questions, sorry :( And when on vacations, mind it, I will be only rarely on irc, so if I'm not there, do not wait for me, send an email, please. I will reply to your emails and I will do my reviews.
By the way, did you do a full mysql-test run? Like this:
./mtr --force --parallel 5
In fact, what I do is:
cmake -DCMAKE_BUILD_TYPE=Debug -DWITH_EMBEDDED_SERVER=ON make -j5 cd mysql-test-run script -c './mtr --force --parallel 5; ./mtr --force --parallel 5 --ps; ./mtr --force --parallel 3 --embed'
and that last command takes 4-5 hours on my laptop. I don't do that very often :) but it's throurough. You can run it overnight. Because of 'script' the complete log will be in the typescript file, so there's no need to monitor manually anything.
Regards, Sergei Chief Architect MariaDB and security@mariadb.org