Hi, Vicențiu! On Dec 20, Vicențiu Ciorbaru wrote:
On Dec 19, Vicentiu Ciorbaru wrote:
revision-id: 64149590c47d1cf6b1b227d8c90bdc23d20a8956 (mariadb-5.5.47-8-g6414959) parent(s): f89c9fc4b7b5d82c79775cb848225900b45a6b79 author: Vicențiu Ciorbaru committer: Vicențiu Ciorbaru timestamp: 2015-12-19 14:14:10 +0200 message:
MDEV-7526: TokuDB doesn't build on OS X
This patch fixes another compilation error caused by specifying attribute nonnull for all the parameters of the copyout function. This is incorrect as the function actually gets called with null parameters indirectly and thus only the output parameter should be nonnull.
ok to push
I could not find the code snippet that you are referring to. I am looking at the file:
https://github.com/Tokutek/ft-index/blob/master/util/dmt.cc
Here there seems to be no available fix. Did I look in the wrong place? The copyout function that I'm referring to has 3 or 4 parameters, not 2, as in your code snippet.
Yes, I don't think this github repository is still updated. TokuDB is now part of Percona-Server tree, that's where I'm merging it from. The snipper I was referring to is in our 10.0 tree now. But now all copyout calls have this protection, so please push your fix. Regards, Sergei Chief Architect MariaDB and security@mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/maria... https://www.percona.com/live/data-performance-conference-2016/sessions/maria...