16 Jul
2011
16 Jul
'11
6:47 p.m.
Hi, Vladislav! On Jul 16, Vladislav Vaintroub wrote:
+MYSQL_ADD_PLUGIN(sql_errlog sql_errlog.c + MODULE_ONLY MODULE_OUTPUT_NAME "sql_erlg")
why non-default module output name?
I think MODULE_OUTPUT_NAME should only be used when converting old plugins that have to keep non-default module name for compatibility reasons.
Correct. I was wondering about why MODULE_ONLY too in this case. Is it bad to optionally link this into the server statically?
new plugins don't need to use MODULE_OUTPUT_NAME at all.
MYSQL_ADD_PLUGIN(sql_errlog sql_errlog.c) should normally be just enough.
Agree. It's very good that in MYSQL_ADD_PLUGIN macro you tried to pick reasonable defaults and to keep amount of boilerplate code to a minimum. Regards, Sergei