Re: [Maria-developers] aeb3432849e: MDEV-20076: SHOW GRANTS does not quote role names properly

Hi, Oleksandr! On Nov 06, Oleksandr Byelkin wrote:

revision-id: aeb3432849e (mariadb-10.3.19-2-gaeb3432849e) parent(s): 5d3bd2b75b5 author: Oleksandr Byelkin committer: Oleksandr Byelkin timestamp: 2019-11-06 12:35:19 +0100 message:

MDEV-20076: SHOW GRANTS does not quote role names properly

Quotes added to output.

+# +# MDEV-20076: SHOW GRANTS does not quote role names properly +# +create role 'role-1'; +create user 'user-1'@'localhost'; +grant select on mysql.user to 'role-1'; +GRANT 'role-1' TO 'user-1'@'localhost'; +show grants for 'role-1'; +Grants for role-1 +GRANT USAGE ON *.* TO 'role-1' +GRANT SELECT ON `mysql`.`user` TO 'role-1' +show grants for 'user-1'@'localhost'; +Grants for user-1@localhost +GRANT 'role-1' TO 'user-1'@'localhost' +GRANT USAGE ON *.* TO 'user-1'@'localhost' +drop role 'role-1'; +drop user 'user-1'@'localhost';

Please, add a test for names that contains a single quote. Like create role `role'1`; create user `user'1`@localhost; and the rest as in your test above. Or, if you want it to look a bit less artificial create role `rock'n'roll`; create user `O'Brien`@localhost; Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org