Hi everyone,
I have updated the attached patch to apply to the 5.1 tree. Please see
the comments in my original mail below.
Any objections to apply this patch?
-------- Original Meddelelse --------
Subject: Separate builddir from src dir with cmake
Date: Mon, 12 Jul 2010 14:01:23 +0200
From: Bo Thorsen
Organization: Monty Program AB
To: maria-developers@lists.launchpad.net
Hi people,
Our cmake scripts weren't able to build outside the source dir. This is
bad for 3 reasons:
- it's supposed to work
- cmake recommends building outside the src dir
- on Windows, cmake can't build 32 and 64 bit in the same solution, so
patches has to be manually copied to test compilation on the other
The attached patch fixes all the issues. I ran a find on the source dir
before and after the the build, and they were identical. I didn't
actually check that no existing files we're modified, but bzr di claim
this isn't the case.
I didn't port the zip creation script, but that shouldn't be a problem.
src != blddir is more a development thing, and the buildbot slave
producing the zip file will just continue to build in the same dir. The
cpack installer builds just fine.
OK to push to 5.1?
Should I send this patch to the Oracle as well to minimize the drift
between the cmake files?
Bo Thorsen.
Monty Program AB.
--
MariaDB: MySQL replacement
Community developed. Feature enhanced. Backward compatible.
