Hi, Alexander, On Jan 09, Alexander Barkov wrote:
Hello Sergei,
This is a new version:
I've looked at the diff of this and previous commit excluding InnoDB. Only one comment, about Lex_ident_routine::check_routine_name_with_error() and Lex_ident_fs::check_table_name(). Why do they have different semantics? The former is a static method and takes the name as an argument. The latter checks `this`, needs a Lex_ident_fs to be constructed first. It's confusing, can you modify one of these methods to work like the other? I believe the generated code is the same either way, so it's only a question of consistency and predictability. Also, I'd suggest you rename them to "check_name", I feel that Lex_ident_routine::check_routine_name_with_error() is a bit redundant. Same for check_table_name(). Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org