Oh sorry, the version in the first branch name is incorrect, it should be bb-11.4-MDEV-24486, of course.
Thanks, Sergei and Daniel. I addressed your comments and force-pushed the updated branches (bb-10.4-MDEV-24486 and bb-10.6-MDEV-24486).
On Tue, Nov 21, 2023 at 9:47 AM Sergei Golubchik via developers
<developers@lists.mariadb.org> wrote:
>
> Hi, Oleg,
>
> ok to push.
> Just one comment below.
>
> On Nov 20, Oleg Smirnov wrote:
> > revision-id: dadcf5ed7b1 (mariadb-11.0.1-259-gdadcf5ed7b1)
> > parent(s): b8f9f796ff8
> > author: Oleg Smirnov
> > committer: Oleg Smirnov
> > timestamp: 2023-11-20 19:35:36 +0700
> > message:
> >
> > MDEV-24486 Add `table_privileges` view to the `sys` schema
> >
> > The existing INFORMATION_SCHEMA.TABLE_PRIVILEGES displays only those
> > privileges that were specifically granted on the table level,
> > whereas it may be useful to see privileges granted at the database
> > and global level.
> >
> > diff --git a/scripts/sys_schema/NEWS.md b/scripts/sys_schema/NEWS.md
> > index 7aeefb7edf9..12ce1382b75 100644
> > --- a/scripts/sys_schema/NEWS.md
> > +++ b/scripts/sys_schema/NEWS.md
> > @@ -1,5 +1,12 @@
> > # Change history for the MySQL sys schema
> >
> > +## 1.5.2 (11/20/23)
Nit - rest of the file uses a DD/MM/YYYY format rather than wonky US format.
Happy to see ISO8601 as an alternative to see ambiguity squashed.
--
Best regards,
-------------------------
Oleg Smirnov
Software Engineer
MariaDB Server Team
--
Best regards,
-------------------------
Oleg Smirnov
Software Engineer
MariaDB Server Team