"slb.songlibing--- via developers" <developers@lists.mariadb.org> writes:
Hi Kristian, Thanks for the detail review.
First of all, about the name --binlog-commit-by-rotate-threshold, It is better than free flush. but IMHO, rotate cannot show the feature directly. Rotate is just an effect of the feature. So how about to name it --binlog-commit-by-rename-threshold? I already used 'rename' in comments and function names.
I would go along with --binlog-fast-rotate-threshold Rename or copy in the name hardly make sense for a plain user. And 'fast' sounds to me as something exceptional to --max-binlog-size=# Binary log will be rotated automatically when the size exceeds this value. which clearly needs mentioning (sql/sys_vars.cc) of the exception the current work introduces.