Re: [Maria-developers] Patch for unaligned word access in CONNECT storage engine

Hi, Kristian! Yes, it is maintained, I've forwarded your email to the maintainer. On Oct 21, Kristian Nielsen wrote:

Sender: Maria-developers From: Kristian Nielsen To: MariaDB Developers Subject: [Maria-developers] Patch for unaligned word access in CONNECT storage engine Date: Fri, 21 Oct 2016 23:16:45 +0200 List-Archive: http://lists.launchpad.net/maria-developers

Who should be contacted about issues in the CONNECT storage engine?

The attached patch is from Debian Bug#838914

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=838914

Apparently the code does direct unaligned accesses of word data. This works fine on the x86 architecture, but on some other architectures (like MIPS), it causes a bus error.

In other places in the server code, the similar issue is handled correctly with uint4korr() and similar macros (though these also deal with byte order).

I think the patch (or something similar) is good and should be upstreamed. But I am not sure how the CONNECT storage engine is maintained - should this go directly into MariaDB? If there is an upstream maintained CONNECT storage engine, probably it should preferably go there first?

- Kristian.g

Regards, Sergei Chief Architect MariaDB and security@mariadb.org