Hi, Oleksandr! On Dec 23, Oleksandr Byelkin wrote:
22.12.2012 21:28, Sergei Golubchik пишет:
@@ -100,6 +101,8 @@ struct st_dynamic_column_value
typedef struct st_dynamic_column_value DYNAMIC_COLUMN_VALUE;
+/* old functions (deprecated) */ I usually prefer code to comments. Kind of a comment that a compiler can make use of. That means an assert(aaa == 0) instead of /* aaa should be 0 here */ and instead of comment above, I'd rather have __attribute__((deprecated))
__attribute__((deprecated)) is GCC, we also use MS compiler. So ifdef is better until we get appropriate multi-platform macro.
1. __attribute__ is defined to be empty for other compilers (somewhere in my_global.h, I guess), so it won't break the compilation. 2. I did not mean to use it instead of the #ifdef, I mean to use it instead of a /* old functions (deprecated) */ comment. Because a compiler cannot read the comment. 3. And anyway, it was just a suggestion, you can keep your current code and not change anything. As you prefer.
everything else will be fixed.
Thanks! Regards, Sergei