Hi, Oleksandr! On Nov 24, Oleksandr Byelkin wrote:
On Nov 23, Oleksandr Byelkin wrote:
diff --git a/include/mysql.h b/include/mysql.h index f088ad6..d398734 100644 --- a/include/mysql.h +++ b/include/mysql.h @@ -270,7 +270,7 @@ typedef struct st_mysql unsigned long thread_id; /* Id for connection in server */ unsigned long packet_length; unsigned int port; - unsigned long client_flag,server_capabilities; + unsigned long long client_flag,server_capabilities; This is an incompatible change, it breaks the ABI. If we have to have this change in libmysqlclient, you can put the new flags in the extension area. But, really, perhaps you should switch to Connector/C? The problem is that we have to remove CLIENT_PROGRESS (there is no such flag in mysql) Right. So either we can keep CLIENT_PROGRESS in libmysqlclient or remove it. As we're moving to Connector/C, I think it might be ok to remove it, for MySQL compatibility. Or we can keep it for a while, for compatibility with older MariaDB clients.
Either change does not break the ABI. OK, then I'll also remove client translation of PROGRESS you liked (as well as all client code).
Ok, but I think it'll be needed in Connector/C, when it connects to the old MariaDB server. Regards, Sergei