22 Oct
2020
22 Oct
'20
5:40 p.m.
Hi, Anel! On Oct 22, Anel Husakovic wrote:
Hi Sergei, thank you for your review. How is easier for you (or to ask a general question: how does the review process go?) regarding the commits? Is it better to add a new commit as a review commit and if the patch gets accepted to squash after, or to rebase commits and send only a single commit again for the review?
One single commit is better, thanks. At least for small patches.
Addressed in the new patch: https://github.com/MariaDB/server/commit/99c144762514d4dea3b6ec395de96aaf108...
Thanks! I'll reply to the commit directly. Regards, Sergei VP of MariaDB Server Engineering and security@mariadb.org