24 Feb
2024
24 Feb
'24
9:51 p.m.
Hi, Alexander, On Feb 24, Alexander Barkov wrote:
revision-id: f22662c36b1 (mariadb-10.11.7-6-gf22662c36b1) parent(s): 656f8867720 author: Alexander Barkov committer: Alexander Barkov timestamp: 2024-02-15 18:11:03 +0400 message:
MDEV-33442 REPAIR TABLE corrupts UUIDs
Looks quite good. A question: you removed a hard-coded check for MYSQL_TYPE_NEWDECIMAL, but I don't see that you added Type_handler_olddecimal::type_handler_for_implicit_upgrade() A suggestion, rename Column_definition_implicit_upgrade(). You've changed its semantics, it's good to make sure that the code using old Column_definition_implicit_upgrade() (added e.g. in 10.6 and merged up) won't compile. Regards, Sergei Chief Architect, MariaDB Server and security@mariadb.org