2 Nov
2023
2 Nov
'23
7:54 p.m.
Hi! On Mon, 30 Oct 2023 at 13:57, Sergei Golubchik <serg@mariadb.org> wrote:
I'd say that all these multi-line functions can be declared the old way.
Have no objections. Extracted them as standalone static functions.
diff --git a/sql/xa.cc b/sql/xa.cc index 234d2a6dccc..97a62f0f095 100644 --- a/sql/xa.cc +++ b/sql/xa.cc @@ -140,6 +140,7 @@ class XID_cache_element { XID_cache_element *element= (XID_cache_element*) (ptr + LF_HASH_OVERHEAD); element->m_state= 0; + new(&element->xid) XID();
why is that? XID::XID isn't doing anything
The field initialization was missing after I made XA_data. Probably that's why some tests were failing after that update. -- Yours truly, Nikita Malyavin