Hi!
It think it should be fairly clear to users if the value is innodb-log-file-mmap=false or innodb-log-file-mmap=none.
Users are already familiar with innodb-use-native-aio=false on all platforms that do not support it. I still feel strongly that having system variables that appear and disappear without external reasons is confusing to users, and this innodb-log-file-mmap is now the first system variable that has that behaviour.
Sure, I can help test pmem support on various platforms. But it will never be 100% on all platforms, so this variable visibility needs to be addressed separately.
OK. What would be the procedure to get a particular branch or commit tested on Debian Salsa CI?
salsa.debian.org is open for anyone, so if you want, you can register an account, fork, push changes etc and see the Salsa CI run. In this case however it only runs for amd64. The issue I describe is only visible on other architectures after upload to Debian archives, which triggered ci.debian.net runs (which is separate from Salsa CI). It is probably just easier that you push email me a patch or share me an url where I can download it, and I can do the testing for you.
Also, just to confirm, you recent work on pmem features means that pmem is still intended to be in MariaDB and the removal in https://github.com/MariaDB/server/commit/8e663f5e9041e8e0998c792bf8d0c297a8b... has been reverted?
Like that commit message says, the PMEM support was only removed from the 10.6 branch, where it made practically no performance difference.
Yes it mentions that but the message isn't clear about what it is referring to by "PMEM support", and metadata shows the commit was merged on all branches (as everything in MariaDB is). ..
I was about to follow suite in Debian in https://salsa.debian.org/mariadb-team/mariadb-server/-/merge_requests/86 but I guess I should not anymore?
A dependency on libpmem was removed from all MariaDB Server versions, so anything related to that should also be removed from any Debian downstream packaging.
InnoDB only ever needed pmem_persist() from that library, to control the flushing of some cache lines.
Thanks for the clarification. With this additional context I understand now that https://github.com/MariaDB/server/commit/3f9f5ca48e6be55613926964314f550c8ca... re-implemented that function in MariaDB and thus the pmem library can be removed everywhere, but that MariaDB continues to use pmem kernel API in 10.11+.