- developers - lists.mariadb.org

[Maria-developers] New (by Igor): Backport BKA (105)
by worklog-noreply＠askmonty.org 10 Mar '10

10 Mar '10

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Backport BKA CREATION DATE..: Wed, 10 Mar 2010, 19:07 SUPERVISOR.....: Monty IMPLEMENTOR....: Igor COPIES TO......: Igor, Monty, Psergey, Sergei, Timour CATEGORY.......: Server-Sprint TASK ID........: 105 (http://askmonty.org/worklog/?tid=105) VERSION........: Server-5.3 STATUS.........: Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 32 (hours remain) ORIG. ESTIMATE.: 32 PROGRESS NOTES: DESCRIPTION: The goal of this task is to back-port the optimizations that use join buffers from the MySQL 6.0 code line into MariaDB 5.3 code. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] New (by Igor): Backport BKA (105)
by worklog-noreply＠askmonty.org 10 Mar '10

10 Mar '10

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Backport BKA CREATION DATE..: Wed, 10 Mar 2010, 19:07 SUPERVISOR.....: Monty IMPLEMENTOR....: Igor COPIES TO......: Igor, Monty, Psergey, Sergei, Timour CATEGORY.......: Server-Sprint TASK ID........: 105 (http://askmonty.org/worklog/?tid=105) VERSION........: Server-5.3 STATUS.........: Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 32 (hours remain) ORIG. ESTIMATE.: 32 PROGRESS NOTES: DESCRIPTION: The goal of this task is to back-port the optimizations that use join buffers from the MySQL 6.0 code line into MariaDB 5.3 code. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] [Branch ~maria-captains/maria/5.1] Rev 2830: Fix for Bug #534626 MyISAM table created in MariaDB not readable by MySQL
by noreply＠launchpad.net 10 Mar '10

10 Mar '10

------------------------------------------------------------ revno: 2830 committer: Michael Widenius <monty(a)askmonty.org> branch nick: maria-5.1 timestamp: Wed 2010-03-10 21:00:34 +0200 message: Fix for Bug #534626 MyISAM table created in MariaDB not readable by MySQL modified: storage/myisam/mi_create.c -- lp:maria https://code.launchpad.net/~maria-captains/maria/5.1 Your team Maria developers is subscribed to branch lp:maria. To unsubscribe from this branch go to https://code.launchpad.net/~maria-captains/maria/5.1/+edit-subscription.

1 0

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2830) Bug#534626
by Michael Widenius 10 Mar '10

10 Mar '10

#At lp:maria based on revid:monty@askmonty.org-20100310135540-mm65on3y6vktzpoy 2830 Michael Widenius 2010-03-10 Fix for Bug #534626 MyISAM table created in MariaDB not readable by MySQL modified: storage/myisam/mi_create.c per-file messages: storage/myisam/mi_create.c Don't set HA_OPTION_NULL_FIELDS if table is not using CHECKSUM as this makes the table incompatible with MySQL. === modified file 'storage/myisam/mi_create.c' --- a/storage/myisam/mi_create.c 2010-01-14 16:51:00 +0000 +++ b/storage/myisam/mi_create.c 2010-03-10 19:00:34 +0000 @@ -175,6 +175,13 @@ int mi_create(const char *name,uint keys } } + /* + Don't set HA_OPTION_NULL_FIELDS if no checksums, as this flag makes + that file incompatible with MySQL. This is ok, as this flag is only + used if one specifics table level checksums. + */ + if (!(options & HA_OPTION_CHECKSUM)) + options&= ~HA_OPTION_NULL_FIELDS; if (packed || (flags & HA_PACK_RECORD)) options|=HA_OPTION_PACK_RECORD; /* Must use packed records */ /* We can't use checksum with static length rows */

1 0

[Maria-developers] New (by Psergey): Backport 6.0 subquery code to MariaDB 5.3 (104)
by worklog-noreply＠askmonty.org 10 Mar '10

10 Mar '10

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Backport 6.0 subquery code to MariaDB 5.3 CREATION DATE..: Wed, 10 Mar 2010, 18:54 SUPERVISOR.....: Igor IMPLEMENTOR....: Psergey COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 104 (http://askmonty.org/worklog/?tid=104) VERSION........: Server-5.3 STATUS.........: Complete PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Backport 6.0 subquery code to MariaDB 5.3 ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] New (by Psergey): Backport 6.0 subquery code to MariaDB 5.3 (104)
by worklog-noreply＠askmonty.org 10 Mar '10

10 Mar '10

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Backport 6.0 subquery code to MariaDB 5.3 CREATION DATE..: Wed, 10 Mar 2010, 18:54 SUPERVISOR.....: Igor IMPLEMENTOR....: Psergey COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 104 (http://askmonty.org/worklog/?tid=104) VERSION........: Server-5.3 STATUS.........: Complete PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Backport 6.0 subquery code to MariaDB 5.3 ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] [Branch ~maria-captains/maria/5.1] Rev 2829: Automatic merge
by noreply＠launchpad.net 10 Mar '10

10 Mar '10

Merge authors: Michael Widenius (monty) ------------------------------------------------------------ revno: 2829 [merge] committer: Michael Widenius <monty(a)askmonty.org> branch nick: maria-5.1 timestamp: Wed 2010-03-10 15:55:40 +0200 message: Automatic merge modified: mysql-test/r/foreign_key.result mysql-test/t/foreign_key.test sql/sql_delete.cc -- lp:maria https://code.launchpad.net/~maria-captains/maria/5.1 Your team Maria developers is subscribed to branch lp:maria. To unsubscribe from this branch go to https://code.launchpad.net/~maria-captains/maria/5.1/+edit-subscription.

1 0

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2829)
by Michael Widenius 10 Mar '10

10 Mar '10

#At lp:maria based on revid:knielsen@knielsen-hq.org-20100310103214-4ao08thvv174zwv6 2829 Michael Widenius 2010-03-10 [merge] Automatic merge modified: mysql-test/r/foreign_key.result mysql-test/t/foreign_key.test sql/sql_delete.cc === modified file 'mysql-test/r/foreign_key.result' --- a/mysql-test/r/foreign_key.result 2001-09-28 05:05:54 +0000 +++ b/mysql-test/r/foreign_key.result 2010-03-10 13:39:02 +0000 @@ -1,4 +1,4 @@ -drop table if exists t1; +drop table if exists t1,t2; create table t1 ( a int not null references t2, b int not null references t2 (c), @@ -13,3 +13,30 @@ foreign key (a,b) references t3 (c,d) on create index a on t1 (a); create unique index b on t1 (a,b); drop table t1; +create table t1 (id int primary key) engine = innodb; +create table t2 (id int PRIMARY KEY, FOREIGN KEY (id) REFERENCES t1(id)) engine=innodb; +insert into t1 values (1), (2), (3), (4), (5), (6); +insert into t2 values (3), (5); +delete from t1; +ERROR 23000: Cannot delete or update a parent row: a foreign key constraint fails (`test`.`t2`, CONSTRAINT `t2_ibfk_1` FOREIGN KEY (`id`) REFERENCES `t1` (`id`)) +select * from t1; +id +1 +2 +3 +4 +5 +6 +delete ignore from t1; +Warnings: +Error 1451 Cannot delete or update a parent row: a foreign key constraint fails (`test`.`t2`, CONSTRAINT `t2_ibfk_1` FOREIGN KEY (`id`) REFERENCES `t1` (`id`)) +Error 1451 Cannot delete or update a parent row: a foreign key constraint fails (`test`.`t2`, CONSTRAINT `t2_ibfk_1` FOREIGN KEY (`id`) REFERENCES `t1` (`id`)) +select row_count(); +row_count() +-1 +select * from t1; +id +3 +5 +drop table t2; +drop table t1; === modified file 'mysql-test/t/foreign_key.test' --- a/mysql-test/t/foreign_key.test 2005-07-28 00:22:47 +0000 +++ b/mysql-test/t/foreign_key.test 2010-03-10 13:39:02 +0000 @@ -2,8 +2,10 @@ # Test syntax of foreign keys # +-- source include/have_innodb.inc + --disable_warnings -drop table if exists t1; +drop table if exists t1,t2; --enable_warnings create table t1 ( @@ -23,3 +25,23 @@ create unique index b on t1 (a,b); drop table t1; # End of 4.1 tests + +# +# Test DELETE IGNORE +# Bug#44987 DELETE IGNORE and FK constraint +# + +create table t1 (id int primary key) engine = innodb; +create table t2 (id int PRIMARY KEY, FOREIGN KEY (id) REFERENCES t1(id)) engine=innodb; +insert into t1 values (1), (2), (3), (4), (5), (6); +insert into t2 values (3), (5); + +--error 1451 +delete from t1; +select * from t1; + +delete ignore from t1; +select row_count(); +select * from t1; +drop table t2; +drop table t1; === modified file 'sql/sql_delete.cc' --- a/sql/sql_delete.cc 2010-03-04 08:03:07 +0000 +++ b/sql/sql_delete.cc 2010-03-10 13:55:40 +0000 @@ -335,8 +335,11 @@ bool mysql_delete(THD *thd, TABLE_LIST * InnoDB it can fail in a FOREIGN KEY error or an out-of-tablespace error. */ - error= 1; - break; + if (!select_lex->no_error) + { + error= 1; + break; + } } } else

1 0

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2826) Bug#44987
by Michael Widenius 10 Mar '10

10 Mar '10

#At lp:maria based on revid:monty@askmonty.org-20100309192224-ycijqc2xxv8v9dai 2826 Michael Widenius 2010-03-10 Fix for: Bug#44987 DELETE IGNORE and FK constraint - Now DELETE IGNORE skips over rows with a foreign key constraints (as it was supposed to do) modified: mysql-test/r/foreign_key.result mysql-test/t/foreign_key.test sql/sql_delete.cc per-file messages: mysql-test/r/foreign_key.result Test case for Bug#44987 DELETE IGNORE and FK constraint mysql-test/t/foreign_key.test Test case for Bug#44987 DELETE IGNORE and FK constraint sql/sql_delete.cc Firx for Bug#44987 DELETE IGNORE and FK constraint Now DELETE IGNORE skips over rows with a foreign key constraints (as it was supposed to do) Bug fix inspired by: Moritz Mertinkat === modified file 'mysql-test/r/foreign_key.result' --- a/mysql-test/r/foreign_key.result 2001-09-28 05:05:54 +0000 +++ b/mysql-test/r/foreign_key.result 2010-03-10 13:39:02 +0000 @@ -1,4 +1,4 @@ -drop table if exists t1; +drop table if exists t1,t2; create table t1 ( a int not null references t2, b int not null references t2 (c), @@ -13,3 +13,30 @@ foreign key (a,b) references t3 (c,d) on create index a on t1 (a); create unique index b on t1 (a,b); drop table t1; +create table t1 (id int primary key) engine = innodb; +create table t2 (id int PRIMARY KEY, FOREIGN KEY (id) REFERENCES t1(id)) engine=innodb; +insert into t1 values (1), (2), (3), (4), (5), (6); +insert into t2 values (3), (5); +delete from t1; +ERROR 23000: Cannot delete or update a parent row: a foreign key constraint fails (`test`.`t2`, CONSTRAINT `t2_ibfk_1` FOREIGN KEY (`id`) REFERENCES `t1` (`id`)) +select * from t1; +id +1 +2 +3 +4 +5 +6 +delete ignore from t1; +Warnings: +Error 1451 Cannot delete or update a parent row: a foreign key constraint fails (`test`.`t2`, CONSTRAINT `t2_ibfk_1` FOREIGN KEY (`id`) REFERENCES `t1` (`id`)) +Error 1451 Cannot delete or update a parent row: a foreign key constraint fails (`test`.`t2`, CONSTRAINT `t2_ibfk_1` FOREIGN KEY (`id`) REFERENCES `t1` (`id`)) +select row_count(); +row_count() +-1 +select * from t1; +id +3 +5 +drop table t2; +drop table t1; === modified file 'mysql-test/t/foreign_key.test' --- a/mysql-test/t/foreign_key.test 2005-07-28 00:22:47 +0000 +++ b/mysql-test/t/foreign_key.test 2010-03-10 13:39:02 +0000 @@ -2,8 +2,10 @@ # Test syntax of foreign keys # +-- source include/have_innodb.inc + --disable_warnings -drop table if exists t1; +drop table if exists t1,t2; --enable_warnings create table t1 ( @@ -23,3 +25,23 @@ create unique index b on t1 (a,b); drop table t1; # End of 4.1 tests + +# +# Test DELETE IGNORE +# Bug#44987 DELETE IGNORE and FK constraint +# + +create table t1 (id int primary key) engine = innodb; +create table t2 (id int PRIMARY KEY, FOREIGN KEY (id) REFERENCES t1(id)) engine=innodb; +insert into t1 values (1), (2), (3), (4), (5), (6); +insert into t2 values (3), (5); + +--error 1451 +delete from t1; +select * from t1; + +delete ignore from t1; +select row_count(); +select * from t1; +drop table t2; +drop table t1; === modified file 'sql/sql_delete.cc' --- a/sql/sql_delete.cc 2010-02-10 19:06:24 +0000 +++ b/sql/sql_delete.cc 2010-03-10 13:39:02 +0000 @@ -335,8 +335,11 @@ bool mysql_delete(THD *thd, TABLE_LIST * InnoDB it can fail in a FOREIGN KEY error or an out-of-tablespace error. */ - error= 1; - break; + if (!select_lex->no_error) + { + error= 1; + break; + } } } else

1 0

[Maria-developers] Updated (by Serg): MySQL/Maria Wait Interface (102)
by worklog-noreply＠askmonty.org 10 Mar '10

10 Mar '10

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: MySQL/Maria Wait Interface CREATION DATE..: Wed, 10 Mar 2010, 10:53 SUPERVISOR.....: Bothorsen IMPLEMENTOR....: COPIES TO......: Sergei CATEGORY.......: Client-BackLog TASK ID........: 102 (http://askmonty.org/worklog/?tid=102) VERSION........: Server-9.x STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: -=-=(Serg - Wed, 10 Mar 2010, 12:41)=-=- Observers changed: Sergei -=-=(Shinguz - Wed, 10 Mar 2010, 12:41)=-=- High Level Description modified. --- /tmp/wklog.102.old.2095 2010-03-10 12:41:15.000000000 +0000 +++ /tmp/wklog.102.new.2095 2010-03-10 12:41:15.000000000 +0000 @@ -10,6 +10,9 @@ http://www.xaprb.com/blog/2009/11/07/a-review-of-optimizing-oracle-performa… http://www.facebook.com/note.php?note_id=355839540932 +Possibly the MySQL performance schema can cover part/all of it yet? +http://dev.mysql.com/doc/performance-schema/en/index.html + Good sources to start with: http://www.amazon.com/Oracle-Wait-Interface-Performance-Diagnostics/dp/0072… http://books.google.ch/books?id=14OmJzfCfXMC&pg=PA6&lpg=PA6&dq=owi+is+a+per… -=-=(Shinguz - Wed, 10 Mar 2010, 10:55)=-=- Title modified. --- /tmp/wklog.102.old.29019 2010-03-10 10:55:18.000000000 +0000 +++ /tmp/wklog.102.new.29019 2010-03-10 10:55:18.000000000 +0000 @@ -1 +1 @@ -MySQL Wait Interface +MySQL/Maria Wait Interface -=-=(Shinguz - Wed, 10 Mar 2010, 10:55)=-=- Version updated. --- /tmp/wklog.102.old.29019 2010-03-10 10:55:18.000000000 +0000 +++ /tmp/wklog.102.new.29019 2010-03-10 10:55:18.000000000 +0000 @@ -1 +1 @@ -Benchmarks-3.0 +Server-9.x DESCRIPTION: What lacks in MySQL is something similar like the Oracle Wait Interface. The basic idea is, that every connection/thread (and the whole system) shows (on request) where it spent how much time doing what. They implemented the wait interface (which is possibly a sub-set of Sun's dtrace) where you can see where you loose your time. Marc Callaghan and Baron Schwartz blogged in this direction recently: http://www.xaprb.com/blog/2009/11/07/a-review-of-optimizing-oracle-performa… http://www.facebook.com/note.php?note_id=355839540932 Possibly the MySQL performance schema can cover part/all of it yet? http://dev.mysql.com/doc/performance-schema/en/index.html Good sources to start with: http://www.amazon.com/Oracle-Wait-Interface-Performance-Diagnostics/dp/0072… http://books.google.ch/books?id=14OmJzfCfXMC&pg=PA6&lpg=PA6&dq=owi+is+a+per… http://www.oracle.com/technology/books/pdfs/sample%20chapter%202729x.pdf http://www.amazon.com/Optimizing-Oracle-Performance-Cary-Millsap/dp/0596005… ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0