- developers - lists.mariadb.org

Re: [Maria-developers] [Commits] Rev 3839: Fix of using uninitialized variadle. in file:///home/bell/maria/bzr/work-maria-5.5-valgrind/
by Sergei Petrunia 18 Jul '13

18 Jul '13

Hi Sanja, On Thu, Jul 18, 2013 at 11:16:21AM +0300, sanja(a)montyprogram.com wrote: > At file:///home/bell/maria/bzr/work-maria-5.5-valgrind/ > > ------------------------------------------------------------ > revno: 3839 > revision-id: sanja(a)montyprogram.com-20130718081618-6ax63urznfnqmzgt > parent: sanja(a)montyprogram.com-20130717140359-123bw8dzelj6wddn > committer: sanja(a)montyprogram.com > branch nick: work-maria-5.5-valgrind > timestamp: Thu 2013-07-18 11:16:18 +0300 > message: > Fix of using uninitialized variadle. > === modified file 'sql/sql_select.cc' > --- a/sql/sql_select.cc 2013-07-17 13:42:13 +0000 > +++ b/sql/sql_select.cc 2013-07-18 08:16:18 +0000 > @@ -15674,6 +15674,8 @@ create_internal_tmp_table_from_heap2(THD > const char *save_proc_info; > int write_err= 0; > DBUG_ENTER("create_internal_tmp_table_from_heap2"); > + if (is_duplicate) > + *is_duplicate= FALSE; > > if (table->s->db_type() != heap_hton || > error != HA_ERR_RECORD_FILE_FULL) > > === modified file 'sql/sql_union.cc' > --- a/sql/sql_union.cc 2013-07-16 05:22:17 +0000 > +++ b/sql/sql_union.cc 2013-07-18 08:16:18 +0000 > @@ -83,7 +83,7 @@ int select_union::send_data(List<Item> & > */ > return -1; > } > - bool is_duplicate; > + bool is_duplicate= FALSE; If you do the part in create_internal_tmp_table_from_heap2(), is this change really necessary? > /* create_internal_tmp_table_from_heap will generate error if needed */ > if (table->file->is_fatal_error(write_err, HA_CHECK_DUP) && > create_internal_tmp_table_from_heap(thd, table, > Ok to push either way. BR Sergei -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

1 0

Re: [Maria-developers] LDAP authentication plugin
by Sergei 18 Jul '13

18 Jul '13

Hi, Ilija! On Jul 11, Ilija Lazarevic wrote: > Hi Sergei, > > The reason I'm writing you is because I'm interested > in details about this gsoc2013 proposal, and I saw you were > supposed to be the mentor. > > Is it open for contributing apart from gsoc? Yes, it is. But please, write to maria-developers(a)lists.launchpad.net next time, not to me personally. Regards, Sergei

3 2

[Maria-developers] help creating error messages
by Roberto Spadim 16 Jul '13

16 Jul '13

hi guys, how could i create a new error / warning message in mariadb? 1) how to add the message text to error list (there's a list, right?) 2) how to return (send) a error to client 3) how to add a message to 'warning list' and after get it with SHOW WARNINGS maybe some example or point lines / files that i should read thanks guys :) -- Roberto Spadim

2 5

[Maria-developers] More enum values in enum fields
by Roberto Spadim 16 Jul '13

16 Jul '13

Hi guys, i have a problem, that i don't know how to easly solve (ok i know but i want the user easy way) i have a ENUM column with some values (today 248 distinct values) i see that in a near future i will have more than 65535 different values inside this enum column, the first solution is change it to varchar, but my problem will be data size the enum is very optimized in size, a char is 'converted' to a smallint value my second solution is a int column, and a external table with int/text values, but here i need to change apps, i don't want the second one, but i don't want a very big database (char column) how could i change the limit of enum size? maybe a new enum2 type? with a limit of bigint value (64bits), ok maybe less (32bits) today (reading code) i see that big enum is a problem for .frm file that don't allow this size of enums and i need to get back to a second table, but what should be done to allow a very big enum field? there's a "easy" way to change mariadb code to allow a bigger enum size? thanks guys -- Roberto Spadim

4 19

[Maria-developers] The funcation of retry_transaction in parallen replication
by nanyi607rao 16 Jul '13

16 Jul '13

hi, In order to test "retry_transaction" in function execute_single_transaction(), I change Relay_log_pos to make SQL thread insert Duplicate entry, but I find it successed and do not report error! so I debug the function execute_single_transaction() and find the reason : at first time, the insert Rows_log_event::do_apply_event() return 121, that means insert fails. But when retry the insert Rows_log_event::do_apply_event(),it return 0, that means insert success! it seems the Rows_log_event::do_apply_event() do twice, but return different results. how this happened? is it a bug of Rows_log_event::do_apply_event() ? By the way, I do this test in mysql-5.5.30, do mariaDB has the some problem? 2013-07-12 nanyi607rao

3 3

[Maria-developers] What issue tracker should we use?
by Roberto Spadim 16 Jul '13

16 Jul '13

hi guys, i see that mariadb have three issue tracker, i'm right? i saw the https://askmonty.org/worklog/Server-RawIdeaBin/?tid=145 (ask monty), jira, and lauchpad what issue tracker should be used? there's any idea porting the others issue to the main issue tracker? -- Roberto Spadim SPAEmpresarial

3 4

[Maria-developers] Reserved words
by Ian Gilfillan 14 Jul '13

14 Jul '13

How can one find a definitive list of reserved words for a particular version? The comments in sql/lex.h say that that's a list of all reserved words and functions, but it appears to contain some words that are neither (such as ACTION). SELECT * FROM mysql.help_keyword also lists ACTION ACTION is listed in the MYSQL docs as an example of one of the keywords that MySQL permits "because many people previously used them"

2 1

[Maria-developers] Pluggable authentication, custom error messages
by Vladislav Vaintroub 14 Jul '13

14 Jul '13

Hi Serg, is there any possibility to return own error messages and codes , if pluggable authentication failed on client on some reason ? Case in point here is Kerberos (GSSAPI or SSPI) - it may fail on client or on server, with some GSSAPI/SSPI specific code. We would like user to know what exactly happened , rather than return a generic CR_ERROR. Perhaps user can fix the situation - maybe he just needs to obtain Kerberos ticket with kinit, or login as Windows domain user, or something like that. If error happens on the server side, at least there it is possible to write to error log. But on the client side, there is no error log, and writing to stdout/err is not a good idea. Is there a trick that allows custom messages on the client? Wlad

2 2

[Maria-developers] MariaDB 10/trunk (re)install destructively overwrites existing my.cnf* @ spec'd SYSCONFDIR
by darx＠sent.com 13 Jul '13

13 Jul '13

Hi, I've a custom my.cnf ls -al /usr/local/etc/mariadb/my.cnf -rw-r--r--+ 1 root root 7.9K Jul 13 13:03 /usr/local/etc/mariadb/my.cnf If I (re)install mariadb 10/trunk from a src build with SYSCONFDIR spec'd for that dir, as done similarly to a MySQL build, cd mariadb/bld cmake .. \ ... -DINSTALL_SYSCONFDIR=/usr/local/etc/mariadb \ ... make make install The INSTALL process *destructively* overwrites the existing my.cnf ... -- Up-to-date: /usr/local/etc/mariadb/logrotate.d/mysql -- Up-to-date: /usr/local/etc/mariadb/init.d/mysql -- Installing: /usr/local/etc/mariadb/my.cnf <================================ !! -- Up-to-date: /usr/local/etc/mariadb/my.cnf.d/client.cnf -- Up-to-date: /usr/local/etc/mariadb/my.cnf.d/mysql-clients.cnf -- Up-to-date: /usr/local/etc/mariadb/my.cnf.d/server.cnf ... with an older default cnf, ls -al /usr/local/etc/mariadb/my.cnf -rw-r--r--+ 1 root root 202 Jul 12 11:31 /usr/local/etc/mariadb/my.cnf with no backup made of the existing cnf, find /usr/local/etc/mariadb -type f -name 'my.cnf*' /usr/local/etc/mariadb/my.cnf This is critically different behavior that MySQL. If that's intended, how are we to exec a mariadb install without overwriting our config files/dirs? If it's not, I suspect this should be fixed. Thanks.

2 2

[Maria-developers] building MariaDB 10/trunk with external SSL generates errors/warnings. Docs are inconsistent. What's the right procedure?
by darx＠sent.com 13 Jul '13

13 Jul '13

hi, building cd /usr/local/src/mariadb bzr log | head -n 5 ------------------------------------------------------------ revno: 3766 [merge] committer: Alexander Barkov <bar(a)mariadb.org> branch nick: maria-10.0.ms timestamp: Wed 2013-07-10 18:46:33 +0400 reading ./BUILD/SETUP.sh ... 120 # SSL library to use.--with-ssl will select our bundled yaSSL # implementation of SSL. To use OpenSSL you will need to specify # the location of OpenSSL headers and libs on your system. # Ex --with-ssl=/usr <================================= OK, do this SSL_LIBRARY=--with-ssl ... configuring @ `cmake` cd /usr/local/src/mariadb rm -rf bld mkdir bld cd bld cmake .. \ -DWITH_SSL=/usr/local/ssl \ -DOPENSSL_INCLUDE_DIR=/usr/local/ssl/include \ -DOPENSSL_SSL_LIBRARY=/usr/local/ssl/lib64/libssl.so \ -DOPENSSL_CRYPTO_LIBRARY=/usr/local/ssl/lib64/libcrypto.so fails, returning, ... CMake Error at cmake/ssl.cmake:90 (MESSAGE): Wrong option for WITH_SSL. Valid values are : yes, no, bundled Call Stack (most recent call first): CMakeLists.txt:260 (MYSQL_CHECK_SSL) ... -- Configuring incomplete, errors occurred! vi ../CmakeLists.txt ... # Add bundled or system zlib. MYSQL_CHECK_ZLIB_WITH_COMPRESS() # Optionally add bundled yassl/taocrypt or system openssl. 260 MYSQL_CHECK_SSL() # Add readline or libedit. MYSQL_CHECK_READLINE() checking vi cmake/ssl.cmake ... # MYSQL_CHECK_SSL # # Provides the following configure options: # WITH_SSL=[yes|no|bundled] MACRO (MYSQL_CHECK_SSL) IF(NOT WITH_SSL) IF(WIN32) CHANGE_SSL_SETTINGS("bundled") ELSE() CHANGE_SSL_SETTINGS("no") ENDIF() ENDIF() IF(WITH_SSL STREQUAL "bundled") MYSQL_USE_BUNDLED_SSL() ELSEIF(WITH_SSL STREQUAL "system" OR WITH_SSL STREQUAL "yes") # Check for system library SET(OPENSSL_FIND_QUIETLY TRUE) INCLUDE(FindOpenSSL) FIND_LIBRARY(CRYPTO_LIBRARY crypto) MARK_AS_ADVANCED(CRYPTO_LIBRARY) INCLUDE(CheckSymbolExists) SET(CMAKE_REQUIRED_INCLUDES ${OPENSSL_INCLUDE_DIR}) CHECK_SYMBOL_EXISTS(SHA512_DIGEST_LENGTH "openssl/sha.h" HAVE_SHA512_DIGEST_LENGTH) SET(CMAKE_REQUIRED_INCLUDES) IF(OPENSSL_FOUND AND CRYPTO_LIBRARY AND HAVE_SHA512_DIGEST_LENGTH) SET(SSL_SOURCES "") SET(SSL_LIBRARIES ${OPENSSL_LIBRARIES} ${CRYPTO_LIBRARY}) SET(SSL_INCLUDE_DIRS ${OPENSSL_INCLUDE_DIR}) SET(SSL_INTERNAL_INCLUDE_DIRS "") SET(SSL_DEFINES "-DHAVE_OPENSSL") CHANGE_SSL_SETTINGS("system") ELSE() IF(WITH_SSL STREQUAL "system") MESSAGE(SEND_ERROR "Cannot find appropriate system libraries for SSL. Use WITH_SSL=bundled to enable SSL su ENDIF() MYSQL_USE_BUNDLED_SSL() ENDIF() ELSEIF(NOT WITH_SSL STREQUAL "no") MESSAGE(SEND_ERROR "Wrong option for WITH_SSL. Valid values are : yes, no, bundled") ENDIF() ENDMACRO() there's no accommodation for "--with-ssl=/path/to/ssl/install". If I instead cmake .. \ -DWITH_SSL=yes \ -DOPENSSL_INCLUDE_DIR=/usr/local/ssl/include \ -DOPENSSL_SSL_LIBRARY=/usr/local/ssl/lib64/libssl.so \ -DOPENSSL_CRYPTO_LIBRARY=/usr/local/ssl/lib64/libcrypto.so it returns, ... -- Running cmake version 2.8.11.1 -- MariaDB 10.0.3 -- Packaging as: mariadb-10.0.3-Linux-x86_64 -- Found OpenSSL: /usr/local/ssl/lib64/libssl.so;/usr/local/ssl/lib64/libcrypto.so (found version "1.0.1e") ... -- Configuring done then a bunch of these messages: ... CMake Warning at cmake/plugin.cmake:184 (ADD_LIBRARY): Cannot generate a safe runtime search path for target feedback because files in some directories may conflict with libraries in implicit directories: runtime library [libcrypto.so.1.0.0] in /usr/lib64 may be hidden by files in: /usr/local/ssl/lib64 Some of these libraries may not be found correctly. Call Stack (most recent call first): plugin/feedback/CMakeLists.txt:20 (MYSQL_ADD_PLUGIN) CMake Warning at cmake/libutils.cmake:259 (ADD_LIBRARY): Cannot generate a safe runtime search path for target libmysql because files in some directories may conflict with libraries in implicit directories: runtime library [libcrypto.so.1.0.0] in /usr/lib64 may be hidden by files in: /usr/local/ssl/lib64 Some of these libraries may not be found correctly. Call Stack (most recent call first): libmysql/CMakeLists.txt:374 (MERGE_LIBRARIES) CMake Warning at client/CMakeLists.txt:78 (ADD_EXECUTABLE): Cannot generate a safe runtime search path for target async_example because files in some directories may conflict with libraries in implicit directories: runtime library [libcrypto.so.1.0.0] in /usr/lib64 may be hidden by files in: /usr/local/ssl/lib64 Some of these libraries may not be found correctly. ... What's the right method to find/use external SSL libs/headers in a MariaDB build without errors or warnings? --darx

2 1