- developers - lists.mariadb.org

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2709)
by Sergey Petrunia 07 Jun '09

07 Jun '09

#At lp:maria based on revid:psergey@askmonty.org-20090603182330-ll3gc91iowhtgb23 2709 Sergey Petrunia 2009-06-07 [merge] Merge MWL#17: Table elimination modified: sql/sql_select.cc === modified file 'sql/sql_select.cc' --- a/sql/sql_select.cc 2009-06-03 13:10:45 +0000 +++ b/sql/sql_select.cc 2009-06-07 18:24:03 +0000 @@ -2586,7 +2586,7 @@ eliminate_tables_for_join_list(JOIN *joi table_map tables_used_outside= used_tables_on_left | used_tables_on_right[i] | used_tables_elsewhere; - table_map cur_tables; + table_map cur_tables= 0; if (tbl->nested_join) {

1 0

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (psergey:2707)
by Sergey Petrunia 07 Jun '09

07 Jun '09

#At lp:maria based on revid:psergey@askmonty.org-20090603131045-c8jqhwlanli7eimv 2707 Sergey Petrunia 2009-06-07 MWL#17: Table Elimination - Fix trivial valgrind warning modified: sql/sql_select.cc per-file messages: sql/sql_select.cc MWL#17: Table Elimination - Fix trivial valgrind warning === modified file 'sql/sql_select.cc' --- a/sql/sql_select.cc 2009-06-03 13:10:45 +0000 +++ b/sql/sql_select.cc 2009-06-07 18:24:03 +0000 @@ -2586,7 +2586,7 @@ eliminate_tables_for_join_list(JOIN *joi table_map tables_used_outside= used_tables_on_left | used_tables_on_right[i] | used_tables_elsewhere; - table_map cur_tables; + table_map cur_tables= 0; if (tbl->nested_join) {

1 0

[Maria-developers] [Branch ~maria-captains/maria/5.1] Rev 2703: Fix accessing ulong enum option as uint, failing on 64-bit big-endian.
by Michael Widenius 07 Jun '09

07 Jun '09

Hi! >>>>> "noreply" == noreply <noreply(a)launchpad.net> writes: noreply> === modified file 'mysys/my_getopt.c' noreply> --- mysys/my_getopt.c 2009-04-25 10:05:32 +0000 noreply> +++ mysys/my_getopt.c 2009-05-20 15:34:34 +0000 noreply> @@ -647,7 +647,7 @@ noreply> return EXIT_OUT_OF_MEMORY; noreply> break; noreply> case GET_ENUM: noreply> - if (((*(int*)result_pos)= find_type(argument, opts->typelib, 2) - 1) < 0) noreply> + if (((*(ulong *)result_pos)= find_type(argument, opts->typelib, 2) - 1) < 0) noreply> return EXIT_ARGUMENT_INVALID; noreply> break; noreply> case GET_SET: noreply> @@ -983,7 +983,7 @@ noreply> *((int*) variable)= (int) getopt_ll_limit_value((int) value, option, NULL); noreply> break; noreply> case GET_ENUM: noreply> - *((uint*) variable)= (uint) value; noreply> + *((ulong*) variable)= (uint) value; noreply> break; noreply> case GET_UINT: noreply> *((uint*) variable)= (uint) getopt_ull_limit_value((uint) value, option, NULL); noreply> @@ -1221,7 +1221,7 @@ noreply> } noreply> break; noreply> case GET_ENUM: noreply> - printf("%s\n", get_type(optp->typelib, *(uint*) value)); noreply> + printf("%s\n", get_type(optp->typelib, *(ulong*) value)); noreply> break; noreply> case GET_STR: noreply> case GET_STR_ALLOC: /* fall through */ Where is the enum used that caused this to break ? (I did a grep of GET_ENUM in the current tree, but couldn't find anything. As an ENUM can only contain a small set of values, it would be more logical that it should be an uint ant not an ulong. (With some 64 bit compilers, uint -> 32 bit while ulong is 64 bit, so there is a clear advantage in using uint) Becasue of this, I am more included to belive the the one that is using GET_ENUM as ulong is doing things wrong instead of the above code. Regards, Monty

2 1

[Maria-developers] how to speed up Maria record loading?
by Giuseppe Maxia 07 Jun '09

07 Jun '09

Hi, I am doing some tests with Maria. Out of the box, without any tuning, the load of records (with multiple record INSERT statements) is 5 times slower than MyISAM, 4 times slower than InnoDB. What can I do to make the loading faster? Thanks Giuseppe -- The Data Charmer http://datacharmer.org/

4 4

[Maria-developers] Query cache test failure in Buildbot for mariadb 5.1
by Kristian Nielsen 07 Jun '09

07 Jun '09

Hi, There is a query cache related failure seen in Buildbot: https://askmonty.org/buildbot/builders/hardy-amd64-dbg/builds/35/steps/test… main.query_cache_28249 [ fail ] Test ended at 2009-05-21 09:13:10 CURRENT_TEST: main.query_cache_28249 --- /home/archivist/archivist-amd64/archivist-amd64/build/mysql-test/r/query_cache_28249.result 2009-05-21 09:30:15.000000000 +0300 +++ /home/archivist/archivist-amd64/archivist-amd64/build/mysql-test/r/query_cache_28249.reject 2009-05-21 11:13:10.000000000 +0300 @@ -46,7 +46,6 @@ 1 0 2 0 3 0 -4 0 RESET QUERY CACHE; SELECT *, (SELECT COUNT(*) FROM t2) FROM t1; a (SELECT COUNT(*) FROM t2) mysqltest: Result length mismatch - saving '/home/archivist/archivist-amd64/archivist-amd64/build/mysql-test/var/1/log/main.query_cache_28249/' to '/home/archivist/archivist-amd64/archivist-amd64/build/mysql-test/var/log/main.query_cache_28249/' Retrying test, attempt(2/3)... main.query_cache_28249 [ retry-pass ] 509 Retrying test, attempt(3/3)... main.query_cache_28249 [ retry-pass ] 404 I checked the bug: http://bugs.mysql.com/bug.php?id=28249 It is about a race condition in query cache and MyISAM (and re-test in Buildbot shows that it is not 100% reproducible). I am thinking that perhaps the bug was re-introduced with Maria, or in any case that someone more familiar with the MyISAM or Maria code would be better at looking into it. Any takers? - Kristian.

2 2

Re: [Maria-developers] Query cache test failure in Buildbot
by Michael Widenius 07 Jun '09

07 Jun '09

In-Reply-To: <87hbzd5mfb.fsf(a)knielsen-hq.org> References: <87hbzd5mfb.fsf(a)knielsen-hq.org> X-Mailer: VM 7.17 under 21.5 (beta28) "fuki" (+CVS-20070806) XEmacs Lucid Reply-To: monty(a)askmonty.org FCC: ~/Mail/outbox --text follows this line-- Hi! >>>>> "Kristian" == Kristian Nielsen <knielsen(a)knielsen-hq.org> writes: Kristian> Hi, Kristian> There is a query cache related failure seen in Buildbot: Kristian> https://askmonty.org/buildbot/builders/hardy-amd64-dbg/builds/35/steps/test… Kristian> main.query_cache_28249 [ fail ] Kristian> Test ended at 2009-05-21 09:13:10 Kristian> CURRENT_TEST: main.query_cache_28249 Kristian> --- /home/archivist/archivist-amd64/archivist-amd64/build/mysql-test/r/query_cache_28249.result 2009-05-21 09:30:15.000000000 +0300 Kristian> +++ /home/archivist/archivist-amd64/archivist-amd64/build/mysql-test/r/query_cache_28249.reject 2009-05-21 11:13:10.000000000 +0300 Kristian> @@ -46,7 +46,6 @@ Kristian> 1 0 Kristian> 2 0 Kristian> 3 0 Kristian> -4 0 Kristian> RESET QUERY CACHE; Kristian> SELECT *, (SELECT COUNT(*) FROM t2) FROM t1; Kristian> a (SELECT COUNT(*) FROM t2) Kristian> mysqltest: Result length mismatch Kristian> - saving '/home/archivist/archivist-amd64/archivist-amd64/build/mysql-test/var/1/log/main.query_cache_28249/' to '/home/archivist/archivist-amd64/archivist-amd64/build/mysql-test/var/log/main.query_cache_28249/' Kristian> Retrying test, attempt(2/3)... Kristian> main.query_cache_28249 [ retry-pass ] 509 Kristian> Retrying test, attempt(3/3)... Kristian> main.query_cache_28249 [ retry-pass ] 404 Kristian> I checked the bug: Kristian> http://bugs.mysql.com/bug.php?id=28249 Kristian> It is about a race condition in query cache and MyISAM (and re-test in Kristian> Buildbot shows that it is not 100% reproducible). Kristian> I am thinking that perhaps the bug was re-introduced with Maria, or in any Kristian> case that someone more familiar with the MyISAM or Maria code would be better Kristian> at looking into it. Sanja, can you create a bug report in launchpad or worklog item to get this fixed? Regards, Monty

1 0

[Maria-developers] [Branch ~maria-captains/maria/5.1] Rev 2711: Added tests to cover more server code
by noreply＠launchpad.net 07 Jun '09

07 Jun '09

------------------------------------------------------------ revno: 2711 committer: Michael Widenius <monty(a)askmonty.org> branch nick: mysql-maria timestamp: Sun 2009-06-07 13:05:19 +0300 message: Added tests to cover more server code Author: Stewart Smith modified: mysql-test/r/alter_table.result mysql-test/r/limit.result mysql-test/t/alter_table.test mysql-test/t/limit.test === modified file 'mysql-test/r/alter_table.result' --- mysql-test/r/alter_table.result 2009-02-19 09:01:25 +0000 +++ mysql-test/r/alter_table.result 2009-06-07 10:05:19 +0000 @@ -1268,4 +1268,21 @@ 4 b 5 a DROP TABLE t1; +SET @save_sql_mode=@@sql_mode; +SET sql_mode=strict_all_tables; +CREATE TABLE t1 (a int NOT NULL default 42); +INSERT INTO t1 values (); +SELECT * FROM t1; +a +42 +ALTER TABLE t1 ALTER COLUMN a DROP DEFAULT; +INSERT INTO t1 values (); +ERROR HY000: Field 'a' doesn't have a default value +INSERT INTO t1 (a) VALUES (11); +SELECT * FROM t1 ORDER BY a; +a +11 +42 +DROP TABLE t1; +SET @@sql_mode=@save_sql_mode; End of 5.1 tests === modified file 'mysql-test/r/limit.result' --- mysql-test/r/limit.result 2008-10-15 21:34:51 +0000 +++ mysql-test/r/limit.result 2009-06-07 10:05:19 +0000 @@ -113,4 +113,36 @@ End of 5.0 tests select 1 as a limit 4294967296,10; a +CREATE TABLE t1 (a int PRIMARY KEY auto_increment); +INSERT INTO t1 VALUES (),(),(),(),(),(),(),(),(),(); +INSERT INTO t1 VALUES (),(),(),(),(),(),(),(),(),(); +SELECT a FROM t1 ORDER BY a LIMIT 10 OFFSET 1; +a +2 +3 +4 +5 +6 +7 +8 +9 +10 +11 +SELECT a FROM t1 ORDER BY a LIMIT 10 OFFSET 10; +a +11 +12 +13 +14 +15 +16 +17 +18 +19 +20 +SELECT a FROM t1 ORDER BY a LIMIT 2 OFFSET 14; +a +15 +16 +DROP TABLE t1; End of 5.1 tests === modified file 'mysql-test/t/alter_table.test' --- mysql-test/t/alter_table.test 2009-02-19 09:01:25 +0000 +++ mysql-test/t/alter_table.test 2009-06-07 10:05:19 +0000 @@ -1000,4 +1000,22 @@ SELECT * FROM t1; DROP TABLE t1; +# +# Test for ALTER column DROP DEFAULT +# + +SET @save_sql_mode=@@sql_mode; +SET sql_mode=strict_all_tables; + +CREATE TABLE t1 (a int NOT NULL default 42); +INSERT INTO t1 values (); +SELECT * FROM t1; +ALTER TABLE t1 ALTER COLUMN a DROP DEFAULT; +--error 1364 +INSERT INTO t1 values (); +INSERT INTO t1 (a) VALUES (11); +SELECT * FROM t1 ORDER BY a; +DROP TABLE t1; +SET @@sql_mode=@save_sql_mode; + --echo End of 5.1 tests === modified file 'mysql-test/t/limit.test' --- mysql-test/t/limit.test 2008-10-16 01:50:56 +0000 +++ mysql-test/t/limit.test 2009-06-07 10:05:19 +0000 @@ -102,4 +102,16 @@ select 1 as a limit 4294967296,10; +# +# Test for LIMIT X OFFSET Y +# + +CREATE TABLE t1 (a int PRIMARY KEY auto_increment); +INSERT INTO t1 VALUES (),(),(),(),(),(),(),(),(),(); +INSERT INTO t1 VALUES (),(),(),(),(),(),(),(),(),(); +SELECT a FROM t1 ORDER BY a LIMIT 10 OFFSET 1; +SELECT a FROM t1 ORDER BY a LIMIT 10 OFFSET 10; +SELECT a FROM t1 ORDER BY a LIMIT 2 OFFSET 14; +DROP TABLE t1; + --echo End of 5.1 tests -- lp:maria https://code.launchpad.net/~maria-captains/maria/5.1 Your team Maria developers is subscribed to branch lp:maria. To unsubscribe from this branch go to https://code.launchpad.net/~maria-captains/maria/5.1/+edit-subscription.

1 0

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2711)
by Michael Widenius 07 Jun '09

07 Jun '09

#At lp:maria based on revid:monty@askmonty.org-20090605204623-ptvh44epiw0pyoj6 2711 Michael Widenius 2009-06-07 Added tests to cover more server code Author: Stewart Smith modified: mysql-test/r/alter_table.result mysql-test/r/limit.result mysql-test/t/alter_table.test mysql-test/t/limit.test per-file messages: mysql-test/r/alter_table.result Testing of ALTER TABLE .. DROP DEFAULT mysql-test/r/limit.result Testing of LIMIT ... OFFSET mysql-test/t/alter_table.test Testing of ALTER TABLE .. DROP DEFAULT mysql-test/t/limit.test Testing of LIMIT ... OFFSET === modified file 'mysql-test/r/alter_table.result' --- a/mysql-test/r/alter_table.result 2009-02-19 09:01:25 +0000 +++ b/mysql-test/r/alter_table.result 2009-06-07 10:05:19 +0000 @@ -1268,4 +1268,21 @@ a b 4 b 5 a DROP TABLE t1; +SET @save_sql_mode=@@sql_mode; +SET sql_mode=strict_all_tables; +CREATE TABLE t1 (a int NOT NULL default 42); +INSERT INTO t1 values (); +SELECT * FROM t1; +a +42 +ALTER TABLE t1 ALTER COLUMN a DROP DEFAULT; +INSERT INTO t1 values (); +ERROR HY000: Field 'a' doesn't have a default value +INSERT INTO t1 (a) VALUES (11); +SELECT * FROM t1 ORDER BY a; +a +11 +42 +DROP TABLE t1; +SET @@sql_mode=@save_sql_mode; End of 5.1 tests === modified file 'mysql-test/r/limit.result' --- a/mysql-test/r/limit.result 2008-10-15 21:34:51 +0000 +++ b/mysql-test/r/limit.result 2009-06-07 10:05:19 +0000 @@ -113,4 +113,36 @@ ERROR HY000: Incorrect arguments to EXEC End of 5.0 tests select 1 as a limit 4294967296,10; a +CREATE TABLE t1 (a int PRIMARY KEY auto_increment); +INSERT INTO t1 VALUES (),(),(),(),(),(),(),(),(),(); +INSERT INTO t1 VALUES (),(),(),(),(),(),(),(),(),(); +SELECT a FROM t1 ORDER BY a LIMIT 10 OFFSET 1; +a +2 +3 +4 +5 +6 +7 +8 +9 +10 +11 +SELECT a FROM t1 ORDER BY a LIMIT 10 OFFSET 10; +a +11 +12 +13 +14 +15 +16 +17 +18 +19 +20 +SELECT a FROM t1 ORDER BY a LIMIT 2 OFFSET 14; +a +15 +16 +DROP TABLE t1; End of 5.1 tests === modified file 'mysql-test/t/alter_table.test' --- a/mysql-test/t/alter_table.test 2009-02-19 09:01:25 +0000 +++ b/mysql-test/t/alter_table.test 2009-06-07 10:05:19 +0000 @@ -1000,4 +1000,22 @@ ALTER TABLE t1 MODIFY b ENUM('a', 'z', ' SELECT * FROM t1; DROP TABLE t1; +# +# Test for ALTER column DROP DEFAULT +# + +SET @save_sql_mode=@@sql_mode; +SET sql_mode=strict_all_tables; + +CREATE TABLE t1 (a int NOT NULL default 42); +INSERT INTO t1 values (); +SELECT * FROM t1; +ALTER TABLE t1 ALTER COLUMN a DROP DEFAULT; +--error 1364 +INSERT INTO t1 values (); +INSERT INTO t1 (a) VALUES (11); +SELECT * FROM t1 ORDER BY a; +DROP TABLE t1; +SET @@sql_mode=@save_sql_mode; + --echo End of 5.1 tests === modified file 'mysql-test/t/limit.test' --- a/mysql-test/t/limit.test 2008-10-16 01:50:56 +0000 +++ b/mysql-test/t/limit.test 2009-06-07 10:05:19 +0000 @@ -102,4 +102,16 @@ execute s using @a, @a; select 1 as a limit 4294967296,10; +# +# Test for LIMIT X OFFSET Y +# + +CREATE TABLE t1 (a int PRIMARY KEY auto_increment); +INSERT INTO t1 VALUES (),(),(),(),(),(),(),(),(),(); +INSERT INTO t1 VALUES (),(),(),(),(),(),(),(),(),(); +SELECT a FROM t1 ORDER BY a LIMIT 10 OFFSET 1; +SELECT a FROM t1 ORDER BY a LIMIT 10 OFFSET 10; +SELECT a FROM t1 ORDER BY a LIMIT 2 OFFSET 14; +DROP TABLE t1; + --echo End of 5.1 tests

1 0

[Maria-developers] Patches to consider to include
by Vadim Tkachenko 07 Jun '09

07 Jun '09

Hello, What do you think about including patches global_trx_ids, binlog event checksums and fixes to crash-proof slaves from https://code.launchpad.net/~jtolmer/mysql-server/global-trx-ids into tree ? -- Vadim Tkachenko, CTO Percona Inc. ICQ: 369-510-335, Skype: vadimtk153, Phone +1-888-401-3403 MySQL Performance Blog - http://www.mysqlperformanceblog.com MySQL Consulting http://www.percona.com/

6 9

[Maria-developers] New (by Monty): global transaction id (31)
by worklog-noreply＠askmonty.org 07 Jun '09

07 Jun '09

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: global transaction id CREATION DATE..: Sun, 07 Jun 2009, 10:59 SUPERVISOR.....: Bothorsen IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-BackLog TASK ID........: 31 (http://askmonty.org/worklog/?tid=31) VERSION........: Benchmarks-3.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 4 (hours remain) ORIG. ESTIMATE.: 4 PROGRESS NOTES: DESCRIPTION: Consider including patches global_trx_ids, binlog event checksums and fixes to crash-proof slaves from https://code.launchpad.net/~jtolmer/mysql-server/global-trx-ids First we should investigate if we can do this in a manner compatible with MySQL 5.1. We want to ensure that we keep a high compatibility between MariaDB and MySQL so that both can be a drop in replacement to each other when it comes to how data and logs are stored. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0