- developers - lists.mariadb.org

[Maria-developers] MDEV-11245 Move prepare_create_field and sp_prepare_create_field() as methods to Column_definition
by Alexander Barkov 18 Nov '16

18 Nov '16

Hello Sanja, can you please review a patch for MDEV-11245 for 10.3? It's a small refactoring intended to make patches for these tasks look better: - MDEV-10577 sql_mode=ORACLE: %TYPE in variable declarations - MDEV-10914 ROW data type for stored routine variables Thanks!

1 0

[Maria-developers] SHOW CREATE TABLE does not display REF_SYSTEM_ID
by Alexander Barkov 17 Nov '16

17 Nov '16

Hello Alexey, I have a question about REF_SYSTEM_ID. DROP TABLE IF EXISTS t1; CREATE TABLE t1 (a POINT REF_SYSTEM_ID=10); SELECT G_TABLE_NAME,G_GEOMETRY_COLUMN,SRID FROM INFORMATION_SCHEMA.GEOMETRY_COLUMNS WHERE G_TABLE_NAME='t1'; The above script returns: +--------------+-------------------+------+ | G_TABLE_NAME | G_GEOMETRY_COLUMN | SRID | +--------------+-------------------+------+ | t1 | a | 10 | +--------------+-------------------+------+ This looks correct. The REF_SYSTEM_ID (which is 10) is correctly displayed in the SRID column. But now if I do: SHOW CREATE TABLE t1; It prints: +-------+-------------------------------------------------------------------------------------+ | Table | Create Table | +-------+-------------------------------------------------------------------------------------+ | t1 | CREATE TABLE `t1` ( `a` point DEFAULT NULL ) ENGINE=InnoDB DEFAULT CHARSET=latin1 | +-------+-------------------------------------------------------------------------------------+ It does not display the REF_SYSTEM_ID part of the column definition. Looks like a bug from a glance. Can you comment please?

1 0

[Maria-developers] Please review MDEV-11298 Split Item_func_hex::val_str_ascii() into virtual methods in Type_handler
by Alexander Barkov 17 Nov '16

17 Nov '16

Hello Alexey, Please review a patch for MDEV-11298 (for 10.3). Thanks.

1 0

[Maria-developers] Please review MDEV-11294 Move definitions of Derivation, DTCollation, Type_std_attributes from field.h and item.h to sql_type.h
by Alexander Barkov 16 Nov '16

16 Nov '16

Hello Alexey, Please review a patch for MDEV-11294. Thanks!

1 0

Re: [Maria-developers] [Commits] 9ed264a391b160ef84121c8699bb3ff61c0059ce Fixed bug mdev-11072. In a general case the conditions with outer fields cannot be pushed into materialized views / derived tables. However if the outer field in the condition refers to a single row table then the condition may be pushable. In this case a special care should be taken for outer fields when pushing the condition into a materialized view / derived table.
by Oleksandr Byelkin 15 Nov '16

15 Nov '16

Hi, Igor! On 11/15/2016 08:23 AM, Igor Babaev wrote: > commit 9ed264a391b160ef84121c8699bb3ff61c0059ce > Author: Igor Babaev <igor(a)askmonty.org> > Commit: Igor Babaev <igor(a)askmonty.org> > > Fixed bug mdev-11072. > In a general case the conditions with outer fields cannot > be pushed into materialized views / derived tables. > However if the outer field in the condition refers to a > single row table then the condition may be pushable. > In this case a special care should be taken for outer > fields when pushing the condition into a materialized view / > derived table. Thank you a lot, OK to push! [skip]

1 0

[Maria-developers] Mdev-10715 -- Galera: Replicate MariaDB GTID to other nodes in the cluster
by Sachin Setiya 15 Nov '16

15 Nov '16

Hi Nirbyay, Serg, Kristian, In this mail I am answering some questions raised by Kristian and blue print for this task. 1. Questions of Kristian <knielsen> sachin_setiya_7: so maybe the problem is - that a node broadcasts its write set before the commit order has been determined? I do not think , this is the problem. Galera enforces the commit order. Yes, it broadcast write set in prepare phase. but it also guarantees that t1->t2 order will be maintained in all participating N nodes. <knielsen> sachin_setiya_7: how is the galera internal transaction id allocated and broadcast? I am here assuming that we are talking about gtid-sequence no. Suppose our initial seqno is S. So basically at this time all N have same sequence no. Some transaction T is executed at node Ni .It broadcast the writeset with its current sequence no S. At all Node Nj (including Ni).It receives this message. It checks some conditions Like it “totally ordered action”. If yes then Nj updates its sequence no to + 1. Here is the relevant code. if (gu_likely(GCS_ACT_TORDERED == rcvd->act.type && GCS_GROUP_PRIMARY == group->state && group->nodes[sender_idx].status >= GCS_NODE_STATE_DONOR && !(group->frag_reset && local) && commonly_supported_version)) { /* Common situation - * increment and assign act_id only for totally ordered actions * and only in PRIM (skip messages while in state exchange) */ rcvd->id = ++group->act_id_; } In function static inline ssize_t gcs_group_handle_act_msg (gcs_group_t* const group, const gcs_act_frag_t* const frg, const gcs_recv_msg_t* const msg, struct gcs_act_rcvd* const rcvd, bool commonly_supported_version) So basically It is like certification(generated at each node ) but done in quite early phase. Blueprint of task:- We can do something like galera GTID, we will take initial sequence no from server. We will add one more variable in gcs_group_t Named s_sequence_no and will increment it at each node. We also have to Create a gtid event and append it to message received at Nj , so that on late stages wsrep_apply_cb() can take care of gtid. Please let me know what you think. -- Regards Sachin Setiya Software Engineer at MariaDB

2 1

[Maria-developers] Changing the error message for ER_LOCK_WAIT_TIMEOUT
by Sergey Petrunia 12 Nov '16

12 Nov '16

Hi Sergei and everyone, MariaDB defines ER_LOCK_WAIT_TIMEOUT as share/errmsg-utf8.txt: eng "Lock wait timeout exceeded; try restarting transaction" facebook/mysql-5.6 has an enhancement: it also shows what kind of lock is held: share/errmsg-utf8.txt: eng "Lock wait timeout exceeded; try restarting transaction: %-.256s" the new error messages have more info and look like this: https://gist.github.com/spetrunia/266272c384a1b43081572e1ba2baf3f3 note that MyRocks also provides extra information. So, the questions are: - Is it (generally) possible to change error message texts in 10.2 still? - Can/should we change the ER_LOCK_WAIT_TIMEOUT error text? - (non-question) I assume that adding another error code with the new error text is not a good solution: two error codes for the same error will be very confusing. The number of times ER_LOCK_WAIT_TIMEOUT is used in the source is actually quite small: https://gist.github.com/spetrunia/2bc2ed7040a930d75b39162becbc7963 (25 occurences, and most of them actually dont care about the error message). There are lots of .result files to update, though. Any opinions? BR Sergei -- Sergei Petrunia, Software Developer MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog

2 1

[Maria-developers] No MTR tests for --encrypt-binlog feature?
by Laurynas Biveinis 11 Nov '16

11 Nov '16

MariaDB - On 10.1 branch, grep on mysql-test for encrypt.binlog returns ./r/mysqld--help.result:180: --encrypt-binlog Encrypt binary logs (including relay logs) ./r/mysqld--help.result:1179:encrypt-binlog FALSE ./suite/sys_vars/r/sysvars_server_embedded.result:698:VARIABLE_NAME ENCRYPT_BINLOG ./suite/sys_vars/r/sysvars_server_notembedded.result:712:VARIABLE_NAME ENCRYPT_BINLOG Thus it does not look that the feature has actual tests. How do you know it works? Thanks, -- Laurynas

2 3

Re: [Maria-developers] Please review: support for --force-restart in MTR
by Sergey Petrunia 10 Nov '16

10 Nov '16

On Mon, Nov 07, 2016 at 06:53:30AM +0100, Sergei Golubchik wrote: > On November 7, 2016 1:34:18 AM GMT+01:00, Sergey Petrunia <sergey(a)mariadb.com> wrote: > >Hi Sergei, Elena > > > >I'm not sure who maintains mysql-test-run.pl but you two seem to have > >contributed to it in the past, this is why I'm addressing this to you. > > > >I'm going to get "MTR v2" to support --force-restart, just like MTR v1 > >did; > > > >http://lists.askmonty.org/pipermail/commits/2016-November/010062.html > >http://lists.askmonty.org/pipermail/commits/2016-November/010063.html > > > >Since I don't really understand this MTRv1 vs MTRv2 change (and why > >some things > >are in v1 but not in v2, etc), I wanted to check this change with you. > > No, please, don't add that. I've removed force-restart and all > other pseudo-arguments few years ago. There are many > ways to guarantee a restart without it - add some dummy > option to .opt file, add a .cnf file, add a .sh file, or - that's > what I did in old tests that needed force-restart (only about > 5-10% out of those, that used it!) - restart the server from > inside the test file. Ok, I've reverted the above two patches, will restart the server from the .test file. BR Sergei -- Sergei Petrunia, Software Developer MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog

1 0

[Maria-developers] Deleting unused branches on github
by Kristian Nielsen 10 Nov '16

10 Nov '16

We currently have more than 200 branches in the MariaDB Server github repo, most of which look like they are no longer used. I would like to remove the unused ones to remove clutter. Eg. in `git branch -la` or the drop-downs on the github webpage. Below is a list of a little less than two-thirds of the branches that I determined to be probably unused. I was fairly conservative in my criteria, ie. if there was reasonable doubt, I omitted a branch from the list to delete. Please take a look at the list and see if there is any branch that should _not_ be deleted from the github repository. Or if someone objects to deleting anything on principle grounds, let me know as well, of course. (I Cc'ed people that were the last to commit on a branch to be deleted). Note that if one of these branches should become needed again later, eg. some bb-XXX branch not used for a long time, there is no problem re-creating it. The only problem with removing a branch should be if it contains contents that will be needed in the future, and which is not available anywhere else (and I tried to avoid putting such branches on the list in the first place). Also note that once these are deleted, a simple `git pull` will not remove them from the local clone. The `git fetch --prune` can be used to effect this. If there are no objections, I will do the deletions in two weeks. - Kristian. ----------------------------------------------------------------------- These branches have not been updated for a long time, and looked like they were not used any more. They are annotated with the date and the committer of the last commit: origin/bb-10.2-decimal 5 months ago Monty <monty(a)mariadb.org> origin/bb-10.1-jan2 8 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-xtrabackup 8 months ago Vladislav Vaintroub <wlad(a)mariadb.com> origin/10.2-window_simple 9 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-10.2-vicentiu-create 10 months ago Vicențiu Ciorbaru <vicentiu(a)mariadb.org> origin/bb-10.0-galera-jan 11 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/10.2-travis-ci 12 months ago Otto Kekäläinen <otto(a)mariadb.org> origin/bb-10.1-systemd 1 year ago Sergey Vojtovich <svoj(a)mariadb.org> origin/bb-10.1-jan-encryption 1 year, 1 month ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/10.1-spider 1 year, 1 month ago Michael Widenius <monty(a)mariadb.org> origin/bb-svoj 1 year, 1 month ago Sergey Vojtovich <svoj(a)mariadb.org> origin/wip-binlog-encryption 1 year, 2 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-5.5-inno 1 year, 3 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-default 1 year, 3 months ago Monty <monty(a)mariadb.org> origin/10.0-FusionIO-Galera 1 year, 4 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/10.0-custombld 1 year, 4 months ago Kristian Nielsen <knielsen(a)knielsen-hq.org> origin/10.1-window 1 year, 4 months ago Vicentiu Ciorbaru <vicentiu(a)mariadb.org> origin/10.0-FusionIO 1 year, 5 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-galera-merge 1 year, 5 months ago Nirbhay Choubey <nirbhay(a)mariadb.com> origin/bb-10.1-binlog_row_image 1 year, 5 months ago Vicențiu Ciorbaru <vicentiu(a)mariadb.org> origin/bb-5.5-galera-merge 1 year, 7 months ago Nirbhay Choubey <nirbhay(a)mariadb.com> origin/bb-10.1-explain-analyze 1 year, 7 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/10.0-power 1 year, 7 months ago Sergey Vojtovich <svoj(a)mariadb.org> origin/bb-10.0-slave 1 year, 8 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-icheck 1 year, 8 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-logf 1 year, 8 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.0-validation 1 year, 8 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-sema 1 year, 9 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/sanja-old-10.0-batch 1 year, 10 months ago Oleksandr Byelkin <sanja(a)mariadb.com> origin/bb-10.1-atomics 1 year, 10 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-lf-no-oom 1 year, 10 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-encryption 1 year, 11 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-page-compress 1 year, 11 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-eperi 1 year, 11 months ago Michael Widenius <monty(a)mariadb.org> origin/bb-10.1-explain-json 1 year, 11 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-lf-iterator 1 year, 11 months ago Sergey Vojtovich <svoj(a)mariadb.org> origin/bb-10.1-4ksectors 2 years ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-set-statement 2 years ago Oleksandr Byelkin <sanja(a)mariadb.com> origin/bb-set-statement 2 years, 1 month ago Oleksandr Byelkin <sanja(a)mariadb.com> origin/bb-10.1-orderby-fixes 2 years, 1 month ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-10.1-galera 2 years, 2 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-deprecate-condpush-flag 2 years, 2 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-sysvars 2 years, 2 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-userstat 2 years, 2 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-innodb-defrag 2 years, 3 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-no-ndb 2 years, 3 months ago Sergei Golubchik <serg(a)mariadb.org> origin/10.1-fus 2 years, 4 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-fus 2 years, 4 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-fusionio 2 years, 4 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-acl-cleanup 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-cmake4plugins 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-rediscover 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-relro 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-set-sysvars 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/10.1-explain-analyze 2 years, 5 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/10.1-explain-json 2 years, 5 months ago Sergei Petrunia <psergey(a)askmonty.org> These branches all contain an MDEV in their name that has been closed: origin/10.1-MDEV-6877-binlog_row_image MDEV-6877 Closed origin/10.1-MDEV-7811 MDEV-7811 Closed origin/10.1-MDEV-7813 MDEV-7813 Closed origin/10.2-MDEV-3944 MDEV-3944 Closed origin/10.2-MDEV-8348 MDEV-8348 Closed origin/10.2-MDEV-8931 MDEV-8931 Closed origin/10.2-MDEV-9114 MDEV-9114 Closed origin/bb-10.0.22-mdev8989 MDEV-8989 Closed origin/bb-10.0-galera-mdev8496-hf MDEV-8496 Closed origin/bb-10.0-mdev-10341 MDEV-10341 Closed origin/bb-10.0-mdev7474 MDEV-7474 Closed origin/bb-10.1-mdev5429 MDEV-5429 Closed origin/bb-10.1-MDEV-6066 MDEV-6066 Closed origin/bb-10.1-mdev6657 MDEV-6657 Closed origin/bb-10.1-mdev6657-r2 MDEV-6657 Closed origin/bb-10.1-MDEV-7006 MDEV-7006 Closed origin/bb-10.1-mdev7110 MDEV-7110 Closed origin/bb-10.1-mdev7572 MDEV-7572 Closed origin/bb-10.1-mdev-8063 MDEV-8063 Closed origin/bb-10.1-MDEV-8241 MDEV-8241 Closed origin/bb-10.1-MDEV-8346 MDEV-8346 Closed origin/bb-10.1-mdev8646 MDEV-8646 Closed origin/bb-10.1-mdev8989 MDEV-8989 Closed origin/bb-10.1-mdev9007 MDEV-9007 Closed origin/bb-10.1-mdev9021 MDEV-9021 Closed origin/bb-10.1-mdev-9304 MDEV-9304 Closed origin/bb-10.1-mdev9362 MDEV-9362 Closed origin/bb-10.1-mdev-9468 MDEV-9468 Closed origin/bb-10.2-mdev10813 MDEV-10813 Closed origin/bb-10.2-mdev5492 MDEV-5492 Closed origin/bb-10.2-mdev-5535 MDEV-5535 Closed origin/bb-10.2-MDEV-6720 MDEV-6720 Closed origin/bb-10.2-mdev7660 MDEV-7660 Closed origin/bb-10.2-mdev8646 MDEV-8646 Closed origin/bb-10.2-mdev8789 MDEV-8789 Closed origin/bb-10.2-mdev9857 MDEV-9857 Closed origin/bb-10.2-mdev9864 MDEV-9864 Closed origin/bb-5.5-mdev6735 MDEV-6735 Closed origin/bb-5.5-MDEV-7445-7565-7846 MDEV-7445 Closed origin/bb-5.5-mdev-7912 MDEV-7912 Closed origin/bb-5.5-mdev-9304 MDEV-9304 Closed origin/bb-MDEV-5317 MDEV-5317 Closed origin/bb-mdev6089 MDEV-6089 Closed origin/bb-mdev7715 MDEV-7715 Closed origin/bb-mdev7728 MDEV-7728 Closed origin/bb-mdev7793 MDEV-7793 Closed origin/bb-mdev7894 MDEV-7894 Closed origin/bb-mdev7895 MDEV-7895 Closed origin/bb-mdev7922 MDEV-7922 Closed origin/bb-vicentiu-mdev7978 MDEV-7978 Closed origin/hf-10.1-mdev9021 MDEV-9021 Closed origin/hf-10.1-mdev9853 MDEV-9853 Closed origin/mdev-60-merge MDEV-60 Closed origin/MDEV-7015 MDEV-7015 Closed origin/MDEV-8909 MDEV-8909 Closed origin/mdev-8380 MDEV-8380 Closed These branches are fully merged into an existing main tree (5.5, 10.0, 10.1, 10.2, 5.5-galera, or 10.0-galera), and have not been updated for a while: origin/MDEV-8947 5 months ago Kristian Nielsen <knielsen(a)knielsen-hq.org> origin/bb-fast-connect 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/10.2-test1234 6 months ago Galina Shalygina <galashalygina(a)gmail.com> origin/10.2-connector-c-integ 7 months ago Vladislav Vaintroub <wlad(a)mariadb.com> origin/bb-10.2-mdev9543 7 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/10.2-ssl 9 months ago Vladislav Vaintroub <wlad(a)mariadb.com> origin/svoj-gittest 1 year, 6 months ago Sergey Vojtovich <svoj(a)mariadb.org> origin/10.0-defragment 1 year, 6 months ago Vicentiu Ciorbaru <vicentiu(a)mariadb.org> origin/bb-5.5-knielsen 1 year, 8 months ago Kristian Nielsen <knielsen(a)knielsen-hq.org> origin/bb-power 1 year, 10 months ago Sergey Vojtovich <svoj(a)mariadb.org> origin/bb-10.1-explain-json 1 year, 11 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-10.1-orderby-fixes 2 years, 1 month ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-10.1-galera 2 years, 2 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-fusionio 2 years, 4 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-cmake4plugins 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/10.1-explain-analyze 2 years, 5 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/10.1-explain-json 2 years, 5 months ago Sergei Petrunia <psergey(a)askmonty.org>

5 7