- developers - lists.mariadb.org

[Maria-developers] mysql engines tests fail on mariadb 5.5.25
by Rich Prohaska 26 Jun '12

26 Jun '12

hello, when i run "./mysql-test-run.pl --suite=engines/funcs,engines/iuds --force --mysqld=--partition --nowarnings --max-test-fail=0", i see lots of test failures on mariadb-5.5.25 (and other distributions). either (1) i am not running the tests correctly, or (2) the test and/or test result files are broken, or (3) there are real problems being detected. i suspect most of the failures are caused by (2) above. anyway, here are the failures: Completed: Failed 37/323 tests, 88.54% were successful. Failing test(s): engines/funcs.an_calendar engines/funcs.datetime_function engines/funcs.db_alter_collate_ascii engines/funcs.db_alter_collate_utf8 engines/funcs.db_use_error engines/funcs.de_calendar_range engines/funcs.in_calendar_2_unique_constraints_duplicate_update engines/funcs.in_calendar_pk_constraint_duplicate_update engines/funcs.in_calendar_pk_constraint_error engines/funcs.in_calendar_pk_constraint_ignore engines/funcs.in_calendar_unique_constraint_duplicate_update engines/funcs.in_calendar_unique_constraint_error engines/funcs.in_calendar_unique_constraint_ignore engines/funcs.in_multicolumn_calendar_pk_constraint_duplicate_update engines/funcs.in_multicolumn_calendar_pk_constraint_error engines/funcs.in_multicolumn_calendar_pk_constraint_ignore engines/funcs.in_multicolumn_calendar_unique_constraint_duplicate_update engines/funcs.in_multicolumn_calendar_unique_constraint_error engines/funcs.in_multicolumn_calendar_unique_constraint_ignore engines/funcs.in_multicolumn_number_pk_constraint_duplicate_update engines/funcs.in_number_boundary_error engines/funcs.in_number_decimal_boundary_error engines/funcs.ld_all_number_string_calendar_types engines/funcs.se_join_left engines/funcs.se_join_left_outer engines/funcs.se_join_natural_left engines/funcs.se_join_natural_left_outer engines/funcs.sq_all engines/funcs.sq_error engines/funcs.up_calendar_range engines/iuds.delete_time engines/iuds.insert_decimal engines/iuds.insert_number engines/iuds.insert_time engines/iuds.type_bit_iuds engines/iuds.update_delete_number engines/iuds.update_time thanks rich prohaska

3 2

Re: [Maria-developers] Add back testcase for lp:817966 (was lost in the merge)
by Sergei Golubchik 23 Jun '12

23 Jun '12

Hi, Sergey! On Jun 23, Sergey Petrunya wrote: > At file:///home/psergey/dev2/5.5-look6/ > > ------------------------------------------------------------ > revno: 3457 > revision-id: psergey(a)askmonty.org-20120623161254-ido3pf16l31psyyv > parent: knielsen(a)knielsen-hq.org-20120622084255-u53u21xv3w7sqxms > committer: Sergey Petrunya <psergey(a)askmonty.org> > branch nick: 5.5-look6 > timestamp: Sat 2012-06-23 20:12:54 +0400 > message: > Add back testcase for lp:817966 (was lost in the merge) > > === modified file 'mysql-test/t/func_in.test' > --- a/mysql-test/t/func_in.test 2012-06-20 11:01:28 +0000 > +++ b/mysql-test/t/func_in.test 2012-06-23 16:12:54 +0000 > @@ -577,6 +577,24 @@ > --echo # > --echo End of 5.1 tests > > +# > +# lp:817966 int_column IN (string_constant) > +# > +# rather illogically, when BIGINT field is compared to a string, > +# the string is converted to an integer, not to a double. > +# When some other integer field (not BIGINT) is compared to a string, > +# or when the BIGINT is not a field, but an expression, both > +# operands are compared as doubles. The latter behavior is correct, > +# according to the manual. I don't think this comment holds anymore, perhaps it'd better to remove it. > +# > +create table t1 (a bigint, b int); > +insert t1 values (1,1),(2,2),(3,3); > +select * from t1 where a in ('2.1'); > +select * from t1 where b in ('2.1'); > +select * from t1 where a='2.1'; > +select * from t1 where b='2.1'; > +select * from t1 where IF(1,a,a)='2.1'; > +drop table t1; > --echo # > --echo # LP bug#992380 Crash when creating PS for a query with > --echo # subquery in WHERE (see also mysql bug#13012483) > Regards, Sergei

1 0

[Maria-developers] lp:817966 causes wrong results when added into 5.5
by Sergei Petrunia 22 Jun '12

22 Jun '12

Hi Sergei, Remember I've pointed out that the testcase for lp:817966 is present in 5.3 but is missing in 5.5, and we figured it was lost in the merge and decided to add it? Well, if I add the testcase into 5.5 it fails like this: main.func_in [ fail ] Test ended at 2012-06-20 15:11:27 CURRENT_TEST: main.func_in --- /home/psergey/dev2/5.5-look6/mysql-test/r/func_in.result 2012-06-20 15:11:12.000000000 +0400 +++ /home/psergey/dev2/5.5-look6/mysql-test/r/func_in.reject 2012-06-20 15:11:27.000000000 +0400 @@ -793,12 +793,10 @@ insert t1 values (1,1),(2,2),(3,3); select * from t1 where a in ('2.1'); a b -2 2 select * from t1 where b in ('2.1'); a b select * from t1 where a='2.1'; a b -2 2 select * from t1 where b='2.1'; a b select * from t1 where IF(1,a,a)='2.1'; I cannot readily tell whether this is a bug or not (could be, the typecasting rules are changed in 5.5?) Do you think this should be filed as a jira issue? BR Sergei -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

2 1

[Maria-developers] MariaDB 5.5.25 release prep
by Daniel Bartholomew 22 Jun '12

22 Jun '12

All, I'm working on getting the bits and pieces ready for this release. Preliminary versions of the Release Notes and Changelog are available here: http://kb.askmonty.org/en/mariadb-5525-release-notes/ http://kb.askmonty.org/en/mariadb-5525-changelog/ As always, if there is anything which should be mentioned in the Release Notes, please let me know ASAP or jump in and edit the page directly. Thanks! -- Daniel Bartholomew MariaDB - http://mariadb.org Monty Program - http://montyprogram.com AskMonty Knowledgebase - http://kb.askmonty.org

1 0

Re: [Maria-developers] MDEV-342: Do not mark old binlog file as cleanly closed during rotate until
by Sergei Golubchik 21 Jun '12

21 Jun '12

Hi, Kristian! Look good. Just one comment, see below, and ok to push On Jun 20, Kristian Nielsen wrote: > > ------------------------------------------------------------ > revno: 3449 > revision-id: knielsen(a)knielsen-hq.org-20120619130327-7vvemizq0akoysvn > parent: knielsen(a)knielsen-hq.org-20120620122323-bimn76haijiwpo7u > committer: knielsen(a)knielsen-hq.org > branch nick: mariadb-5.5 > timestamp: Tue 2012-06-19 15:03:27 +0200 > message: > MDEV-342: Do not mark old binlog file as cleanly closed during rotate until > the new file is fully synced to disk and binlog index. This fixes a window > where a crash would leave next server restart unable to detect that a crash > occured, causing recovery to fail. > === modified file 'sql/log.cc' > --- a/sql/log.cc 2012-05-21 18:54:41 +0000 > +++ b/sql/log.cc 2012-06-19 13:03:27 +0000 > @@ -6344,6 +6373,21 @@ void MYSQL_BIN_LOG::close(uint exiting) > } > > > +/* > + For binlog rotation, this function is used to ensure that the old binlog > + file is not marked as cleanly closed until the new binlog file is synced to > + disk and index. This is needed to ensure that we will always detect a prior > + crash at next server restart. > +*/ > +void MYSQL_BIN_LOG::delayed_close(File file) > +{ > + my_off_t offset= BIN_LOG_HEADER_SIZE + FLAGS_OFFSET; > + uchar flags= 0; // clearing LOG_EVENT_BINLOG_IN_USE_F > + mysql_file_pwrite(file, &flags, 1, offset, MYF(0)); I'd rather reuse this piece of code that overwrites the flag. If you move mysql_file_close() to the caller, you can call this function set_binlog_flag_when_closing() and use it both for normal and delayed close. > + mysql_file_close(file, MYF(MY_WME)); > +} > + Regards, Sergei

1 0

[Maria-developers] Some input re MDEV-83
by Sergei Petrunia 21 Jun '12

21 Jun '12

Hi Timour, Please find below some input re MDEV-83: * I expect that MDEV-83 will have an @@optimizer_switch flag. Is that so? * MDEV-83 will change optimizer behavior, however the change will not be visible in EXPLAIN. We have a history of such attempts and we've always ended up having to fix the EXPLAIN so that the change is visible. Do you have any ideas how to do it? My proposal is to show "subquery#n" in the Extra column of the table to which the subquery predicate is attached. * You need to take join buffering into account. For example, for this query: explain select * from ten A, ten B where cond(B.col) and cond(A.col, B.col); +--+-----------+-----+----+-------------+----+-------+----+----+------------------------------------------------+ |id|select_type|table|type|possible_keys|key |key_len|ref |rows|Extra | +--+-----------+-----+----+-------------+----+-------+----+----+------------------------------------------------+ | 1|SIMPLE |A |ALL |NULL |NULL|NULL |NULL| 10| | | 1|SIMPLE |B |ALL |NULL |NULL|NULL |NULL| 10|Using where; Using join buffer (flat, BNL join) | +--+-----------+-----+----+-------------+----+-------+----+----+------------------------------------------------+ both cond(B.col) and cond(A.col, B.col) will be attached to table B, however they will have different cardinalities. * The same goes for semi-join strategies. It is possible to calculate output cardinality for any condition, however it is much less obvious. * Suppose you have a query: select * from ot1, ot2 where expr in (select it1.col1 from it1, it2 where subquery_cond(it2.col2)) suppose the join order is: SJ-Materialize-scan(it1, it2), ot1, ot2 Here, subquery_cond may only be attached inside the SJ-Materialization nest. This is because subquery cond relies on the value of it2.col2, which is not available outside the SJ-Materialization nest. * LEFT JOINs: when the query has outer joins, predicates that are attached to tables that are inner w.r.t some LEFT JOIN, are wrapped in Item_func_trig_cond. I suppose you'll reuse the wrapping code, so that repositioned conditions are wrapped into appropriate Item_func_trig_conds. I'm not sure whether we should support predicate repositioning for parts of ON expressions. I suppose not implementing this allows to deliver sooner. If this is the case, we should not support repositioning inside ON expressions in the first milestone. * Section 1.2 says: " An estimate is made of the partial result cardinality, such that it takes into account actual pushed predicate selectivity" As far as I understand, you only have ability to estimate selectivity of predicates in form "tbl1.col CMP const" For such conditions, it is known in advance which table they will be attached to. There is no need to traverse the "cheap" pushed-down conditions. Then, what exactly do you mean by "take into account actual pushed predicate selectivity"? BR Sergei -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

1 0

Re: [Maria-developers] Please review: [Commits] Rev 3538: Fix bug lp:1008773 in file:///home/tsk/mprog/src/5.3-lpb1008773/
by Sergei Petrunia 18 Jun '12

18 Jun '12

Hi Timour, Ok to push. On Tue, Jun 05, 2012 at 04:20:35PM +0300, Timour Katchaounov wrote: > Sergey, > > Could you please review yet another rather trivial fix. > The only thing here is whether the semantics is correct. > As the bug report says, all MariaDB/MySQL versions (except > mariadb 5.3/5.5), and Postgresql return the value of the > constant as part of the empty row produced when we have > implicit grouping. I didn't verify this in the SQL standard, > because AFAIR this is non-standard. > > Timour > > ------------------------------------------------------------ > revno: 3538 > revision-id: timour(a)askmonty.org-20120605124124-akdmgdmr01h10s2w > parent: psergey(a)askmonty.org-20120602121305-mhw0u2zppjk0erhk > fixes bug(s): https://launchpad.net/bugs/1008773 > committer: timour(a)askmonty.org > branch nick: 5.3-lpb1008773 > timestamp: Tue 2012-06-05 15:41:24 +0300 > message: > Fix bug lp:1008773 > > Analysis: > Queries with implicit grouping (there is aggregate, but no group by) > follow some non-obvious semantics in the case of empty result set. > Aggregate functions produce some special "natural" value depending on > the function. For instance MIN/MAX return NULL, COUNT returns 0. > > The complexity comes from non-aggregate expressions in the select list. > If the non-aggregate expression is a constant, it can be computed, so > we should return its value, however if the expression is non-constant, > and depends on columns from the empty result set, then the only meaningful > value is NULL. > > The cause of the wrong result was that for subqueries the optimizer didn't > make a difference between constant and non-constant ones in the case of > empty result for implicit grouping. > > Solution: > In all implementations of Item_subselect::no_rows_in_result() check if the > subquery predicate is constant. If it is constant, do not set it to the > default value for implicit grouping, instead let it be evaluated. > === modified file 'mysql-test/r/subselect4.result' > --- a/mysql-test/r/subselect4.result 2012-02-28 14:41:55 +0000 > +++ b/mysql-test/r/subselect4.result 2012-06-05 12:41:24 +0000 > @@ -2124,6 +2124,61 @@ ERROR 21000: Subquery returns more than > DROP TABLE t2; > ERROR 42S02: Unknown table 't2' > DROP TABLE t1; > +# > +# LP BUG#1008773 Wrong result (NULL instead of a value) with no matching rows, subquery in FROM and HAVING > +# > +CREATE TABLE t1 (a INT) ENGINE=MyISAM; > +CREATE TABLE t2 (b INT) ENGINE=MyISAM; > +INSERT INTO t2 VALUES (1); > +EXPLAIN > +SELECT MAX(a), ( SELECT 1 FROM t2 ) AS bb FROM t1; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY t1 system NULL NULL NULL NULL 0 const row not found > +2 SUBQUERY t2 system NULL NULL NULL NULL 1 > +SELECT MAX(a), ( SELECT 1 FROM t2 ) AS bb FROM t1; > +MAX(a) bb > +NULL 1 > +EXPLAIN > +SELECT MAX(a), 1 in ( SELECT b FROM t2 ) AS bb FROM t1; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY t1 system NULL NULL NULL NULL 0 const row not found > +2 DEPENDENT SUBQUERY t2 system NULL NULL NULL NULL 1 > +SELECT MAX(a), 1 in ( SELECT b FROM t2 ) AS bb FROM t1; > +MAX(a) bb > +NULL 1 > +EXPLAIN > +SELECT MAX(a), 1 >= ALL ( SELECT b FROM t2 ) AS bb FROM t1; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY t1 system NULL NULL NULL NULL 0 const row not found > +2 DEPENDENT SUBQUERY NULL NULL NULL NULL NULL NULL NULL Impossible WHERE noticed after reading const tables > +SELECT MAX(a), 1 >= ALL ( SELECT b FROM t2 ) AS bb FROM t1; > +MAX(a) bb > +NULL 1 > +EXPLAIN > +SELECT MAX(a), ( SELECT 1 FROM t2 where b = a) AS bb FROM t1; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY t1 system NULL NULL NULL NULL 0 const row not found > +2 DEPENDENT SUBQUERY NULL NULL NULL NULL NULL NULL NULL Impossible WHERE noticed after reading const tables > +SELECT MAX(a), ( SELECT 1 FROM t2 where b = a) AS bb FROM t1; > +MAX(a) bb > +NULL NULL > +EXPLAIN > +SELECT MAX(a), a in ( SELECT b FROM t2 ) AS bb FROM t1; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY t1 system NULL NULL NULL NULL 0 const row not found > +2 DEPENDENT SUBQUERY t2 system NULL NULL NULL NULL 1 > +SELECT MAX(a), a in ( SELECT b FROM t2 ) AS bb FROM t1; > +MAX(a) bb > +NULL NULL > +EXPLAIN > +SELECT MAX(a), a >= ALL ( SELECT b FROM t2 ) AS bb FROM t1; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY t1 system NULL NULL NULL NULL 0 const row not found > +2 DEPENDENT SUBQUERY t2 system NULL NULL NULL NULL 1 > +SELECT MAX(a), a >= ALL ( SELECT b FROM t2 ) AS bb FROM t1; > +MAX(a) bb > +NULL NULL > +drop table t1, t2; > set optimizer_switch=@subselect4_tmp; > SET optimizer_switch= @@global.optimizer_switch; > set @@tmp_table_size= @@global.tmp_table_size; > > === modified file 'mysql-test/t/subselect4.test' > --- a/mysql-test/t/subselect4.test 2012-02-28 14:41:55 +0000 > +++ b/mysql-test/t/subselect4.test 2012-06-05 12:41:24 +0000 > @@ -1761,6 +1761,40 @@ CREATE TABLE t2 AS > DROP TABLE t2; > DROP TABLE t1; > > +--echo # > +--echo # LP BUG#1008773 Wrong result (NULL instead of a value) with no matching rows, subquery in FROM and HAVING > +--echo # > + > +CREATE TABLE t1 (a INT) ENGINE=MyISAM; > +CREATE TABLE t2 (b INT) ENGINE=MyISAM; > +INSERT INTO t2 VALUES (1); > + > +EXPLAIN > +SELECT MAX(a), ( SELECT 1 FROM t2 ) AS bb FROM t1; > +SELECT MAX(a), ( SELECT 1 FROM t2 ) AS bb FROM t1; > + > +EXPLAIN > +SELECT MAX(a), 1 in ( SELECT b FROM t2 ) AS bb FROM t1; > +SELECT MAX(a), 1 in ( SELECT b FROM t2 ) AS bb FROM t1; > + > +EXPLAIN > +SELECT MAX(a), 1 >= ALL ( SELECT b FROM t2 ) AS bb FROM t1; > +SELECT MAX(a), 1 >= ALL ( SELECT b FROM t2 ) AS bb FROM t1; > + > + > +EXPLAIN > +SELECT MAX(a), ( SELECT 1 FROM t2 where b = a) AS bb FROM t1; > +SELECT MAX(a), ( SELECT 1 FROM t2 where b = a) AS bb FROM t1; > + > +EXPLAIN > +SELECT MAX(a), a in ( SELECT b FROM t2 ) AS bb FROM t1; > +SELECT MAX(a), a in ( SELECT b FROM t2 ) AS bb FROM t1; > + > +EXPLAIN > +SELECT MAX(a), a >= ALL ( SELECT b FROM t2 ) AS bb FROM t1; > +SELECT MAX(a), a >= ALL ( SELECT b FROM t2 ) AS bb FROM t1; > + > +drop table t1, t2; > > set optimizer_switch=@subselect4_tmp; > > > === modified file 'sql/item_subselect.cc' > --- a/sql/item_subselect.cc 2012-05-22 12:22:55 +0000 > +++ b/sql/item_subselect.cc 2012-06-05 12:41:24 +0000 > @@ -892,6 +892,8 @@ void Item_maxmin_subselect::print(String > > void Item_maxmin_subselect::no_rows_in_result() > { > + if (const_item()) > + return; > value= Item_cache::get_cache(new Item_null()); > null_value= 0; > was_values= 0; > @@ -901,6 +903,8 @@ void Item_maxmin_subselect::no_rows_in_r > > void Item_singlerow_subselect::no_rows_in_result() > { > + if (const_item()) > + return; > value= Item_cache::get_cache(new Item_null()); > reset(); > make_const(); > @@ -1363,6 +1367,8 @@ Item* Item_exists_subselect::expr_cache_ > > void Item_exists_subselect::no_rows_in_result() > { > + if (const_item()) > + return; > value= 0; > null_value= 0; > make_const(); > @@ -2707,6 +2713,8 @@ void Item_allany_subselect::print(String > > void Item_allany_subselect::no_rows_in_result() > { > + if (const_item()) > + return; > value= 0; > null_value= 0; > was_null= 0; > > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits -- BR Sergei -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

3 2

Re: [Maria-developers] [Commits] Rev 3434: MDEV-339, LP1001340 - system_time_zone is wrong on Windows in file:///H:/bzr/5.5/
by Sergei Golubchik 15 Jun '12

15 Jun '12

Hi, Vladislav! On Jun 15, Vladislav Vaintroub wrote: > ------------------------------------------------------------ > revno: 3434 > revision-id: wlad(a)montyprogram.com-20120615152106-p4a50d0yv2qj4fxk > parent: wlad(a)montyprogram.com-20120613093751-tv67fxuh1qcxm0by > fixes bug: https://launchpad.net/bugs/1001340 > committer: Vladislav Vaintroub <wlad(a)montyprogram.com> > branch nick: 5.5 > timestamp: Fri 2012-06-15 17:21:06 +0200 > message: > MDEV-339, LP1001340 - system_time_zone is wrong on Windows > > On localized Windows versions, Windows uses localized time zone > names and contain non-ASCII characters. non-ASCII characters appear > broken when displayed by clients > The fix is to declare system_time_zone variable to have UTF8 > encoding and to convert tzname to UTF8. Looks good, thanks! Did you verify that it works? (I vaguely remember that you don't have a localized Windows version) Ok to push, if yes. Regards, Sergei

1 0

Re: [Maria-developers] MDEV-339 lp:1001340 system_time_zone is wrong on Windows
by Sergei Golubchik 15 Jun '12

15 Jun '12

Hi, Vladislav! On Jun 14, Vladislav Vaintroub wrote: > At file:///H:/bzr/5.5/ > > revno: 3434 > revision-id: wlad(a)montyprogram.com-20120614122958-bq20w9xbqjw032nk > parent: wlad(a)montyprogram.com-20120613093751-tv67fxuh1qcxm0by > fixes bug: https://launchpad.net/bugs/1001340 > committer: Vladislav Vaintroub <wlad(a)montyprogram.com> > branch nick: 5.5 > timestamp: Thu 2012-06-14 14:29:58 +0200 > message: > MDEV-339, LP1001340 - system_time_zone is wrong on Windows > > On localized Windows versions, Windows uses localized time zone > names. Since characters in timezone name can be outside of ASCII > range, thus not every client would be able to read variable without > loosing information, and even server misinterprets the encoding (it > does not try to interpret the encoding). > > The fix is to use the UTC offset format "+/-hh:mm" for > system_time_zone on Windows, compatible with time_zone values > everywhere else. UTC offset format is however not used if TZ > environment variable is defined - MySQL documents to handle TZ > environment variable in OS-dependent way. I am not sure I like this idea. UTC offset format specifies a *different* time zone. Not the system one. Timezone that surely produces different results for the historical dates. Original bug report says that system_time_zone value is not a valid MySQL (or POSIX) time zone name. But is it a problem? When time_zone is set to SYSTEM, MariaDB will use OS functions for date/time conversion, and not the data from timezone tables. So it will use the system time zone *exactly*, not UTC offset approximation. And it won't try to look up system_time_zone value in the timezone tables. So, I think, it's quite ok for system_time_zone to have "Westeuropäische Sommerzeit" value. You only need to fix the charset/truncation issue and that's all. Regards, Sergei

3 2

Re: [Maria-developers] [Commits] Rev 3543: Fix bug lp:1008686 in file:///home/tsk/mprog/src/5.3/
by Sergei Petrunia 14 Jun '12

14 Jun '12

Hi Timour, How does this relate to fix for lp:1008773? In this bug, you've added: > + if (parsing_place != SELECT_LIST) > + return; and in that one: > + if (const_item()) > + return; How will the fixes work together? Generally, I'm wondering if we're taking the right approach here: from an out-of-context view, it seems that approach "equip every Item with ability to evaluate to NULL under some special circumnstances" is very confusing, and one should just ignore the non-group-by items and produce NULLs instead.. Let's discuss it on irc. On Wed, Jun 13, 2012 at 08:52:19AM +0000, timour(a)askmonty.org wrote: > At file:///home/tsk/mprog/src/5.3/ > > ------------------------------------------------------------ > revno: 3543 > revision-id: timour(a)askmonty.org-20120613085100-1a3zlttyiebfvzuy > parent: psergey(a)askmonty.org-20120610100611-0l0qf7ov53h1elr9 > fixes bug(s): https://launchpad.net/bugs/1008686 > committer: timour(a)askmonty.org > branch nick: 5.3 > timestamp: Wed 2012-06-13 11:51:00 +0300 > message: > Fix bug lp:1008686 > > Analysis: > The fix for bug lp:985667 implements the method Item_subselect::no_rows_in_result() > for all main kinds of subqueries. The purpose of this method is to be called from > return_zero_rows() and set Items to some default value in the case when a query > returns no rows. Aggregates and subqueries require special treatment in this case. > > Every implementation of Item_subselect::no_rows_in_result() called > Item_subselect::make_const() to set the subquery predicate to its default value > irrespective of where the predicate was located in the query. Once the predicate > was set to a constant it was never executed. > > At the same time, the JOIN object of the fake select for UNIONs (the one used for > the final result of the UNION), was set after all subqueries in the union were > executed. Since we set the subquery as constant, it was never executed, and the > corresponding JOIN was never created. > > In order to decide whether the result of NOT IN is NULL or FALSE, Item_in_optimizer > needs to check if the subquery result was empty or not. This is where we got the > crash, because subselect_union_engine::no_rows() checks for > unit->fake_select_lex->join->send_records, and the join object was NULL. > > Solution: > If a subquery is in the HAVING clause it must be evaluated in order to know its > result, so that we can properly filter the result records. Once subqueries in the > HAVING clause are executed even in the case of no result rows, this specific > crash will be solved, because the UNION will be executed, and its JOIN will be > constructed. Therefore the fix for this crash is to narrow the fix for lp:985667, > and to apply Item_subselect::no_rows_in_result() only when the subquery predicate > is in the SELECT clause. > === modified file 'mysql-test/r/subselect.result' > --- a/mysql-test/r/subselect.result 2012-06-05 14:25:10 +0000 > +++ b/mysql-test/r/subselect.result 2012-06-13 08:51:00 +0000 > @@ -6112,5 +6112,30 @@ NULL UNION RESULT <union2,3> ALL NULL NU > SELECT SUM(a) AS f1, a AS f2 FROM (t1, t2) HAVING f2 >= ALL (SELECT 4 UNION SELECT 5) AND f1 = 7; > f1 f2 > drop table t1,t2; > +# > +# LP BUG#1008686 Server crashes in subselect_union_engine::no_rows on SELECT with impossible > +# WHERE and UNION in HAVING > +# > +CREATE TABLE t1 (a INT); > +INSERT INTO t1 VALUES (1),(7); > +EXPLAIN > +SELECT MIN(a) AS min_a, a FROM t1 WHERE 0 HAVING a NOT IN ( SELECT 2 UNION SELECT 5 ) OR min_a != 1; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY NULL NULL NULL NULL NULL NULL NULL Impossible WHERE > +2 DEPENDENT SUBQUERY NULL NULL NULL NULL NULL NULL NULL No tables used > +3 DEPENDENT UNION NULL NULL NULL NULL NULL NULL NULL No tables used > +NULL UNION RESULT <union2,3> ALL NULL NULL NULL NULL NULL > +SELECT MIN(a) AS min_a, a FROM t1 WHERE 0 HAVING a NOT IN ( SELECT 2 UNION SELECT 5 ) OR min_a != 1; > +min_a a > +EXPLAIN > +SELECT MIN(a) AS min_a, a FROM t1 WHERE 1=2 HAVING a NOT IN ( SELECT a from t1 UNION select a+1 from t1 ) OR min_a != 1; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY NULL NULL NULL NULL NULL NULL NULL Impossible WHERE > +2 DEPENDENT SUBQUERY t1 ALL NULL NULL NULL NULL 2 Using where > +3 DEPENDENT UNION t1 ALL NULL NULL NULL NULL 2 Using where > +NULL UNION RESULT <union2,3> ALL NULL NULL NULL NULL NULL > +SELECT MIN(a) AS min_a, a FROM t1 WHERE 1=2 HAVING a NOT IN ( SELECT a from t1 UNION select a+1 from t1 ) OR min_a != 1; > +min_a a > +drop table t1; > # return optimizer switch changed in the beginning of this test > set optimizer_switch=@subselect_tmp; > > === modified file 'mysql-test/t/subselect.test' > --- a/mysql-test/t/subselect.test 2012-05-22 12:22:55 +0000 > +++ b/mysql-test/t/subselect.test 2012-06-13 08:51:00 +0000 > @@ -5190,5 +5190,23 @@ SELECT SUM(a) AS f1, a AS f2 FROM (t1, t > > drop table t1,t2; > > +--echo # > +--echo # LP BUG#1008686 Server crashes in subselect_union_engine::no_rows on SELECT with impossible > +--echo # WHERE and UNION in HAVING > +--echo # > + > +CREATE TABLE t1 (a INT); > +INSERT INTO t1 VALUES (1),(7); > + > +EXPLAIN > +SELECT MIN(a) AS min_a, a FROM t1 WHERE 0 HAVING a NOT IN ( SELECT 2 UNION SELECT 5 ) OR min_a != 1; > +SELECT MIN(a) AS min_a, a FROM t1 WHERE 0 HAVING a NOT IN ( SELECT 2 UNION SELECT 5 ) OR min_a != 1; > + > +EXPLAIN > +SELECT MIN(a) AS min_a, a FROM t1 WHERE 1=2 HAVING a NOT IN ( SELECT a from t1 UNION select a+1 from t1 ) OR min_a != 1; > +SELECT MIN(a) AS min_a, a FROM t1 WHERE 1=2 HAVING a NOT IN ( SELECT a from t1 UNION select a+1 from t1 ) OR min_a != 1; > + > +drop table t1; > + > --echo # return optimizer switch changed in the beginning of this test > set optimizer_switch=@subselect_tmp; > > === modified file 'sql/item_subselect.cc' > --- a/sql/item_subselect.cc 2012-05-22 12:22:55 +0000 > +++ b/sql/item_subselect.cc 2012-06-13 08:51:00 +0000 > @@ -892,6 +892,8 @@ void Item_maxmin_subselect::print(String > > void Item_maxmin_subselect::no_rows_in_result() > { > + if (parsing_place != SELECT_LIST) > + return; > value= Item_cache::get_cache(new Item_null()); > null_value= 0; > was_values= 0; > @@ -901,6 +903,8 @@ void Item_maxmin_subselect::no_rows_in_r > > void Item_singlerow_subselect::no_rows_in_result() > { > + if (parsing_place != SELECT_LIST) > + return; > value= Item_cache::get_cache(new Item_null()); > reset(); > make_const(); > @@ -1363,6 +1367,8 @@ Item* Item_exists_subselect::expr_cache_ > > void Item_exists_subselect::no_rows_in_result() > { > + if (parsing_place != SELECT_LIST) > + return; > value= 0; > null_value= 0; > make_const(); > @@ -2707,6 +2713,8 @@ void Item_allany_subselect::print(String > > void Item_allany_subselect::no_rows_in_result() > { > + if (parsing_place != SELECT_LIST) > + return; > value= 0; > null_value= 0; > was_null= 0; > > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits -- BR Sergei -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

1 0