- developers - lists.mariadb.org

[Maria-developers] Deleting unused branches on github
by Kristian Nielsen 10 Nov '16

10 Nov '16

We currently have more than 200 branches in the MariaDB Server github repo, most of which look like they are no longer used. I would like to remove the unused ones to remove clutter. Eg. in `git branch -la` or the drop-downs on the github webpage. Below is a list of a little less than two-thirds of the branches that I determined to be probably unused. I was fairly conservative in my criteria, ie. if there was reasonable doubt, I omitted a branch from the list to delete. Please take a look at the list and see if there is any branch that should _not_ be deleted from the github repository. Or if someone objects to deleting anything on principle grounds, let me know as well, of course. (I Cc'ed people that were the last to commit on a branch to be deleted). Note that if one of these branches should become needed again later, eg. some bb-XXX branch not used for a long time, there is no problem re-creating it. The only problem with removing a branch should be if it contains contents that will be needed in the future, and which is not available anywhere else (and I tried to avoid putting such branches on the list in the first place). Also note that once these are deleted, a simple `git pull` will not remove them from the local clone. The `git fetch --prune` can be used to effect this. If there are no objections, I will do the deletions in two weeks. - Kristian. ----------------------------------------------------------------------- These branches have not been updated for a long time, and looked like they were not used any more. They are annotated with the date and the committer of the last commit: origin/bb-10.2-decimal 5 months ago Monty <monty(a)mariadb.org> origin/bb-10.1-jan2 8 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-xtrabackup 8 months ago Vladislav Vaintroub <wlad(a)mariadb.com> origin/10.2-window_simple 9 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-10.2-vicentiu-create 10 months ago Vicențiu Ciorbaru <vicentiu(a)mariadb.org> origin/bb-10.0-galera-jan 11 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/10.2-travis-ci 12 months ago Otto Kekäläinen <otto(a)mariadb.org> origin/bb-10.1-systemd 1 year ago Sergey Vojtovich <svoj(a)mariadb.org> origin/bb-10.1-jan-encryption 1 year, 1 month ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/10.1-spider 1 year, 1 month ago Michael Widenius <monty(a)mariadb.org> origin/bb-svoj 1 year, 1 month ago Sergey Vojtovich <svoj(a)mariadb.org> origin/wip-binlog-encryption 1 year, 2 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-5.5-inno 1 year, 3 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-default 1 year, 3 months ago Monty <monty(a)mariadb.org> origin/10.0-FusionIO-Galera 1 year, 4 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/10.0-custombld 1 year, 4 months ago Kristian Nielsen <knielsen(a)knielsen-hq.org> origin/10.1-window 1 year, 4 months ago Vicentiu Ciorbaru <vicentiu(a)mariadb.org> origin/10.0-FusionIO 1 year, 5 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-galera-merge 1 year, 5 months ago Nirbhay Choubey <nirbhay(a)mariadb.com> origin/bb-10.1-binlog_row_image 1 year, 5 months ago Vicențiu Ciorbaru <vicentiu(a)mariadb.org> origin/bb-5.5-galera-merge 1 year, 7 months ago Nirbhay Choubey <nirbhay(a)mariadb.com> origin/bb-10.1-explain-analyze 1 year, 7 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/10.0-power 1 year, 7 months ago Sergey Vojtovich <svoj(a)mariadb.org> origin/bb-10.0-slave 1 year, 8 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-icheck 1 year, 8 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.1-logf 1 year, 8 months ago Jan Lindström <jan.lindstrom(a)mariadb.com> origin/bb-10.0-validation 1 year, 8 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-sema 1 year, 9 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/sanja-old-10.0-batch 1 year, 10 months ago Oleksandr Byelkin <sanja(a)mariadb.com> origin/bb-10.1-atomics 1 year, 10 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-lf-no-oom 1 year, 10 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-encryption 1 year, 11 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-page-compress 1 year, 11 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-eperi 1 year, 11 months ago Michael Widenius <monty(a)mariadb.org> origin/bb-10.1-explain-json 1 year, 11 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-lf-iterator 1 year, 11 months ago Sergey Vojtovich <svoj(a)mariadb.org> origin/bb-10.1-4ksectors 2 years ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-set-statement 2 years ago Oleksandr Byelkin <sanja(a)mariadb.com> origin/bb-set-statement 2 years, 1 month ago Oleksandr Byelkin <sanja(a)mariadb.com> origin/bb-10.1-orderby-fixes 2 years, 1 month ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-10.1-galera 2 years, 2 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-deprecate-condpush-flag 2 years, 2 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-sysvars 2 years, 2 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-userstat 2 years, 2 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-innodb-defrag 2 years, 3 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-no-ndb 2 years, 3 months ago Sergei Golubchik <serg(a)mariadb.org> origin/10.1-fus 2 years, 4 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-fus 2 years, 4 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-fusionio 2 years, 4 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-acl-cleanup 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-cmake4plugins 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-rediscover 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-relro 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/bb-10.1-set-sysvars 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/10.1-explain-analyze 2 years, 5 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/10.1-explain-json 2 years, 5 months ago Sergei Petrunia <psergey(a)askmonty.org> These branches all contain an MDEV in their name that has been closed: origin/10.1-MDEV-6877-binlog_row_image MDEV-6877 Closed origin/10.1-MDEV-7811 MDEV-7811 Closed origin/10.1-MDEV-7813 MDEV-7813 Closed origin/10.2-MDEV-3944 MDEV-3944 Closed origin/10.2-MDEV-8348 MDEV-8348 Closed origin/10.2-MDEV-8931 MDEV-8931 Closed origin/10.2-MDEV-9114 MDEV-9114 Closed origin/bb-10.0.22-mdev8989 MDEV-8989 Closed origin/bb-10.0-galera-mdev8496-hf MDEV-8496 Closed origin/bb-10.0-mdev-10341 MDEV-10341 Closed origin/bb-10.0-mdev7474 MDEV-7474 Closed origin/bb-10.1-mdev5429 MDEV-5429 Closed origin/bb-10.1-MDEV-6066 MDEV-6066 Closed origin/bb-10.1-mdev6657 MDEV-6657 Closed origin/bb-10.1-mdev6657-r2 MDEV-6657 Closed origin/bb-10.1-MDEV-7006 MDEV-7006 Closed origin/bb-10.1-mdev7110 MDEV-7110 Closed origin/bb-10.1-mdev7572 MDEV-7572 Closed origin/bb-10.1-mdev-8063 MDEV-8063 Closed origin/bb-10.1-MDEV-8241 MDEV-8241 Closed origin/bb-10.1-MDEV-8346 MDEV-8346 Closed origin/bb-10.1-mdev8646 MDEV-8646 Closed origin/bb-10.1-mdev8989 MDEV-8989 Closed origin/bb-10.1-mdev9007 MDEV-9007 Closed origin/bb-10.1-mdev9021 MDEV-9021 Closed origin/bb-10.1-mdev-9304 MDEV-9304 Closed origin/bb-10.1-mdev9362 MDEV-9362 Closed origin/bb-10.1-mdev-9468 MDEV-9468 Closed origin/bb-10.2-mdev10813 MDEV-10813 Closed origin/bb-10.2-mdev5492 MDEV-5492 Closed origin/bb-10.2-mdev-5535 MDEV-5535 Closed origin/bb-10.2-MDEV-6720 MDEV-6720 Closed origin/bb-10.2-mdev7660 MDEV-7660 Closed origin/bb-10.2-mdev8646 MDEV-8646 Closed origin/bb-10.2-mdev8789 MDEV-8789 Closed origin/bb-10.2-mdev9857 MDEV-9857 Closed origin/bb-10.2-mdev9864 MDEV-9864 Closed origin/bb-5.5-mdev6735 MDEV-6735 Closed origin/bb-5.5-MDEV-7445-7565-7846 MDEV-7445 Closed origin/bb-5.5-mdev-7912 MDEV-7912 Closed origin/bb-5.5-mdev-9304 MDEV-9304 Closed origin/bb-MDEV-5317 MDEV-5317 Closed origin/bb-mdev6089 MDEV-6089 Closed origin/bb-mdev7715 MDEV-7715 Closed origin/bb-mdev7728 MDEV-7728 Closed origin/bb-mdev7793 MDEV-7793 Closed origin/bb-mdev7894 MDEV-7894 Closed origin/bb-mdev7895 MDEV-7895 Closed origin/bb-mdev7922 MDEV-7922 Closed origin/bb-vicentiu-mdev7978 MDEV-7978 Closed origin/hf-10.1-mdev9021 MDEV-9021 Closed origin/hf-10.1-mdev9853 MDEV-9853 Closed origin/mdev-60-merge MDEV-60 Closed origin/MDEV-7015 MDEV-7015 Closed origin/MDEV-8909 MDEV-8909 Closed origin/mdev-8380 MDEV-8380 Closed These branches are fully merged into an existing main tree (5.5, 10.0, 10.1, 10.2, 5.5-galera, or 10.0-galera), and have not been updated for a while: origin/MDEV-8947 5 months ago Kristian Nielsen <knielsen(a)knielsen-hq.org> origin/bb-fast-connect 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/10.2-test1234 6 months ago Galina Shalygina <galashalygina(a)gmail.com> origin/10.2-connector-c-integ 7 months ago Vladislav Vaintroub <wlad(a)mariadb.com> origin/bb-10.2-mdev9543 7 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/10.2-ssl 9 months ago Vladislav Vaintroub <wlad(a)mariadb.com> origin/svoj-gittest 1 year, 6 months ago Sergey Vojtovich <svoj(a)mariadb.org> origin/10.0-defragment 1 year, 6 months ago Vicentiu Ciorbaru <vicentiu(a)mariadb.org> origin/bb-5.5-knielsen 1 year, 8 months ago Kristian Nielsen <knielsen(a)knielsen-hq.org> origin/bb-power 1 year, 10 months ago Sergey Vojtovich <svoj(a)mariadb.org> origin/bb-10.1-explain-json 1 year, 11 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-10.1-orderby-fixes 2 years, 1 month ago Sergei Petrunia <psergey(a)askmonty.org> origin/bb-10.1-galera 2 years, 2 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-fusionio 2 years, 4 months ago Jan Lindström <jan.lindstrom(a)skysql.com> origin/bb-10.1-cmake4plugins 2 years, 5 months ago Sergei Golubchik <serg(a)mariadb.org> origin/10.1-explain-analyze 2 years, 5 months ago Sergei Petrunia <psergey(a)askmonty.org> origin/10.1-explain-json 2 years, 5 months ago Sergei Petrunia <psergey(a)askmonty.org>

5 7

[Maria-developers] Please review a fix for MDEV-10780 (and likely for MDEV-10806 and MDEV-10910)
by Alexander Barkov 10 Nov '16

10 Nov '16

Hello Sanja, Elena, Wlad, Sanja, please review a patch for MDEV-10780. The patch is for 10.1. I could not reproduce it in 10.0. But it should be safe to push it into 10.0 anyway. This patch is most likely fixing MDEV-10806 (assigned to Sanja) and MDEV-10910 (assigned to Elena). Thanks!

3 6

[Maria-developers] Building MariaDB 10.3 on windows
by jerome brauge 07 Nov '16

07 Nov '16

Hi, I'm new on this mailing list, so sorry if it's not the right place. I'm trying to build MariaDB 10.3 on Windows 10 with Visual Studio Express 2014. Compiling failed with many errors "fatal error C1189: #error: Macro definition of snprintf conflicts with Standard Library function declaration". To correct this, in ma_global.h, i replaced line #define snprintf _snprintf by #ifdef _MSC_VER #if _MSC_VER< 1900 #define snprintf _snprintf #endif #else #define snprintf _snprintf #endif and build success. Best regards. J.Brauge -----Message d'origine----- De : Maria-developers [mailto:maria-developers-bounces+j.brauge=qualiac.com@lists.launchpad.net] De la part de Sergei Golubchik Envoyé : vendredi 4 novembre 2016 11:41 À : maria-developers(a)lists.launchpad.net Objet : [Maria-developers] security spring cleaning in MariaDB org on github Hi, Now when Github has per-user ownership rights and suggests to migrate away from the legacy admin team https://help.github.com/articles/migrating-your-previous-admin-teams-to-the… we're performing some spring cleaning in this area. The legacy admin team (named "Core") is removed. Most of its members lost admin access to the org. Currently only the MariaDB Foundation CEO and few board members (those, who actually have used admin access recently) retained their admin rights. Everyone who was in the Core team should still have write access to repositories, if you've found that it's not the case, please complain asap. If you think you need admin access, please request it (again). Note that - only members of the organization can have it, being in the Developers group is a plus - 2FA is required for all admins (and highly recommended for all other members) Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org _______________________________________________ Mailing list: https://launchpad.net/~maria-developers Post to : maria-developers(a)lists.launchpad.net Unsubscribe : https://launchpad.net/~maria-developers More help : https://help.launchpad.net/ListHelp

2 1

[Maria-developers] Please review MDEV-11245 Move prepare_create_field and sp_prepare_create_field() as methods to Column_definition
by Alexander Barkov 07 Nov '16

07 Nov '16

Hello Monty, I'm done with: MDEV-10577 sql_mode=ORACLE: %TYPE in variable declarations But I'd like to move a certain part of MDEV-10577 into a separate patch. I created an MDEV entry for this: MDEV-11245 Move prepare_create_field and sp_prepare_create_field() as methods to Column_definition Can you please review it? See attached. There's also a copy here: hasky.askmonty.org:/tmp/MDEV-11245.diff The patch is for 10.3. Thanks.

1 0

[Maria-developers] Community Involvement - GSoC Mentor Summit impressions
by Vicențiu Ciorbaru 07 Nov '16

07 Nov '16

Hi everyone! Since MariaDB has completed another Google Summer of Code program this year, with some great projects as well, the MariaDB Foundation was able to send 2 mentors to the summit in California this year. I was one of the people that had the privilege to go. There were a lot of talks there about community involvement and how to encourage people to contribute. I've picked the ideas that I've found to be most interesting and useful and have blogged [1] about them. I intend to try and apply some of them if possible. Since this is a community matter (albeit more GSoC related), it makes sense to ask for feedback from the community. I think some of the ideas are at least partly implemented but we can always do better. If you're interested, lets have a discussion on this. Vicențiu [1] http://vicentiu.ciorbaru.io/community-involvement-gsoc-mentor-summit-impres…

1 0

[Maria-developers] security spring cleaning in MariaDB org on github
by Sergei Golubchik 07 Nov '16

07 Nov '16

Hi, Now when Github has per-user ownership rights and suggests to migrate away from the legacy admin team https://help.github.com/articles/migrating-your-previous-admin-teams-to-the… we're performing some spring cleaning in this area. The legacy admin team (named "Core") is removed. Most of its members lost admin access to the org. Currently only the MariaDB Foundation CEO and few board members (those, who actually have used admin access recently) retained their admin rights. Everyone who was in the Core team should still have write access to repositories, if you've found that it's not the case, please complain asap. If you think you need admin access, please request it (again). Note that - only members of the organization can have it, being in the Developers group is a plus - 2FA is required for all admins (and highly recommended for all other members) Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

2 5

[Maria-developers] Please review: support for --force-restart in MTR
by Sergey Petrunia 07 Nov '16

07 Nov '16

Hi Sergei, Elena I'm not sure who maintains mysql-test-run.pl but you two seem to have contributed to it in the past, this is why I'm addressing this to you. I'm going to get "MTR v2" to support --force-restart, just like MTR v1 did; http://lists.askmonty.org/pipermail/commits/2016-November/010062.html http://lists.askmonty.org/pipermail/commits/2016-November/010063.html Since I don't really understand this MTRv1 vs MTRv2 change (and why some things are in v1 but not in v2, etc), I wanted to check this change with you. Thanks, Sergei -- Sergei Petrunia, Software Developer MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog

1 0

Re: [Maria-developers] [MariaDB/server] MDEV-11065 - Compressed binary log (#247)
by Kristian Nielsen 03 Nov '16

03 Nov '16

vinchen <notifications(a)github.com> writes: > The new code is here: > https://github.com/vinchen/server/commits/GCSAdmin-10.2-binlog-compressed2-2 > And added two fixed: > 1.Avoid overflowing buffers in case of corrupt events > 2.Check the compressed algorithm. Looks fine, thanks for fixing this. I have now merged and pushed this to MariaDB 10.2. > > Rows_log_event::write_data_body(). I *think* the reason for that is that > > the > > SQL thread never sees the compressed events (they are uncompressed by the > > IO > > thread), but I would like your confirmation that my understanding is > > correct. > > 3. Did you think about testing that BINLOG statements with compressed > As mentioned above, the compressed events would uncompressed in constructor > in SQL thread. Right, thanks, I understand now. So the BINLOG statements in the output of mysqlbinlog have the uncompressed data. This makes sense, just like the SQL queries are uncompressed before being output by mysqlbinlog. So in fact, one change I suggested is wrong, to accept compressed event types in BINLOG statements. So I reverted this change again, and also added some test cases: https://github.com/MariaDB/server/commit/56a041cde657e5618c519a3c50e8075136… BTW, I think this is recently merged code (from the delayed replication feature) that would not have appeared in your original patch. Thanks for the explanation to help me understand this. I also fixed a .result file - this is a failure that would only show up when running the test suite with --embedded: https://github.com/MariaDB/server/commit/3c0ff6153f75bb8e63c08ff3c828235512… So I think everything should be fine now and this should appear in MariaDB 10.2.3, if I understand correctly. Once again thanks for the patch. It was a pleasure to see a replication addition that was so well done, and with so much attention to detail. - Kristian.

1 0

[Maria-developers] MDEV-11219 main.null fails in buldbot and outside with ps-protocol
by Alexander Barkov 03 Nov '16

03 Nov '16

Hello Sergei, Please review a patch for MDEV-11219. Thanks!

1 0

[Maria-developers] Please review MDEV-10811 Change design from "Item is Type_handler" to "Item has Type_handler"
by Alexander Barkov 03 Nov '16

03 Nov '16

Hello Alexey, Please review a patch for 10.3 for MDEV-10811 Change design from "Item is Type_handler" to "Item has Type_handler Thanks.

1 0