- developers - lists.mariadb.org

Re: [Maria-developers] [Branch ~maria-captains/maria/5.1] Rev 2988: Fix LP Bug#686184 - merge_debug test fails.
by Oleksandr Byelkin 07 Dec '10

07 Dec '10

Hi! On 07.12.2010 01:15, noreply(a)launchpad.net wrote: > ------------------------------------------------------------ > revno: 2988 > fixes bug(s): https://launchpad.net/bugs/686184 > committer: Vladislav Vaintroub<wlad(a)montyprogram.com> > branch nick: 5.1 > timestamp: Mon 2010-12-06 22:34:50 +0100 > message: > Fix LP Bug#686184 - merge_debug test fails. > The reason for failure is that DBUG_EXECUTE_IF in mi_open() > only worked for Unix-formatted file names, due to strstr(name, "/crashed") > > The fix change strstr() above to strstr(name, "crashed"), to it can work with > Windows file names as well. > modified: > storage/myisam/mi_open.c (M)Aria engine also has code like you fixed above in ma_open.c: DBUG_EXECUTE_IF("maria_pretend_crashed_table_on_open", if (strstr(name, "/t1")) { my_errno= HA_ERR_CRASHED; goto err; }); Should it be also fixed?

1 0

[Maria-developers] Ready to release MariaDB 5.1.53
by Kristian Nielsen 07 Dec '10

07 Dec '10

Daniel, We are now ready to release MariaDB 5.1.53 and MariaDB 5.2.4. For 5.1.53, the tag is "mariadb-5.1.53" and the tree is: lp:~maria-captains/maria/5.1-release Packages should be downloaded from here: http://knielsen-hq.org/archive/pack/5.1-release/build-660/ For 5.2.4, the tag is "mariadb-5.2.4" and the tree is: lp:maria/5.2 Packages from here: http://knielsen-hq.org/archive/pack/5.2/build-661/ Let me know if you need anything else for the release. - Kristian.

2 2

[Maria-developers] WL#168 New (by Timour): Remove lazy subquery optimization
by worklog-noreply＠askmonty.org 06 Dec '10

06 Dec '10

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Remove lazy subquery optimization CREATION DATE..: Mon, 06 Dec 2010, 12:55 SUPERVISOR.....: Igor IMPLEMENTOR....: Timour COPIES TO......: CATEGORY.......: Maria-BackLog TASK ID........: 168 (http://askmonty.org/worklog/?tid=168) VERSION........: Server-5.3 STATUS.........: Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 16 (hours remain) ORIG. ESTIMATE.: 16 PROGRESS NOTES: DESCRIPTION: Remove all instances of lazy subquery optimization after MWL#89 is complete. Even after MWL#89, there are certain cases when subquery predicates are executed without prior optimization. This may result in bugs as well as high optimization/explain cost. In addition having a mixed subquery optimization approach results in a more complex architecture and higher degree of coupling between different query processing phases. The goal of this task is to investigate all remaining cases of lazy subquery optimization, and whenever possible change each such case to utilize the general approach of MWL#89. Currently known remaining cases: - sql_select.cc:remove_eq_cond calls cond->const_item() without checking if cond is expensive. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#167 New (by Sergei): sparse bitmaps
by worklog-noreply＠askmonty.org 30 Nov '10

30 Nov '10

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: sparse bitmaps CREATION DATE..: Tue, 30 Nov 2010, 11:40 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 167 (http://askmonty.org/worklog/?tid=167) VERSION........: Benchmarks-3.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 20 (hours remain) ORIG. ESTIMATE.: 20 PROGRESS NOTES: DESCRIPTION: implement sparse bitmaps. in mysys, as a generic data structure. preferably with the API compatible to MY_BITMAP. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] New BuildBot tests - compiling the MySQL drivers for PHP and Perl
by Philip Stoev 29 Nov '10

29 Nov '10

Hello, I have installed a new builder "compile-connectors", which will compile the DBD::mysql and the PHP (5.3) mysql connector (the oldest of them all). The purpose is to make sure that MariaDB does not break compatibility with MySQL when it comes to things such as headers, file locations, compilability, linking and loadability of the compiled module. I will try to get some more things tested, such as the newer PHP driver, the C++ connector and drivers containing the embedded server. If you can think of any other connectors or important applications that link or load libmysql, let me know and I will try to add them too. I do not think the new test will catch bugs such as LP#674812, which showed up when mixing and matching OS packages, downloaded packages and self-compiled stuff, but we can at least catch the regression if our headers get modified enough for the third-party drivers to become uncompilable. My next step will be to automate the testing of the Windows installer and the installation of MariaDB as a service. Any thoughts you may have in that area are also appreciated. Thank you. Philip Stoev

2 1

[Maria-developers] Strange pbxt issue in 5.1 (missing rows)
by Michael Widenius 29 Nov '10

29 Nov '10

Hi! I just merged MySQL 5.1.53 into MariaDB and as part of that, did run the pbxt test suite. I encountered this test failure: mysql-test-run --suite=pbxt URRENT_TEST: pbxt.insert --- /home/my/maria-5.1-release/mysql-test/suite/pbxt/r/insert.result 2010-11-25 12:02:26.083226000 +0200 +++ /home/my/maria-5.1-release/mysql-test/suite/pbxt/r/insert.reject 2010-11-25 19:33:48.281738504 +0200 @@ -298,7 +298,7 @@ insert into t2 select t1.* from t1, t2 t, t3 where t1.id1 = t.id2 and t.id2 = t3.id3; select count(*) from t2; count(*) -25500 +25495 drop table t1,t2,t3; create table t1 (a int, b int); insert into t1 (a,b) values (a,b); This only happened once for this test. (I did get similar failures with one other test for that run, but not for new runs). I could not repeat it by running the test or suite again. I also tested to run the test with valgrind, but not problems found. I noticed this also happens in buildbot from time to time: See http://buildbot.askmonty.org/buildbot/builders/gentoo-x86-dbg/builds/396/st…, search after pbxt.insert Paul, have you ever encountered something like this? Any clues where to start looking? (The tree I am working with is 5.1-release) Regards, Monty

2 1

Re: [Maria-developers] MySQL: THDVAR in full-text parser
by Sergei Golubchik 27 Nov '10

27 Nov '10

Hi, 0x00F6! First: please send questions like this to maria-developers(a)lists.launchpad.net it's a public mailing list dedicated to MySQL and MariaDB internals, source code, and related things. I am subscribed, so I'll see you mail there, and you may be sure I will, because it won't be accidentally catched by my spam filter, or sorted out in some obscure folder. Furthermore other subscribers will see your question and could reply if I will be not available (e.g. I could be travelling). Thank you. On Nov 27, 0x00F6 - wrote: > Hello Sergei, > > Would you please help me in one small problem? > I'm writing MySQL full-text parser plugin and I need to configure it > by several session-level variables. So I need to execute THDVAR macro > in my parse function. So how to obtain "thd" variable for this macro? The server uses 'current_thd' in such a case. It should probably be in the plugin.h, I'd say. But at the moment it is not. You can copy the declaration from mysql_priv.h, something like this: extern pthread_key_t THR_THD; THD *current_thd() { return (THD*)pthread_getspecific(THR_THD); } if you want it to work on windows, see mysql_priv.h for the complete definition of current_thd. Regards, Sergei

1 0

Re: [Maria-developers] [Maria-discuss] Problem with MariaDb as a Windows service
by Peter Laursen 25 Nov '10

25 Nov '10

Same problem with MariaDB 5.1.51. --Peter On Sun, Nov 21, 2010 at 02:43, Vladislav Vaintroub < vladislav.vaintroub(a)oracle.com> wrote: > Hi, > It is likely this bug http://bugs.mysql.com/bug.php?id=56821 , was for > some > time in MySQL, already fixed. > > -----Original Message----- > From: maria-developers-bounces+wlad=sun.com(a)lists.launchpad.net > [mailto:maria-developers-bounces+wlad <maria-developers-bounces%2Bwlad>= > sun.com(a)lists.launchpad.net] On Behalf > Of Philip Stoev > Sent: Samstag, 20. November 2010 20:04 > To: Peter Laursen > Cc: maria-discuss(a)lists.launchpad.net; > maria-developers(a)lists.launchpad.net > Subject: Re: [Maria-developers] [Maria-discuss] Problem with MariaDb as a > Windows service > > Hi, > > It seems that the service requires the --console option to operate > properly. > > Here is how I could make it work: > > 1. In the Services Control panel, open up the properties for the service 2. > In the "Start Parameters" box, type "--console" without the quotation marks > 3. In the same dialog box, hit Start > > Philip Stoev > > ----- Original Message ----- > From: "Peter Laursen" <peter_laursen(a)webyog.com> > To: <maria-discuss(a)lists.launchpad.net>; > <maria-developers(a)lists.launchpad.net> > Sent: Saturday, November 20, 2010 3:36 PM > Subject: [Maria-discuss] Problem with MariaDb as a Windows service > > > > Some person claimed here around one week ago that MariaDB would not > > run as service after "mysqld --install". > > I replied that it worked for me - but it does not with the latest > > stable version 5.2.3 (it did with the 5.2.3 RC) (so my apology to this > > person!) > > > > Windows console output: > > > > C:\maria52\bin>sc delete maria52 > > [SC] DeleteService LYKKEDES > > > > C:\maria52\bin>mysqld --install maria52 Service successfully > > installed. > > > > C:\maria52\bin>net start maria52 > > Tjenesten maria52 starter... > > Tjenesten maria52 kunne ikke startes. > > > > Der opstod en systemfejl. > > > > Systemfejlen 1067 opstod. > > > > (From Danish --> service could not start --> the system error 1067 > > occurred) > > > > I have tried with both old datadir and the empty one shipped with > > mariaDB and also my old my.ini as well as a fresh one. > > Also I tried to add --defaults-dir to the registry (just in case I had > > overlooked a my.ini copy in C:\ or C:\Windows) and adding doublequotes > > key manually like "C:\maria52\bin\mysqld" > > --defaults-file="C:\maria52\my.ini" maria52 > > > > I double checked there are no conflicts wit all settings. > > > > The command > > "C:\maria52\bin\mysqld" --defaults-file="C:\maria52\my.ini" > > .. starts the server (also when --defaults-file is omitted) .. but not > > as a service of course. > > > > > > Was it tested with the 5.2.3 GA release that it will run as a Windows > > service? > > The RC worked as a charm - but the GA will not. Any idea? > > (I am using Win7, 64 bit, Home Premium) > > > > > > Peter > > (Webyog) > > > > > > ---------------------------------------------------------------------------- > ---- > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~maria-discuss > > Post to : maria-discuss(a)lists.launchpad.net > > Unsubscribe : https://launchpad.net/~maria-discuss > > More help : https://help.launchpad.net/ListHelp > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~maria-developers > Post to : maria-developers(a)lists.launchpad.net > Unsubscribe : https://launchpad.net/~maria-developers > More help : https://help.launchpad.net/ListHelp > >

3 2

Re: [Maria-developers] [Maria-discuss] Problem with MariaDb as a Windows service
by Alex Budovski 24 Nov '10

24 Nov '10

> Right, this was subsequently fixed in MySQL in > http://lists.mysql.com/commits/118824 > Yes, I noticed that too late.

1 0

Re: [Maria-developers] [Commits] Rev 2977: Fix of LP BUG#675248. in file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/
by Igor Babaev 23 Nov '10

23 Nov '10

Sanja. Ok to push after the required changes in comments Regards, Igor. sanja(a)askmonty.org wrote: > At file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/ > > ------------------------------------------------------------ > revno: 2977 > revision-id: sanja(a)askmonty.org-20101123150005-adpcldzod759jgp1 > parent: sanja(a)askmonty.org-20101118141011-gth6b6pa0w9lyu1b > committer: sanja(a)askmonty.org > branch nick: work-maria-5.1-lb675248-prep-where > timestamp: Tue 2010-11-23 17:00:05 +0200 > message: > Fix of LP BUG#675248. > > Registration of pointer change if we assign it to other pointer which should be identical after statememnt execution (PS/SP). > ^fix spelling in the comment > > ------------------------------------------------------------------------ > > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits + /** + Assigns new value to place and check item tree changes for need of + re-registering the change. Make change in item tree after checking whether it needs registering + + @param place place where we should assign new value + @param new_value place of the new value + + @details + see check_and_register_item_tree_change details + */ + void check_and_register_item_tree(Item **place, Item **new_value) + { + if (!stmt_arena->is_conventional()) + check_and_register_item_tree_change(place, new_value, mem_root); + *place= *new_value; + } void nocheck_register_item_tree_change(Item **place, Item *old_value, MEM_ROOT *runtime_memroot); + void check_and_register_item_tree_change(Item **place, Item **new_value, + MEM_ROOT *runtime_memroot); void rollback_item_tree_changes();

1 0