- developers - lists.mariadb.org

Re: [Maria-developers] Rev 3517: MySQL 5.6.10 performance schema: merge of host_cache table
by Sergei Golubchik 25 Jun '13

25 Jun '13

Hi, Timour! Just few comments On Jun 25, timour(a)askmonty.org wrote: > ------------------------------------------------------------ > revno: 3517 > revision-id: timour(a)askmonty.org-20130621115451-tyxgeeroqyxwz7gn > parent: monty(a)askmonty.org-20130623091543-zqu5dvhry6okna6g > committer: timour(a)askmonty.org > branch nick: 10.0-perf-schema-merge > timestamp: Fri 2013-06-21 14:54:51 +0300 > message: > MySQL 5.6.10 performance schema: merge of host_cache table > === modified file 'sql/hostname.cc' > --- a/sql/hostname.cc 2013-01-15 18:13:32 +0000 > +++ b/sql/hostname.cc 2013-06-21 11:54:51 +0000 > @@ -24,7 +24,7 @@ > Hostnames are checked with reverse name lookup and checked that they > doesn't resemble an IP address. > */ > - > +#include "my_global.h" > #include "sql_priv.h" > #include "hostname.h" > #include "my_global.h" you don't need to include my_global.h twice here > === modified file 'sql/sql_acl.cc' > --- a/sql/sql_acl.cc 2013-06-17 23:01:34 +0000 > +++ b/sql/sql_acl.cc 2013-06-21 11:54:51 +0000 > @@ -8730,7 +8737,6 @@ static int server_mpvio_read_packet(MYSQ > err: > if (mpvio->status == MPVIO_EXT::FAILURE) > { > - inc_host_errors(mpvio->thd->security_ctx->ip); > if (!mpvio->thd->is_error()) > { > if (mpvio->make_it_fail) > @@ -8890,6 +8896,10 @@ static int do_auth_once(THD *thd, const > else > { > /* Server cannot load the required plugin. */ > + Host_errors errors; > + errors.m_no_auth_plugin= 1; > + // merge-todo: struct MPVIO_EXT’ has no member named ‘ip’ > + // inc_host_errors(mpvio->ip, &errors); see above, the line you've removed in a previous chunk, used inc_host_errors(mpvio->thd->security_ctx->ip); > my_error(ER_PLUGIN_IS_NOT_LOADED, MYF(0), auth_plugin_name->str); > res= CR_ERROR; > } > @@ -8913,8 +8923,6 @@ static int do_auth_once(THD *thd, const > Perform the handshake, authorize the client and update thd sctx variables. > > @param thd thread handle > - @param connect_errors number of previous failed connect attemps > - from this host really? you've removed it from the comment, but not from the function, so now acl_authenticate() has one undocumented argument. > @param com_change_user_pkt_len size of the COM_CHANGE_USER packet > (without the first, command, byte) or 0 > if it's not a COM_CHANGE_USER (that is, if > @@ -9017,8 +9025,27 @@ bool acl_authenticate(THD *thd, uint con > > if (res > CR_OK && mpvio.status != MPVIO_EXT::SUCCESS) > { > + Host_errors errors; > DBUG_ASSERT(mpvio.status == MPVIO_EXT::FAILURE); > - > + switch (res) > + { > + case CR_AUTH_PLUGIN_ERROR: > + errors.m_auth_plugin= 1; > + break; > + case CR_AUTH_HANDSHAKE: > + errors.m_handshake= 1; > + break; > + case CR_AUTH_USER_CREDENTIALS: > + errors.m_authentication= 1; > + break; > + case CR_ERROR: > + default: > + /* Unknown of unspecified auth plugin error. */ > + errors.m_auth_plugin= 1; > + break; > + } > + // merge-todo: struct MPVIO_EXT’ has no member named ‘ip’ > + // inc_host_errors(mpvio.ip, &errors); same as above. And personally, I'd rather make a method errors.set_error(res); and move the switch inside. But you may decide to stay closer to 5.6 code. > if (!thd->is_error()) > login_failed_error(thd); > DBUG_RETURN(1); > @@ -9256,23 +9283,20 @@ static int native_password_authenticate( > #endif > > if (pkt_len == 0) /* no password */ > - DBUG_RETURN(info->auth_string[0] ? CR_ERROR : CR_OK); > + DBUG_RETURN(mpvio->acl_user->salt_len != 0 ? CR_AUTH_USER_CREDENTIALS : CR_OK); Why did you change the condition? Our pluggable auth code is not identical to MySQL's, so not all changes can be copied verbatim from there. I think the old condition was ok. > info->password_used= PASSWORD_USED_YES; > if (pkt_len == SCRAMBLE_LENGTH) > { > if (!mpvio->acl_user->salt_len) > - DBUG_RETURN(CR_ERROR); > + DBUG_RETURN(CR_AUTH_USER_CREDENTIALS); > > - if (check_scramble(pkt, thd->scramble, mpvio->acl_user->salt)) > - DBUG_RETURN(CR_ERROR); > - else > - DBUG_RETURN(CR_OK); > + DBUG_RETURN(check_scramble(pkt, thd->scramble, mpvio->acl_user->salt) ? > + CR_AUTH_USER_CREDENTIALS : CR_OK); could you change it back please and only replace the error code? if() is easier to debug, than a function call inside DBUG_RETURN(). I suppose that's why we have it that way. > } > > - inc_host_errors(mpvio->thd->security_ctx->ip); > my_error(ER_HANDSHAKE_ERROR, MYF(0)); > - DBUG_RETURN(CR_ERROR); > + DBUG_RETURN(CR_AUTH_HANDSHAKE); > } Regards, Sergei

1 0

[Maria-developers] Debug interface
by Roberto Spadim 25 Jun '13

25 Jun '13

hi guys, what ide could i use to debug easily in linux mariadb version? i'm using gdb via command line, but it's very complicate, i'm a visual studio user, but a console interface is nice, if i could put some break points and F5 (run),F8 (run one step) there's another place to ask about it? -- Roberto Spadim

3 2

[Maria-developers] RFC: Pausing a query thread
by Marian Marinov 25 Jun '13

25 Jun '13

Hi guys, I work with hosting companies and all of my clients have the same irritating problem, one query taking a lot of time to finish and consuming a lot of resources. So I have solved the same issue but with processes on the machine by simply pausing(kill -STOP) these processes when the load is high and continuing(kill -CONT) them when the server load goes down. I want to implement the same logic within MariaDB, so I can STOP/CONT the thread that is executing this query. My idea is to implement this in the 'KILL query_id' function, so it will accept one more argument, which will be either STOP or CONT. If the parameter is not present, the default behavior should remain. What do you think about my approach? Marian

6 18

Re: [Maria-developers] Help with MDEV-4419, ENUM optimization
by Roberto Spadim 24 Jun '13

24 Jun '13

hummm :) nice, i will study it =) it give me a lot of speed, since some system are closed source and i can't rewrite the query, just change the mysql server or put a mysql proxy

1 5

[Maria-developers] users table
by Roberto Spadim 24 Jun '13

24 Jun '13

hi guys, what's the better way to have a shared mysql schema? i'm talking about creating a user in one database and this user be created in many databases (in the same server) i'm trying with symbolic links in data directory, but sure i have some problems that i need same server version (ok no problem) and flush tables in all servers after add an user i don't know if i could do a two replications since it's like a master-master storage when one database add a user all databases need that information any idea? -- Roberto Spadim

4 4

[Maria-developers] Debug on windows
by Roberto Spadim 24 Jun '13

24 Jun '13

Hi guys i want to learn about optrange.cc, but i dont know how to debug I'm using visual studio 2008 on windows, could anyone help me I will place a break point at get_mm_leaf function and watch all variables Anyone could help me?

1 0

[Maria-developers] Build and/or support of MariaDB on AIX
by Frank Fegert 23 Jun '13

23 Jun '13

Hello all, i'm currently running MySQL 5.1.62 on IBM Power LPARs with AIX 6.1. I'll spare you the discussion of why AIX and not Linux and will just say "it is what it is ATM" ;-) Anyhow, with things proceeding as they are, i guess chances are that Oracle and IBM are not going to get any more friendly with each other, so i'm looking for an alternative way to move forward. That being said, i'd like to get an idea of the general feeling around the MariaDB development team on the support of non-(Linux|*BSD|Windows) platforms. Are there currently any plans? Would you be willing to invest some time in helping to get MariaDB running on AIX? Right now, i can successfully build stock MySQL 5.1.70 with some minor patches and stock MySQL 5.5.32 with some minor patches and the option "DWITHOUT_PERFSCHEMA_STORAGE_ENGINE=ON". With performance schema enabled the build fails at linking the unittests in "storage/perfschema/unittest/", see below for a full error output. The MariaDB 5.5.31 build does currently not even go that far, if fails earlier on the threadpool code, see below. Unfortunately my C/C++-fu is not strong enough to determine what might be considered a sound alternative to the epoll/kevent/port_event calls on AIX to do an alteration like the one in MDEV-4174. Can someone please help me out here? My build environment: Compiler: IBM XL C/C++ for AIX, V11.1 (5724-X13) Version: 11.01.0000.0009 AIX oslevel: 6100-08-01-1245 Thanks & best regards, Frank Fegert ## Begin: MariaDB 5.5.31 ############################################## ... [ 37%] Building CXX object sql/CMakeFiles/sql.dir/threadpool_unix.cc.o cd /home/user/rpmbuild/tmp/mariadb-5.5.31/build-mysql/sql && /usr/vacpp/bin/xlC_r -+ -DHAVE_CONFIG_H -DHAVE_EVENT_SCHEDULER -DHAVE_OPENSSL -DHAVE_POOL_OF_THREADS -DMYSQL_SERVER -ma -O2 -qlanglvl=extc99 -qstrict -qoptimize=2 -qmaxmem=16384 -DSYSV -D_AIX -D_AIX32 -D_AIX41 -D_AIX43 -D_AIX51 -D_AIX52 -D_AIX53 -D_AIX61 -D_ALL_SOURCE -DFUNCPROTO=15 -I/opt/freeware/include -qthreaded -qhalt=e -qstaticinline -g -DDBUG_OFF -I/home/user/rpmbuild/tmp/mariadb-5.5.31/build-mysql/include -I/home/user/rpmbuild/tmp/mariadb-5.5.31/include -I/home/user/rpmbuild/tmp/mariadb-5.5.31/sql -I/home/user/rpmbuild/tmp/mariadb-5.5.31/regex -I/home/user/rpmbuild/tmp/mariadb-5.5.31/build-mysql/sql -o CMakeFiles/sql.dir/threadpool_unix.cc.o -c /home/user/rpmbuild/tmp/mariadb-5.5.31/sql/threadpool_unix.cc "/home/user/rpmbuild/tmp/mariadb-5.5.31/sql/threadpool_unix.cc", line 39.2: 1540-0859 (S) #error directive: threadpool is not available on this platform. gmake[2]: *** [sql/CMakeFiles/sql.dir/threadpool_unix.cc.o] Error 1 gmake[2]: Leaving directory `/home/user/rpmbuild/tmp/mariadb-5.5.31/build-mysql' gmake[1]: *** [sql/CMakeFiles/sql.dir/all] Error 2 gmake[1]: Leaving directory `/home/user/rpmbuild/tmp/mariadb-5.5.31/build-mysql' gmake: *** [all] Error 2 ## End: MariaDB 5.5.31 ################################################ ## Begin: MySQL 5.5.32 ################################################ ... Linking CXX executable pfs-t cd /home/user/rpmbuild/tmp/mysql-5.5.32/build-mysql/storage/perfschema/unittest && /opt/freeware/bin/cmake -E cmake_link_script CMakeFiles/pfs-t.dir/lin k.txt --verbose=1 /usr/vacpp/bin/xlC_r -ma -O2 -qlanglvl=extc99 -qstrict -qoptimize=2 -qmaxmem=16384 -DSYSV -D_AIX -D_AIX32 -D_AIX41 -D_AIX43 -D_AIX51 -D_AIX52 -D_AIX53 -D_A IX61 -D_ALL_SOURCE -DFUNCPROTO=15 -I/opt/freeware/include -qthreaded -qhalt=e -qstaticinline -L/opt/freeware/lib/mysql -L/opt/freeware/lib -Wl,-bmaxdata:0x80000000 CMakeFiles/pfs-t.dir/pfs-t.cc.o -o pfs-t -Wl,-brtl,-bnoipath,-bexpfull ../../../unittest/mytap/libmytap.a ../libperfschema.a ../../../mysys/libmysys.a ../../../dbug/libdbug.a ../../../mysys/libmysys.a ../../../dbug/libdbug.a ../../../strings/libstrings.a -lz -lm -Wl,-blibpath:/opt/freeware/lib:/usr/lib:/lib ld: 0711-317 ERROR: Undefined symbol: .MDL_request::init(MDL_key::enum_mdl_namespace,const char*,const char*,enum_mdl_type,enum_mdl_duration) ld: 0711-317 ERROR: Undefined symbol: .LEX::LEX() ld: 0711-317 ERROR: Undefined symbol: .lex_start(THD*) ld: 0711-317 ERROR: Undefined symbol: Virtual table for class "DML_prelocking_strategy": Some possible causes are: first non-inline virtual function in "DML_prelocking_strategy" is not defined; or the class is a template instantiation and an explicit instantiation definition of the class is missing. ld: 0711-317 ERROR: Undefined symbol: .open_and_lock_tables(THD*,TABLE_LIST*,bool,unsigned int,Prelocking_strategy*) ld: 0711-317 ERROR: Undefined symbol: .Table_check_intact::check(TABLE*,const st_table_field_def*) ld: 0711-317 ERROR: Undefined symbol: .close_thread_tables(THD*) ld: 0711-317 ERROR: Undefined symbol: .lex_end(LEX*) ld: 0711-317 ERROR: Undefined symbol: .Query_tables_list::destroy_query_tables_list() ld: 0711-317 ERROR: Undefined symbol: .plugin_unlock_list(THD*,st_plugin_int**,unsigned int) ld: 0711-317 ERROR: Undefined symbol: THR_THD ld: 0711-317 ERROR: Undefined symbol: .sql_print_error(const char*,...) ld: 0711-317 ERROR: Undefined symbol: Virtual table for class "st_select_lex_node": Some possible causes are: first non-inline virtual function in "st_select_lex_node" is not defined; or the class is a template instantiation and an explicit instantiation definition of the class is missing. ld: 0711-317 ERROR: Undefined symbol: lower_case_table_names ld: 0711-317 ERROR: Undefined symbol: .Field_enum::store_type(unsigned long long) ld: 0711-317 ERROR: Undefined symbol: .ACL_internal_schema_registry::register_schema(const st_mysql_lex_string*,const ACL_internal_schema_access*) ld: 0711-317 ERROR: Undefined symbol: handler::clone(const char*,st_mem_root*) ld: 0711-317 ERROR: Undefined symbol: handler::get_error_message(int,String*) ld: 0711-317 ERROR: Undefined symbol: handler::column_bitmaps_signal() ld: 0711-317 ERROR: Undefined symbol: handler::index_read_idx_map(unsigned char*,unsigned int,const unsigned char*,unsigned long,ha_rkey_function) ld: 0711-317 ERROR: Undefined symbol: handler::index_next_same(unsigned char*,const unsigned char*,unsigned int) ld: 0711-317 ERROR: Undefined symbol: handler::read_multi_range_first(st_key_multi_range**,st_key_multi_range*,unsigned int,bool,st_handler_buffer*) ld: 0711-317 ERROR: Undefined symbol: handler::read_multi_range_next(st_key_multi_range**) ld: 0711-317 ERROR: Undefined symbol: handler::read_range_first(const st_key_range*,const st_key_range*,bool,bool) ld: 0711-317 ERROR: Undefined symbol: handler::read_range_next() ld: 0711-317 ERROR: Undefined symbol: handler::read_first_row(unsigned char*,unsigned int) ld: 0711-317 ERROR: Undefined symbol: handler::get_dynamic_partition_info(PARTITION_STATS*,unsigned int) ld: 0711-317 ERROR: Undefined symbol: handler::get_auto_increment(unsigned long long,unsigned long long,unsigned long long,unsigned long long*,unsigned long long*) ld: 0711-317 ERROR: Undefined symbol: handler::drop_table(const char*) ld: 0711-317 ERROR: Undefined symbol: Virtual table for class "handler": Some possible causes are: first non-inline virtual function in "handler" is not defined; or the class is a template instantiation and an explicit instantiation definition of the class is missing. ld: 0711-317 ERROR: Undefined symbol: .handler::ha_table_share_psi(const TABLE_SHARE*) const ld: 0711-317 ERROR: Undefined symbol: .handler::ha_statistic_increment(unsigned long system_status_var::*) const ld: 0711-317 ERROR: Undefined symbol: .handler::print_error(int,int) ld: 0711-317 ERROR: Undefined symbol: key_map_empty ld: 0711-317 ERROR: Undefined symbol: .calculate_key_len(TABLE*,unsigned int,const unsigned char*,unsigned long) ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information. gmake[2]: *** [storage/perfschema/unittest/pfs-t] Error 8 gmake[2]: Leaving directory `/home/user/rpmbuild/tmp/mysql-5.5.32/build-mysql' gmake[1]: *** [storage/perfschema/unittest/CMakeFiles/pfs-t.dir/all] Error 2 gmake[1]: Leaving directory `/home/user/rpmbuild/tmp/mysql-5.5.32/build-mysql' gmake: *** [all] Error 2 ###End: MySQL 5.5.32 ##################################################

3 3

Re: [Maria-developers] Build and/or support of MariaDB on AIX
by Frank Fegert 23 Jun '13

23 Jun '13

Hello Harald, On Sun, Jun 23, 2013 at 12:37:24PM +0200, Reindl Harald wrote: > your outoput contains "#error directive: threadpool is not available > on this platform" which clearly states you must not configure > "-DHAVE_POOL_OF_THREADS" on your platform thanks for your fast reply! Yes, to disable threadpool for AIX would be an option, but unfortunately the /dev/human attached to my computer seems to be defective ;-) All fun aside, i went through the configure option list, but nothing related to threadpools caught my eye. Manually patching the above option out of "sql/CMakeLists.txt" didn't help either. I'm missing something here, aren't i? Thanks & best regards, Frank

1 0

[Maria-developers] Uninstalling MariaDB 5.2 does not remove everything.
by Peter Laursen 22 Jun '13

22 Jun '13

For @wlad I guess: After uninstalling MariaDB 5.2.on Win7/64 some (don't remember which minor version), it remains in the list of installed programs in Control Panel .. Programs. Trying to uninstall displays this dialog (translates to "This action is only valid for programs currently installed"). I did not try if rebooting system would remove the item from the list. It may also have been fixed in the installer since the 5.2 release I installed. -- Peter

2 5

Re: [Maria-developers] [GSoC] Kerberize MariaDB -- some unclear point about the project
by QIU Shuang 22 Jun '13

22 Jun '13

Hi wlad, Thank you for your concern. > Create user > 'foo@bar'@localhost creates user foo@bar, on localhost. > create user that is identified with name and domain and can connect > from any computer I admit that I mis-understood the usage of User@Host in MariaDB. I thought the User and Host fields in MariaDB are in the same place as those in a Kerberos principal. i.e. if my MariaDB login name is qiush(a)sjtu.edu.cn, then my Kerberos principal will be qiush(a)sjtu.edu.cn/CHINA, where MariaDB login name is part of Kerberos principal. (if that case, the realm part is omitted in MariaDB, and we should find another way to figure it out. That's what I argued in my previous email.) From your reply, it seems qiush@sjtu.edu.cn/CHINA@sjtu.edu.cn, the bold part is MariaDB User and italic part Host, can be a valid login name in our project. Suddenly realise the Host in MariaDB login name will constraint the user login place. It's much clear now. > Re realm, I do not know this much but 'shuang(a)uni.shanghai.edu/REALM' also > does not look too weird to me. To me, either :). > Or perhaps I miss something still? Can you elaborate? No, you're right. I confused these two names. Thank you for you hints! Sincerely, Shuang On Jun 20, 2013, at 2:22 AM, Vladislav Vaintroub <wlad(a)montyprogram.com> wrote: > > > From: QIU Shuang [mailto:qiush.summer@gmail.com] > Sent: Mittwoch, 19. Juni 2013 19:52 > To: Vladislav Vaintroub > Subject: Re: [Maria-developers] [GSoC] Kerberize MariaDB -- some unclear > point about the project > > > Hi Shuang, > >>> Trying to make a nicer name, for example by removing domain part could > introduce some ambiguity here and different Kerberos users to login as the > same. >> I think so. >> But per my knowledge, the fully qualified name in MariaDB is > username@hostname. >> What about the realm/domain part? >> I think this may be a gap between MariaDB and Kerberos. > > Maybe I oversee something, but I do not really see any contradiction here. > Do you mean that @ is special character should not be used in usernames? It > actually can, it just must be properly escaped. Create user > 'foo@bar'@localhost creates user foo@bar, on localhost. > Hypothetical CREATE USER 'shuang(a)uni.shanghai.edu' @'%' IDENTIFIED WITH > 'Kerberos' > > will create user that is identified with name and domain and can connect > from any computer (due to use of wildcard for computername part, this > wildcard can be omitted). > Re realm, I do not know this much but 'shuang(a)uni.shanghai.edu/REALM' also > does not look too weird to me. > > Or perhaps I miss something still? Can you elaborate? > > Wlad >

3 4