- developers - lists.mariadb.org

Re: [Maria-developers] 21265d5: MDEV-9943 - TokuDB fails to compile with gcc 5.2.1
by Sergei Golubchik 19 Apr '16

19 Apr '16

Hi, Sergey! On Apr 19, Sergey Vojtovich wrote: > revision-id: 21265d58c1ea65f5c21a56cf669321f39066d7b5 (mariadb-5.5.48-19-g21265d5) > parent(s): 6c0e231c0282b43d6a46a4983f5971e960d3b8ca > committer: Sergey Vojtovich > timestamp: 2016-04-19 16:16:13 +0400 > message: > > MDEV-9943 - TokuDB fails to compile with gcc 5.2.1 > > For some reason check_cxx_compiler_flag() passes result variable name down to > compiler: > https://github.com/Kitware/CMake/blob/master/Modules/CheckCXXSourceCompiles… > > But compiler doesn't permit dashes in macro name, like in > -DHAVE_CXX_-fimplicit-templates. > > Workarounded by renaming HAVE_CXX_-fimplicit-templates to > HAVE_CXX_IMPLICIT_TEMPLAES. > > diff --git a/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake b/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake > index 99629e4..4ae7b63 100644 > --- a/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake > +++ b/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake > @@ -103,8 +103,8 @@ set_cflags_if_supported( > > if (CMAKE_CXX_FLAGS MATCHES -fno-implicit-templates) > # must append this because mysql sets -fno-implicit-templates and we need to override it > - check_cxx_compiler_flag(-fimplicit-templates HAVE_CXX_-fimplicit-templates) > - if (HAVE_CXX_-fimplicit-templates) > + check_cxx_compiler_flag(-fimplicit-templates HAVE_CXX_IMPLICIT_TEMPLATES) > + if (HAVE_CXX_IMPLICIT_TEMPLATES) > set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fimplicit-templates") > endif () > endif() I'd rather fix other similar places too. If you agree, ok to push with the patch below. --- a/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake +++ b/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake @@ -61,12 +61,13 @@ endmacro(set_cflags_if_supported_named) ## adds a compiler flag if the compiler supports it macro(set_cflags_if_supported) foreach(flag ${ARGN}) - check_c_compiler_flag(${flag} HAVE_C_${flag}) - if (HAVE_C_${flag}) + STRING(REGEX REPLACE "[-,= ]" "_" res ${flag}) + check_c_compiler_flag(${flag} HAVE_C_${res}) + if (HAVE_C_${res}) set(CMAKE_C_FLAGS "${flag} ${CMAKE_C_FLAGS}") endif () - check_cxx_compiler_flag(${flag} HAVE_CXX_${flag}) - if (HAVE_CXX_${flag}) + check_cxx_compiler_flag(${flag} HAVE_CXX_${res}) + if (HAVE_CXX_${res}) set(CMAKE_CXX_FLAGS "${flag} ${CMAKE_CXX_FLAGS}") endif () endforeach(flag) @@ -75,8 +76,9 @@ endmacro(set_cflags_if_supported) ## adds a linker flag if the compiler supports it macro(set_ldflags_if_supported) foreach(flag ${ARGN}) - check_cxx_compiler_flag(${flag} HAVE_${flag}) - if (HAVE_${flag}) + STRING(REGEX REPLACE "[-,= ]" "_" res ${flag}) + check_cxx_compiler_flag(${flag} HAVE_${res}) + if (HAVE_${res}) set(CMAKE_EXE_LINKER_FLAGS "${flag} ${CMAKE_EXE_LINKER_FLAGS}") set(CMAKE_SHARED_LINKER_FLAGS "${flag} ${CMAKE_SHARED_LINKER_FLAGS}") endif () Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

2 1

Re: [Maria-developers] 6c0e231: MDEV-9945 - main.kill_processlist-6619 fails sporadically
by Sergei Golubchik 19 Apr '16

19 Apr '16

Hi, Sergey! On Apr 19, Sergey Vojtovich wrote: > revision-id: 6c0e231c0282b43d6a46a4983f5971e960d3b8ca (mariadb-5.5.48-18-g6c0e231) > parent(s): 18ff6f654b1ca595fc5c0eebddbc1d0c5ee0d09e > committer: Sergey Vojtovich > timestamp: 2016-04-19 14:05:52 +0400 > message: > > MDEV-9945 - main.kill_processlist-6619 fails sporadically > > SHOW PROCESSLIST output can be affected by not completed concurrent queries. > Removed this affected SHOW PROCESSLIST since it doesn't seem to affect original > problem. ok to push Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

1 0

Re: [Maria-developers] 18ff6f6: MDEV-9944 - main.events_2 fails sporadically
by Sergei Golubchik 19 Apr '16

19 Apr '16

Hi, Sergey! On Apr 19, Sergey Vojtovich wrote: > revision-id: 18ff6f654b1ca595fc5c0eebddbc1d0c5ee0d09e (mariadb-5.5.48-17-g18ff6f6) > parent(s): 6fd54c01bb5bc480497b143d63181837148ff47f > committer: Sergey Vojtovich > timestamp: 2016-04-19 12:38:00 +0400 > message: > > MDEV-9944 - main.events_2 fails sporadically > > Fixed wait condition in test case to actually wait for get_lock() completion > (not for lock acquisition as it was before). This removes sporadic extra row in > subsequent processlist queries. ok to push Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

1 0

Re: [Maria-developers] InnoDB blob for primary key
by Sachin Setia 18 Apr '16

18 Apr '16

Hi Sergei! Actually I was going through the mysql source code for unique long constraints in file sql_tmp_table.cc in function create_tmp_table they make a new field and a new key(hash_key) and pass this table obejct to storage engine.They actually refer this field as a hash field On the time of insert they call bool check_unique_constraint(TABLE *table) function which first calculate the hash and store it in field then they see for duplicate hash and retrive ha_index_next_same if records are not same then record We can do the same thing in mariadb by adding one more field and key in mysql_prepare_create_table in this we check for blob with unlimited length or varchar for length greater then internal storage engine by doing this in mysql_prepare_create_table there will be no issues of frm file inconsistance. In case of insert first we will fill the hash field in fill_record function of sql_base.cc by first calculating the hash. Then we will retrive the index map using ha_index_read_map if returened value is zero then we will comapare two records and if they match then we will through error I am not sure where to place this code either in fill_record or later Or i can simple just fill hash in field in fill_record and then check for duplicates later on. Current I am not sure how to hide columns from user.Sir, can you suggest me where to look But there is one problem we can make unique key by this approch but not primary key because primary key is clustered and hashes can collide so i think we can't use hash field as primary key. To overcome this problem I have one idea instead of storing just hash we can make hash field length 10 bytes and in last two bytes we can store short int which tells how much time hash is repeated this can make hash unique in case of collusion. And also we are not doing more computation because we already retrive all records with same hashes. What do you think of this idea?. And there is one more problem how to make it foreign key. Will send you a prototype code tomorrow. Regards sachin On Fri, Apr 15, 2016 at 12:23 AM, Sergei Golubchik <serg(a)mariadb.org> wrote: > Hi, Sachin! > > On Apr 13, Sachin Setia wrote: >> Hello Sergei >> Sorry I did not see your mail. Actually i was thinking something like >> this before implementing the prototype but if i am more closer to >> innodb the more performance i will i get. I will definitively think >> about it. > > Great! > > Could you please tell me (mailing list, that is) what you think before > next Monday (before April 18h, that is)? > > Regards, > Sergei > Chief Architect MariaDB > and security(a)mariadb.org

2 5

[Maria-developers] Deadlock with STOP SLAVE and LOCK_active_mi
by Kristian Nielsen 18 Apr '16

18 Apr '16

So while looking at MDEV-9573, I found this code in mysql_execute_command() for STOP SLAVE: mysql_mutex_lock(&LOCK_active_mi); if ((mi= (master_info_index-> get_master_info(&lex_mi->connection_name, Sql_condition::WARN_LEVEL_ERROR)))) if (!stop_slave(thd, mi, 1/* net report*/)) my_ok(thd); mysql_mutex_unlock(&LOCK_active_mi); So basically, this code is holding LOCK_active_mi for the entire duration of the STOP SLAVE operation. This seems completely broken. Anything in a slave thread that tries to take LOCK_active_mi will then deadlock with the STOP SLAVE operation. It is simple enough to trigger, testcase (with sleep-injecting patch) at the end of the email. This uses INFORMATION_SCHEMA.SESSSION_STATUS; I could imagine accessing a number of system variables could trigger it as well. >From a quick check, it looks like this has been like this forever, eg. 5.1 has similar code. Any suggestions for how this is supposed to work? Or is it just broken by design, but saved because normally slave threads do not need to access SHOW STATUS or system variables? - Kristian. ----------------------------------------------------------------------- diff --git a/sql/mysqld.cc b/sql/mysqld.cc index ced9225..2358d6b 100644 --- a/sql/mysqld.cc +++ b/sql/mysqld.cc @@ -7765,6 +7765,7 @@ static int show_heartbeat_period(THD *thd, SHOW_VAR *var, char *buff, var->type= SHOW_CHAR; var->value= buff; +if (thd->slave_thread) my_sleep(5000000); mysql_mutex_lock(&LOCK_active_mi); if (master_info_index) { ----------------------------------------------------------------------- --source include/have_innodb.inc --source include/master-slave.inc --connection master CREATE TABLE t1 (a INT PRIMARY KEY) ENGINE=InnoDB; --save_master_pos --connection slave --sync_with_master --source include/stop_slave.inc --connection master INSERT INTO t1 SELECT VARIABLE_VALUE FROM INFORMATION_SCHEMA.SESSION_STATUS WHERE VARIABLE_NAME='COM_COMMIT'; --save_master_pos --connection slave --source include/start_slave.inc # Wait a bit to hit a sleep() in code after taking LOCK_active_mi. SELECT SLEEP(2); STOP SLAVE; SELECT * FROM t1 ORDER BY a; START SLAVE; --sync_with_master SELECT * FROM t1 ORDER BY a; # Clean up. --connection master DROP TABLE t1; --source include/rpl_end.inc -----------------------------------------------------------------------

2 2

[Maria-developers] MDEV-9521 Least function returns 0000-00-00 for null date columns instead of null
by Alexander Barkov 18 Apr '16

18 Apr '16

Hi Sergei, Please review a patch for MDEV-9521. Thanks.

2 3

[Maria-developers] Enabling DBUG_* macros
by Игорь Пашев 18 Apr '16

18 Apr '16

Hi all :-) How can I enable all those nice DBUG_* macros and/or see their output? I'm configuring MariaDB with cmake -DCMAKE_BUILD_TYPE=Debug, but it seems I don't have those macros.

2 1

[Maria-developers] nariadb 10.1.13 fails with openssl on gentoo
by Benny Pedersen 17 Apr '16

17 Apr '16

if openssl works for othres i like to know a working my.cnf to make it work, i have added my ssql same way as used in dovecot / postfix, no ssl error in mysql, but openssl s_client -showcerts -connect 127.0.0.1:3306 says ssl23 fails, at best i see ssl3 tlsv1 fails, output is CONNECTED(00000003) --- no peer certificate available --- No client certificate CA names sent --- SSL handshake has read 7 bytes and written 308 bytes --- New, (NONE), Cipher is (NONE) Secure Renegotiation IS NOT supported Compression: NONE Expansion: NONE No ALPN negotiated SSL-Session: Protocol : TLSv1.2 Cipher : 0000 Session-ID: Session-ID-ctx: Master-Key: Key-Arg : None PSK identity: None PSK identity hint: None SRP username: None Start Time: 1460845475 Timeout : 300 (sec) Verify return code: 0 (ok) --- how to debug it more from here ?

3 5

Re: [Maria-developers] 56ef213: MDEV-9836 Connection lost when using SSL
by Sergei Golubchik 16 Apr '16

16 Apr '16

Hi, Vlad! On Mar 30, wlad(a)mariadb.com wrote: > revision-id: 56ef213b8be7c91331168df002c4f69d54a26081 (mariadb-5.5.48-15-g56ef213) > parent(s): 11b77e9b18a8d97063b4c4a96e40bf9c75bd0e8b > author: Vladislav Vaintroub > committer: Vladislav Vaintroub > timestamp: 2016-03-30 23:09:57 +0200 > message: > > MDEV-9836 Connection lost when using SSL > > Don't read from socket in yassl in SSL_pending(). > Just return size of the buffered unprocessed data. As far as I understand, you make it to return the size of buffered *processed* data. Which is correct, according to OpenSSL documentation: SSL_pending() returns the number of bytes which have been processed, buffered and are available inside ssl for immediate read. If you agree with my understanding, please fix the commit comment to say "processed" and add a reference to the manual (a quote as above or "as specified in the OpenSSL manual" or whatever you prefer). Then ok push. > diff --git a/extra/yassl/src/ssl.cpp b/extra/yassl/src/ssl.cpp > index 9516e8b..2346533 100644 > --- a/extra/yassl/src/ssl.cpp > +++ b/extra/yassl/src/ssl.cpp > @@ -1471,10 +1471,6 @@ int SSL_peek(SSL* ssl, void* buffer, int sz) > > int SSL_pending(SSL* ssl) > { > - // Just in case there's pending data that hasn't been processed yet... > - char c; > - SSL_peek(ssl, &c, 1); > - > return ssl->bufferedData(); > } > Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

1 0

[Maria-developers] Error compiling MariaDB 10.1.13
by Alexey Strokach 14 Apr '16

14 Apr '16

I am having trouble compiling MariaDB as a conda package on Ubuntu 14.04. I pushed the conda recipe that I am using as well as the the stdout and stderr output to a github repo <https://github.com/ostrokach/conda-recipes-extra/tree/master/mariadb-10>. In brief, I am compiling MariaDB using CFLAGS="-I$PREFIX/include -I$PREFIX/include/ncurses" \ CPPFLAGS="-I$PREFIX/include -I$PREFIX/include/ncurses" \ CXXFLAGS="-I$PREFIX/include -I$PREFIX/include/ncurses" \ LDFLAGS="-L$PREFIX/lib" \ cmake . \ -DBUILD_CONFIG=mysql_release \ -DCMAKE_PREFIX_PATH:PATH="$PREFIX" \ -DCMAKE_INSTALL_PREFIX:PATH="$PREFIX" \ -DMYSQL_DATADIR:PATH="$PREFIX/data" make make install where $PREFIX is the location of the conda build environment containing the following packages: requirements: build: - cmake - bison - ncurses - zlib - lzo - jemalloc ==3.6.0 - aio - readline - openssl - zeromq I am using the system gcc compiler: gcc (Ubuntu 4.8.5-2ubuntu1~14.04.1) 4.8.5 Copyright (C) 2015 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. I get the following error at 91% during make: + CFLAGS='-I/home/user/anaconda3/envs/_build/include -I/home/user/anaconda3/envs/_build/include/ncurses' + CPPFLAGS='-I/home/user/anaconda3/envs/_build/include -I/home/user/anaconda3/envs/_build/include/ncurses' + CXXFLAGS='-I/home/user/anaconda3/envs/_build/include -I/home/user/anaconda3/envs/_build/include/ncurses' + LDFLAGS=-L/home/user/anaconda3/envs/_build/lib + cmake . -DBUILD_CONFIG=mysql_release -DCMAKE_PREFIX_PATH:PATH=/home/user/anaconda3/envs/_build -DCMAKE_INSTALL_PREFIX:PATH=/home/user/anaconda3/envs/_build -DMYSQL_DATADIR:PATH=/home/user/anaconda3/envs/_build/data + make /usr/bin/ar: creating /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/libmysql/libmysqlclient.a /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/sql/sql_yacc.yy:1022.1-12: warning: deprecated directive, use ‘%pure-parser’ [-Wdeprecated] %pure_parser /* We have threads */ ^^^^^^^^^^^^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/storage/mroonga/vendor/groonga/lib/expr.c: In function ‘grn_expr_exec’: /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/storage/mroonga/vendor/groonga/lib/expr.c:3543:1: warning: const/copy propagation disabled: 21688 basic blocks and 63352 registers [-Wdisabled-optimization] } ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/storage/mroonga/vendor/groonga/lib/expr.c:3543:1: warning: PRE disabled: 21688 basic blocks and 63352 registers [-Wdisabled-optimization] /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/storage/mroonga/vendor/groonga/lib/expr.c:3543:1: warning: const/copy propagation disabled: 21688 basic blocks and 63352 registers [-Wdisabled-optimization] /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/storage/mroonga/vendor/groonga/lib/expr.c:3543:1: warning: const/copy propagation disabled: 19113 basic blocks and 64360 registers [-Wdisabled-optimization] CMake Warning (dev) in CMakeLists.txt: No cmake_minimum_required command is present. A line of code such as cmake_minimum_required(VERSION 3.5) should be added at the top of the file. The version specified may be lower if you wish to support older CMake versions for this project. For more information run "cmake --help-policy CMP0000". This warning is for project developers. Use -Wno-dev to suppress it. /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/storage/tokudb/PerconaFT/xz/src/build_lzma/src/liblzma/lz/lz_encoder.c: In function ‘fill_window’: /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/storage/tokudb/PerconaFT/xz/src/build_lzma/src/liblzma/lz/lz_encoder.c:89:9: warning: variable ‘in_used’ set but not used [-Wunused-but-set-variable] size_t in_used; ^ In file included from /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/plugin/auth_gssapi/client_plugin.cc:37:0: /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/include/mysql/client_plugin.h:64:9: warning: ‘_mysql_client_plugin_declaration_’ initialized and declared ‘extern’ [enabled by default] _mysql_client_plugin_declaration_ = { \ ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/plugin/auth_gssapi/client_plugin.cc:101:1: note: in expansion of macro ‘mysql_declare_client_plugin’ mysql_declare_client_plugin(AUTHENTICATION) ^ troff: fatal error: can't find macro file m troff: fatal error: can't find macro file m /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc: In function ‘int com_status(String*, char*)’: /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4738:13: error: ‘A_BOLD’ was not declared in this scope vidattr(A_BOLD); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4738:19: error: ‘vidattr’ was not declared in this scope vidattr(A_BOLD); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4740:13: error: ‘A_NORMAL’ was not declared in this scope vidattr(A_NORMAL); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4808:13: error: ‘A_BOLD’ was not declared in this scope vidattr(A_BOLD); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4808:19: error: ‘vidattr’ was not declared in this scope vidattr(A_BOLD); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4810:13: error: ‘A_NORMAL’ was not declared in this scope vidattr(A_NORMAL); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc: In function ‘int put_info(const char*, INFO_TYPE, uint, const char*)’: /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4905:47: error: ‘setupterm’ was not declared in this scope (void) setupterm((char *)0, 1, (int *) 0); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4918:15: error: ‘A_STANDOUT’ was not declared in this scope vidattr(A_STANDOUT); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4918:25: error: ‘vidattr’ was not declared in this scope vidattr(A_STANDOUT); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4937:15: error: ‘A_BOLD’ was not declared in this scope vidattr(A_BOLD); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4937:21: error: ‘vidattr’ was not declared in this scope vidattr(A_BOLD); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4939:13: error: ‘A_NORMAL’ was not declared in this scope vidattr(A_NORMAL); ^ /home/user/anaconda3/conda-bld/work/server-mariadb-10.1.13/client/mysql.cc:4939:21: error: ‘vidattr’ was not declared in this scope vidattr(A_NORMAL); ^ make[2]: *** [client/CMakeFiles/mysql.dir/mysql.cc.o] Error 1 make[1]: *** [client/CMakeFiles/mysql.dir/all] Error 2 make: *** [all] Error 2 Using Anaconda Cloud api site https://api.anaconda.org Command failed: /bin/bash -x -e /home/user/anaconda/conda-recipes-extra/mariadb-10/build.sh Any help would be much appreciated, Alexey

2 1