- developers - lists.mariadb.org

[Maria-developers] Strange pbxt issue in 5.1 (missing rows)
by Michael Widenius 29 Nov '10

29 Nov '10

Hi! I just merged MySQL 5.1.53 into MariaDB and as part of that, did run the pbxt test suite. I encountered this test failure: mysql-test-run --suite=pbxt URRENT_TEST: pbxt.insert --- /home/my/maria-5.1-release/mysql-test/suite/pbxt/r/insert.result 2010-11-25 12:02:26.083226000 +0200 +++ /home/my/maria-5.1-release/mysql-test/suite/pbxt/r/insert.reject 2010-11-25 19:33:48.281738504 +0200 @@ -298,7 +298,7 @@ insert into t2 select t1.* from t1, t2 t, t3 where t1.id1 = t.id2 and t.id2 = t3.id3; select count(*) from t2; count(*) -25500 +25495 drop table t1,t2,t3; create table t1 (a int, b int); insert into t1 (a,b) values (a,b); This only happened once for this test. (I did get similar failures with one other test for that run, but not for new runs). I could not repeat it by running the test or suite again. I also tested to run the test with valgrind, but not problems found. I noticed this also happens in buildbot from time to time: See http://buildbot.askmonty.org/buildbot/builders/gentoo-x86-dbg/builds/396/st…, search after pbxt.insert Paul, have you ever encountered something like this? Any clues where to start looking? (The tree I am working with is 5.1-release) Regards, Monty

2 1

Re: [Maria-developers] MySQL: THDVAR in full-text parser
by Sergei Golubchik 26 Nov '10

26 Nov '10

Hi, 0x00F6! First: please send questions like this to maria-developers(a)lists.launchpad.net it's a public mailing list dedicated to MySQL and MariaDB internals, source code, and related things. I am subscribed, so I'll see you mail there, and you may be sure I will, because it won't be accidentally catched by my spam filter, or sorted out in some obscure folder. Furthermore other subscribers will see your question and could reply if I will be not available (e.g. I could be travelling). Thank you. On Nov 27, 0x00F6 - wrote: > Hello Sergei, > > Would you please help me in one small problem? > I'm writing MySQL full-text parser plugin and I need to configure it > by several session-level variables. So I need to execute THDVAR macro > in my parse function. So how to obtain "thd" variable for this macro? The server uses 'current_thd' in such a case. It should probably be in the plugin.h, I'd say. But at the moment it is not. You can copy the declaration from mysql_priv.h, something like this: extern pthread_key_t THR_THD; THD *current_thd() { return (THD*)pthread_getspecific(THR_THD); } if you want it to work on windows, see mysql_priv.h for the complete definition of current_thd. Regards, Sergei

1 0

Re: [Maria-developers] [Maria-discuss] Problem with MariaDb as a Windows service
by Peter Laursen 25 Nov '10

25 Nov '10

Same problem with MariaDB 5.1.51. --Peter On Sun, Nov 21, 2010 at 02:43, Vladislav Vaintroub < vladislav.vaintroub(a)oracle.com> wrote: > Hi, > It is likely this bug http://bugs.mysql.com/bug.php?id=56821 , was for > some > time in MySQL, already fixed. > > -----Original Message----- > From: maria-developers-bounces+wlad=sun.com(a)lists.launchpad.net > [mailto:maria-developers-bounces+wlad <maria-developers-bounces%2Bwlad>= > sun.com(a)lists.launchpad.net] On Behalf > Of Philip Stoev > Sent: Samstag, 20. November 2010 20:04 > To: Peter Laursen > Cc: maria-discuss(a)lists.launchpad.net; > maria-developers(a)lists.launchpad.net > Subject: Re: [Maria-developers] [Maria-discuss] Problem with MariaDb as a > Windows service > > Hi, > > It seems that the service requires the --console option to operate > properly. > > Here is how I could make it work: > > 1. In the Services Control panel, open up the properties for the service 2. > In the "Start Parameters" box, type "--console" without the quotation marks > 3. In the same dialog box, hit Start > > Philip Stoev > > ----- Original Message ----- > From: "Peter Laursen" <peter_laursen(a)webyog.com> > To: <maria-discuss(a)lists.launchpad.net>; > <maria-developers(a)lists.launchpad.net> > Sent: Saturday, November 20, 2010 3:36 PM > Subject: [Maria-discuss] Problem with MariaDb as a Windows service > > > > Some person claimed here around one week ago that MariaDB would not > > run as service after "mysqld --install". > > I replied that it worked for me - but it does not with the latest > > stable version 5.2.3 (it did with the 5.2.3 RC) (so my apology to this > > person!) > > > > Windows console output: > > > > C:\maria52\bin>sc delete maria52 > > [SC] DeleteService LYKKEDES > > > > C:\maria52\bin>mysqld --install maria52 Service successfully > > installed. > > > > C:\maria52\bin>net start maria52 > > Tjenesten maria52 starter... > > Tjenesten maria52 kunne ikke startes. > > > > Der opstod en systemfejl. > > > > Systemfejlen 1067 opstod. > > > > (From Danish --> service could not start --> the system error 1067 > > occurred) > > > > I have tried with both old datadir and the empty one shipped with > > mariaDB and also my old my.ini as well as a fresh one. > > Also I tried to add --defaults-dir to the registry (just in case I had > > overlooked a my.ini copy in C:\ or C:\Windows) and adding doublequotes > > key manually like "C:\maria52\bin\mysqld" > > --defaults-file="C:\maria52\my.ini" maria52 > > > > I double checked there are no conflicts wit all settings. > > > > The command > > "C:\maria52\bin\mysqld" --defaults-file="C:\maria52\my.ini" > > .. starts the server (also when --defaults-file is omitted) .. but not > > as a service of course. > > > > > > Was it tested with the 5.2.3 GA release that it will run as a Windows > > service? > > The RC worked as a charm - but the GA will not. Any idea? > > (I am using Win7, 64 bit, Home Premium) > > > > > > Peter > > (Webyog) > > > > > > ---------------------------------------------------------------------------- > ---- > > > > _______________________________________________ > > Mailing list: https://launchpad.net/~maria-discuss > > Post to : maria-discuss(a)lists.launchpad.net > > Unsubscribe : https://launchpad.net/~maria-discuss > > More help : https://help.launchpad.net/ListHelp > > > > > _______________________________________________ > Mailing list: https://launchpad.net/~maria-developers > Post to : maria-developers(a)lists.launchpad.net > Unsubscribe : https://launchpad.net/~maria-developers > More help : https://help.launchpad.net/ListHelp > >

3 2

Re: [Maria-developers] [Maria-discuss] Problem with MariaDb as a Windows service
by Alex Budovski 24 Nov '10

24 Nov '10

> Right, this was subsequently fixed in MySQL in > http://lists.mysql.com/commits/118824 > Yes, I noticed that too late.

1 0

Re: [Maria-developers] [Commits] Rev 2977: Fix of LP BUG#675248. in file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/
by Igor Babaev 23 Nov '10

23 Nov '10

Sanja. Ok to push after the required changes in comments Regards, Igor. sanja(a)askmonty.org wrote: > At file:///home/bell/maria/bzr/work-maria-5.1-lb675248-prep-where/ > > ------------------------------------------------------------ > revno: 2977 > revision-id: sanja(a)askmonty.org-20101123150005-adpcldzod759jgp1 > parent: sanja(a)askmonty.org-20101118141011-gth6b6pa0w9lyu1b > committer: sanja(a)askmonty.org > branch nick: work-maria-5.1-lb675248-prep-where > timestamp: Tue 2010-11-23 17:00:05 +0200 > message: > Fix of LP BUG#675248. > > Registration of pointer change if we assign it to other pointer which should be identical after statememnt execution (PS/SP). > ^fix spelling in the comment > > ------------------------------------------------------------------------ > > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits + /** + Assigns new value to place and check item tree changes for need of + re-registering the change. Make change in item tree after checking whether it needs registering + + @param place place where we should assign new value + @param new_value place of the new value + + @details + see check_and_register_item_tree_change details + */ + void check_and_register_item_tree(Item **place, Item **new_value) + { + if (!stmt_arena->is_conventional()) + check_and_register_item_tree_change(place, new_value, mem_root); + *place= *new_value; + } void nocheck_register_item_tree_change(Item **place, Item *old_value, MEM_ROOT *runtime_memroot); + void check_and_register_item_tree_change(Item **place, Item **new_value, + MEM_ROOT *runtime_memroot); void rollback_item_tree_changes();

1 0

Re: [Maria-developers] really annoying bug in mysql 5.0/5.1 optimiser, opened for more than 2 years, and still present in MariaDB
by Jocelyn Fournier 23 Nov '10

23 Nov '10

Hi, Just FYI, it's created as https://bugs.launchpad.net/maria/+bug/639949 I really hope it could be fixed soon, since it could impact mysql performances for a lot of customers. Thanks and regards, Jocelyn Fournier Le 15/09/2010 18:43, Igor Babaev a écrit : > Jocelyn Fournier wrote: >> Hi Igor, >> >> Just curious, is there any bug corresponding to this issue in launchpad ? > Hi Jocelyn, > > No, feel yourself free to add it for MariaDB 5.1. In this case the > chances are higher that the problem will be fixed in one of the nearest > releases. > > Regards, > Igor. > >> Thanks ! >> Jocelyn >> >> >> Le 27/08/10 18:04, Igor Babaev a écrit : >>> Jocelyn Fournier wrote: >>>> Hi, >>>> >>>> There's a really annoying bug in the mysql optimiser existing for a >>>> really long time now, and which has a direct impact on performances : >>>> >>>> http://bugs.mysql.com/bug.php?id=36817 >>>> >>>> Since MySQL definitly doesn't seem to want to fix it, I hope MariaDB >>>> could do something to help the poor developpers who need to heavily hack >>>> there apps with USE INDEX ;) >>>> >>>> Note I've tested with mariadb 5.2.1-beta, and the bug is still present. >>>> >>>> Thanks a lot ! >>>> Jocelyn Fournier >>> Jocelyn, >>> >>> I will take care of this bug. >>> >>> Regards, >>> Igor. >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~maria-developers >>>> Post to : maria-developers(a)lists.launchpad.net >>>> Unsubscribe : https://launchpad.net/~maria-developers >>>> More help : https://help.launchpad.net/ListHelp >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~maria-developers >>> Post to : maria-developers(a)lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~maria-developers >>> More help : https://help.launchpad.net/ListHelp >

1 0

[Maria-developers] Buildbot Outage
by Adam M. Dutko 22 Nov '10

22 Nov '10

Sorry for the delayed notice but adutko-centos5-amd64 will probably be offline until Wednesday (11/24/10) awaiting a part replacement. -Adam <http://buildbot.askmonty.org/buildbot/buildslaves/adutko-centos5-amd64>

1 0

Re: [Maria-developers] [Commits] Rev 2832: Fix for LP BUG#606013: Adding bit field support for heap tables. in file:///home/bell/maria/bzr/work-maria-5.3-lp606013/
by Michael Widenius 22 Nov '10

22 Nov '10

Hi! Here is a review of this <cut> > --- a/storage/heap/hp_create.c 2010-08-05 19:56:11 +0000 > +++ b/storage/heap/hp_create.c 2010-11-16 21:03:26 +0000 > @@ -104,6 +104,13 @@ int heap_create(const char *name, uint k > */ > keyinfo->seg[j].type= HA_KEYTYPE_VARTEXT1; > break; > + case HA_KEYTYPE_BIT: > + /* > + The odd bits which stored separately (if they are present > + (bit_pos, bit_length)) are already present in seg[j].length as > + additional byte. Add: See field.h, function key_length() <cut> > @@ -720,7 +765,8 @@ uint hp_rb_make_key(HP_KEYDEF *keydef, u > { > uint length= seg->length; > uchar *pos= (uchar*) rec + seg->start; > - > + DBUG_ASSERT(seg->type != HA_KEYTYPE_BIT); Add a check in the test suite that one can't create a rb key with bit fields. Add also a MRT for this. (you can probable reuse something from type_bit.test and archive_bitfield.test for this) Regards, Monty

1 0

[Maria-developers] Problem with prep_where (LP BUG#675248)
by Oleksandr Byelkin 22 Nov '10

22 Nov '10

Preparation statement for PS looks like this (example uses prep_where, but we have the same problem for other parts stored in st_select_lex::fix_prepare_information()): ... conds->fix_fields(...&conds...) /* (1.1) JOIN::prepare()*/ ... prep_where= *conds; /* (1.2) st_select_lex::fix_prepare_information() */ *conds= where= prep_where->copy_andor_structure() ... Then executing of the prepared statement is like this: where= prep_where->copy_andor_structure() /* (2.1) reinit_stmt_before_use */ ... where->fix_fields() /* (2.2) JOIN::prepare() */ ... The problem is that during (1.1) we could substitute conds with reference on other item (for example if we change reference on Item_field on Item_ref* or Item_ref on Item_field). The new item will be destroyed after preparation (i.e before (2.1)). So during (2.1) prep_where points on freed memory. How to solve the problem. 1. Workarounds 1.1. Make changing Items inherited from Item_ident (Item_field and Item_ref*) during resolving permanent. Pros: - Looks logical - reduce work during second preparation Cons: - Play with statement memory usually complex enough. - have to be sure that there is no any reference on the original Item 1.2 Add new method for Item, which return 'this' pointer but for Item_idents creating during resolving original Item. (1.2) turns to something like: prep_where= (*conds)->original_ident_item(); Pros: - Looks simple Cons: - Item already overloaded with methods like this 1.3 Assign prep_where before (1.1) Pros: - Easy to implement Cons: - Need changing logic and semantic of some calls and prep_where/prep_having... class variables. 2. Global solutions for the problem of double/triple/... reference on transformed expression (it is not applicadle for 5.1-5.3 but could de universal solution in 5.5 of higher): 2.1 Absolutely transparent wrapper to save only one reference on any expression which could be transformed: Pros: - Could base class for many other wrappers Cons: - It is difficult to implement such absolutely transparent wrapper. - A lot of places where it should be put, make Item tree bigger 2.2 Turn THD::change_list to hash (for example) and chack presence of assigning variable in the list, if it found, also register changing for variable we are assigning value now. For example instead of prep_where= *conds; use thd->assign_changeable(&prep_where, conds), where: void THD::assign_changeable(void **newref, void **oldref) { if (in_changed_references(oldref) change_item_tree(newref, *oldref); else *newref= *oldref; } Pros: - no additional work for usual statements Cons: - List supports order of assigments easyly, but hash can't - time for finding pointers in the hash

2 1

Re: [Maria-developers] [Commits] Rev 89: MBug#674413: better fix following review: clear sql_mode rather than add every column explicitly. in http://bazaar.launchpad.net/~maria-captains/maria/5.1
by Sergei Golubchik 21 Nov '10

21 Nov '10

Hi, knielsen! On Nov 20, knielsen(a)knielsen-hq.org wrote: > At http://bazaar.launchpad.net/~maria-captains/maria/5.1 > > ------------------------------------------------------------ > revno: 89 > revision-id: knielsen(a)knielsen-hq.org-20101120084531-x0hbb64q9x0yj376 > parent: knielsen(a)knielsen-hq.org-20101119133933-wb5g8sdjynao018w > committer: knielsen(a)knielsen-hq.org > branch nick: ourdelta-montyprogram-fixes > timestamp: Sat 2010-11-20 09:45:31 +0100 > message: > MBug#674413: better fix following review: clear sql_mode rather than add every column explicitly. > === modified file 'bakery/debian-5.2/dist/Debian/mariadb-server-5.2.postinst' > --- a/bakery/debian-5.2/dist/Debian/mariadb-server-5.2.postinst 2010-11-19 13:39:33 +0000 > +++ b/bakery/debian-5.2/dist/Debian/mariadb-server-5.2.postinst 2010-11-20 08:45:31 +0000 > @@ -195,6 +195,7 @@ EOF > "ALTER TABLE user CHANGE Password Password char(41) character set latin1 collate latin1_bin DEFAULT '' NOT NULL"`; > replace_query=`/bin/echo -e \ > "USE mysql\n" \ > + "SET sql_mode='';\n" \ > "REPLACE INTO user SET " \ > " host='localhost', user='debian-sys-maint', password=password('$pass'), " \ > " Select_priv='Y', Insert_priv='Y', Update_priv='Y', Delete_priv='Y', " \ > @@ -205,9 +206,7 @@ EOF > " Repl_slave_priv='Y', Repl_client_priv='Y', Create_view_priv='Y', "\ > " Show_view_priv='Y', Create_routine_priv='Y', Alter_routine_priv='Y', "\ > " Create_user_priv='Y', Event_priv='Y', Trigger_priv='Y',"\ > - " ssl_type='', ssl_cipher='', x509_issuer='', x509_subject='',"\ > - " max_questions=0, max_updates=0, max_connections=0,"\ > - " max_user_connections=0, plugin='', auth_string='';"`; > + " ssl_cipher='', x509_issuer='', x509_subject='';"`; There's no need to set ssl_cipher and other blob columns - they'll get the empty string by default anyway. Regards, Sergei

2 1