- developers - lists.mariadb.org

[Maria-developers] 5.5 merge: sql_select.cc
by Sergei Golubchik 23 Jun '11

23 Jun '11

Hi. Here I'll list changesets that cause conflicts and ask what to do. 1. http://tinyurl.com/63tey39 vs. http://tinyurl.com/5v2pluf it's a fix for bug#49322. both changes are similar, return is moved down. But Igor put it after the while() loop, while Ole John - in the loop, as soon a non-match is found. What difference does it make, I mean the earlier return, what consequences? 2. http://tinyurl.com/69lwrp9 - a big chunk is moved around in test_if_skip_sort_order() that's all, the rest of the file I've merged already. Regards, Sergei

3 2

[Maria-developers] forwarded message from Kristian Köhntopp
by Michael Widenius 21 Jun '11

21 Jun '11

Hi! Here is booking.com's wish list! Regards, Monty

3 2

[Maria-developers] MariaDB limits
by Marian Marinov 21 Jun '11

21 Jun '11

Hello guys, I have a lot of clients requesting some kind of per user limiting based on the information from the STATISTICS tables. I'm thinking of creating a patch that will add this functionality by creating two more tables in the INFORMATION_SCHEMA: USER_LIMITS CLIENT_LIMITS They will have some parts of the structure of USER_STATISTICS and CLIENT_STATISTICS and will keep only values for limits. By default a 0 would mean no limit. Do you have any comments about my aproach? Would you be willing to accept a patch that adds such functionality? I want to know before I start work on this project if the community is interested in such enhancement of MariaDB. Regards, Marian

3 4

Re: [Maria-developers] Notes from the two IT Day Sessions
by Michael Widenius 20 Jun '11

20 Jun '11

Hi! Follow up to last email. I will hope to have the worklog items for all the wishes done by Thursday. Regards, Monty

1 0

[Maria-developers] MariaDB in EPEL
by Marian Marinov 20 Jun '11

20 Jun '11

Hello, I wish to package MariaDB for the EPEL repository. I have searched a bit to see if there were any efforts in that direction but I saw none. In 2009 there was some talk about MariaDB and Fedora, but that was it, only some talk. I have the time to prepare and test the MariaDB RPMs and to continue support them later. My idea is to have MariaDB RPMs as replacements of the default mysql installation. In order to do so, I first want the approval of the MariaDB developers. Best regards, Marian Marinov

2 3

Re: [Maria-developers] Rev 2994: BUG#790513: MariaDB crashes on startup
by Sergei Golubchik 17 Jun '11

17 Jun '11

Hi, Sergey! On Jun 17, Sergey Petrunya wrote: > Hi Sergei, > > Could you please review the below: > > ------------------------------------------------------------ > revno: 2994 > committer: Sergey Petrunya <psergey(a)askmonty.org> > timestamp: Fri 2011-06-17 01:05:20 +0400 > message: > BUG#790513: MariaDB crashes on startup please use lp:790513 abbreviation for bugs. see 'bzr help bugs' for details. > - Let ha_resolve_by_name() print error in case it could locate > the needed plugin but the plugin hasn't yet been initialized. > One can hit this problem by having mysql.plugin of type=innodb. Okay, I see the problem. But why couldn't we just initialize *all* built-in plugins earlier, before accessing mysql.plugin table ? > === modified file 'sql/handler.cc' > --- a/sql/handler.cc 2011-05-03 16:10:10 +0000 > +++ b/sql/handler.cc 2011-06-16 21:05:20 +0000 > @@ -135,6 +135,12 @@ > if ((plugin= my_plugin_lock_by_name(thd, name, MYSQL_STORAGE_ENGINE_PLUGIN))) > { > handlerton *hton= plugin_data(plugin, handlerton *); > + if (!hton) > + { > + sql_print_error("Attempt to use a built-in plugin %*s before it " > + "has been initialized", name->length, name->str); > + return NULL; > + } > if (!(hton->flags & HTON_NOT_USER_SELECTABLE)) > return plugin; > Regards, Sergei

1 0

Re: [Maria-developers] [Commits] Rev 3049: BUG#778406: Crash in hp_movelink with Aria engine and subqueries in file:///home/psergey/dev2/5.3-push3/
by Timour Katchaounov 17 Jun '11

17 Jun '11

Sergey, Ok to push. I'd rather add a comment to the block of code starting with: " // 1. Store the length " At least to me it was not obvious why it is the way it is. Timour > At file:///home/psergey/dev2/5.3-push3/ > > ------------------------------------------------------------ > revno: 3049 > revision-id: psergey(a)askmonty.org-20110615143701-cgzzcr5l4ot2cxjy > parent: psergey(a)askmonty.org-20110615134018-5g5jbhqhce43onz4 > committer: Sergey Petrunya<psergey(a)askmonty.org> > branch nick: 5.3-push3 > timestamp: Wed 2011-06-15 18:37:01 +0400 > message: > BUG#778406: Crash in hp_movelink with Aria engine and subqueries > -In do_sj_dups_weedout(), set nulls_ptr to point to NULL bytes (and not to length bytes) of the DuplicateWeedout column. > === modified file 'mysql-test/r/subselect_sj.result' > --- a/mysql-test/r/subselect_sj.result 2011-06-15 09:43:04 +0000 > +++ b/mysql-test/r/subselect_sj.result 2011-06-15 14:37:01 +0000 > @@ -1305,4 +1305,25 @@ > GROUP BY field2 ; > field2 > drop table t1, t2, t3; > +# > +# BUG#778406 Crash in hp_movelink with Aria engine and subqueries > +# > +CREATE TABLE t4 (f10 varchar(32) , KEY (f10)) ENGINE=Aria; > +INSERT INTO t4 VALUES ('x'),('m'),('c'); > +CREATE TABLE t1 (f11 int) ENGINE=Aria; > +INSERT INTO t1 VALUES (0),(0),(0); > +CREATE TABLE t2 ( f10 int) ENGINE=Aria; > +INSERT INTO t2 VALUES (0),(0),(0); > +CREATE TABLE t3 ( f10 int, f11 int) ENGINE=Aria; > +SELECT * > +FROM t4 > +WHERE f10 IN > +( SELECT t1.f11 > +FROM t1 > +LEFT JOIN t2 JOIN t3 ON t3.f10 = t2.f10 ON t3.f11 != 0 ); > +f10 > +x > +m > +c > +drop table t1,t2,t3,t4; > set @@optimizer_switch=@save_optimizer_switch; > > === modified file 'mysql-test/r/subselect_sj_jcl6.result' > --- a/mysql-test/r/subselect_sj_jcl6.result 2011-06-15 09:43:04 +0000 > +++ b/mysql-test/r/subselect_sj_jcl6.result 2011-06-15 14:37:01 +0000 > @@ -1313,6 +1313,27 @@ > GROUP BY field2 ; > field2 > drop table t1, t2, t3; > +# > +# BUG#778406 Crash in hp_movelink with Aria engine and subqueries > +# > +CREATE TABLE t4 (f10 varchar(32) , KEY (f10)) ENGINE=Aria; > +INSERT INTO t4 VALUES ('x'),('m'),('c'); > +CREATE TABLE t1 (f11 int) ENGINE=Aria; > +INSERT INTO t1 VALUES (0),(0),(0); > +CREATE TABLE t2 ( f10 int) ENGINE=Aria; > +INSERT INTO t2 VALUES (0),(0),(0); > +CREATE TABLE t3 ( f10 int, f11 int) ENGINE=Aria; > +SELECT * > +FROM t4 > +WHERE f10 IN > +( SELECT t1.f11 > +FROM t1 > +LEFT JOIN t2 JOIN t3 ON t3.f10 = t2.f10 ON t3.f11 != 0 ); > +f10 > +x > +m > +c > +drop table t1,t2,t3,t4; > set @@optimizer_switch=@save_optimizer_switch; > # > # BUG#49129: Wrong result with IN-subquery with join_cache_level=6 and firstmatch=off > > === modified file 'mysql-test/t/subselect_sj.test' > --- a/mysql-test/t/subselect_sj.test 2011-06-15 09:43:04 +0000 > +++ b/mysql-test/t/subselect_sj.test 2011-06-15 14:37:01 +0000 > @@ -1189,5 +1189,28 @@ > > drop table t1, t2, t3; > > +--echo # > +--echo # BUG#778406 Crash in hp_movelink with Aria engine and subqueries > +--echo # > +CREATE TABLE t4 (f10 varchar(32) , KEY (f10)) ENGINE=Aria; > +INSERT INTO t4 VALUES ('x'),('m'),('c'); > + > +CREATE TABLE t1 (f11 int) ENGINE=Aria; > +INSERT INTO t1 VALUES (0),(0),(0); > + > +CREATE TABLE t2 ( f10 int) ENGINE=Aria; > +INSERT INTO t2 VALUES (0),(0),(0); > + > +CREATE TABLE t3 ( f10 int, f11 int) ENGINE=Aria; > + > +SELECT * > +FROM t4 > +WHERE f10 IN > +( SELECT t1.f11 > +FROM t1 > +LEFT JOIN t2 JOIN t3 ON t3.f10 = t2.f10 ON t3.f11 != 0 ); > + > +drop table t1,t2,t3,t4; > + > # The following command must be the last one the file > set @@optimizer_switch=@save_optimizer_switch; > > === modified file 'sql/opt_subselect.cc' > --- a/sql/opt_subselect.cc 2011-06-06 22:50:46 +0000 > +++ b/sql/opt_subselect.cc 2011-06-15 14:37:01 +0000 > @@ -3515,7 +3515,6 @@ > } > > ptr= sjtbl->tmp_table->record[0] + 1; > - nulls_ptr= ptr; > > /* Put the the rowids tuple into table->record[0]: */ > > @@ -3531,6 +3530,7 @@ > ptr += 2; > } > > + nulls_ptr= ptr; > // 2. Zero the null bytes > if (sjtbl->null_bytes) > { > > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits

1 0

[Maria-developers] MariaDB 5.2.7
by Daniel Bartholomew 15 Jun '11

15 Jun '11

Hello all, Just writing to let you know that MariaDB 5.2.7 is now almost completely mirrored worldwide, so I've activated the downloads page and the release notes and changelog. Here are the links: http://kb.askmonty.org/en/mariadb-527-release-notes http://kb.askmonty.org/en/mariadb-527-changelog http://downloads.askmonty.org/mariadb/5.2.7/ If any of you have a moment, please review the release notes and make (or suggest) any necessary changes. I tried to incorporate everything that I was told about this release, but I may have missed something. Now turning things over to the community team to announce and promote. Thanks. -- Daniel Bartholomew MariaDB - http://mariadb.org Monty Program - http://montyprogram.com AskMonty Knowledgebase - http://kb.askmonty.org

1 0

[Maria-developers] Preparing to release MariaDB 5.2.7
by Daniel Bartholomew 14 Jun '11

14 Jun '11

Monty, I saw your note about the new MariaDB 5.2.7 release being ready, but it looks like the "mariadb-5.2.7" tag has not been added to the 5.2 tree on launchpad. Can you or one of the other developers add it? I need the tag as part of my process for creating the changelog. Apart from that, I just need to determine which buildbot build is the correct one. Kristian, You sent me some instructions a while back for how to do this but I can't remember them. I guess you've spoiled me by usually just telling me the build number. :) Can you send the instructions to me again? Thanks. -- Daniel Bartholomew MariaDB - http://mariadb.org Monty Program - http://montyprogram.com AskMonty Knowledgebase - http://kb.askmonty.org

3 4

[Maria-developers] tmp-table-tests MariaDB 5.2.6 vs. 5.5.12 vs. 5.1.57
by erkan yanar 09 Jun '11

09 Jun '11

Moin, I did some tmp-table tests. As it is told MariaDB is faster on tmp-tables because of the Aria-Engine. Therefore Ive got 3 Severs running: onyx:/data/dbod # for i in 6051 6053 6060; do mysql -u erkan -h 10.255.128.4 -P $i -e 'select version()'; done +------------+ | version() | +------------+ | 5.5.12-log | +------------+ +-------------------+ | version() | +-------------------+ | 5.2.6-MariaDB-log | +-------------------+ +------------+ | version() | +------------+ | 5.1.57-log | key_buffer_size is 16MB. For MariaDB there is also: mysql> show global variables like 'aria_pagecache_buffer_size'; +----------------------------+----------+ | Variable_name | Value | +----------------------------+----------+ | aria_pagecache_buffer_size | 16777216 | +----------------------------+----------+ To provoke tmp-tables I did: onyx:/data/dbod # for i in 6051 6053 6060; do mysql -u erkan -h 10.255.128.4 -P $i -e 'show global variables like "tmp_table_size"'; done +----------------+-------+ | Variable_name | Value | +----------------+-------+ | tmp_table_size | 1024 | +----------------+-------+ +----------------+-------+ | Variable_name | Value | +----------------+-------+ | tmp_table_size | 1024 | +----------------+-------+ +----------------+-------+ | Variable_name | Value | +----------------+-------+ | tmp_table_size | 1024 | +----------------+-------+ We got two tables: mysql> desc sort_id; +-------+---------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-----+---------+-------+ | id | int(11) | YES | | NULL | | +-------+---------+------+-----+---------+-------+ 1 row in set (0.00 sec) mysql> desc sort_1; +-------+---------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-----+---------+-------+ | id | int(11) | YES | | NULL | | | tea | text | YES | | NULL | | +-------+---------+------+-----+---------+-------+ 2 rows in set (0.00 sec) With 10000 Rows each. Tests: onyx:/var/tmp # for i in 6051 6053 6060; do mysqlslap -u erkan -P $i -h 10.255.128.4 --create-schema=sbtest -q "SELECT * from sbtest.sort_1 group by id;" --number-of-queries=20 -i 3; done Benchmark [[5.5.12]] Average number of seconds to run all queries: 1.803 seconds Minimum number of seconds to run all queries: 1.791 seconds Maximum number of seconds to run all queries: 1.826 seconds Number of clients running queries: 1 Average number of queries per client: 20 Benchmark [[MariaDB]] Average number of seconds to run all queries: 5.547 seconds Minimum number of seconds to run all queries: 5.542 seconds Maximum number of seconds to run all queries: 5.556 seconds Number of clients running queries: 1 Average number of queries per client: 20 Benchmark [[5.1.57]] Average number of seconds to run all queries: 1.605 seconds Minimum number of seconds to run all queries: 1.603 seconds Maximum number of seconds to run all queries: 1.606 seconds Number of clients running queries: 1 Average number of queries per client: 20 onyx:/var/tmp # for i in 6051 6053 6060; do mysqlslap -u erkan -P $i -h 10.255.128.4 --create-schema=sbtest -q "SELECT * from sbtest.sort_id group by id;" --number-of-queries=20 -i 3; done Benchmark [[5.5.12]] Average number of seconds to run all queries: 1.146 seconds Minimum number of seconds to run all queries: 1.135 seconds Maximum number of seconds to run all queries: 1.170 seconds Number of clients running queries: 1 Average number of queries per client: 20 Benchmark [[MariaDB]] Average number of seconds to run all queries: 4.359 seconds Minimum number of seconds to run all queries: 4.352 seconds Maximum number of seconds to run all queries: 4.366 seconds Number of clients running queries: 1 Average number of queries per client: 20 Benchmark [[5.1.57]] Average number of seconds to run all queries: 1.049 seconds Minimum number of seconds to run all queries: 1.032 seconds Maximum number of seconds to run all queries: 1.068 seconds Number of clients running queries: 1 Average number of queries per client: 20 So MariaDb doesn't perform in this test. So I wonder I did something wrong ... Regards Erkan -- über den grenzen muß die freiheit wohl wolkenlos sein

3 2