- developers - lists.mariadb.org

[Maria-developers] Please review MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring
by Alexander Barkov 17 May '16

17 May '16

Hi Sergei, Please review a partial patch for MDEV-6353. It removes my_mbcharlen() in all remaining pieces of the code, except LOAD DATA and SELECT INTO OUTFILE. I'll do LOAD DATA and SELECT INTO OUTFILE in a separate patch. Thanks.

2 4

[Maria-developers] MDEV-10035 DBUG_ASSERT on CREATE VIEW v1 AS SELECT * FROM t1 FOR UPDATE
by Alexander Barkov 16 May '16

16 May '16

Hi Sanja, Sergei, Sanja, you asked me to review a patch for MDEV-10035: revision-id: 4ffe2295e78538dde93df078421726f0c5a7d2a2 (mariadb-10.2.0-29-g4ffe229) parent(s): b79944950e5e5db40cf7ad49061edf5f105512c4 committer: Oleksandr Byelkin timestamp: 2016-05-15 15:25:33 +0200 message: I earlier also proposed the same idea to disallow FOR UPDATE, and even created a patch disallowing this in the parser syntactically (see attached). But Sergei worried that we should not do it this way and proposed some other solutions. Please see Sergei's comments in: MDEV-10063 VIEWs and subqueries with FOR UPDATE Sergei, are you still in doubts? Thanks.

3 9

Re: [Maria-developers] 7e70658: MDEV-9947: COM_MULTI united response
by Sergei Golubchik 14 May '16

14 May '16

Hi, Sanja! Looks ok to me. You're simply disable net_flush as far as I can see. For comments and questions, see below... On May 09, Oleksandr Byelkin wrote: > revision-id: 7e70658d1e88b4a255e3c28426f8259e5e596a85 (mariadb-10.2.0-20-g7e70658) > parent(s): c0a59b46be5be341bd6ffc9fe188a236ced46522 > committer: Oleksandr Byelkin > timestamp: 2016-05-09 15:26:18 +0200 > message: > > MDEV-9947: COM_MULTI united response > diff --git a/sql/protocol.cc b/sql/protocol.cc > index 9e52870..0bf2a05 100644 > --- a/sql/protocol.cc > +++ b/sql/protocol.cc > @@ -208,7 +208,8 @@ bool net_send_error(THD *thd, uint sql_errno, > const char *err, > bool > net_send_ok(THD *thd, > uint server_status, uint statement_warn_count, > - ulonglong affected_rows, ulonglong id, const char > *message) > + ulonglong affected_rows, ulonglong id, const char > *message, > + bool postpond_flush) "postpone" or "delay" or even (looking at how you use it) "skip" > { > NET *net= &thd->net; > uchar buff[MYSQL_ERRMSG_SIZE+10],*pos; > diff --git a/sql/sql_error.h b/sql/sql_error.h > index e03c3dd..98c8d77 100644 > --- a/sql/sql_error.h > +++ b/sql/sql_error.h > @@ -704,6 +704,12 @@ class Diagnostics_area > const char *message() const > { DBUG_ASSERT(m_status == DA_ERROR || m_status == DA_OK); return > m_message; } > > + bool postpond_flush() const > + { DBUG_ASSERT(m_status == DA_OK); return m_postpond_flush; } What if one uses COM_MULTI to send two commands and the first fails (results in an error). Will the second be executed? (This is a question about *sending*, client-to-server, not about MDEV-9947) > + > + void set_postpond_flush() > + { m_postpond_flush= TRUE; } > + > uint sql_errno() const > { DBUG_ASSERT(m_status == DA_ERROR); return m_sql_errno; } > > @@ -857,6 +863,8 @@ class Diagnostics_area > /** Set to make set_error_status after set_{ok,eof}_status > possible. */ > bool m_can_overwrite_status; A comment would've been nice... > + bool m_postpond_flush; > + > /** Message buffer. Can be used by OK or ERROR status. */ > char m_message[MYSQL_ERRMSG_SIZE]; Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

2 1

[Maria-developers] Cassandra v2 Project Blog and git setup.
by Charles Muurmu 12 May '16

12 May '16

Hi everyone, I am not used to blogging but I have created a wordpress blog on which I will be making posts about my progress on this project with Spetrunia. Please feel free to criticize and suggest corrections. So far I have forked the code to my Github and my work will be based on 10.1. <https://github.com/charlesmuurmu/server> I have build the code on OS X El Capitan. I have also created a branch in which I will be working. I am currently going through some documentation and tutorials on the Datastax C++ driver. Regards, Biggy

2 3

Re: [Maria-developers] GSoC Student Introduction
by Sergey Petrunia 11 May '16

11 May '16

On Wed, May 11, 2016 at 08:26:49PM +0300, Sergey Petrunia wrote: > On Wed, Apr 27, 2016 at 07:44:11AM +0100, Charles Muurmu wrote: > > I am Charles Muurmu also known as laserlight on IRC and I was selected for > > GSoC 2016 to work on migrating MariaDB Cassandra storage engine from the > > Thrift API to Datastax driver. I will be mentored by Spetrunia. My goals > > for this community bonding period will be get myself ready by accomplishing > > the following tasks: > > > > Fork and clone the server code. > > > > Try to build the code. > > > > Setup a blog on which I will post weekly reports on progress. > > > > Study the Datastax C++ driver API and documentation. > > When CassandraSE V1 was in development, I was unable to use CQL, because Thrift API was such that the entire CQL resultset had to be materialized before it could be sent to the client. That is, running "select * from column_family" would cause the cassandra node and/or MySQL to die from attempting to use too much memory. I'm interested to learn how this is resolved in the Datastax driver. > > Study the ha_cassandra.xx code and storage engines architecture. > > > Good plan. > > Hopefully the last two items will give a better idea about how to structure the > coding (what to do as the first, second, etc milestone). Another question to think about is data models. Use of Thrift API calls in CassandraSE V1 meant that - secondary indexes could not be used - there were some other limitation on what datatypes could be used (I don't remember what they were exactly). Now, if we are using CQL, it should be possible to use those. Maybe there's also something else that I'm not aware of. BR Sergei -- Sergei Petrunia, Software Developer MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog

1 0

[Maria-developers] Please review MDEV-10051 Fix subselect to return a syntax error instead of "Incorrect usage of UNION and LIMIT"
by Alexander Barkov 11 May '16

11 May '16

Hello Sergei, Please review the next step for MDEV-8909 union parser cleanup Now it's MDEV-10051, and it fixes subselects. Note, I decided to fix derived tables in a separate patch later. So there will be one more patch blocking MDEV-8909. Thanks!

2 1

[Maria-developers] MDEV-10036 sql_yacc.yy: Split select_part2 to disallow syntactically bad constructs with INTO, PROCEDURE, UNION
by Alexander Barkov 10 May '16

10 May '16

Hi Sergei, Please review a patch for MDEV-10036. This is the next step for: MDEV-8909 union parser cleanup Thanks!

2 2

[Maria-developers] Please review MDEV-10030 sql_yacc.yy: Split table_expression and remove PROCEDURE from create_select, select_paren_derived, select_derived2, query_specification
by Alexander Barkov 09 May '16

09 May '16

Hi Sergei, Please review a patch for MDEV-10030, which is a part of MDEV-8909 union parser cleanup. Thanks!

2 4

[Maria-developers] GSoC 2016: Starting blog
by Галина Шалыгина 07 May '16

07 May '16

Hi everyone, I have created blog, where I'm going to write everything about my progress on project "Pushing conditions into non-mergeable views and derived tables in MariaDB". I've already written a post on what I've done, so if you are interested, you can check it out HERE <http://gsocmariadbshagalla.blogspot.ru/>. Best wishes, Galina Shalygina.

1 0

[Maria-developers] Joinable threads
by Sergey Vojtovich 06 May '16

06 May '16

Hi Monty, I vaguely recall you told me once that you like detached threads more than joinable, specifically for service threads. Could you remind me what were the reasons behind it? I need this to fix https://jira.mariadb.org/browse/MDEV-9994 properly. Thanks, Sergey

2 4