- developers - lists.mariadb.org

[Maria-developers] Fwd: Do we have anywhere some code that copies from one internal tmp table into another?
by Igor Babaev 23 Apr '16

23 Apr '16

Hi, Please help me if you are aware of such code. In my case the tables are similar. I understand that it's easy to write this code. (Read rows from the source table one by one updating the destination table). Still I would prefer to use the existing code. Regards, Igor.

2 2

Re: [Maria-developers] 745b522: MDEV-8889 - Assertion `next_insert_id == 0' failed in handler::ha_external_lock
by Sergei Golubchik 22 Apr '16

22 Apr '16

Hi, Sergey! I believe this fix is ok... On Apr 21, Sergey Vojtovich wrote: > revision-id: 745b5226e68d376eed709d930f72c3fbc7f07d2a (mariadb-10.0.24-26-g745b522) > parent(s): 072ca71d26487817d025ee97955e6360c3c5c086 > committer: Sergey Vojtovich > timestamp: 2016-04-21 16:51:00 +0400 > message: > > MDEV-8889 - Assertion `next_insert_id == 0' failed in handler::ha_external_lock > > There was a race condition between delayed insert thread and connection thread > actually performing INSERT/REPLACE DELAYED. It was triggered by concurrent > INSERT/REPLACE DELAYED and statements that flush the same table either > explicitely or implicitely (like FLUSH TABLE, ALTER TABLE, ...). > > This race condition was caused by a gap in delayed thread shutdown logic, > which allowed concurrent connection running INSERT/REPLACE DELAYED to change > essential data consequently leaving table in semi-consistent state. > > Specifically query thread could decrease "tables_in_use" reference counter in > this gap, causing delayed insert thread to shutdown without releasing auto > increment and table lock. > > Fixed by extending condition so that delayed insert thread won't shutdown > until there're locked tables. s/until/if/ > Also removed volatile qualifier from tables_in_use and stacked_inserts since > they're supposed to be protected by mutexes. It looks like stacked_inserts is accessed without a mutex at the end of Delayed_insert::handle_inserts(). Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

2 1

Re: [Maria-developers] cd216b1: MDEV-9142 :Adding Constraint with no database reference
by Sergei Golubchik 22 Apr '16

22 Apr '16

Hi, Jan! On Apr 07, Jan Lindström wrote: > revision-id: cd216b1ab577ffe00253ec135d6194051f7ecfa0 (mariadb-5.5.48-15-gcd216b1) > parent(s): 11b77e9b18a8d97063b4c4a96e40bf9c75bd0e8b > committer: Jan Lindström > timestamp: 2016-04-07 10:47:46 +0300 > message: > > MDEV-9142 :Adding Constraint with no database reference > results in ERROR 1046 (3D000) at line 13: No database selected. > > Use database from create table to foreign key database if > nothing else is given. Ok to push Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

1 0

Re: [Maria-developers] failing tests
by Alexander Barkov 22 Apr '16

22 Apr '16

Hi Olivier, Vladislav, Please have a look into MDEV-9739 Assertion `m_status == DA_ERROR || m_status == DA_OK' failed in Diagnostics_area::message() ; connect.xml* tests fail in buildbot The crash appeared after this commit by Vladislav: commit 3a24f1cf8426409a69619982e84ca498d581f8a1 Author: Vladislav Vaintroub <vvaintroub(a)googlemail.com> Date: Mon Feb 22 12:48:03 2016 +0100 MDEV-9307 - provide info about DATA/INDEX directory in INFORMATION_SCHEMA.TA BLES (in CREATE_OPTIONS column) Vladislav thinks that the actual problem resides in the ConnectSE code, in a wrong use of my_error(). Can you please take over the problem from this point? Thanks. On 03/21/2016 12:54 PM, Alexander Barkov wrote: > Hi Olivier, > > > On 03/20/2016 02:10 AM, Olivier Bertrand wrote: >> Hello Alexander, >> >> Le 19/03/2016 14:59, Alexander Barkov a écrit : >>> Hi Olivier, >>> >>> On 03/19/2016 02:18 AM, Olivier Bertrand wrote: >>>> Hello Alexander, >>>> >>>> I went into linux ubuntu and pass the tests but all XML tests were >>>> skipped saying "need libxml2". However I could check was libxml2 was >>>> installed indeed. Don't know what to do next. >>> Please make sure that libxml2-dev is installed. >> It was not and I installed it. However it did not change anything. > > Please make sure to remove CMakeCache.txt and run cmake again from > scratch. Does this help? > > >> The problem is that libxml2 is not recognized as installed when >> compiling Connect and then the XML type is not available. >> (trying to create an XML table fails saying "invalid table type") >> >> Btw, how do the tests fail and for what reason? > > For some reasons it crashes in DEBUG build when doing this query: > > > SELECT count(*) FROM INFORMATION_SCHEMA.TABLES WHERE > TABLE_SCHEMA='test' AND TABLE_NAME='t1' AND ENGINE='CONNECT' > AND CREATE_OPTIONS LIKE '%`table_type`=XML%' AND CREATE_OPTIONS > LIKE '%xmlsup=libxml2%' > > > with this stack trace: > > > sql/sql_error.h:705(Diagnostics_area::message() const)[0x563787dda10a] > sql/sql_select.cc:2669(JOIN::exec_inner())[0x563787dd97b5] > sql/sql_select.cc:3453(mysql_select(THD*, Item***, TABLE_LIST*, unsigned > int, List<Item>&, Item*, unsigned int, st_order*, st_order*, Item*, > st_order*, unsigned long long, select_result*, st_select_lex_unit*, > st_select_lex*))[0x563787ddcd1b] > sql/sql_select.cc:384(handle_select(THD*, LEX*, select_result*, unsigned > long))[0x563787dd2811] > sql/sql_parse.cc:5936(execute_sqlcom_select)[0x563787da2ae4] > sql/sql_parse.cc:2962(mysql_execute_command(THD*))[0x563787d98625] > sql/sql_parse.cc:7336(mysql_parse(THD*, char*, unsigned int, > Parser_state*))[0x563787da615d] > sql/sql_parse.cc:1490(dispatch_command(enum_server_command, THD*, char*, > unsigned int))[0x563787d94846] > sql/sql_parse.cc:1109(do_command(THD*))[0x563787d93576] > sql/sql_connect.cc:1349(do_handle_one_connection(THD*))[0x563787ec8a6c] > sql/sql_connect.cc:1262(handle_one_connection)[0x563787ec87bb] > perfschema/pfs.cc:1862(pfs_spawn_thread)[0x56378827a1da] > /lib64/libpthread.so.0(+0x760a)[0x7f427b8aa60a] > /lib64/libc.so.6(clone+0x6d)[0x7f427959fa4d] > > > Can you please try to compile a DEBUG version on Linux and check > if you get the same problem? > > In the meanwhile I'll try to find the commit which caused this problem. > > Thanks. > > >>> >>> >>>> Olivier >>>> >>>> Le 18/03/2016 14:46, Alexander Barkov a écrit : >>>>> Hello Olivier, >>>>> >>>>> a few tests are failing in the main 10.1 tree on Linux: >>>>> >>>>> connect.xml >>>>> connect.xml_grant >>>>> connect.xml_html >>>>> connect.xml_mdev5261 >>>>> connect.xml_mult >>>>> >>>>> Can you please have a look? >>>>> >>>>> Thanks! >>

3 4

[Maria-developers] Dynamic column expression limitat - 252 characters
by Sergey Petrunia 21 Apr '16

21 Apr '16

https://mariadb.com/kb/en/mariadb/virtual-computed-columns/ says the expression cannot exceed 252 characters in length. I've got a complaint about this limitation. Do we have any plans to remove it? (Does Oracle have it in their variant of this feature?) BR Sergei -- Sergei Petrunia, Software Developer MariaDB Corporation | Skype: sergefp | Blog: http://s.petrunia.net/blog

3 2

[Maria-developers] MDEV-9372 select 100 between 1 and 9223372036854775808 returns false
by Alexander Barkov 20 Apr '16

20 Apr '16

Hi Sergei, Please review a patch for MDEV-9372. Thanks.

2 1

Re: [Maria-developers] [Commits] 308cee547f6573a9825b5f08f938d4452d0095d9 Fixed bug mdev-9931.
by Oleksandr Byelkin 20 Apr '16

20 Apr '16

Hi, Igor! On 20.04.2016 00:37, Igor Babaev wrote: > commit 308cee547f6573a9825b5f08f938d4452d0095d9 > Author: Igor Babaev <igor(a)askmonty.org> > Commit: Igor Babaev <igor(a)askmonty.org> > > Fixed bug mdev-9931. > > When the specification of a WITH table referred to a view > that used a based table with the same name as the WITH table > the server went into an infinite loop because it erroneously > resolved the reference to the base table as the reference to > the WITH table. > > With tables used in a view cannot be searched for beyond the > scope the view. > --- It looks OK to push. I'd name it 'is_view_border' (because it can be more units which belon to a view), but if you think 'is_view' is better, OK to leave it as is. > mysql-test/r/cte_nonrecursive.result | 13 +++++++++++++ > mysql-test/t/cte_nonrecursive.test | 14 ++++++++++++++ > sql/sql_cte.cc | 5 ++++- > sql/sql_lex.cc | 1 + > sql/sql_lex.h | 1 + > sql/sql_view.cc | 2 ++ > 6 files changed, 35 insertions(+), 1 deletions(-) > > diff --git a/mysql-test/r/cte_nonrecursive.result b/mysql-test/r/cte_nonrecursive.result > index df64115..a9c13f3 100644 > --- a/mysql-test/r/cte_nonrecursive.result > +++ b/mysql-test/r/cte_nonrecursive.result > @@ -746,3 +746,16 @@ with t(f1,f1) as (select * from t1 where b >= 'c') > select t1.b from t2,t1 where t1.a = t2.c; > ERROR 42S21: Duplicate column name 'f1' > drop table t1,t2; > +# > +# Bug mdev-9937: View used in the specification of with table > +# refers to the base table with the same name > +# > +create table t1 (a int); > +insert into t1 values (20), (30), (10); > +create view v1 as select * from t1 where a > 10; > +with t1 as (select * from v1) select * from t1; > +a > +20 > +30 > +drop view v1; > +drop table t1; > diff --git a/mysql-test/t/cte_nonrecursive.test b/mysql-test/t/cte_nonrecursive.test > index 5a6e07e..e3164f5 100644 > --- a/mysql-test/t/cte_nonrecursive.test > +++ b/mysql-test/t/cte_nonrecursive.test > @@ -434,3 +434,17 @@ with t(f1,f1) as (select * from t1 where b >= 'c') > select t1.b from t2,t1 where t1.a = t2.c; > > drop table t1,t2; > + > +--echo # > +--echo # Bug mdev-9937: View used in the specification of with table > +--echo # refers to the base table with the same name > +--echo # > + > +create table t1 (a int); > +insert into t1 values (20), (30), (10); > +create view v1 as select * from t1 where a > 10; > + > +with t1 as (select * from v1) select * from t1; > + > +drop view v1; > +drop table t1; > diff --git a/sql/sql_cte.cc b/sql/sql_cte.cc > index 1203a4c..77f0bcf 100644 > --- a/sql/sql_cte.cc > +++ b/sql/sql_cte.cc > @@ -512,7 +512,10 @@ bool With_element::prepare_unreferenced(THD *thd) > { > With_clause *with_clause=sl->get_with_clause(); > if (with_clause && (found= with_clause->find_table_def(table))) > - return found; > + return found; > + /* Do not look for the table's definition beyond the scope of the view */ > + if (sl->master_unit()->is_view) > + break; > } > return found; > } > diff --git a/sql/sql_lex.cc b/sql/sql_lex.cc > index 6056b03..de345b4 100644 > --- a/sql/sql_lex.cc > +++ b/sql/sql_lex.cc > @@ -2078,6 +2078,7 @@ void st_select_lex_unit::init_query() > found_rows_for_union= 0; > insert_table_with_stored_vcol= 0; > derived= 0; > + is_view= false; > with_clause= 0; > with_element= 0; > columns_are_renamed= false; > diff --git a/sql/sql_lex.h b/sql/sql_lex.h > index 0b4f0da..10247bd 100644 > --- a/sql/sql_lex.h > +++ b/sql/sql_lex.h > @@ -645,6 +645,7 @@ class st_select_lex_unit: public st_select_lex_node { > derived tables/views handling. > */ > TABLE_LIST *derived; > + bool is_view; > /* With clause attached to this unit (if any) */ > With_clause *with_clause; > /* With element where this unit is used as the specification (if any) */ > diff --git a/sql/sql_view.cc b/sql/sql_view.cc > index 41fd5b7..b66f678 100644 > --- a/sql/sql_view.cc > +++ b/sql/sql_view.cc > @@ -1612,6 +1612,8 @@ bool mysql_make_view(THD *thd, TABLE_SHARE *share, TABLE_LIST *table, > sl->context.error_processor_data= (void *)table; > } > > + table->select_lex->master_unit()->is_view= true; > + > /* > check MERGE algorithm ability > - algorithm is not explicit TEMPORARY TABLE > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits

1 0

[Maria-developers] MDEV-9745 Crash with CASE WHEN TRUE THEN COALESCE(CAST(NULL AS UNSIGNED)) ELSE 4 END
by Alexander Barkov 19 Apr '16

19 Apr '16

Hello Sergei, please review a patch for MDEV-9745. This is actually a backport of MDEV-9653 from 10.1 to 5.5. Thanks.

2 1

Re: [Maria-developers] 21265d5: MDEV-9943 - TokuDB fails to compile with gcc 5.2.1
by Sergei Golubchik 19 Apr '16

19 Apr '16

Hi, Sergey! On Apr 19, Sergey Vojtovich wrote: > revision-id: 21265d58c1ea65f5c21a56cf669321f39066d7b5 (mariadb-5.5.48-19-g21265d5) > parent(s): 6c0e231c0282b43d6a46a4983f5971e960d3b8ca > committer: Sergey Vojtovich > timestamp: 2016-04-19 16:16:13 +0400 > message: > > MDEV-9943 - TokuDB fails to compile with gcc 5.2.1 > > For some reason check_cxx_compiler_flag() passes result variable name down to > compiler: > https://github.com/Kitware/CMake/blob/master/Modules/CheckCXXSourceCompiles… > > But compiler doesn't permit dashes in macro name, like in > -DHAVE_CXX_-fimplicit-templates. > > Workarounded by renaming HAVE_CXX_-fimplicit-templates to > HAVE_CXX_IMPLICIT_TEMPLAES. > > diff --git a/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake b/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake > index 99629e4..4ae7b63 100644 > --- a/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake > +++ b/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake > @@ -103,8 +103,8 @@ set_cflags_if_supported( > > if (CMAKE_CXX_FLAGS MATCHES -fno-implicit-templates) > # must append this because mysql sets -fno-implicit-templates and we need to override it > - check_cxx_compiler_flag(-fimplicit-templates HAVE_CXX_-fimplicit-templates) > - if (HAVE_CXX_-fimplicit-templates) > + check_cxx_compiler_flag(-fimplicit-templates HAVE_CXX_IMPLICIT_TEMPLATES) > + if (HAVE_CXX_IMPLICIT_TEMPLATES) > set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fimplicit-templates") > endif () > endif() I'd rather fix other similar places too. If you agree, ok to push with the patch below. --- a/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake +++ b/storage/tokudb/ft-index/cmake_modules/TokuSetupCompiler.cmake @@ -61,12 +61,13 @@ endmacro(set_cflags_if_supported_named) ## adds a compiler flag if the compiler supports it macro(set_cflags_if_supported) foreach(flag ${ARGN}) - check_c_compiler_flag(${flag} HAVE_C_${flag}) - if (HAVE_C_${flag}) + STRING(REGEX REPLACE "[-,= ]" "_" res ${flag}) + check_c_compiler_flag(${flag} HAVE_C_${res}) + if (HAVE_C_${res}) set(CMAKE_C_FLAGS "${flag} ${CMAKE_C_FLAGS}") endif () - check_cxx_compiler_flag(${flag} HAVE_CXX_${flag}) - if (HAVE_CXX_${flag}) + check_cxx_compiler_flag(${flag} HAVE_CXX_${res}) + if (HAVE_CXX_${res}) set(CMAKE_CXX_FLAGS "${flag} ${CMAKE_CXX_FLAGS}") endif () endforeach(flag) @@ -75,8 +76,9 @@ endmacro(set_cflags_if_supported) ## adds a linker flag if the compiler supports it macro(set_ldflags_if_supported) foreach(flag ${ARGN}) - check_cxx_compiler_flag(${flag} HAVE_${flag}) - if (HAVE_${flag}) + STRING(REGEX REPLACE "[-,= ]" "_" res ${flag}) + check_cxx_compiler_flag(${flag} HAVE_${res}) + if (HAVE_${res}) set(CMAKE_EXE_LINKER_FLAGS "${flag} ${CMAKE_EXE_LINKER_FLAGS}") set(CMAKE_SHARED_LINKER_FLAGS "${flag} ${CMAKE_SHARED_LINKER_FLAGS}") endif () Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

2 1

Re: [Maria-developers] 6c0e231: MDEV-9945 - main.kill_processlist-6619 fails sporadically
by Sergei Golubchik 19 Apr '16

19 Apr '16

Hi, Sergey! On Apr 19, Sergey Vojtovich wrote: > revision-id: 6c0e231c0282b43d6a46a4983f5971e960d3b8ca (mariadb-5.5.48-18-g6c0e231) > parent(s): 18ff6f654b1ca595fc5c0eebddbc1d0c5ee0d09e > committer: Sergey Vojtovich > timestamp: 2016-04-19 14:05:52 +0400 > message: > > MDEV-9945 - main.kill_processlist-6619 fails sporadically > > SHOW PROCESSLIST output can be affected by not completed concurrent queries. > Removed this affected SHOW PROCESSLIST since it doesn't seem to affect original > problem. ok to push Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

1 0