- developers - lists.mariadb.org

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (knielsen:2791)
by knielsen＠knielsen-hq.org 23 Oct '09

23 Oct '09

#At lp:maria 2791 knielsen(a)knielsen-hq.org 2009-10-23 [merge] Merge Peter Lieverdink's fixes: - configtest target in rc script. - type fix usefull -> useful. modified: Docs/myisam.txt configure.in mysql-test/mysql-stress-test.pl mysys/safemalloc.c sql/mysqld.cc sql/sql_select.cc sql/udf_example.c support-files/mysql.server.sh === modified file 'Docs/myisam.txt' --- a/Docs/myisam.txt 2000-07-31 19:29:14 +0000 +++ b/Docs/myisam.txt 2009-09-30 23:40:51 +0000 @@ -868,7 +868,7 @@ Space compression makes the index file s Prefix compression helps if there are many strings with an identical prefix. In memory table characteristics -HEAP tables only exists in memory so they are lost if `mysqld' is taken down or crashes. But since they are *very* fast they are usefull as anyway. +HEAP tables only exists in memory so they are lost if `mysqld' is taken down or crashes. But since they are *very* fast they are useful as anyway. The *MySQL* internal HEAP tables uses 100% dynamic hashing without overflow areas and don't have problems with delete. === modified file 'configure.in' --- a/configure.in 2009-10-08 09:43:31 +0000 +++ b/configure.in 2009-10-16 06:18:37 +0000 @@ -2847,7 +2847,7 @@ do done AC_SUBST(sql_union_dirs) -# Some usefull subst +# Some useful subst AC_SUBST(CC) AC_SUBST(GXX) === modified file 'mysql-test/mysql-stress-test.pl' --- a/mysql-test/mysql-stress-test.pl 2006-03-03 18:15:01 +0000 +++ b/mysql-test/mysql-stress-test.pl 2009-09-30 23:40:51 +0000 @@ -1100,7 +1100,7 @@ mysql-stress-test.pl --stress-basedir=<d they specified in the list file. --sleep-time=<time in seconds> - Delay between test execution. Could be usefull in continued testsing + Delay between test execution. Could be useful in continued testsing when one of instance of stress script perform periodical cleanup or recreating of some database objects @@ -1109,7 +1109,7 @@ mysql-stress-test.pl --stress-basedir=<d --check-tests-file Check file with list of tests. If file was modified it will force to - reread list of tests. Could be usefull in continued testing for + reread list of tests. Could be useful in continued testing for adding/removing tests without script interruption --mysqltest=/path/to/mysqltest binary === modified file 'mysys/safemalloc.c' --- a/mysys/safemalloc.c 2009-09-07 20:50:10 +0000 +++ b/mysys/safemalloc.c 2009-09-30 23:40:51 +0000 @@ -436,7 +436,7 @@ void TERMINATE(FILE *file, uint flag) /* Report where a piece of memory was allocated - This is usefull to call from withing a debugger + This is useful to call from withing a debugger */ void sf_malloc_report_allocated(void *memory) === modified file 'sql/mysqld.cc' --- a/sql/mysqld.cc 2009-10-16 15:44:58 +0000 +++ b/sql/mysqld.cc 2009-10-23 11:43:17 +0000 @@ -6630,7 +6630,7 @@ log and this option does nothing anymore 0, 0, 0, 0, 0}, {"test-ignore-wrong-options", OPT_TEST_IGNORE_WRONG_OPTIONS, - "Ignore wrong enums values in command line arguments. Usefull only for test scripts", + "Ignore wrong enums values in command line arguments. Useful only for test scripts", (uchar**) &opt_ignore_wrong_options, (uchar**) &opt_ignore_wrong_options, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0}, {"timed_mutexes", OPT_TIMED_MUTEXES, === modified file 'sql/sql_select.cc' --- a/sql/sql_select.cc 2009-09-15 10:46:35 +0000 +++ b/sql/sql_select.cc 2009-09-30 23:40:51 +0000 @@ -11812,7 +11812,7 @@ join_read_const_table(JOIN_TAB *tab, POS { #if !defined(DBUG_OFF) && defined(NOT_USING_ITEM_EQUAL) /* - This test could be very usefull to find bugs in the optimizer + This test could be very useful to find bugs in the optimizer where we would call this function with an expression that can't be evaluated yet. We can't have this enabled by default as long as have items like Item_equal, that doesn't report they are const but === modified file 'sql/udf_example.c' --- a/sql/udf_example.c 2009-04-25 10:05:32 +0000 +++ b/sql/udf_example.c 2009-09-30 23:40:51 +0000 @@ -205,7 +205,7 @@ char *is_const(UDF_INIT *initid, UDF_ARG ** try to keep the error message less than 80 bytes long! ** ** This function should return 1 if something goes wrong. In this case -** message should contain something usefull! +** message should contain something useful! **************************************************************************/ #define MAXMETAPH 8 === modified file 'support-files/mysql.server.sh' --- a/support-files/mysql.server.sh 2009-07-02 13:18:12 +0000 +++ b/support-files/mysql.server.sh 2009-10-16 06:15:30 +0000 @@ -434,9 +434,36 @@ case "$mode" in fi fi ;; - *) + 'configtest') + # Safeguard (relative paths, core dumps..) + cd $basedir + echo $echo_n "Testing MySQL configuration syntax" + daemon=$bindir/mysqld + if test -x $libexecdir/mysqld + then + daemon=$libexecdir/mysqld + elif test -x $sbindir/mysqld + then + daemon=$sbindir/mysqld + elif test -x `which mysqld` + then + daemon=`which mysqld` + else + log_failure_msg "Unable to locate the mysqld binary!" + exit 1 + fi + help_out=`$daemon --help 2>&1`; r=$? + if test "$r" != 0 ; then + log_failure_msg "$help_out" + log_failure_msg "There are syntax errors in the server configuration. Please fix them!" + else + log_success_msg "Syntax OK" + fi + exit $r + ;; + *) # usage - echo "Usage: $0 {start|stop|restart|reload|force-reload|status} [ MySQL server options ]" + echo "Usage: $0 {start|stop|restart|reload|force-reload|status|configtest} [ MySQL server options ]" exit 1 ;; esac

1 0

[Maria-developers] bzr commit into Mariadb 5.2, with Maria 2.0:maria/5.2 branch (monty:2727)
by Michael Widenius 23 Oct '09

23 Oct '09

#At lp:maria/5.2 based on revid:monty@askmonty.org-20091019171448-rkr7tyitt2m544h9 2727 Michael Widenius 2009-10-23 Fixed version number modified: configure.in === modified file 'configure.in' --- a/configure.in 2009-10-19 17:14:48 +0000 +++ b/configure.in 2009-10-23 07:54:38 +0000 @@ -15,7 +15,7 @@ AC_CANONICAL_SYSTEM # MySQL version number. # # Note: the following line must be parseable by win/configure.js:GetVersion() -AM_INIT_AUTOMAKE(mysql, 5.1.38-maria-beta) +AM_INIT_AUTOMAKE(mysql, 5.2.0-alpha) AM_CONFIG_HEADER([include/config.h:config.h.in]) PROTOCOL_VERSION=10

1 0

[Maria-developers] Updated (by Monty): Improve the show statistics (60)
by worklog-noreply＠askmonty.org 22 Oct '09

22 Oct '09

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Improve the show statistics CREATION DATE..: Thu, 22 Oct 2009, 17:42 SUPERVISOR.....: Monty IMPLEMENTOR....: Bothorsen COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 60 (http://askmonty.org/worklog/?tid=60) VERSION........: WorkLog-3.4 STATUS.........: Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: -=-=(Monty - Thu, 22 Oct 2009, 18:38)=-=- High Level Description modified. --- /tmp/wklog.60.old.17258 2009-10-22 15:38:47.000000000 +0000 +++ /tmp/wklog.60.new.17258 2009-10-22 15:38:47.000000000 +0000 @@ -1,12 +1,17 @@ In the MariaDB 5.2 branch, some new parts to show statistics have been added. Monty wants these to be improved upon. -1) Change "show table_statistics" to "show table statistics" +1) +Change "show [table|index|user|client]_statistics" to +"show [table|index|user|client] statistics" -2) Add a "flush statistics" that flushes all statistics to the current "flush -table statistics" +Do the same change to the flush command -3) Add where and like clauses to show statistics. +2) +Add a "flush statistics" as a synonym for +flush table_statistics, index statistics..." + +3) Add where and like clauses to show XXXX_statistics. (only like: match most important column) This will be done as a patch to the 5.2 tree. DESCRIPTION: In the MariaDB 5.2 branch, some new parts to show statistics have been added. Monty wants these to be improved upon. 1) Change "show [table|index|user|client]_statistics" to "show [table|index|user|client] statistics" Do the same change to the flush command 2) Add a "flush statistics" as a synonym for flush table_statistics, index statistics..." 3) Add where and like clauses to show XXXX_statistics. (only like: match most important column) This will be done as a patch to the 5.2 tree. Interesting files for this patch are: sql_show.cc, sql_yacc.yy and lex.h. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] Updated (by Monty): Improve the show statistics (60)
by worklog-noreply＠askmonty.org 22 Oct '09

22 Oct '09

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Improve the show statistics CREATION DATE..: Thu, 22 Oct 2009, 17:42 SUPERVISOR.....: Monty IMPLEMENTOR....: Bothorsen COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 60 (http://askmonty.org/worklog/?tid=60) VERSION........: WorkLog-3.4 STATUS.........: Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: -=-=(Monty - Thu, 22 Oct 2009, 18:38)=-=- High Level Description modified. --- /tmp/wklog.60.old.17258 2009-10-22 15:38:47.000000000 +0000 +++ /tmp/wklog.60.new.17258 2009-10-22 15:38:47.000000000 +0000 @@ -1,12 +1,17 @@ In the MariaDB 5.2 branch, some new parts to show statistics have been added. Monty wants these to be improved upon. -1) Change "show table_statistics" to "show table statistics" +1) +Change "show [table|index|user|client]_statistics" to +"show [table|index|user|client] statistics" -2) Add a "flush statistics" that flushes all statistics to the current "flush -table statistics" +Do the same change to the flush command -3) Add where and like clauses to show statistics. +2) +Add a "flush statistics" as a synonym for +flush table_statistics, index statistics..." + +3) Add where and like clauses to show XXXX_statistics. (only like: match most important column) This will be done as a patch to the 5.2 tree. DESCRIPTION: In the MariaDB 5.2 branch, some new parts to show statistics have been added. Monty wants these to be improved upon. 1) Change "show [table|index|user|client]_statistics" to "show [table|index|user|client] statistics" Do the same change to the flush command 2) Add a "flush statistics" as a synonym for flush table_statistics, index statistics..." 3) Add where and like clauses to show XXXX_statistics. (only like: match most important column) This will be done as a patch to the 5.2 tree. Interesting files for this patch are: sql_show.cc, sql_yacc.yy and lex.h. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] New (by Bothorsen): Improve the show statistics (60)
by worklog-noreply＠askmonty.org 22 Oct '09

22 Oct '09

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Improve the show statistics CREATION DATE..: Thu, 22 Oct 2009, 17:42 SUPERVISOR.....: Monty IMPLEMENTOR....: Bothorsen COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 60 (http://askmonty.org/worklog/?tid=60) VERSION........: WorkLog-3.4 STATUS.........: Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: In the MariaDB 5.2 branch, some new parts to show statistics have been added. Monty wants these to be improved upon. 1) Change "show table_statistics" to "show table statistics" 2) Add a "flush statistics" that flushes all statistics to the current "flush table statistics" 3) Add where and like clauses to show statistics. (only like: match most important column) This will be done as a patch to the 5.2 tree. Interesting files for this patch are: sql_show.cc, sql_yacc.yy and lex.h. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] New (by Bothorsen): Improve the show statistics (60)
by worklog-noreply＠askmonty.org 22 Oct '09

22 Oct '09

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Improve the show statistics CREATION DATE..: Thu, 22 Oct 2009, 17:42 SUPERVISOR.....: Monty IMPLEMENTOR....: Bothorsen COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 60 (http://askmonty.org/worklog/?tid=60) VERSION........: WorkLog-3.4 STATUS.........: Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: In the MariaDB 5.2 branch, some new parts to show statistics have been added. Monty wants these to be improved upon. 1) Change "show table_statistics" to "show table statistics" 2) Add a "flush statistics" that flushes all statistics to the current "flush table statistics" 3) Add where and like clauses to show statistics. (only like: match most important column) This will be done as a patch to the 5.2 tree. Interesting files for this patch are: sql_show.cc, sql_yacc.yy and lex.h. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] New (by Bothorsen): Provide an " ORDER BY FIRST_JOIN.column" feature (59)
by worklog-noreply＠askmonty.org 22 Oct '09

22 Oct '09

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Provide an "ORDER BY FIRST_JOIN.column" feature CREATION DATE..: Thu, 22 Oct 2009, 12:33 SUPERVISOR.....: Bothorsen IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 59 (http://askmonty.org/worklog/?tid=59) VERSION........: WorkLog-3.4 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Question: How much effort would be required to provide an "ORDER BY FIRST_JOIN.column" feature? We often do self-join queries and want to order them by index, i.e.: create table t1 (a int, b int, unique key 'by_a_b' (a, b))); select * from t1 x inner join t1 y on (x.b = y.b) where x.a=1 and y.a=2 order by (x|y).b desc limit 10; but it is only ordered by index if you order by the first table in the optimized join order, which could be either x or y depending on which is more selective. we don't want to force the join order because often one is far more selective than the other, but the only way to know what table to order by then is to explain the query first. if there was some way to tell mysql to just order by the first join in the optimized order, that would help us. sometimes we do this across tables too. both of these can be solved by rewriting the query to say "using" instead of "on" in which case we don't have to specify the table name of the column, just "order by b desc". but, we also want to be able to do exclusions, in which case an "on" is required and therefore we run into ambiguous column names: Monty answered: MySQL has an optimization where it knows that if x.b = y.b is used then it can replace x.b with y.b and y.b with x.b in the WHERE part MySQL however doesn't do it for the ORDER BY part and I don't think that should be very hard to do. Question continues: create table t2 (c int, b int, unique key 'by_c_b' (c, b))); select * from t1 x inner join t1 y using (b) left join t2 on (t2.c = 3 and t1.b = t2.b) where x.a=1 and y.a=2 and t2.c is null order by (x| y).b desc limit 10; if we were ordering ascending, i think we could just leave off the order by entirely in this case and it would happen to work since it's reading in index order. but the combination of requiring an "on" and descending sort leaves us unable to use these tricks. if we had either an "ORDER BY FIRST_JOIN.column" or some way to tell the server that 'b' is in fact joined as being equivalent across tables (except where it may be null from left joining) and that we shouldn't have to specify the table name at all, that would save us having to figure out the table from the explain. Monty answers: It may be that the eq-replacment we have would solve this. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] New (by Bothorsen): Implement a new modifier for flush table (57)
by worklog-noreply＠askmonty.org 22 Oct '09

22 Oct '09

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Implement a new modifier for flush table CREATION DATE..: Thu, 22 Oct 2009, 12:25 SUPERVISOR.....: Bothorsen IMPLEMENTOR....: COPIES TO......: Bothorsen CATEGORY.......: Server-RawIdeaBin TASK ID........: 57 (http://askmonty.org/worklog/?tid=57) VERSION........: WorkLog-3.4 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Create a patch to implement a modifier for "flush table" that allows you to only flush a limited number of blocks. One of the difficulties we have is that we would like to persist some things to disk, but flushing an entire table worth of delay_key_write'd indexes takes minutes, during which time the server is so I/O bound that it cannot serve read traffic. If it was possible to spread this flush over time, we would be able to actually do it without removing the server from read production beforehand. Monty answered this question in an email: The right way to do this is probably to add a background thread that flushes blocks in a 'slow' manner. Note that in the Maria storage engine we do already have this, but I wouldn't recommend you to use this yet; This is more a note about what to expect in the future.. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v3.5.9)

1 0

[Maria-developers] bzr commit into MariaDB 5.1, with Maria 1.5:maria branch (monty:2790)
by Michael Widenius 21 Oct '09

21 Oct '09

#At lp:maria based on revid:psergey@askmonty.org-20091016154458-g89p8v46silum9v7 2790 Michael Widenius 2009-10-21 Updated make_binary_distribution for MariaDB - Changed tar file base name - Added binaries needed by the Maria storage engine modified: scripts/make_binary_distribution.sh === modified file 'scripts/make_binary_distribution.sh' --- a/scripts/make_binary_distribution.sh 2009-09-07 20:50:10 +0000 +++ b/scripts/make_binary_distribution.sh 2009-10-20 23:32:21 +0000 @@ -171,9 +171,9 @@ case $VERSION_NAME in *-ndb-* ) VERSION_NAME=`echo $VERSION_NAME | sed -e 's/[.0-9]*-ndb-//'` ;; esac if [ x"$SHORT_PRODUCT_TAG" != x"" ] ; then - NEW_NAME=mysql-$SHORT_PRODUCT_TAG-$VERSION_NAME-$PLATFORM$SUFFIX + NEW_NAME=mariadb-$SHORT_PRODUCT_TAG-$VERSION_NAME-$PLATFORM$SUFFIX else - NEW_NAME=mysql@MYSQL_SERVER_SUFFIX@-$VERSION_NAME-$PLATFORM$SUFFIX + NEW_NAME=mariadb@MYSQL_SERVER_SUFFIX@-$VERSION_NAME-$PLATFORM$SUFFIX fi # ---------------------------------------------------------------------- @@ -389,6 +389,9 @@ BIN_FILES="extra/comp_err$BS extra/repla extra/resolve_stack_dump$BS extra/mysql_waitpid$BS \ storage/myisam/myisamchk$BS storage/myisam/myisampack$BS \ storage/myisam/myisamlog$BS storage/myisam/myisam_ftdump$BS \ + storage/maria/maria_chk$BS storage/maria/maria_pack$BS \ + storage/maria/maria_ftdump$BS storage/maria/maria_read_log$BS \ + storage/maria/maria_dump_log$BS \ sql/mysqld$BS sql/mysqld-debug$BS \ sql/mysql_tzinfo_to_sql$BS \ server-tools/instance-manager/mysqlmanager$BS \

1 0

[Maria-developers] Windows installer, part 2
by Sergey Petrunya 20 Oct '09

20 Oct '09

Hi! Thanks everyone for input on the input so far! I believe I've collected it all and put into the WL entry: http://askmonty.org/worklog/Server-RawIdeaBin/?tid=55 * If there is something missing there, please bring that argument up again. * Final call for objections/comments on Step#1. Please voice them now, otherwise what is described in step #1 may end up implemented. BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

4 10