- developers - lists.mariadb.org

Re: [Maria-developers] [Commits] 135d926d3: MDEV-6714 mysqldump slow with tables in big databases
by Sergei Golubchik 02 Apr '15

02 Apr '15

Hi, Vicentiu! Just one minor change, see the comment in get_actual_table_name(). After that please push. Well done, thanks! Regards, Sergei On Mar 19, vicentiu(a)mariadb.org wrote: > revision-id: 135d926d347443672626f1e655709fd5bf6dec80 > parent(s): 197afb413fcc9f06b5e5e6ef41ce980d108b354f > committer: Vicențiu Ciorbaru > branch nick: server > timestamp: 2015-03-19 15:16:22 +0200 > message: > > MDEV-6714 mysqldump slow with tables in big databases > > mysqldump now attempts to make use of the INFORMATION_SCHEMA tables. > If the table name is not found with a case sensitive search, it > fallbacks to a case insensitive search. > > --- > client/mysqldump.c | 90 ++++++++++++++++++++++++++++++++++++++++++------------ > 1 file changed, 71 insertions(+), 19 deletions(-) > > diff --git a/client/mysqldump.c b/client/mysqldump.c > index 2da4ce6..c265217 100644 > --- a/client/mysqldump.c > +++ b/client/mysqldump.c > @@ -3341,8 +3341,10 @@ static int dump_triggers_for_table(char *table_name, char *db_name) > /* Get list of triggers. */ > > my_snprintf(query_buff, sizeof(query_buff), > - "SHOW TRIGGERS LIKE %s", > - quote_for_like(table_name, name_buff)); > + "SELECT TRIGGER_NAME FROM INFORMATION_SCHEMA.TRIGGERS " > + "WHERE EVENT_OBJECT_SCHEMA = DATABASE() AND " > + "EVENT_OBJECT_TABLE = \"%s\"", > + table_name); You still need to quote table_name, it might contain a double quote inside. quote_names() almost does what you need, but you don't need a check for MASK_ANSI_QUOTES. So you might either create a quote_names_helper, again, or simply create a new function for this, it's just a few lines anyway. UPD: There are other similar places in mysqldump where it doesn't quote table names, e.g. in get_table_structure(), for show_fields_stmt query. So, please create a separate bug report for this and then it'll fix everything at once. > if (mysql_query_with_error_report(mysql, &show_triggers_rs, query_buff)) > goto done; > @@ -4695,29 +4697,37 @@ static my_bool dump_all_views_in_db(char *database) > > > /* > - get_actual_table_name -- executes a SHOW TABLES LIKE '%s' to get the actual > - table name from the server for the table name given on the command line. > - we do this because the table name given on the command line may be a > - different case (e.g. T1 vs t1) > - > - RETURN > - pointer to the table name > - 0 if error > + See get_actual_table_name. Used to retrieve the correct table name > + from the database schema. > */ > - > -static char *get_actual_table_name(const char *old_table_name, MEM_ROOT *root) > +static char *get_actual_table_name_helper(const char *old_table_name, > + my_bool case_sensitive, > + MEM_ROOT *root) > { > char *name= 0; > MYSQL_RES *table_res; > MYSQL_ROW row; > char query[50 + 2*NAME_LEN]; > char show_name_buff[FN_REFLEN]; > - DBUG_ENTER("get_actual_table_name"); > + DBUG_ENTER("get_actual_table_name_helper"); > > /* Check memory for quote_for_like() */ > DBUG_ASSERT(2*sizeof(old_table_name) < sizeof(show_name_buff)); > - my_snprintf(query, sizeof(query), "SHOW TABLES LIKE %s", > - quote_for_like(old_table_name, show_name_buff)); > + > + if (case_sensitive) > + { > + DBUG_PRINT("info", ("case sensitive search")); > + my_snprintf(query, sizeof(query), > + "SELECT table_name FROM INFORMATION_SCHEMA.TABLES " > + "WHERE table_schema = DATABASE() AND table_name = \"%s\"", > + old_table_name); > + } > + else > + { > + DBUG_PRINT("info", ("case insensitive search")); > + my_snprintf(query, sizeof(query), "SHOW TABLES LIKE %s", > + quote_for_like(old_table_name, show_name_buff)); > + } > > if (mysql_query_with_error_report(mysql, 0, query)) > return NullS; > @@ -4742,6 +4752,46 @@ static char *get_actual_table_name(const char *old_table_name, MEM_ROOT *root) > DBUG_RETURN(name); > } > > +/* > + get_actual_table_name -- executes a SELECT .. FROM I_S.tables to check > + if the table name given on the command line matches the one in the database. > + If the table is not found, it falls back to a slower SHOW TABLES LIKE '%s' to > + get the actual table name from the server. > + > + We do this because the table name given on the command line may be a > + different case (e.g. T1 vs t1), but checking this takes a long time > + when there are many tables present. > + > + RETURN > + pointer to the table name > + 0 if error > +*/ > + > +static char *get_actual_table_name(const char *old_table_name, MEM_ROOT *root) > +{ > + char *name= 0; > + MYSQL_RES *table_res; > + MYSQL_ROW row; > + int lower_case_table_names; > + const char *show_var_query = "SHOW VARIABLES LIKE 'lower_case_table_names'"; > + DBUG_ENTER("get_actual_table_name"); > + > + if (mysql_query_with_error_report(mysql, &table_res, show_var_query)) > + return NullS; I'd prefer if you do it only once, not for every get_actual_table_name() call. > + > + if ((row= mysql_fetch_row(table_res))) > + { > + lower_case_table_names= atoi(row[1]); > + mysql_free_result(table_res); > + } > + > + name= get_actual_table_name_helper(old_table_name, TRUE, root); > + if (!name && !lower_case_table_names) > + name= get_actual_table_name_helper(old_table_name, FALSE, root); > + DBUG_RETURN(name); > +} > + > + > > static int dump_selected_tables(char *db, char **table_names, int tables) > {

1 0

[Maria-developers] Problem of accessing pfs table in maria version 10.1.3
by 김경남 01 Apr '15

01 Apr '15

Hi, I'm developing monitoring tool in daemon plugin I'm tyring to access pfs table via low level interface not using sql. (see below) ------------------------------------------------------------------------ ------------- ..... tables.init_one_table(STRING_WITH_LEN("performance_schema"), STRING_WITH_LEN("events_statements_current"), "events_statements_current", TL_READ); bool result = open_and_lock_tables(ctx->thd, &tables, FALSE, MYSQL_LOCK_IGNORE_TIMEOUT); if (result) { sql_print_error("monm plugin error: Can't open the %s.%s table.",dbname,tblname); } ..... /* read routine */ ------------------------------------------------------------ In open_and_lock_table function, I hava a error. I found the reason of this error by debugging. In table_cache.cc, open_table_def() requires .frm file as a table definition. but above version 10.1.3, there is no frm file for pfs table as I know. right? Let me know a correct way to get data from pfs table not using sql. Regards, Kyungnam. _____ 상기 메시지와 첨부화일 내에는 비밀정보가 포함되어 있을 수 있으며, 지정된 수신자에 한하여 조회 및 사용될 수 있습니다. 만약 송신자의 실수로 인하여 상기 메시지를 수신하였다면, 송신자에게 메시지를 반송해 주시고, 원본 메시지와 모든 사본을 폐기해 주시기 바랍니다. 상기 메시지의 전체 또는 일부에 대해 무단 열람, 사용, 공개, 배포하는 것은 금지되어 있습니다.(주)LG CNS. This message and its attachments may contain confidential information, and they are intended to be viewed or used by only the individuals specified in the message. If you have received this message in an error from the sender, please contact the sender immediately to notify the error and delete all of the message and its copies. It is prohibited to view, use, make public and/or distribute part or whole of this message without written permission.

1 0

[Maria-developers] Using THD instance in a daemon thread.
by 김경남 31 Mar '15

31 Mar '15

Hi, I'm writing mariadb daemon type plugin. I hava a question. In a daemon thread, I want to use THD instance. for example, ------------------------------------------------------------------------ ----------- class THD; static int plugin_init() { ... pthread_create(&id,&attr,my_func,...); } void my_func(void* p) { THD* thd = new THD; thd->thread_stack= (char*) &thd; thd->store_globals(); tables.init_one_table("performance_schema", 18, "events_statements_current", 25, "events_statements_current", TL_READ); open_and_lock_tables(thd, &tables, FALSE, MYSQL_LOCK_IGNORE_TIMEOUT); ... } ------------------------------------------------------------------------ -------------------- but In my_func(), new THD cause error. I guess thread problem. So I moved that code to plugin_init() for test as below -------------------------------------------------------------- class THD; static int plugin_init() { ... pthread_create(&id,&attr,my_func,...); THD* thd = new THD; thd->thread_stack= (char*) &thd; thd->store_globals(); tables.init_one_table("performance_schema", 18, "events_statements_current", 25, "events_statements_current", TL_READ); open_and_lock_tables(thd, &tables, FALSE, MYSQL_LOCK_IGNORE_TIMEOUT); ... } ------------------------------------------------------------------------ ----- and then there is no problem. but I need a daemon thread. I think that the reason of this error is assertion of thread. So I changed my code as below. ------------------------------------------------------------------------ --------- class THD; THD* thd; static int plugin_init() { ... pthread_create(&id,&attr,my_func,...); THD* thd = new THD; // moved here from my_func() for avoiding error. } void my_func(void* p) { thd->thread_stack= (char*) &thd; thd->store_globals(); tables.init_one_table("performance_schema", 18, "events_statements_current", 25, "events_statements_current", TL_READ); open_and_lock_tables(thd, &tables, FALSE, MYSQL_LOCK_IGNORE_TIMEOUT); ... } ------------------------------------------------------------------------ ----------------- At this time, thd->store_globals() cause error. In sql_class.cc , mysys_var->id= thread_id cause error because mysys_var is null. Let me know how to use THD instance in daemon thread. Regards, Kyungnam 김경남 부책임연구원 솔루션사업본부 정보기술 연구원 신기술개발팀 02-2099-6177 / 010-2208-3006 _____ 상기 메시지와 첨부화일 내에는 비밀정보가 포함되어 있을 수 있으며, 지정된 수신자에 한하여 조회 및 사용될 수 있습니다. 만약 송신자의 실수로 인하여 상기 메시지를 수신하였다면, 송신자에게 메시지를 반송해 주시고, 원본 메시지와 모든 사본을 폐기해 주시기 바랍니다. 상기 메시지의 전체 또는 일부에 대해 무단 열람, 사용, 공개, 배포하는 것은 금지되어 있습니다.(주)LG CNS. This message and its attachments may contain confidential information, and they are intended to be viewed or used by only the individuals specified in the message. If you have received this message in an error from the sender, please contact the sender immediately to notify the error and delete all of the message and its copies. It is prohibited to view, use, make public and/or distribute part or whole of this message without written permission.

2 1

[Maria-developers] ok to change FixVersion to 10.1 for MDEV-7649 wrong result when comparing utf8 column with an invalid literal
by Alexander Barkov 31 Mar '15

31 Mar '15

Hi Sergei, Do you think it's ok to change FixVersion for MDEV-7649 to 10.1? It requires some changes in sql_lex.cc, sql_yacc.yy and needs a new Item_string-alike Item to handle such malformed strings properly. Too big change to 10.0 or 5.5.

2 1

[Maria-developers] TokuDB test suite failures when building at Launchpad
by Otto Kekäläinen 29 Mar '15

29 Mar '15

Hello! Are here any TokuDB devs who could help me debug why TokuDB does repeatedly fails to pass build suite tests when built on Launchpad.net? I repeatedly get these test failures when running MariaDB builds on Launchpad: rpl-tokudb.tokudb_innodb_xa_crash tokudb_bugs.mdev4533 tokudb.simple_join_tokudb_innodb tokudb.truncate_txn_rollback_innodb tokudb_bugs.5733_innodb The build run log can be viewed at https://launchpad.net/~mysql-ubuntu/+archive/ubuntu/mariadb-10.0/+builds?bu… and it links to the individual build logs. All amd64 builds fail while all i386 (where TokuDB is disabled) pass OK. Sounds very much like a TokuDB-related issue. Or could the problem be something else and the TokuDB tests are just the first victim? Example of a recent log: https://launchpadlibrarian.net/196425361/buildlog_ubuntu-vivid-amd64.mariad… One example of the test outputs: *** rpl-tokudb.tokudb_innodb_xa_crash 'mix,xtradb' [ fail ] Test ended at 2015-02-02 22:29:06 CURRENT_TEST: rpl-tokudb.tokudb_innodb_xa_crash Failed to start mysqld.1 mysqltest failed but provided no output - saving '/build/buildd/mariadb-10.0-10.0.16/builddir/mysql-test/var/log/rpl-tokudb.tokudb_innodb_xa_crash-mix,xtradb/' to '/build/buildd/mariadb-10.0-10.0.16/builddir/mysql-test/var/log/rpl-tokudb.tokudb_innodb_xa_crash-mix,xtradb/' - found 'core' (1/5) Trying 'dbx' to get a backtrace Trying 'gdb' to get a backtrace Compressed file /build/buildd/mariadb-10.0-10.0.16/builddir/mysql-test/var/log/rpl-tokudb.tokudb_innodb_xa_crash-mix,xtradb/mysqld.1/data/core ***Warnings generated in error logs during shutdown after running tests: rpl-tokudb.tokudb_innodb_xa_crash 150202 22:29:05 [ERROR] mysqld got signal 11 ; Attempting backtrace. You can use the following information to find out 150202 22:29:05 [ERROR] mysqld got signal 11 ; Attempting backtrace. You can use the following information to find out ***

4 15

[Maria-developers] GSoC Proposal Submitted.
by arlene seuleu 28 Mar '15

28 Mar '15

Hello everyone, I am Arlene Flavie, currently a Sofeware Engineering student and I have submitted a proposal for the CONC-125 task: "Imporrt and Export popular data formats from and to dynamic columns". I had been in contact with the mentor and other mariadb developpers(serg, danblack) whose help was immense in writing my proposal. However I am still available to discuss it here and on #maria as Arlene. Hoping to get feedback from the community soon. Best Regards Arlene Flavie

1 0

[Maria-developers] MySQL 5.7.6 adds "statement digest" independent of P_S
by Peter Laursen 27 Mar '15

27 Mar '15

.. as well as configurable digest length. http://mysqlserverteam.com/mysql-statement-digests-configurable-max-lengths/ http://mysqlserverteam.com/mysql-statement-digests/ Will this be ported to MariaDB? IMO this is/was one of the (not so many) useful things in P_S. And better now. -- Peter -- Webyog

1 0

[Maria-developers] In daemon plugin, THD problem.
by 김경남 27 Mar '15

27 Mar '15

Hi, Sergei! I'm writing daemon plugin . I hava a problem and don't find soultion yet. There is my code as below. ex)plugin.cc ----------------------------------------------------- pthread_handler_t monm_monitor(void *p) { .... THD* thd; thd = new THD; thd->thread_stack= (char*) &thd; tables.init_one_table("performance_schema", 18, "events_statements_current", 25, "events_statements_current", TL_READ); open_and_lock_tables(thd, &tables, FALSE, MYSQL_LOCK_IGNORE_TIMEOUT); ..... } static int monm_plugin_init(void *p __attribute__ ((unused))) { ... pthread_create(&mon_thread, &attr, monm_monitor,(void *) ctx)!= 0) .... } ------------------------------------------------------------- In monm_monitor function, THD* thd cause server crash. so I examined coredump. #6 0x0000000000598752 in THD::THD (this=0x7f9b64000930, is_wsrep_applier=false) at /home/windfree/workspace/ws-mariadb/maria-mon/sql/sql_class.cc:1015 I don't know the reason of crash. What I just want to is read events_statements_current's row by using internal interface in a daemon plugin. Is there a another way ? let me know the solution. Regards, Kyungnam. 김경남 부책임연구원 솔루션사업본부 정보기술 연구원 신기술개발팀 02-2099-6177 / 010-2208-3006 _____ 상기 메시지와 첨부화일 내에는 비밀정보가 포함되어 있을 수 있으며, 지정된 수신자에 한하여 조회 및 사용될 수 있습니다. 만약 송신자의 실수로 인하여 상기 메시지를 수신하였다면, 송신자에게 메시지를 반송해 주시고, 원본 메시지와 모든 사본을 폐기해 주시기 바랍니다. 상기 메시지의 전체 또는 일부에 대해 무단 열람, 사용, 공개, 배포하는 것은 금지되어 있습니다.(주)LG CNS. This message and its attachments may contain confidential information, and they are intended to be viewed or used by only the individuals specified in the message. If you have received this message in an error from the sender, please contact the sender immediately to notify the error and delete all of the message and its copies. It is prohibited to view, use, make public and/or distribute part or whole of this message without written permission.

2 2

Re: [Maria-developers] [Org FW][RE]Re: init_one_table problem.
by sergei 25 Mar '15

25 Mar '15

Hi, 김경남! On Mar 25, 김경남 wrote: > Hi, Sergei ! > > below contents is my previous question . > > After sending email , I see the debug message.like below. > > "Assertion thd == current_thd() failed." > > My code contains. > > THD thd = new THD; > > so I changed my code as > > THD thd = current_thd; > > but thd is null. > > how to I fix it? Note that sql_acl.cc (for example) has THD *thd=new THD; thd->thread_stack= (char*) &thd; thd->store_globals(); All three lines are important. In particular, THD::store_global sets current_thd. Regards, Sergei

1 0

[Maria-developers] init_one_table problem.
by 김경남 25 Mar '15

25 Mar '15

Hi ~ I hava a problem below code in my plugin. ---------------------------------- TABLE_LIST tables; TABLE table; tables.init_one_table(C_STRING_WITH_LEN("performance_schema"),C_STRING_W ITH_LEN("events_statements_current"), events_statements_current, TL_READ); if(table = tables.table) {...} ------------------------------------------------------- During debugging, I found that tables.table is null. Is there a additional task before my code? Regards, Kyungnam. 김경남 부책임연구원 솔루션사업본부 정보기술 연구원 신기술개발팀 02-2099-6177 / 010-2208-3006 _____ 상기 메시지와 첨부화일 내에는 비밀정보가 포함되어 있을 수 있으며, 지정된 수신자에 한하여 조회 및 사용될 수 있습니다. 만약 송신자의 실수로 인하여 상기 메시지를 수신하였다면, 송신자에게 메시지를 반송해 주시고, 원본 메시지와 모든 사본을 폐기해 주시기 바랍니다. 상기 메시지의 전체 또는 일부에 대해 무단 열람, 사용, 공개, 배포하는 것은 금지되어 있습니다.(주)LG CNS. This message and its attachments may contain confidential information, and they are intended to be viewed or used by only the individuals specified in the message. If you have received this message in an error from the sender, please contact the sender immediately to notify the error and delete all of the message and its copies. It is prohibited to view, use, make public and/or distribute part or whole of this message without written permission.

2 1