- developers - lists.mariadb.org

Re: [Maria-developers] [Commits] 732d45e: MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many
by Sergei Golubchik 16 Dec '15

16 Dec '15

Hi, Sergey! On Dec 14, Sergey Vojtovich wrote: > revision-id: 732d45e93b81a104e3f3931e4908e22167a54622 (mariadb-10.0.22-57-g732d45e) > parent(s): 3e206a518dec400e084451165f633b78eb2e7fee > committer: Sergey Vojtovich > timestamp: 2015-12-14 15:27:09 +0400 > message: > > MDEV-8378 - Debian: the Lintian complains about many "shlib-calls-exit" in many > of the plugins > > Fixed exit/_exit calls from libdaemon_example.so, libmysqlclient.so, > libmysqlclient_r.so, libmysqld.so. > > Note: this is just rough prototype, not to be pushed. libmysqld.so still has > a bunch of exit/_exit calls from InnoDB. > > diff --git a/mysys/my_addr_resolve.c b/mysys/my_addr_resolve.c > index 90e6f43..276d5aa 100644 > --- a/mysys/my_addr_resolve.c > +++ b/mysys/my_addr_resolve.c > @@ -190,7 +190,7 @@ const char *my_addr_resolve_init() > close(out[0]); > close(out[1]); > execlp("addr2line", "addr2line", "-C", "-f", "-e", my_progname, NULL); > - exit(1); > + abort(); ok > } > > close(in[0]); > diff --git a/mysys/my_default.c b/mysys/my_default.c > index 8faee00..7bf86f2 100644 > --- a/mysys/my_default.c > +++ b/mysys/my_default.c > @@ -631,7 +631,7 @@ int my_load_defaults(const char *conf_file, const char **groups, > if (!my_getopt_is_args_separator((*argv)[i])) /* skip arguments separator */ > printf("%s ", (*argv)[i]); > puts(""); > - exit(0); > + abort(); /* !!! */ not ok. --print-defaults means exit(0), not abort() > } > > if (default_directories) > @@ -641,7 +641,7 @@ int my_load_defaults(const char *conf_file, const char **groups, > > err: > fprintf(stderr,"Fatal error in defaults handling. Program aborted\n"); > - exit(1); > + abort(); ok > return 0; /* Keep compiler happy */ > } > > diff --git a/mysys/my_malloc.c b/mysys/my_malloc.c > index e5332301..111bc7f 100644 > --- a/mysys/my_malloc.c > +++ b/mysys/my_malloc.c > @@ -108,7 +108,7 @@ void *my_malloc(size_t size, myf my_flags) > my_error(EE_OUTOFMEMORY, MYF(ME_BELL + ME_WAITTANG + > ME_NOREFRESH + ME_FATALERROR),size); > if (my_flags & MY_FAE) > - exit(1); > + abort(); no, MY_FAE means exit(1) not abort() > } > else > { > diff --git a/mysys/my_static.c b/mysys/my_static.c > index 84d2dc6..4272c24 100644 > --- a/mysys/my_static.c > +++ b/mysys/my_static.c > @@ -72,7 +72,8 @@ ulong my_time_to_wait_for_lock=2; /* In seconds */ > #ifdef SHARED_LIBRARY > const char *globerrs[GLOBERRS]; /* my_error_messages is here */ > #endif > -void (*my_abort_hook)(int) = (void(*)(int)) exit; > +void my_abort_wrapper(int a __attribute__((unused))) { abort(); } > +void (*my_abort_hook)(int)= my_abort_wrapper; whatever, it's never used, as far as I can see. It can as well be removed. > void (*error_handler_hook)(uint error, const char *str, myf MyFlags)= > my_message_stderr; > void (*fatal_error_handler_hook)(uint error, const char *str, myf MyFlags)= > diff --git a/mysys/typelib.c b/mysys/typelib.c > index 75744a6..ec1e8fb 100644 > --- a/mysys/typelib.c > +++ b/mysys/typelib.c > @@ -51,7 +51,7 @@ int find_type_or_exit(const char *x, TYPELIB *typelib, const char *option) > if ((res= find_type_with_warning(x, typelib, option)) <= 0) > { > sf_leaking_memory= 1; /* no memory leak reports here */ > - exit(1); > + abort(); no, it's find_type_or_exit, not find_type_or_abort. Incorrect option on the command line should not cause SIGABRT. > } > return res; > } > diff --git a/plugin/daemon_example/daemon_example.cc b/plugin/daemon_example/daemon_example.cc > index dbc3c5c..cdea632 100644 > --- a/plugin/daemon_example/daemon_example.cc > +++ b/plugin/daemon_example/daemon_example.cc > @@ -129,7 +129,7 @@ static int daemon_example_plugin_init(void *p __attribute__ ((unused))) > (void *)con) != 0) > { > fprintf(stderr,"Could not create heartbeat thread!\n"); > - exit(0); > + DBUG_RETURN(1); ok > } > plugin->data= (void *)con; > > diff --git a/sql-common/client.c b/sql-common/client.c > index d20759c..7a4efc3 100644 > --- a/sql-common/client.c > +++ b/sql-common/client.c > @@ -1219,7 +1219,7 @@ void mysql_read_default_options(struct st_mysql_options *options, > FIND_TYPE_BASIC)) <= 0) > { > fprintf(stderr, "Unknown option to protocol: %s\n", opt_arg); > - exit(1); > + abort(); No way. An application should not SIGABRT on the invalid values in the my.cnf file. It should not exit either, in fact, but it's a different issue. > } > break; > case OPT_shared_memory_base_name: > diff --git a/sql/signal_handler.cc b/sql/signal_handler.cc > index 3fadbcd..b301b4c 100644 > --- a/sql/signal_handler.cc > +++ b/sql/signal_handler.cc > @@ -69,7 +69,7 @@ extern "C" sig_handler handle_fatal_signal(int sig) > if (segfaulted) > { > my_safe_printf_stderr("Fatal " SIGNAL_FMT " while backtracing\n", sig); > - _exit(1); /* Quit without running destructors */ > + abort(); Heh, no. You don't want to send another signal when you've encountered an fatal error inside the signal handler. ... etc ... Are you sure we want to fix that at all? And if yes - is it something we need to bother fixing now? How comes it's "critical"? Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/mari… https://www.percona.com/live/data-performance-conference-2016/sessions/mari…

2 2

Re: [Maria-developers] [Commits] 0b0d341: MDEV-9044 : Binlog corruption in Galera
by Sergei Golubchik 16 Dec '15

16 Dec '15

Hi, Nirbhay! On Dec 07, Nirbhay Choubey wrote: > revision-id: 0b0d34138300b891ccbec58e01f3ab5bebe24d71 > parent(s): 3c0e9d31b3e6494931deb09f5c93b05a96df8471 > committer: Nirbhay Choubey > branch nick: 10.1.b9044 > timestamp: 2015-12-07 14:01:52 -0500 > message: > > MDEV-9044 : Binlog corruption in Galera > > While refreshing the IO_CACHE, do not update its parameters (read_pos, > read_end & pos_in_file) if there is nothing left to read. I'm sorry, but I don't understand the fix. Why should parameters be not updated? If there's nothing left to read, the cache is marked as empty, that seems to be correct. > diff --git a/mysys/mf_iocache.c b/mysys/mf_iocache.c > index 28e5e72..db8d0b5 100644 > --- a/mysys/mf_iocache.c > +++ b/mysys/mf_iocache.c > @@ -663,7 +663,11 @@ int _my_b_cache_read(IO_CACHE *info, uchar *Buffer, size_t Count) > info->error= (int) left_length; > DBUG_RETURN(1); > } > - length=0; /* Didn't read any chars */ > + else > + { > + info->error= 0; > + DBUG_RETURN(0); /* EOF */ > + } > } Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/mari… https://www.percona.com/live/data-performance-conference-2016/sessions/mari…

1 0

Re: [Maria-developers] [Commits] 9d8ad0d: Add --persistent option for mysqlcheck
by Sergey Vojtovich 15 Dec '15

15 Dec '15

Hi Vicentu, this is contribution by Daniel. He should get some credit for this. Assuming you didn't change this code much, this should be committed on Daniel's behalf, so that he gets credit on github. Or at the very least mention in a comment contribution author. Thanks, Sergey On Tue, Dec 15, 2015 at 11:11:50AM +0200, Vicentiu Ciorbaru wrote: > revision-id: 9d8ad0d79e3c3a1a9bf7c8cc6477ee4e69fba633 (mariadb-10.0.22-63-g9d8ad0d) > parent(s): e9b4a041af5122dffd59012493c565e6e3db2664 > committer: Vicențiu Ciorbaru > timestamp: 2015-12-15 11:11:28 +0200 > message: > > Add --persistent option for mysqlcheck > > 10.0 has an "analyze table .. persistent for all" syntax. This adds > --persistent to mysqlcheck(mysqlanalyize) to perform this extended > analyze table option. > > --- > client/mysqlcheck.c | 6 +++++- > man/mysqlcheck.1 | 18 +++++++++++++++++- > 2 files changed, 22 insertions(+), 2 deletions(-) > > diff --git a/client/mysqlcheck.c b/client/mysqlcheck.c > index ead4127..b9e5478 100644 > --- a/client/mysqlcheck.c > +++ b/client/mysqlcheck.c > @@ -43,7 +43,7 @@ static my_bool opt_alldbs = 0, opt_check_only_changed = 0, opt_extended = 0, > opt_silent = 0, opt_auto_repair = 0, ignore_errors = 0, > tty_password= 0, opt_frm= 0, debug_info_flag= 0, debug_check_flag= 0, > opt_fix_table_names= 0, opt_fix_db_names= 0, opt_upgrade= 0, > - opt_do_tables= 1; > + opt_persistent_all= 0, opt_do_tables= 1; > static my_bool opt_write_binlog= 1, opt_flush_tables= 0; > static uint verbose = 0, opt_mysql_port=0; > static int my_end_arg; > @@ -160,6 +160,9 @@ static struct my_option my_long_options[] = > {"password", 'p', > "Password to use when connecting to server. If password is not given, it's solicited on the tty.", > 0, 0, 0, GET_STR, OPT_ARG, 0, 0, 0, 0, 0, 0}, > + {"persistent", 'Z', "When using ANALYZE TABLE use the PERSISTENT FOR ALL option.", > + &opt_persistent_all, &opt_persistent_all, 0, GET_BOOL, NO_ARG, 0, 0, > + 0, 0, 0, 0}, > #ifdef __WIN__ > {"pipe", 'W', "Use named pipes to connect to server.", 0, 0, 0, GET_NO_ARG, > NO_ARG, 0, 0, 0, 0, 0, 0}, > @@ -909,6 +912,7 @@ static int handle_request_for_tables(char *tables, size_t length, my_bool view) > case DO_ANALYZE: > DBUG_ASSERT(!view); > op= (opt_write_binlog) ? "ANALYZE" : "ANALYZE NO_WRITE_TO_BINLOG"; > + if (opt_persistent_all) end = strmov(end, " PERSISTENT FOR ALL"); > break; > case DO_OPTIMIZE: > DBUG_ASSERT(!view); > diff --git a/man/mysqlcheck.1 b/man/mysqlcheck.1 > index c175483..e05bbf8 100644 > --- a/man/mysqlcheck.1 > +++ b/man/mysqlcheck.1 > @@ -1,6 +1,6 @@ > '\" t > .\" > -.TH "\FBMYSQLCHECK\FR" "1" "04/08/2015" "MariaDB 10\&.0" "MariaDB Database System" > +.TH "\FBMYSQLCHECK\FR" "1" "27/12/2015" "MariaDB 10\&.0" "MariaDB Database System" > .\" ----------------------------------------------------------------- > .\" * set default formatting > .\" ----------------------------------------------------------------- > @@ -677,6 +677,22 @@ Specifying a password on the command line should be considered insecure\&. You c > .sp -1 > .IP \(bu 2.3 > .\} > +.\" mysqlcheck: persisent option > +.\" persistent option: mysql > +\fB\-\-persistent\fR, > +\fB\-Z\fR > +.sp > +Used with ANALYZE TABLE to append the option PERSISENT FOR ALL. > +.RE > +.sp > +.RS 4 > +.ie n \{\ > +\h'-04'\(bu\h'+03'\c > +.\} > +.el \{\ > +.sp -1 > +.IP \(bu 2.3 > +.\} > .\" mysqlcheck: pipe option > .\" pipe option: mysql > \fB\-\-pipe\fR, > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits

2 2

[Maria-developers] MDEV-8721 AIX: Compile error xtradb:log0log.cc
by Alexander Barkov 15 Dec '15

15 Dec '15

Hi Jan, Can you please review a patch for: MDEV-8721 AIX: Compile error xtradb:log0log.cc which seems to be the same bug with: MDEV-8516 AIX xtradb -> log -> log0log.cc.o Note, I don't have an AIX 7 machine. Just applying the fix suggested by the complainer. The fix looks fine for me. Thanks.

1 0

[Maria-developers] gsoc 2016 and Contributing to MariaDB
by Malith Jayaweera 13 Dec '15

13 Dec '15

Hi! I'm a student and am very much interested in contributing to Maria db. I'm new to development and I haven't got a clue as to where to start. Any sort of guidance is highly appreciated. Thanks. Malith

1 0

[Maria-developers] Please review MDEV-7055 MySQL#74664 - InnoDB: Failing assertion ...
by Alexander Barkov 11 Dec '15

11 Dec '15

Hi Sergei, Please review a patch for MDEV-7055. Thanks.

2 2

[Maria-developers] BUILD ERROR
by Laketra Musa 11 Dec '15

11 Dec '15

Hi, I was Building mariadb on Mac OS X and got this error: [ 81%] Built target pfs_misc-t [ 81%] Built target pfs_timer-t [ 81%] Built target pfs_user-oom-t [ 81%] Built target sphinx [ 83%] Built target spider [ 83%] Built target test_sql_discovery [ 84%] Built target tokuportability_static_conv [ 84%] Built target tokuportability_static [ 84%] Built target logformat [ 84%] Built target generate_log_code [ 84%] Built target make_tdb [ 84%] Built target install_tdb_h [ 84%] Building CXX object storage/tokudb/ft-index/src/CMakeFiles/tokudb_static_conv.dir/ydb.cc.o In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/src/ydb.cc:97: /Users/osiris/Desktop/server/build/storage/tokudb/ft-index/buildheader/db.h:323:1: error: empty struct has size 0 in C, size 1 in C++ [-Werror,-Wextern-c-compat] struct __toku_db_lsn { ^ In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/src/ydb.cc:107: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/ft/ft-flusher.h:94: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/ft/ft-internal.h:103: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/ft/node.h:91: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/ft/bndata.h:93: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.h:731: /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.cc:925:9: error: nonnull parameter 'outlen' will evaluate to 'true' on first encounter [-Werror,-Wpointer-bool-conversion] if (outlen) { ~~ ^~~~~~ /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.cc:935:9: error: nonnull parameter 'outlen' will evaluate to 'true' on first encounter [-Werror,-Wpointer-bool-conversion] if (outlen) { ~~ ^~~~~~ /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.cc:945:9: error: nonnull parameter 'outlen' will evaluate to 'true' on first encounter [-Werror,-Wpointer-bool-conversion] if (outlen) { ~~ ^~~~~~ /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.cc:955:9: error: nonnull parameter 'outlen' will evaluate to 'true' on first encounter [-Werror,-Wpointer-bool-conversion] if (outlen) { ~~ ^~~~~~ 5 errors generated. make[2]: *** [storage/tokudb/ft-index/src/CMakeFiles/tokudb_static_conv.dir/ydb.cc.o] Error 1 make[1]: *** [storage/tokudb/ft-index/src/CMakeFiles/tokudb_static_conv.dir/all] Error 2 make: *** [all] Error 2 How can I fix this please?

3 2

[Maria-developers] PR#129 - 'truncate table' make server crash in sharding&ha configuration when wrapper is oracle
by Sergey Vojtovich 10 Dec '15

10 Dec '15

Hi Kentoku, we got new pull request for Spider. Could you suggest what should we do about it? What license should be requested for Spider contributions? PR: https://github.com/MariaDB/server/pull/129 MDEV: https://mariadb.atlassian.net/browse/MDEV-9254 Thanks, Sergey

1 0

Re: [Maria-developers] [Commits] 6c19f0b: MDEV-9172 - Analyze patches for IBM System z
by Sergei Golubchik 09 Dec '15

09 Dec '15

Hi, Sergey! On Nov 27, Sergey Vojtovich wrote: > revision-id: 6c19f0b0eb0600c276f8681673dc768d542d3bd3 (mariadb-10.1.9-8-g6c19f0b) > parent(s): 3c0e9d31b3e6494931deb09f5c93b05a96df8471 > committer: Sergey Vojtovich > timestamp: 2015-11-27 13:58:30 +0400 > message: > > MDEV-9172 - Analyze patches for IBM System z > > Extended my_timer_cycles() to support s390. > Some compiler tunings for RHEL/SLES RPM packages on s390. > > diff --git a/cmake/build_configurations/mysql_release.cmake b/cmake/build_configurations/mysql_release.cmake > index 8c79ec2..75ce57e 100644 > --- a/cmake/build_configurations/mysql_release.cmake > +++ b/cmake/build_configurations/mysql_release.cmake > @@ -154,6 +154,25 @@ IF(UNIX) > SET(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 ${COMMON_CXX_FLAGS}") > ENDIF() > > + # IBM Z flags > + IF(CMAKE_SYSTEM_PROCESSOR MATCHES "s390x") > + IF(RPM MATCHES "(rhel|centos)6" OR RPM MATCHES "(suse|sles)11") > + SET(z_flags "-funroll-loops -march=z9-109 -mtune=z10 ") > + ELSEIF(RPM MATCHES "(rhel|centos)7" OR RPM MATCHES "(suse|sles)12") > + SET(z_flags "-funroll-loops -march=z196 -mtune=zEC12 ") > + ELSE() > + SET(z_flags "") > + ENDIF() Does MariaDB compile and work without these flags? > diff --git a/mysys/my_rdtsc.c b/mysys/my_rdtsc.c > index 82e5609..4228973 100644 > --- a/mysys/my_rdtsc.c > +++ b/mysys/my_rdtsc.c > @@ -249,6 +249,13 @@ ulonglong my_timer_cycles(void) > clock_gettime(CLOCK_SGI_CYCLE, &tp); > return (ulonglong) tp.tv_sec * 1000000000 + (ulonglong) tp.tv_nsec; > } > +#elif defined(__GNUC__) && defined(__s390__) > + /* covers both s390 and s390x */ > + { > + ulonglong result; > + __asm__ __volatile__ ("stck %0" : "=Q" (result) : : "cc"); I cannot really review that :) If you've checked the documentation and tested it and whatever, then let's push it. > + return result; > + } > #elif defined(HAVE_SYS_TIMES_H) && defined(HAVE_GETHRTIME) Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/mari… https://www.percona.com/live/data-performance-conference-2016/sessions/mari…

2 1

[Maria-developers] Unsubscribe
by Abdul Hakeem 06 Dec '15

06 Dec '15

1 0