March 2017 - developers - lists.mariadb.org

Re: [Maria-developers] [Commits] [PATCH] Use size_t in thd_alloc() and friends.
by Sergei Golubchik 13 Mar '17

13 Mar '17

Hi, Marko! On Mar 11, Marko Mäkelä wrote: > THD::alloc() and related member functions use size_t parameters. > > thd_alloc(), thd_calloc(), thd_strmake(), thd_memdup(): > Define the interface with size_t instead of unsigned int, to avoid > truncating integer conversions on 64-bit Windows, where size_t > is longer than unsigned int. > --- > include/mysql/plugin_audit.h.pp | 20 ++++++++++---------- > include/mysql/plugin_auth.h.pp | 20 ++++++++++---------- > include/mysql/plugin_encryption.h.pp | 20 ++++++++++---------- > include/mysql/plugin_ftparser.h.pp | 20 ++++++++++---------- > include/mysql/plugin_password_validation.h.pp | 20 ++++++++++---------- > include/mysql/service_thd_alloc.h | 21 +++++++++++---------- > sql/sql_class.cc | 10 +++++----- > sql/sql_class.h | 2 +- > storage/innobase/handler/ha_innodb.cc | 18 ++++++++---------- > 9 files changed, 75 insertions(+), 76 deletions(-) Marko, when you change the ABI of services you absolutely must update coresponding service versions in include/service_versions.h. May be, it's best not to break the ABI for such a minor reason and only change THD methods, not service functions. Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

2 1

[Maria-developers] bb-10.2-compatibility
by jerome brauge 13 Mar '17

13 Mar '17

Hello Alexander, When I compiled some real procedures, I find some tables alias not supported by the current grammar. Example : create table t1 (col1 int); select dec.* from t1 dec; select mod.* from t1 mod; I have done a complete test on Oracle and Mariadb with all keywords used as variables, table alias and goto/block labels. You can find result in attached excel file. In addition, schema object names and qualifiers must complied with : https://docs.oracle.com/cd/B28359_01/server.111/b28286/sql_elements008.htm#… I tried to add these keywords in rules keyword_directly_assignable, keyword_sp_not_data_type and keyword_sp_data_type, but this generates too many conflicts. I think that some refactoring of the grammar rules must be done, but I don't know how to do this. Regards, Jérôme.

2 4

[Maria-developers] MDEV-10598 - bb-10.2-compatibility
by jerome brauge 13 Mar '17

13 Mar '17

Hello Alexander, I've done this patch for MDEV-10598. Can you review it ? Regards, Jérôme.

2 11

[Maria-developers] Please review MDEV-12239 Add Type_handler::Item_sum_{sum|avg|variance}_mod_length_and_dec()
by Alexander Barkov 13 Mar '17

13 Mar '17

Hello Alexey, Please review a patch for MDEV-12239. Thanks!

1 0

[Maria-developers] MDEV-12238 Add Type_handler::Item_func_{plus|minus|mul|div|mod}_fix_length_and_dec()
by Alexander Barkov 13 Mar '17

13 Mar '17

Hello Alexey, Please review a patch for MDEV-12238. Thanks!

1 0

Re: [Maria-developers] 23d1188: MDEV-10555: Server crashes in mysql_admin_table upon killing ANALYZE
by Sergei Golubchik 13 Mar '17

13 Mar '17

Hi, Oleksandr! On Mar 08, Oleksandr Byelkin wrote: > revision-id: 23d118899fe9fa030e61b6a9ac06df5210d36294 (mariadb-10.2.4-29-g23d1188) > parent(s): 5da6bd7b959af4a9755556afedde8f34d95c679a > committer: Oleksandr Byelkin > timestamp: 2017-03-08 19:05:44 +0100 > message: > > MDEV-10555: Server crashes in mysql_admin_table upon killing ANALYZE > > Take into acount result of open table operation in mysql_admin_table. Where's the test case? Otherwise ok to push. Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

1 0

[Maria-developers] GSoC 2016 Student Introduction. [ MDEV-4989 ]
by Mike Reiss 13 Mar '17

13 Mar '17

Hi, I am Mike Reiss a MS Computer Science student and I would love to work on enhancing the mysqlbinlog tool during GSoC 2017 [MDEV-4989 <https://jira.mariadb.org/browse/MDEV-4989>]. I have studied the mysqlbinlog.cc file and experimented with the various options available in the my_options array of the tool. The proposed idea is straight forward to implement: We add the --start-gtid and --stop-gtid options to the array of options then parse the GTID passed to these options to get the GTID sequence number for the binlog. One quick question. Is there any relationship between a GTID sequence number and the argument passed to the --start-position option? that way we need to set the start position to the GTID sequence number. I am still doing more research into the source files and I will love to discuss this more with the mentor. I am having difficulties debugging mysqlbinlog on OS X sierra because it does not support GDB any ideas please? Thanks.

2 1

[Maria-developers] Knowing the process
by Sagar Shivani 11 Mar '17

11 Mar '17

Dear sir / ma'am, > My name is sagar. I am interested in contributing into the project > idea of allowing different authentication processes per user. > I have skills in c and c++ programming language. Also i have learned SQL > previous semester. I would really like to know about the process to > pursue this idea. Please guide me .

2 1

Re: [Maria-developers] Please review MDEV-12199 Split Item_func_{abs|neg|int_val}::fix_length_and_dec() into methods in Type_handler
by Alexander Barkov 10 Mar '17

10 Mar '17

Hello Alexey, On 03/10/2017 10:56 AM, Alexey Botchkov wrote: > Ok, i see. > > Last question then. > - item->cast_to_int_type() == cast_to_int_type() && > + item->cast_to_int_type_handler() == > cast_to_int_type_handler() && > Are you sure we should compare typehandlers here, not their ->cmp_type()? Item_hex_constant can be: 1. Either Item_hex_hybrid, which can act as a string or as a number, depending on context: SELECT 0x30, 0x30+1; +------+--------+ | 0x30 | 0x30+1 | +------+--------+ | 0 | 49 | +------+--------+ (the first 0x30 is a string '0', the second 0x30 is an integer 0x30, which is decimal 48) 2. Or Item_hex_string, which is always a string: SELECT X'30', X'30'+1; +-------+---------+ | X'30' | X'30'+1 | +-------+---------+ | 0 | 1 | +-------+---------+ (both X'30's are strings '0') The method Item_hex_constant::eq() needs to make sure that X'30' and 0x30 are considered as different items, and thus don't replace each other, e.g. in equal field propagation. Item_hex_hybrid::cast_to_int_type_handler() returns &type_handler_longlong. Item_hex_string::cast_to_int_type_handler() returns &type_handler_varchar. Comparing type handlers should be enough here. Comparing cmp_type() would be also correct, but would involve one extra virtual call, which is nice to avoid. > > Also i don't like that we have the 'val_int_signed_typecast' as a > virtual functions. Code would > be much nicer without that and all it was done just for Item_dyncol_get. > Not that simple to fix it though and I agree that it shouldn't be > touched as a part of this patch. > Probably sometime later... Maybe. Perhaps some related code will also migrate to Type_handler. Probably this would do: virtual longlong Type_handler::val_int_signed_typecast(Item *item); But I'm not 100% sure. Let's return to this later. Thanks! > > Best regards. > HF > > > > On Fri, Mar 10, 2017 at 1:10 AM, Alexander Barkov <bar(a)mariadb.org > <mailto:bar@mariadb.org>> wrote: > > Hello Alexey, > > > On 03/09/2017 11:38 PM, Alexey Botchkov wrote: > > Hi, Alexander. > > > > Some questions about the patch. > > > > I don't get why we have two sets of functions > > Type_handler_**::+bool > > Type_handler_int_result::Item_func_abs_fix_length_and_dec > > and > > Type_handler_**::+bool > > Type_handler_int_result::Item_func_neg_fix_length_and_dec > > > > As far as i can see these are equal and we just can have one > > Type_handler_**::+bool > > Type_handler_int_result::Item_func_abs_neg_fix_length_and_dec > > Did I miss something? > > > They might look similar: > > > bool Type_handler_int_result:: > Item_func_abs_fix_length_and_dec(Item_func_abs *item) const > { > item->fix_length_and_dec_int(); > return false; > } > > bool Type_handler_int_result:: > Item_func_neg_fix_length_and_dec(Item_func_neg *item) const > { > item->fix_length_and_dec_int(); > return false; > } > > > But they have arguments of different pointer types! > > > The former calls Item_func_abs::fix_length_and_dec_int(), and > the latter calls Item_func_neg::fix_length_and_dec_int(), > > and those are different. > > > > > Secondly, since Item_func::fix_length_and_dec() was historically 'void' > > and i don't see you're > > changing it, why do all these typehandler's 'xxx_fix_length_and_dec' > > return something? > > Nobody checks their return anyway. > > > Currently fix_fields() does this: > > fix_length_and_dec(); > if (thd->is_error()) // An error inside fix_length_and_dec occurred > return TRUE; > > I'm thinking of eventually changing this to: > > if (fix_length_and_dec()) > return true; > > > So I decided to make all Type_handler::xxxx_fix_length_and_dec() > return bool right now, so we have to do less changes in the future. > > > Thanks! > > > > > Best regards. > > HF > > > > > > On Tue, Mar 7, 2017 at 6:15 PM, Alexander Barkov <bar(a)mariadb.org <mailto:bar@mariadb.org> > > <mailto:bar@mariadb.org <mailto:bar@mariadb.org>>> wrote: > > > > Hello Alexey, > > > > Please review a patch for MDEV-12199. > > > > Thanks! > > > > > >

1 0

[Maria-developers] GTID and Optimize, Analyze etc
by Peter Mclarty 10 Mar '17

10 Mar '17

Hi I have some very large tables and I would like to give them a cleanup. If I run OPTIMIZE and ANALYZE on a slave does that affect the GTID of that slave and cause me to eventually get the dreaded Slave has diverged too far from the master type error Can I set a session variable to block any change Cheers -- *Cheers* *Peter McLarty* -- Compare The Market is a brand and trading name of Compare The Market (Pty) Ltd (CTM). This email is for the intended addressee and is confidential and subject to copyright. If you are not the intended addressee, confidentiality has not been waived and any use, interference with, or disclosure of this email is unauthorised. If you are not the intended addressee please immediately notify CTM and then delete the email. CTM does not warrant that this email is error or virus free.

2 1