January 2016 - developers - lists.mariadb.org

[Maria-developers] MDEV-9332 Bug after upgrade to 10.1.10
by Alexander Barkov 26 Jan '16

26 Jan '16

Hi Sergei, Please review a patch form MDEV-9332. It does the following: - Changes the behaviour of copy_if_not_alloced in case from->Alloced_length==0 and from_length==0 to return "to" instead of "from", because "from" can point to a constant string. - Rewrites the code to make it more readable (I hope), adding comments. Thanks.

2 2

Re: [Maria-developers] [Commits] e58e69e: MDEV-6421 SQL_ERROR_LOG doesn't log comments in Events.
by Sergei Golubchik 25 Jan '16

25 Jan '16

Hi, Alexey! On Jan 25, Alexey Botchkov wrote: > revision-id: e58e69e2feed36cdbffbae18f75faf0aea028401 (mariadb-10.1.10-24-ge58e69e) > parent(s): ff8d4009a7743b99c1c13831172b08041a4b272e > committer: Alexey Botchkov > timestamp: 2016-01-25 11:28:58 +0400 > message: > > MDEV-6421 SQL_ERROR_LOG doesn't log comments in Events. > Change parser so it saves all the query line to the ';' in the > sp_instr::m_query. Looks ok to push, thanks! Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org

1 0

[Maria-developers] More contributors welcome to MariaDB packaging in Debian
by Otto Kekäläinen 24 Jan '16

24 Jan '16

Hello! Do you want to improve MariaDB in Debian? Do you want to contribute to Debian packaging using modern git-buildpackage tools and state of the art QA tools? Do you want to see the result of your work in the hands of numerous of Linux users who run Debian and MariaDB? I am happy to mentor anybody who want's to start contributing to Debian packaging of MariaDB. I have created some items with priority "wishlist" and title prepended with "TODO" visible at https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=mariadb-10.0#_0_6_4 These are all farily easy tasks that anybody interested in contributing could pick up and and start working on. If you want to contribute, please subscribe to the packaging teams list and show your interest there / ask questions to get directions and more help: http://lists.alioth.debian.org/pipermail/pkg-mysql-maint/ I promise to quickly review and respond to questions so that contributors feel welcomed! - Otto

3 4

[Maria-developers] bugs for beginners
by Aniket Shukla 22 Jan '16

22 Jan '16

Hello developers,I was wondering if anyone could point out some bugs for beginners in MariaDB(for the purpose of contribution) .Any help would be thankfully welcomed. Aniket

2 1

[Maria-developers] Oracle CPU January 2016
by Colin Charles 21 Jan '16

21 Jan '16

Hi! Oracle has released a Critical Patch Update: http://www.oracle.com/technetwork/topics/security/cpujan2016-2367955.html The following vulnerabilities are fixed by upgrading from MySQL 5.5.46 to 5.5.47 (picked it from the Debian maintainers list): CVE-2016-0505 CVE-2016-0546 CVE-2016-0597 CVE-2016-0598 CVE-2016-0600 CVE-2016-0606 CVE-2016-0608 CVE-2016-0609 CVE-2016-0596 CVE-2016-0616 We already have released MariaDB Server 5.5.47, so I guess its time we updated: https://mariadb.com/kb/en/mariadb/security/ (assuming that all this is fixed?) As an aside, it is interesting to see that there are CVE’s fixed for 5.7 only (see: http://www.oracle.com/technetwork/topics/security/cpujan2016-2367955.html#A…) -- Colin Charles, http://bytebot.net/blog/ twitter: @bytebot | skype: colincharles "First they ignore you, then they laugh at you, then they fight you, then you win." -- Mohandas Gandhi

1 0

Re: [Maria-developers] MDEV-8615: Assertion `m_cpp_buf <= begin_ptr && begin_ptr <= m_cpp_buf + m_buf_length' failed in Lex_input_stream::body_utf8_start
by Sergei Golubchik 21 Jan '16

21 Jan '16

Hi, Sanja! On Dec 25, OleksandrByelkin wrote: > revision-id: 684bd68c33284f6106551188d9567f35b18593ed (mariadb-10.1.9-21-g684bd68) > parent(s): 59fcd7ff2315d007045eb987da5f21abbea6f6f1 > committer: Oleksandr Byelkin > timestamp: 2015-12-25 18:39:43 +0100 > message: > > MDEV-8615: Assertion `m_cpp_buf <= begin_ptr && begin_ptr <= m_cpp_buf + m_buf_length' failed in Lex_input_stream::body_utf8_start > > Nothing should be done before any keyword recognised. > > diff --git a/mysql-test/r/mysqltest.result b/mysql-test/r/mysqltest.result > index e258b1d..a9980a7 100644 > --- a/mysql-test/r/mysqltest.result > +++ b/mysql-test/r/mysqltest.result > @@ -29,40 +29,40 @@ select 0 as "after_successful_stmt_errno" ; > after_successful_stmt_errno > 0 > garbage ; > -ERROR 42000: You have an error in your SQL syntax; <...> near 'garbage' at line 1 > +ERROR 42000: You have an error in your SQL syntax; <...> near '' at line 1 Why is that? I mean, how does the parser parse "garbage" now? > diff --git a/mysql-test/suite/funcs_1/r/storedproc.result b/mysql-test/suite/funcs_1/r/storedproc.result > index f0e1ee7..485082a 100644 > --- a/mysql-test/suite/funcs_1/r/storedproc.result > +++ b/mysql-test/suite/funcs_1/r/storedproc.result > @@ -15982,8 +15982,7 @@ insert into res_t3_itisalongname_1381742_itsaverylongname_1381742 values( 'xyz' > until count1 < 3 > END repeat label1; > END// > -ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'label1; > -END' at line 8 > +ERROR 42000: End-label label1 without match New error message is correct, great! > diff --git a/sql/sql_yacc.yy b/sql/sql_yacc.yy > index a5a62ae..74d308f 100644 > --- a/sql/sql_yacc.yy > +++ b/sql/sql_yacc.yy > @@ -248,6 +248,36 @@ static bool maybe_start_compound_statement(THD *thd) > return 0; This looks quite good! But it was a bit difficult to see how the new sql_yacc.yy will look like. Did you push this patch? In what branch? Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/mari… https://www.percona.com/live/data-performance-conference-2016/sessions/mari…

2 1

[Maria-developers] MDEV-8930 main.func_hybrid_type with --embedded --ps-protocol: Assertion `(longlong) thd->status_var.local_memory_used >= 0' failed
by Alexander Barkov 20 Jan '16

20 Jan '16

Hi Sergei, IIRC you fixed this bug during the meeting in Amsterdam. Can you please confirm? (or just close it, if so) Thanks.

1 0

[Maria-developers] Request for the project
by Ayush Bhargav 20 Jan '16

20 Jan '16

Hi. I am studying programming in college and I wanted to have some hand on experience on larger projects. I know c++ and mysql well. Please can you provide me a project on which I can start working. Thanks. - Ayush Bhargav

2 1

Re: [Maria-developers] [Commits] cae1945: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality
by Sergei Golubchik 20 Jan '16

20 Jan '16

Hi, Sanja! On Nov 25, OleksandrByelkin wrote: > revision-id: cae19452eec1d3be47fa04759dd2dda6d061543e (mariadb-10.1.8-69-gcae1945) > parent(s): 55e67c3e344317c6f349f5391e5d117ec51ae062 > committer: Oleksandr Byelkin > timestamp: 2015-11-25 18:09:39 +0100 > message: > > MDEV-9117: Client Server capability negotiation for MariaDB specific functionality > > New capability flags space. > Removed old progress flag, added new one. > > diff --git a/include/mysql_com.h b/include/mysql_com.h > index aa6ab0f..57092dc 100644 > --- a/include/mysql_com.h > +++ b/include/mysql_com.h > @@ -215,7 +216,8 @@ enum enum_server_command > /* Don't close the connection for a connection with expired password. */ > #define CLIENT_CAN_HANDLE_EXPIRED_PASSWORDS (1UL << 22) > > -#define CLIENT_PROGRESS (1UL << 29) /* Client support progress indicator */ > +#define CLIENT_PROGRESS_OBSOLETE (1UL << 29) ok > +#define CLIENT_PROGRESS 0 why is that? > #define CLIENT_SSL_VERIFY_SERVER_CERT (1UL << 30) > /* > It used to be that if mysql_real_connect() failed, it would delete any > @@ -228,6 +230,13 @@ enum enum_server_command > */ > #define CLIENT_REMEMBER_OPTIONS (1UL << 31) > > +/* MariaDB extended capability flags */ > +#define MARIADB_CLIENT_FLAGS_MASK 0xffffffff00000000ULL > +/* Client support progress indicator */ > +#define MARIADB_CLIENT_PROGRESS (1ULL << 32) > +/* Client support mariaDB extended flags */ > +#define MARIADB_CLIENT_EXTENDED_FLAGS (1ULL << 63) how can this work, if client_flag and server_capabilities are only 32-bit variables? > + > #ifdef HAVE_COMPRESS > #define CAN_CLIENT_COMPRESS CLIENT_COMPRESS > #else > diff --git a/sql/sql_acl.cc b/sql/sql_acl.cc > index 1240d5d..d07e0a4 100644 > --- a/sql/sql_acl.cc > +++ b/sql/sql_acl.cc > @@ -11729,18 +11731,38 @@ static ulong parse_client_handshake_packet(MPVIO_EXT *mpvio, > */ > DBUG_ASSERT(net->read_pos[pkt_len] == 0); > > - ulong client_capabilities= uint2korr(net->read_pos); > + ulonglong client_capabilities= uint2korr(net->read_pos); > + compile_time_assert(sizeof(client_capabilities) >= 8); > if (client_capabilities & CLIENT_PROTOCOL_41) > { > - if (pkt_len < 4) > + if (pkt_len < 32) > return packet_error; > client_capabilities|= ((ulong) uint2korr(net->read_pos+2)) << 16; > + if (!(client_capabilities & CLIENT_MYSQL)) > + { > + // it is client with mariadb extensions > + client_capabilities|= CLIENT_MYSQL; > + ulonglong ext_client_capabilities= > + (((ulonglong)uint4korr(net->read_pos + 28)) << 32); > + if (ext_client_capabilities & MARIADB_CLIENT_EXTENDED_FLAGS) > + client_capabilities|= ext_client_capabilities; > + else > + { > + DBUG_PRINT("error", ("CLIENT_PROTOCOL_41: on, " > + "CLIENT_LONG_PASSWORD/CLIENT_MYSQL off, " > + "but MARIADB_CLIENT_EXTENDED_FLAGS is off. " > + "flags: %llx ext flags %llx", > + client_capabilities, ext_client_capabilities)); > + return packet_error; Why do you need that (MARIADB_CLIENT_EXTENDED_FLAGS and the check)? > + } > + } here you need to check for old MariaDB clients - they will have CLIENT_MYSQL and might have CLIENT_PROGRESS_OBSOLETE - do something like else if (client_capabilities & CLIENT_PROGRESS_OBSOLETE) { client_capabilities |= MARIADB_CLIENT_PROGRESS; } > } > > diff --git a/tests/mysql_client_test.c b/tests/mysql_client_test.c > index a1a52e8..31fca0f 100644 > --- a/tests/mysql_client_test.c > +++ b/tests/mysql_client_test.c > @@ -15336,7 +15336,7 @@ static void test_mysql_insert_id() > > myheader("test_mysql_insert_id"); > > - rc= mysql_query(mysql, "drop table if exists t1"); > + rc= mysql_query(mysql, "drop table if exists t1,t2"); separate commit, please > myquery(rc); > /* table without auto_increment column */ > rc= mysql_query(mysql, "create table t1 (f1 int, f2 varchar(255), key(f1))"); > @@ -18700,7 +18700,8 @@ static void test_progress_reporting() > myheader("test_progress_reporting"); > > conn= client_connect(CLIENT_PROGRESS, MYSQL_PROTOCOL_TCP, 0); > - DIE_UNLESS(conn->client_flag & CLIENT_PROGRESS); > + if (!(conn->client_flag & CLIENT_PROGRESS)) > + return; what are you testing here? Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/mari… https://www.percona.com/live/data-performance-conference-2016/sessions/mari…

2 8

[Maria-developers] Contribution in MariaDB
by Sanjana Garg 18 Jan '16

18 Jan '16

Hi, I am interested in contributing to the MariaDB project. Can someone guide me on how to get started. I am proficient in C, C++, python and SQL. Thanks Sanjana Garg

2 1