December 2015 - developers - lists.mariadb.org

[Maria-developers] MDEV-8721 AIX: Compile error xtradb:log0log.cc
by Alexander Barkov 15 Dec '15

15 Dec '15

Hi Jan, Can you please review a patch for: MDEV-8721 AIX: Compile error xtradb:log0log.cc which seems to be the same bug with: MDEV-8516 AIX xtradb -> log -> log0log.cc.o Note, I don't have an AIX 7 machine. Just applying the fix suggested by the complainer. The fix looks fine for me. Thanks.

1 0

[Maria-developers] gsoc 2016 and Contributing to MariaDB
by Malith Jayaweera 13 Dec '15

13 Dec '15

Hi! I'm a student and am very much interested in contributing to Maria db. I'm new to development and I haven't got a clue as to where to start. Any sort of guidance is highly appreciated. Thanks. Malith

1 0

[Maria-developers] Please review MDEV-7055 MySQL#74664 - InnoDB: Failing assertion ...
by Alexander Barkov 11 Dec '15

11 Dec '15

Hi Sergei, Please review a patch for MDEV-7055. Thanks.

2 2

[Maria-developers] BUILD ERROR
by Laketra Musa 11 Dec '15

11 Dec '15

Hi, I was Building mariadb on Mac OS X and got this error: [ 81%] Built target pfs_misc-t [ 81%] Built target pfs_timer-t [ 81%] Built target pfs_user-oom-t [ 81%] Built target sphinx [ 83%] Built target spider [ 83%] Built target test_sql_discovery [ 84%] Built target tokuportability_static_conv [ 84%] Built target tokuportability_static [ 84%] Built target logformat [ 84%] Built target generate_log_code [ 84%] Built target make_tdb [ 84%] Built target install_tdb_h [ 84%] Building CXX object storage/tokudb/ft-index/src/CMakeFiles/tokudb_static_conv.dir/ydb.cc.o In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/src/ydb.cc:97: /Users/osiris/Desktop/server/build/storage/tokudb/ft-index/buildheader/db.h:323:1: error: empty struct has size 0 in C, size 1 in C++ [-Werror,-Wextern-c-compat] struct __toku_db_lsn { ^ In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/src/ydb.cc:107: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/ft/ft-flusher.h:94: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/ft/ft-internal.h:103: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/ft/node.h:91: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/ft/bndata.h:93: In file included from /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.h:731: /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.cc:925:9: error: nonnull parameter 'outlen' will evaluate to 'true' on first encounter [-Werror,-Wpointer-bool-conversion] if (outlen) { ~~ ^~~~~~ /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.cc:935:9: error: nonnull parameter 'outlen' will evaluate to 'true' on first encounter [-Werror,-Wpointer-bool-conversion] if (outlen) { ~~ ^~~~~~ /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.cc:945:9: error: nonnull parameter 'outlen' will evaluate to 'true' on first encounter [-Werror,-Wpointer-bool-conversion] if (outlen) { ~~ ^~~~~~ /Users/osiris/Desktop/server/storage/tokudb/ft-index/util/dmt.cc:955:9: error: nonnull parameter 'outlen' will evaluate to 'true' on first encounter [-Werror,-Wpointer-bool-conversion] if (outlen) { ~~ ^~~~~~ 5 errors generated. make[2]: *** [storage/tokudb/ft-index/src/CMakeFiles/tokudb_static_conv.dir/ydb.cc.o] Error 1 make[1]: *** [storage/tokudb/ft-index/src/CMakeFiles/tokudb_static_conv.dir/all] Error 2 make: *** [all] Error 2 How can I fix this please?

3 2

[Maria-developers] PR#129 - 'truncate table' make server crash in sharding&ha configuration when wrapper is oracle
by Sergey Vojtovich 10 Dec '15

10 Dec '15

Hi Kentoku, we got new pull request for Spider. Could you suggest what should we do about it? What license should be requested for Spider contributions? PR: https://github.com/MariaDB/server/pull/129 MDEV: https://mariadb.atlassian.net/browse/MDEV-9254 Thanks, Sergey

1 0

Re: [Maria-developers] [Commits] 6c19f0b: MDEV-9172 - Analyze patches for IBM System z
by Sergei Golubchik 09 Dec '15

09 Dec '15

Hi, Sergey! On Nov 27, Sergey Vojtovich wrote: > revision-id: 6c19f0b0eb0600c276f8681673dc768d542d3bd3 (mariadb-10.1.9-8-g6c19f0b) > parent(s): 3c0e9d31b3e6494931deb09f5c93b05a96df8471 > committer: Sergey Vojtovich > timestamp: 2015-11-27 13:58:30 +0400 > message: > > MDEV-9172 - Analyze patches for IBM System z > > Extended my_timer_cycles() to support s390. > Some compiler tunings for RHEL/SLES RPM packages on s390. > > diff --git a/cmake/build_configurations/mysql_release.cmake b/cmake/build_configurations/mysql_release.cmake > index 8c79ec2..75ce57e 100644 > --- a/cmake/build_configurations/mysql_release.cmake > +++ b/cmake/build_configurations/mysql_release.cmake > @@ -154,6 +154,25 @@ IF(UNIX) > SET(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 ${COMMON_CXX_FLAGS}") > ENDIF() > > + # IBM Z flags > + IF(CMAKE_SYSTEM_PROCESSOR MATCHES "s390x") > + IF(RPM MATCHES "(rhel|centos)6" OR RPM MATCHES "(suse|sles)11") > + SET(z_flags "-funroll-loops -march=z9-109 -mtune=z10 ") > + ELSEIF(RPM MATCHES "(rhel|centos)7" OR RPM MATCHES "(suse|sles)12") > + SET(z_flags "-funroll-loops -march=z196 -mtune=zEC12 ") > + ELSE() > + SET(z_flags "") > + ENDIF() Does MariaDB compile and work without these flags? > diff --git a/mysys/my_rdtsc.c b/mysys/my_rdtsc.c > index 82e5609..4228973 100644 > --- a/mysys/my_rdtsc.c > +++ b/mysys/my_rdtsc.c > @@ -249,6 +249,13 @@ ulonglong my_timer_cycles(void) > clock_gettime(CLOCK_SGI_CYCLE, &tp); > return (ulonglong) tp.tv_sec * 1000000000 + (ulonglong) tp.tv_nsec; > } > +#elif defined(__GNUC__) && defined(__s390__) > + /* covers both s390 and s390x */ > + { > + ulonglong result; > + __asm__ __volatile__ ("stck %0" : "=Q" (result) : : "cc"); I cannot really review that :) If you've checked the documentation and tested it and whatever, then let's push it. > + return result; > + } > #elif defined(HAVE_SYS_TIMES_H) && defined(HAVE_GETHRTIME) Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/mari… https://www.percona.com/live/data-performance-conference-2016/sessions/mari…

2 1

[Maria-developers] Unsubscribe
by Abdul Hakeem 06 Dec '15

06 Dec '15

1 0

Re: [Maria-developers] [Commits] bde705f: MDEV-7050: MySQL#74603 - Assertion `comma_length > 0' failed in mysql_prepare_create_table
by Sergei Golubchik 06 Dec '15

06 Dec '15

Hi, Jan! On Dec 02, Jan Lindström wrote: > revision-id: bde705fdaec49ab495eafcd18c609970a2566cb7 (mariadb-5.5.46-10-gbde705f) > parent(s): 13ad179c96ee8c8c4043806b8575c851e3676f0d > committer: Jan Lindström > timestamp: 2015-12-02 17:53:28 +0200 > message: > > MDEV-7050: MySQL#74603 - Assertion `comma_length > 0' failed in mysql_prepare_create_table > > Too short buffer was used for ENUM comma buffer. > > --- > mysql-test/r/create.result | 20 ++++++++++++++++++++ > mysql-test/t/create.test | 21 +++++++++++++++++++++ > sql/sql_table.cc | 2 +- > 3 files changed, 42 insertions(+), 1 deletion(-) > > diff --git a/mysql-test/r/create.result b/mysql-test/r/create.result > index 8dd3cc8..2da3460 100644 > --- a/mysql-test/r/create.result > +++ b/mysql-test/r/create.result > @@ -2477,3 +2477,23 @@ t1 CREATE TABLE `t1` ( > `c` char(32) AS (convert(cast(n as char), char)) PERSISTENT > ) ENGINE=MyISAM DEFAULT CHARSET=latin1 > drop table t1; > +DROP DATABASE test; > +CREATE DATABASE test; > +USE test; > +SET character_set_filesystem=filename; > +SET @session_start_value=@@character_set_filesystem; > +SET @@session.collation_server=@session_start_value; > +create table t0(a ENUM('','')); > +Warnings: > +Note 1291 Column 'a' has duplicated value '' in ENUM > +DROP DATABASE test; > +CREATE DATABASE test; > +USE test; > +create table t0(a ENUM('','')); > +Warnings: > +Note 1291 Column 'a' has duplicated value '' in ENUM > +DROP TABLE t0; > +SET @@session.collation_server = latin1_swedish_ci; > +DROP DATABASE test; > +CREATE DATABASE test; > +USE test; You could do with a simpler test case. This one worked for me: set @@session.collation_server=filename; create table t1(a enum('','')); drop table t1; set @@session.collation_server=default; > diff --git a/sql/sql_table.cc b/sql/sql_table.cc > index 6e589e2..6ce46ad 100644 > --- a/sql/sql_table.cc > +++ b/sql/sql_table.cc > @@ -2986,7 +2986,7 @@ mysql_prepare_create_table(THD *thd, HA_CREATE_INFO *create_info, > sql_field->interval_list); > List_iterator<String> int_it(sql_field->interval_list); > String conv, *tmp; > - char comma_buf[4]; /* 4 bytes for utf32 */ > + char comma_buf[8]; /* 4*2 bytes for utf32 */ incorrect comment, must be char comma_buf[5]; /* 5 bytes for 'filename' charset */ and please, add an assert: DBUG_ASSERT(sizeof(comma_buf) >= cs->mbmaxlen); > int comma_length= cs->cset->wc_mb(cs, ',', (uchar*) comma_buf, > (uchar*) comma_buf + > sizeof(comma_buf)); There's another bug, while 5 and the assert might not be working for you. I'll attach the patch with the fix. Feel free to push it, it must be pushed before your bugfix. Or wait for me to, as you like. Just tell me what you choose. Regards, Sergei Chief Architect MariaDB and security(a)mariadb.org -- Vote for my Percona Live 2016 talks: https://www.percona.com/live/data-performance-conference-2016/sessions/mari… https://www.percona.com/live/data-performance-conference-2016/sessions/mari…

1 0

[Maria-developers] Error Compiling MariaDB with clang on Mac Os X
by Vicențiu Ciorbaru 04 Dec '15

04 Dec '15

Hi Sergei, While working on features for 10.2 I've encountered a problem when compiling MariaDB as a Debug build. According to your change on commit 29dd634a4c0b9c3579cf9d318ed64d748d848b1d dbug: correct trace for DBUG_RETURN(func()); This causes a small problem, in two places within the codebase. One is in the myisam storage engine and one in the maria storage engine. Within thr_find_all_keys, there is a hack with goto statements and using DBUG_ENTER after my_thread_init(). /Users/cvicentiu/Workspace/MariaDB/storage/myisam/sort.c:352:5: error: cannot jump from this goto statement to its label goto err; ^ /Users/cvicentiu/Workspace/MariaDB/storage/myisam/sort.c:355:5: note: jump bypasses initialization of variable with __attribute__((cleanup)) DBUG_ENTER("thr_find_all_keys"); ^ /Users/cvicentiu/Workspace/MariaDB/include/my_dbug.h:74:47: note: expanded from macro 'DBUG_ENTER' #define DBUG_ENTER(a) struct _db_stack_frame_ _db_stack_frame_ __attribute__((cleanup(_db_return_))); \ In the current code state, the attribute_cleanup callback does not make sense if my_thread_init() fails and forces the goto err; Technically, it is undefined behaviour, as we're jumping within the block that has the variables defined, without initialising it. The sensible thing to do is to refactor the block that has DBUG_ENTER into a separate function and decoupling the error cleanup from the my_thread_init() call. I've looked at that code and have seen that much of the logic is redundant during the cleanup part. I can refactor it to fix the problem, but I'm looking for input on your side if you're ok with me doing that. I've also found a bug in that same code in the error checking that I can fix. Regards, Vicentiu

2 1

[Maria-developers] [MDEV-7122] Questions regarding code history
by Vicențiu Ciorbaru 04 Dec '15

04 Dec '15

Hi Sergey! I've been investigating MDEV-7122. I'm still quite a ways to go before I can understand all the underlying bits of logic. I need a little help regarding a change that you've committed a while back. Do you know (remember) why you've placed DBUG_ASSERT(0) in the commit: a1b4eadf89a3940b80a6ed0eadd15ba456c2fa7a BUG#868908: Crash in check_simple_equality() with semijoin + materialization + prepared statement - Part2: safety and code cleanup To me, it feels like it's some leftover debugging code, but it would be good to get your input on this. @@ -4182,6 +4183,8 @@ bool subselect_hash_sj_engine::init(List<Item> *tmp_columns, uint subquery_id) */ if (tmp_table->s->keys == 0) { + //fprintf(stderr, "Q: %s\n", current_thd->query()); + DBUG_ASSERT(0); Obviously we should also get rid of the commented fprintf statement. After trying to debug this by just looking at the adjacent function calls and logic, I've come to the conclusion that I need to actually understand the code methodically. This is what I am actually doing right now, starting from the parser, all the way to how this particular query is executed. Expect more questions from me on this topic. Thanks, Vicentiu

1 0