July 2012 - developers - lists.mariadb.org

[Maria-developers] problem with savepoints in mariadb 5.5.25
by Rich Prohaska 10 Jul '12

10 Jul '12

Hello, We observed a problem with savepoints in Mariadb 5.5.25. The problem at the SQL layer is that a "rollback to savepoint" statement would get an error after the savepoint was created. The problem was caused by the savepoint name in the savepoint stack getting overwritten by the handlerton savepoint_set method. Here is what we think is going on: 1. space is reserved in the savepoint memory for each handlerton in the ha_initialize_handlerton function. 2. then space is reserved for the SAVEPOINT object in ha_init. (Yes, ha_init gets called AFTER the ha_initialize_handlerton calls. 3. ha_savepoint computes the address of the handlerton's object as (uchar*)(sv+1) + ht->savepoint_offset. this assumes that the SAVEPOINT object is laid out first, followed by the handlerton's space. unfortunately, step (1) occurs before step (2) so this is not the case. Here is a possible fix: Move the base initialization of the savepoint_alloc_size from ha_init to the global intiializer. With this change, the handlerton's offsets are computed AFTER the SAVEPOINT space is reserved. Is this correct? Thanks Rich Prohaska

2 3

[Maria-developers] Please test: Rev 3458: MDEV-376: Wrong result (missing rows) with index_merge+index_merge_intersection, join
by Sergei Petrunia 04 Jul '12

04 Jul '12

Hi Elena, Could you please re-run the tests with this fix: ----- Forwarded message from Sergey Petrunya <psergey(a)askmonty.org> ----- From: Sergey Petrunya <psergey(a)askmonty.org> To: commits(a)mariadb.org X-Mailer: mail (GNU Mailutils 1.2) Date: Wed, 4 Jul 2012 13:34:48 +0300 (EEST) Subject: [Commits] Rev 3458: MDEV-376: Wrong result (missing rows) with index_merge+index_merge_intersection, join in file:///home/psergey/dev2/5.5-look6/ At file:///home/psergey/dev2/5.5-look6/ ------------------------------------------------------------ revno: 3458 revision-id: psergey(a)askmonty.org-20120704103445-ro4sk3cwbbzn3t4p parent: psergey(a)askmonty.org-20120623161254-ido3pf16l31psyyv committer: Sergey Petrunya <psergey(a)askmonty.org> branch nick: 5.5-look6 timestamp: Wed 2012-07-04 14:34:45 +0400 message: MDEV-376: Wrong result (missing rows) with index_merge+index_merge_intersection, join - Let QUICK_RANGE_SELECT::init_ror_merged_scan() call quick->reset() only after we've set the column read bitmaps. === modified file 'mysql-test/r/index_merge_innodb.result' --- a/mysql-test/r/index_merge_innodb.result 2012-06-06 19:26:40 +0000 +++ b/mysql-test/r/index_merge_innodb.result 2012-07-04 10:34:45 +0000 @@ -777,4 +777,19 @@ commit; select * from t1 where t1.zone_id=830 AND modified=9; pk zone_id modified drop table t0, t1; +# +# MDEV-376: Wrong result (missing rows) with index_merge+index_merge_intersection, join +# +CREATE TABLE t1 ( +a INT, b CHAR(1), c CHAR(1), KEY(a), KEY(b) +) ENGINE=InnoDB; +INSERT INTO t1 VALUES (8,'v','v'),(8,'m','m'),(9,'d','d'); +SELECT ta.* FROM t1 AS ta, t1 AS tb +WHERE ( tb.b != ta.b OR tb.a = ta.a ) +AND ( tb.b = ta.c OR tb.b = ta.b ); +a b c +8 v v +8 m m +9 d d +DROP TABLE t1; set optimizer_switch= @optimizer_switch_save; === modified file 'mysql-test/t/index_merge_innodb.test' --- a/mysql-test/t/index_merge_innodb.test 2012-06-04 15:26:11 +0000 +++ b/mysql-test/t/index_merge_innodb.test 2012-07-04 10:34:45 +0000 @@ -156,6 +156,21 @@ select * from t1 where t1.zone_id=830 AN drop table t0, t1; +--echo # +--echo # MDEV-376: Wrong result (missing rows) with index_merge+index_merge_intersection, join +--echo # +CREATE TABLE t1 ( + a INT, b CHAR(1), c CHAR(1), KEY(a), KEY(b) +) ENGINE=InnoDB; + +INSERT INTO t1 VALUES (8,'v','v'),(8,'m','m'),(9,'d','d'); + + +SELECT ta.* FROM t1 AS ta, t1 AS tb +WHERE ( tb.b != ta.b OR tb.a = ta.a ) + AND ( tb.b = ta.c OR tb.b = ta.b ); + +DROP TABLE t1; set optimizer_switch= @optimizer_switch_save; === modified file 'sql/opt_range.cc' --- a/sql/opt_range.cc 2012-06-04 15:26:11 +0000 +++ b/sql/opt_range.cc 2012-07-04 10:34:45 +0000 @@ -2008,7 +2008,7 @@ int QUICK_RANGE_SELECT::init_ror_merged_ if (reuse_handler) { DBUG_PRINT("info", ("Reusing handler 0x%lx", (long) file)); - if (init() || reset()) + if (init()) { DBUG_RETURN(1); } @@ -2043,7 +2043,7 @@ int QUICK_RANGE_SELECT::init_ror_merged_ if (file->ha_external_lock(thd, F_RDLCK)) goto failure; - if (init() || reset()) + if (init()) { file->ha_external_lock(thd, F_UNLCK); file->ha_close(); @@ -2090,7 +2090,18 @@ int QUICK_RANGE_SELECT::init_ror_merged_ head->key_read= org_key_read; bitmap_copy(&column_bitmap, head->read_set); head->column_bitmaps_set(&column_bitmap, &column_bitmap); - + + if (reset()) + { + if (!reuse_handler) + { + file->ha_external_lock(thd, F_UNLCK); + file->ha_close(); + goto failure; + } + else + DBUG_RETURN(1); + } DBUG_RETURN(0); failure: _______________________________________________ commits mailing list commits(a)mariadb.org https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits ----- End forwarded message ----- -- BR Sergei -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

2 1

[Maria-developers] Fixing 10.0 buildbot: OS-dependent error messages
by Sergei Petrunia 04 Jul '12

04 Jul '12

Hi! As some have noticed, 10.0 tree is red for all non-Linux builds. The errors look like this (on Windows) http://buildbot.askmonty.org/buildbot/builders/win64-release2/builds/1558/s… -ERROR HY000: Got error 1478 "Unknown error 1478" from storage engine +ERROR HY000: Got error 1478 "Unknown error" from storage engine ... -Error 1005 Can't create table 'test.t1' (errno: 1478 "Unknown error 1478") +Error 1005 Can't create table 'test.t1' (errno: 1478 "Unknown error") or like this (on Mac) http://buildbot.askmonty.org/buildbot/builders/labrador/builds/95/steps/tes… -ERROR HY000: Got error 1478 "Unknown error 1478" from storage engine +ERROR HY000: Got error 1478 "Unknown error: 1478" from storage engine ... -ERROR HY000: Out of resources when opening file '<partition file>' (Errcode: 24 - Too many open files) +ERROR HY000: Out of resources when opening file '<partition file>' (Errcode: 24 "Too many open files") I've narrowed it down. It is caused by revision 3414 monty(a)askmonty.org-20120529213755-876ptdhhaj0t7l8r. The revision adds %M modifier to error error messages, which prints "error number - system-error-text" into the error message (see strings/my_vsnprintf.c, my_strerror()). The problem is that system-error-text depends on the OS one is running. grep '%M' sql/share/errmsg-utf8.txt | grep 'eng ' | wc -l 27 There are currently 27 errors that use %M modifier in the error message The testsuite's .result files have only 5 of the errors, but there are lots of occurrences. Buildbot can get at least 3 variants of error message (Windows, Mac, Linux). I suppose, --replace_result will be too complex and fragile. We need to solve it somewhere else. My first idea was to: make mysql-test-run recognize error messages that have the %M pattern and remove the custom text, leaving the error code. To keep things simple/loosely coupled, I'd base recognition of error messages on list of patterns. I'm not sure where to keep the patterns and where to do the matching: should it be done inside mysql-test-run, or inside mysqltest.cc, or I should introduce some commands into mysqltest.cc that will make it apply rewrite rules to all error messages. Any ideas? -- BR Sergei -- Sergei Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

2 1