June 2011 - developers - lists.mariadb.org

[Maria-developers] MySQL Bug 59449 - Accepted by MariaDB?
by Jeremy Thomerson 21 Sep '11

21 Sep '11

I just submitted a patch to a MySQL bug that I am also experiencing. I would like to see it accepted into the wider community (MySQL, MariaDB, Percona, etc). Please let me know what I need to do so that this patch could also be accepted into your project. The bug is here: http://bugs.mysql.com/bug.php?id=59449 The "[11 Jun 3:16] Jeremy Thomerson" comment will be the most useful. Please CC me on any replies to this thread because I am not subscribed to this mailing list. Best Regards, Jeremy Thomerson

3 4

Re: [Maria-developers] [Commits] Rev 3067: Added progress reporting for alter table, LOAD DATA INFILE and for aria tables: check table, repair table, analyze table. in lp:maria/5.3
by Sergei Golubchik 05 Jul '11

05 Jul '11

Hi, Michael! On Jun 30, Michael Widenius wrote: > message: > Added progress reporting for alter table, LOAD DATA INFILE and for > aria tables: check table, repair table, analyze table. > - The client gets a progress report message that triggers a callback > function if requested with mysql_options(MYSQL_PROGRESS_CALLBACK, > function) > - Added Progress field last to 'show processlist' > - Stage, Max_stage and Progress field added to > information_schema.progresslist > - The 'mysql' client by defaults enables progress reports when the > output is a tty. > - Added progress_report_time time variable to configure how often > progress reports is sent to client > Added read only system variable 'in_transaction' which is 1 if we > have executed a BEGIN statement. > === modified file 'include/mysql/plugin.h' > --- a/include/mysql/plugin.h 2010-10-25 13:21:16 +0000 > +++ b/include/mysql/plugin.h 2011-06-30 12:23:49 +0000 > @@ -783,6 +784,21 @@ int thd_killed(const MYSQL_THD thd); > > > /** > + Report progress for long running operations (for information schema) > + > + @param thd User thread connection handle > + @param progress Where we are now > + @param max_progress Progress will continue up to this > +*/ > + > +void thd_progress_init(MYSQL_THD thd, unsigned int max_stage); > +void thd_progress_report(MYSQL_THD thd, > + unsigned long long progress, > + unsigned long long max_progress); > +void thd_progress_next_stage(MYSQL_THD thd); > +void thd_progress_end(MYSQL_THD thd); This should be implemented as a service. See libservices/HOWTO > + > +/** > Return the thread id of a user thread > > @param thd user thread connection handle > > === modified file 'mysql-test/r/create.result' > --- a/mysql-test/r/create.result 2011-05-16 11:05:45 +0000 > +++ b/mysql-test/r/create.result 2011-06-30 12:23:49 +0000 > @@ -1760,7 +1760,10 @@ t1 CREATE TABLE `t1` ( > `TIME` int(7) NOT NULL DEFAULT '0', > `STATE` varchar(64) DEFAULT NULL, > `INFO` longtext, > - `TIME_MS` decimal(22,3) NOT NULL DEFAULT '0.000' > + `TIME_MS` decimal(22,3) NOT NULL DEFAULT '0.000', > + `STAGE` tinyint(2) NOT NULL DEFAULT '0', > + `MAX_STAGE` tinyint(2) NOT NULL DEFAULT '0', > + `PROGRESS_DONE` decimal(7,3) NOT NULL DEFAULT '0.000' please run ./mtr --suite funcs_1 --ps-protocol and update test results accordingly. > ) DEFAULT CHARSET=utf8 > drop table t1; > create temporary table t1 like information_schema.processlist; > === modified file 'scripts/mytop.sh' > --- a/scripts/mytop.sh 2011-06-27 16:30:05 +0000 > +++ b/scripts/mytop.sh 2011-06-30 12:23:49 +0000 > @@ -17,6 +17,7 @@ use strict; > use DBI; > use Getopt::Long; > use Socket; > +use List::Util qw[min max]; conventionally one uses qw/.../ or qw(...) > $main::VERSION = "1.9a"; > > @@ -1075,21 +1076,22 @@ sub GetData() > ## Threads > ## > > - #my $sz = $width - 52; > - my @sz = (9, 9, 15, 10, 10, 6, 8); > + my @sz = (9, 8, 15, 9, 6, 5, 6, 8); do I understand correctly, that you've also committed other mytop bugfixes in this changeset? > my $used = scalar(@sz) + Sum(@sz); > - my $free = $width - $used; > - > + my $state= $width <= 80 ? 6 : int(min(6+($width-80)/3, 15)); > + my $free = $width - $used - ($state - 6); > + my $format= "%9s %8s %15s %9s %6s %5s %6s %${state}s %-.${free}s\n"; > + my $format2= "%9d %8.8s %15.15s %9.9s %6d %5.1f %6.6s %${state}.${state}s %-${free}.${free}s\n"; > print BOLD() if ($HAS_COLOR); > > - printf "%9s %9s %15s %10s %10s %6s %8s %-${free}s\n", > - 'Id','User','Host/IP','DB','Time', 'Cmd', 'State', 'Query'; > + printf $format, > + 'Id','User','Host/IP','DB','Time', '%', 'Cmd', 'State', 'Query'; > > print RESET() if ($HAS_COLOR); > > ## Id User Host DB > - printf "%9s %9s %15s %10s %10s %6s %8s %-.${free}s\n", > - '--','----','-------','--','----', '---', '-----', '----------'; > + printf $format, > + '--','----','-------','--','----', '-', '---', '-----', '----------'; > > $lines_left -= 2; > > === modified file 'sql-common/client.c' > --- a/sql-common/client.c 2011-03-18 15:03:43 +0000 > +++ b/sql-common/client.c 2011-06-30 12:23:49 +0000 > @@ -875,6 +886,29 @@ static void cli_flush_use_result(MYSQL * > } > > > +static void cli_report_progress(MYSQL *mysql, uchar *packet, uint length) > +{ > + if (mysql->options.extension && mysql->options.extension->report_progress && > + length > 5) you basically ignore the packet if length <= 5. Better report an error here. > + { > + uint stage, max_stage, proc_length; > + double progress; > + uchar *start= packet; > + > + packet++; /* Ignore number of strings */ > + stage= (uint) *packet++; > + max_stage= (uint) *packet++; > + progress= uint3korr(packet)/1000.0; > + packet+= 3; > + proc_length= net_field_length(&packet); > + if (packet + proc_length > start + length) > + return; /* Error packet */ same here. I am not sure I like the idea of silently ignoring bad packets. > + (*mysql->options.extension->report_progress)(mysql, stage, max_stage, > + progress, (char*) packet, > + proc_length); > + } > +} > + > #ifdef __WIN__ > static my_bool is_NT(void) > { > @@ -883,57 +917,6 @@ static my_bool is_NT(void) > } > #endif > > - > -#ifdef CHECK_LICENSE > -/** > - Check server side variable 'license'. > - > - If the variable does not exist or does not contain 'Commercial', > - we're talking to non-commercial server from commercial client. > - > - @retval 0 success > - @retval !0 network error or the server is not commercial. > - Error code is saved in mysql->net.last_errno. > -*/ > - > -static int check_license(MYSQL *mysql) > -{ > - MYSQL_ROW row; > - MYSQL_RES *res; > - NET *net= &mysql->net; > - static const char query[]= "SELECT @@license"; > - static const char required_license[]= STRINGIFY_ARG(LICENSE); > - > - if (mysql_real_query(mysql, query, sizeof(query)-1)) > - { > - if (net->last_errno == ER_UNKNOWN_SYSTEM_VARIABLE) > - { > - set_mysql_extended_error(mysql, CR_WRONG_LICENSE, unknown_sqlstate, > - ER(CR_WRONG_LICENSE), required_license); > - } > - return 1; > - } > - if (!(res= mysql_use_result(mysql))) > - return 1; > - row= mysql_fetch_row(res); > - /* > - If no rows in result set, or column value is NULL (none of these > - two is ever true for server variables now), or column value > - mismatch, set wrong license error. > - */ > - if (!net->last_errno && > - (!row || !row[0] || > - strncmp(row[0], required_license, sizeof(required_license)))) > - { > - set_mysql_extended_error(mysql, CR_WRONG_LICENSE, unknown_sqlstate, > - ER(CR_WRONG_LICENSE), required_license); > - } > - mysql_free_result(res); > - return net->last_errno; > -} > -#endif /* CHECK_LICENSE */ should be a separate changeset > @@ -3737,6 +3715,15 @@ mysql_options(MYSQL *mysql,enum mysql_op > case MYSQL_DEFAULT_AUTH: > extension_set_string(&mysql->options, default_auth, arg); > break; > + case MYSQL_PROGRESS_CALLBACK: > + if (!mysql->options.extension) > + mysql->options.extension= (struct st_mysql_options_extention *) > + my_malloc(sizeof(struct st_mysql_options_extention), > + MYF(MY_WME | MY_ZEROFILL)); > + if (mysql->options.extension) > + mysql->options.extension->report_progress= > + (void (*)(const MYSQL *, uint, uint, double, const char *, uint)) arg; > + break; please create a macro extension_set(), and rewrite extension_set_string() to use extension_set(). Something like #define extension_set(OPTS, X, VAL) \ if (!(OPTS)->extension) \ (OPTS)->extension= (struct st_mysql_options_extention *) \ my_malloc(sizeof(struct st_mysql_options_extention), \ MYF(MY_WME | MY_ZEROFILL)); \ (OPTS)->extension->X= VAL; #define extension_set_string(OPTS, X, STR) \ if ((OPTS)->extension) \ my_free((OPTS)->extension->X, MYF(MY_ALLOW_ZERO_PTR)); \ extension_set(OPTS, X, my_strdup((STR), MYF(MY_WME))); > default: > DBUG_RETURN(1); > } > > === modified file 'sql/protocol.cc' > --- a/sql/protocol.cc 2011-05-28 02:11:32 +0000 > +++ b/sql/protocol.cc 2011-06-30 12:23:49 +0000 > @@ -515,6 +515,52 @@ void net_end_statement(THD *thd) > } > > > +/** > + Send a progress report to the client > + > + What we send is: > + header (255,255,255,1) > + stage, max_stage as on byte integers > + % withing the stage as %*100000 as a 3 byte integer write "percentage" not "%". It only takes few more key presses to type the complete word, and is much more clear than printf-like %*100000 besides, in the packet you put percentage*1000 or ratio*100000, but not percentage*100000. > + proc_info as a string > +*/ > + > +const uchar progress_header[2]= {(uchar) 255, (uchar) 255 }; > + > +void net_send_progress_packet(THD *thd) > +{ > + uchar buff[200], *pos; > + const char *proc_info= thd->proc_info ? thd->proc_info : ""; > + uint length= strlen(proc_info); > + ulonglong progress; > + > + if (unlikely(!thd->net.vio)) > + return; // Socket is closed > + > + pos= buff; > + /* > + Store number of strings first. This allows us to later expand the > + progress indicator if needed. > + */ > + *pos++= (uchar) 1; // Number of strings > + *pos++= (uchar) thd->progress.stage + 1; > + /* > + We have the max() here to avoid problems if max_stage is not set, > + which may happen during automatic repair of table > + */ > + *pos++= (uchar) max(thd->progress.max_stage, thd->progress.stage + 1); > + progress= 0; > + if (thd->progress.max_counter) > + progress= 100000ULL * thd->progress.counter / thd->progress.max_counter; > + int3store(pos, progress); // Between 0 & 100000 > + pos+= 3; > + pos= net_store_data(pos, (const uchar*) proc_info, > + min(length, sizeof(buff)-7)); > + net_write_command(&thd->net, (uchar) 255, progress_header, 2, (uchar*) buff, better sizeof(progress_header) instead of a literal 2. > + (uint) (pos - buff)); > +} > + > + > /**************************************************************************** > Functions used by the protocol functions (like net_send_ok) to store > strings and numbers in the header result packet. > > === modified file 'sql/set_var.cc' > --- a/sql/set_var.cc 2011-06-11 09:04:42 +0000 > +++ b/sql/set_var.cc 2011-06-30 12:23:49 +0000 > @@ -527,6 +528,10 @@ static sys_var_thd_ulong sys_opti > static sys_var_thd_optimizer_switch sys_optimizer_switch(&vars, "optimizer_switch", > &SV::optimizer_switch); > > +static sys_var_long_ptr sys_progress_report_time(&vars, > + "progress_report_time", > + &opt_progress_report_time); this should be session local variable, not global. (as discussed on the phone) > @@ -997,6 +1002,12 @@ static sys_var_enum_const sys_plugin > &plugin_maturity, > &plugin_maturity_values); > > +static sys_var_readonly sys_in_transaction(&vars, "in_transaction", > + OPT_SESSION, SHOW_BOOL, > + in_transaction); > + > + > + this belongs to a separate changeset > bool sys_var::check(THD *thd, set_var *var) > { > var->save_result.ulonglong_value= var->value->val_int(); > @@ -3399,6 +3410,13 @@ static uchar *get_myisam_mmap_size(THD * > return (uchar *)&myisam_mmap_size; > } > > +static uchar *in_transaction(THD *thd) > +{ > + long tmp; // Not active > + tmp= test(thd->options & OPTION_BEGIN); better tmp= test(thd->server_status & SERVER_STATUS_IN_TRANS); > + thd->sys_var_tmp.my_bool_value= tmp; > + return (uchar*) &thd->sys_var_tmp.my_bool_value; > +} > > /**************************************************************************** > Main handling of variables: > > === modified file 'sql/sql_acl.cc' > --- a/sql/sql_acl.cc 2011-05-20 19:47:39 +0000 > +++ b/sql/sql_acl.cc 2011-06-30 12:23:49 +0000 > @@ -7478,7 +7478,7 @@ static ulong parse_client_handshake_pack > THD *thd= mpvio->thd; > NET *net= &thd->net; > char *end; > - > + ulonglong client_capabilities; why? client_capabilities are 32-bit, not 64. > DBUG_ASSERT(mpvio->status == MPVIO_EXT::FAILURE); > > if (pkt_len < MIN_HANDSHAKE_SIZE) > === modified file 'sql/sql_class.h' > --- a/sql/sql_class.h 2011-06-27 16:07:24 +0000 > +++ b/sql/sql_class.h 2011-06-30 12:23:49 +0000 > @@ -1551,6 +1551,17 @@ class THD :public Statement, > ulonglong prior_thr_create_utime, thr_create_utime; > ulonglong start_utime, utime_after_lock; > > + // Process indicator > + struct { > + /* Set to 1 if command should report progress to client for the command */ > + my_bool report_to_client; > + /* Internal: If we should report progress to client */ > + my_bool report; these comments are confusing. I could not understand from them what is the difference between report_to_client and report - both specify "if we should report progress to client". and why they are my_bool, not bool? > + uint stage, max_stage; > + ulonglong counter, max_counter; > + ulonglong last_report_time; > + } progress; > + > thr_lock_type update_lock_default; > Delayed_insert *di; > > === modified file 'sql/sql_table.cc' > --- a/sql/sql_table.cc 2011-06-27 16:07:24 +0000 > +++ b/sql/sql_table.cc 2011-06-30 12:23:49 +0000 > @@ -8015,8 +8018,10 @@ copy_data_between_tables(TABLE *from,TAB > HA_POS_ERROR) > goto err; > } > - }; > + thd_progress_next_stage(thd); > + } > > + thd_proc_info(thd, "copy to tmp table"); you need to document explicitly that stage name (that is sent over wire) may change any time, without changing the number of a stage. Which, I'd say, is not a very logical requirement, and it may be better not to change stage names in the middle of a stage. > /* Tell handler that we have values for all columns in the to table */ > to->use_all_columns(); > to->mark_virtual_columns_for_write(TRUE); > === modified file 'storage/maria/ha_maria.cc' > --- a/storage/maria/ha_maria.cc 2011-06-27 16:07:24 +0000 > +++ b/storage/maria/ha_maria.cc 2011-06-30 12:23:49 +0000 > @@ -711,6 +711,15 @@ int _ma_killed_ptr(HA_CHECK *param) > } > > > +void _ma_report_progress(HA_CHECK *param, ulonglong progress, > + ulonglong max_progress) > +{ > + thd_progress_report((THD*)param->thd, > + progress + max_progress * param->stage, > + max_progress * param->max_stage); why? I'd expect simple thd_progress_report((THD*)param->thd, progress, max_progress) explained on the phone. but this absolutely needs a comment here. > +} > + > + > void _ma_check_print_error(HA_CHECK *param, const char *fmt, ...) > { > va_list args; > @@ -1132,12 +1141,16 @@ int ha_maria::check(THD * thd, HA_CHECK_ > return HA_ADMIN_ALREADY_DONE; > > maria_chk_init_for_check(&param, file); > + old_proc_info= thd_proc_info(thd, "Checking table"); > + thd_progress_init(thd, 3); > (void) maria_chk_status(&param, file); // Not fatal > error= maria_chk_size(&param, file); > if (!error) > error|= maria_chk_del(&param, file, param.testflag); > + thd_progress_next_stage(thd); > if (!error) > error= maria_chk_key(&param, file); you forgot to set proc_info for a new stage (here, and above) > + thd_progress_next_stage(thd); > if (!error) > { > if ((!(param.testflag & T_QUICK) && > === modified file 'storage/maria/ma_sort.c' > --- a/storage/maria/ma_sort.c 2011-01-11 13:36:41 +0000 > +++ b/storage/maria/ma_sort.c 2011-06-30 12:23:49 +0000 > @@ -1066,6 +1087,8 @@ merge_index(MARIA_SORT_PARAM *info, uint > if (merge_buffers(info,keys,tempfile,(IO_CACHE*) 0,sort_keys,buffpek,buffpek, > buffpek+maxbuffer)) > DBUG_RETURN(1); /* purecov: inspected */ > + if (info->sort_info->param->max_stage != 1) /* If not parallel */ > + _ma_report_progress(info->sort_info->param, 1, 1); > DBUG_RETURN(0); > } /* merge_index */ would be nice if you'd copied these changes into MyISAM too. > === modified file 'tests/mysql_client_test.c' > --- a/tests/mysql_client_test.c 2011-06-07 16:13:02 +0000 > +++ b/tests/mysql_client_test.c 2011-06-30 12:23:49 +0000 > @@ -309,7 +309,8 @@ mysql_simple_prepare(MYSQL *mysql_arg, c > > @return pointer to initialized and connected MYSQL object > */ > -static MYSQL* client_connect(ulong flag, uint protocol, my_bool auto_reconnect) > +static MYSQL* client_connect(ulonglong flag, uint protocol, flags fit in 32 bits, no need to change to ulonglong > + my_bool auto_reconnect) > { > MYSQL* mysql; > int rc; Regards, Sergei

3 2

[Maria-developers] WL#229 New (by Monty): Multiple InnoDB Buffer pools
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Multiple InnoDB Buffer pools CREATION DATE..: Thu, 30 Jun 2011, 18:16 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-BackLog TASK ID........: 229 (http://askmonty.org/worklog/?tid=229) VERSION........: Server-5.7 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Innodb multiple buffer pools, but size of each, and to which pool will a page go configured by the dba (instead of random/hash as in 5.5, at table level) ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#228 New (by Monty): Dynamic ENUM
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Dynamic ENUM CREATION DATE..: Thu, 30 Jun 2011, 18:13 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-BackLog TASK ID........: 228 (http://askmonty.org/worklog/?tid=228) VERSION........: Server-5.7 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 200 (hours remain) ORIG. ESTIMATE.: 200 PROGRESS NOTES: DESCRIPTION: Create a ENUM-type like data type that does string compression (at a scale). For example, create a type LOOKUP(255) CHARSET utf8. We store browser user-agent strings here, you store bigint unsigned numbers internally, and create a lookup structure so that each occurrence of a string is physically stored only once. Convert from VARCHAR to LOOKUP using ALTER TABLE. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#227 New (by Monty): Add a time types that contains timezone
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Add a time types that contains timezone CREATION DATE..: Thu, 30 Jun 2011, 18:11 SUPERVISOR.....: Monty IMPLEMENTOR....: Sergei COPIES TO......: CATEGORY.......: Server-BackLog TASK ID........: 227 (http://askmonty.org/worklog/?tid=227) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 160 (hours remain) ORIG. ESTIMATE.: 160 PROGRESS NOTES: DESCRIPTION: Create DATE_TZ, TIME_TZ, DATETIME_TZ and TIMESTAMP_TZ types. Relegate the timezone in a session to the same function as the charset in a session ('this is what the client uses') and convert accordingly. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#226 New (by Monty): Replace the MYISAM mysql.* tables with Aria / XtraDB
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Replace the MYISAM mysql.* tables with Aria / XtraDB CREATION DATE..: Thu, 30 Jun 2011, 18:06 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-BackLog TASK ID........: 226 (http://askmonty.org/worklog/?tid=226) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 120 (hours remain) ORIG. ESTIMATE.: 120 PROGRESS NOTES: DESCRIPTION: Replace the MYISAM mysql.* tables with Aria / XtraDB We need to get these files crash safe. There is some unknown (for me) reasons why it's hard to use XtraDB for these tables. Using crash safe Aria tables should however be possible. To use Aria, we should first fix that one can use aria_chk to change page size for Aria tables, as otherwise there will be problems with the system tables if one want's to change the aria page size. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#225 New (by Monty): Cache VIEW's
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Cache VIEW's CREATION DATE..: Thu, 30 Jun 2011, 17:58 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-BackLog TASK ID........: 225 (http://askmonty.org/worklog/?tid=225) VERSION........: Server-5.7 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 40 (hours remain) ORIG. ESTIMATE.: 40 PROGRESS NOTES: DESCRIPTION: Views are read from file and parsed for every access. We should fix this in two stages: This task: Cache the VIEW file in memory (easy task) Later: Store a pre-parsed view in memory (hard task) ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#224 New (by Monty): Handle milions of users & roles.
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Handle milions of users & roles. CREATION DATE..: Thu, 30 Jun 2011, 17:54 SUPERVISOR.....: Sergei IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-BackLog TASK ID........: 224 (http://askmonty.org/worklog/?tid=224) VERSION........: Server-5.7 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: The database should be able to work fine with one million users, one million roles. Do not keep all data in memory, load the required info on login into a cache (size changeable without restart). On login, load the requested data, if it is not in cache already. Example: SET GLOBAL USERNAME_CACHE = 1000000; SET GLOBAL ROLE_CACHE = 1000000; ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#223 New (by Monty): Handle millions of tables (add dictionary)
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Handle millions of tables (add dictionary) CREATION DATE..: Thu, 30 Jun 2011, 17:48 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 223 (http://askmonty.org/worklog/?tid=223) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 200 (hours remain) ORIG. ESTIMATE.: 200 PROGRESS NOTES: DESCRIPTION: Information_schema falls apart when there is millions of tables. Fix is to add a table dictionary of the existing files into a mysql.dict file and use this instead of the file system to return information schema queries that doesn't require a table to be opened. When we try to access a table that doesn't exists in the dictionary, we should open it to see if the .frm file exists and if yes, add it to the dictionary. In a similar fashion, if a table that should exist doesn't, we should remove it from the dictionary. We would also need a refresh command to update the dict from the .frm file (to be used if one copies a table over an old table with different information). ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#222 New (by Monty): Make all innodb variables changeable without server restart
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Make all innodb variables changeable without server restart CREATION DATE..: Thu, 30 Jun 2011, 17:41 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 222 (http://askmonty.org/worklog/?tid=222) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Make all XtraDB variables changeable without server restart. "About every second innodb config change requires a server restart to be picked up" ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#221 New (by Monty): move InnoDB data files between servers
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: move InnoDB data files between servers CREATION DATE..: Thu, 30 Jun 2011, 17:34 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 221 (http://askmonty.org/worklog/?tid=221) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Add ALTER TABLE ... DETACH/ATTACH commands (or similar) to XtraDB/InnoDB to allow one to easily copy tables between servers. (Aria can already do this) ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#220 New (by Monty): Dissallow table scan in SELECT
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Dissallow table scan in SELECT CREATION DATE..: Thu, 30 Jun 2011, 17:28 SUPERVISOR.....: Monty IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 220 (http://askmonty.org/worklog/?tid=220) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 16 (hours remain) ORIG. ESTIMATE.: 16 PROGRESS NOTES: DESCRIPTION: Add a variable SQL_FORCE_INDEX_USAGE= 0 | 1 | 2 0 is normal. 1 would give an error if you are not specifying a usable index for all tables. It would still allow MariaDB to do a table scan if that's the best method. 2 Give an error for any SELECT's that would use a table scan on a normal (not internal temporary) table. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#219 New (by Monty): Query statistics
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Query statistics CREATION DATE..: Thu, 30 Jun 2011, 17:08 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 219 (http://askmonty.org/worklog/?tid=219) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 120 (hours remain) ORIG. ESTIMATE.: 120 PROGRESS NOTES: DESCRIPTION: Log skeletons for queries in server (live from parser) but without constants with statistics. Things to consider: * Should use a fixed memory size. Queries should be removed as FIFO * Small CPU overhead * IN(a,b,c) should be equal recorded as IN(#) (One constant) * multi row inserts needs to be handled as one insert. We also need a method to do regular expression replacement for table names. This is needed to be able to recognize similar tables like log tables with a _YYMMDD prefix. Statistics to collect per query: - Number of times executed - Total time executed (in microseconds) - Rows read, inserted, updated and deleted. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#218 New (by Monty): Better EXPLAIN
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Better EXPLAIN CREATION DATE..: Thu, 30 Jun 2011, 16:58 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 218 (http://askmonty.org/worklog/?tid=218) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: This is a master task for all tasks that makes EXPLAIN better. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#217 New (by Monty): Get list of active GET_LOCK
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Get list of active GET_LOCK CREATION DATE..: Thu, 30 Jun 2011, 16:51 SUPERVISOR.....: Monty IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 217 (http://askmonty.org/worklog/?tid=217) VERSION........: Server-5.6 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 16 (hours remain) ORIG. ESTIMATE.: 16 PROGRESS NOTES: DESCRIPTION: Add a command SHOW GET_LOCKS to show all active GET_LOCK commands. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#216 New (by Monty): Make aria_pack an internal command in mysqld
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Make aria_pack an internal command in mysqld CREATION DATE..: Thu, 30 Jun 2011, 16:45 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 216 (http://askmonty.org/worklog/?tid=216) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 40 (hours remain) ORIG. ESTIMATE.: 40 PROGRESS NOTES: DESCRIPTION: Make aria_pack an internal command in mysqld Add the aria_pack source inside mysqld and add a new handler commands 'compress table' and 'uncompress table' ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#215 New (by Monty): Add functional indexes
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Add functional indexes CREATION DATE..: Thu, 30 Jun 2011, 16:17 SUPERVISOR.....: Monty IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 215 (http://askmonty.org/worklog/?tid=215) VERSION........: Server-5.6 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 200 (hours remain) ORIG. ESTIMATE.: 200 PROGRESS NOTES: DESCRIPTION: Add support for functional indexes. This is needed for MWL#34 Dynamic columns. The idea would be to extend the handler interface with a callback function that provides the handler with a key in normal key-read format of the index entry. In addition we need to enhance the optimizer to recognize the function used for the functional index parts so that it can use the index. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#214 New (by Monty): Make Indexes first level objects
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Make Indexes first level objects CREATION DATE..: Thu, 30 Jun 2011, 16:11 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Maria-RawIdeaBin TASK ID........: 214 (http://askmonty.org/worklog/?tid=214) VERSION........: Server-5.3 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: An index should be able to exist as an object that is not tied to a physical table. That would allow for indexes that are global to a > partition, and for functional indexes or indexes on virtual columns. The above is extremely hard to do as Indexes are very closely tied to storage engines. What is easier to do is to do functional indexes, where the storage engine will ask MySQL for the index data for a row. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#213 New (by Monty): Run SP on binary log rotation
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Run SP on binary log rotation CREATION DATE..: Thu, 30 Jun 2011, 16:03 SUPERVISOR.....: Knielsen IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 213 (http://askmonty.org/worklog/?tid=213) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: On binlog rotation, run a SP asynchronously (for example to run a shell command to copy/compress the binary logs) Provide sufficient environmental data to the SP (binlog names old and new, binlog position for old and new log, etc). ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#212 New (by Monty): Compressed binary log
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Compressed binary log CREATION DATE..: Thu, 30 Jun 2011, 15:34 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 212 (http://askmonty.org/worklog/?tid=212) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 80 (hours remain) ORIG. ESTIMATE.: 80 PROGRESS NOTES: DESCRIPTION: Compress the binary log to make it smaller. The following options exists: a) Compress old binary log when they are not in use. On access from delayed slave, decompress it from start to memory and feed the slave the data from the uncompressed stream. b) Compress each binary log event separately with a format: <length><data>. Ship the binary log in the compressed format. I assume that b) is much easier to do. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#211 New (by Monty): conflict resolution for RBR replication
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: conflict resolution for RBR replication CREATION DATE..: Thu, 30 Jun 2011, 15:28 SUPERVISOR.....: Knielsen IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 211 (http://askmonty.org/worklog/?tid=211) VERSION........: Server-5.3 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: In RBR, when there is any kind of RBR problem, call a SP. The SP gets all required data made available somehow, can define a resolution policy. 4 Outcomes: Choose old, choose new, fail (error) and synthesize (merge) new row. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#210 New (by Monty): Make all replication variables changeable without server restart
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Make all replication variables changeable without server restart CREATION DATE..: Thu, 30 Jun 2011, 15:17 SUPERVISOR.....: IMPLEMENTOR....: Knielsen COPIES TO......: CATEGORY.......: Server-Sprint TASK ID........: 210 (http://askmonty.org/worklog/?tid=210) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Make all replication variables changeable without server restart. This requires some work as there is many variables and some variables require more work than others. Here we will list the variables in priority order that should be made changeable. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#209 New (by Monty): Setting up a new slave easily
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Setting up a new slave easily CREATION DATE..: Thu, 30 Jun 2011, 15:12 SUPERVISOR.....: Knielsen IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 209 (http://askmonty.org/worklog/?tid=209) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: The current procedure to setup a slave is: * mylvmbackup (or similar snapshot) on a slave * restore it to a new box * recover InnoDB * connect it to the master. We'd like to have a command that can be issues to an empty database, will download the data from a master (or a co-slave), and then attach the new slave to the master (using the configuration provided on the command line or by the co-slave). Requirements: * Should be done at SQL level. * With progress report. * The data should move at disk speed; No index creation, ship binary index data from the co-slave or master. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#208 New (by Monty): Replicate ALTER TABLE in parallel
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Replicate ALTER TABLE in parallel CREATION DATE..: Thu, 30 Jun 2011, 14:55 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 208 (http://askmonty.org/worklog/?tid=208) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 80 (hours remain) ORIG. ESTIMATE.: 80 PROGRESS NOTES: DESCRIPTION: Replicate ALTER TABLE in parallel For ALTER TABLES on the slave we could start another thread to do the ALTER TABLE while the replication thread continues. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#202 New (by Monty): Extend progress reporting
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Extend progress reporting CREATION DATE..: Thu, 30 Jun 2011, 11:04 SUPERVISOR.....: Monty IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 202 (http://askmonty.org/worklog/?tid=202) VERSION........: Server-5.3 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 80 (hours remain) ORIG. ESTIMATE.: 80 PROGRESS NOTES: DESCRIPTION: MariaDB 5.3 supports progress reporting for ALTER TABLE and some other comands. See http://kb.askmonty.org/en/progress-reporting The task is to expand this to other commands and storage engines. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

3 7

[Maria-developers] WL#207 New (by Monty): Replicate LOAD DATA INFILE 'out of band'
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Replicate LOAD DATA INFILE 'out of band' CREATION DATE..: Thu, 30 Jun 2011, 14:47 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 207 (http://askmonty.org/worklog/?tid=207) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 80 (hours remain) ORIG. ESTIMATE.: 80 PROGRESS NOTES: DESCRIPTION: Adding support for replication some LOAD DATA INFILE commands 'out of band' The problem to solve is to allow upload of large new tables to slaves, without having the data downloading stop the normal replication stream. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#206 New (by Monty): Parallel replication
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Parallel replication CREATION DATE..: Thu, 30 Jun 2011, 14:29 SUPERVISOR.....: Knielsen IMPLEMENTOR....: Knielsen COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 206 (http://askmonty.org/worklog/?tid=206) VERSION........: Server-5.3 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: This is a master task for all tasks that makes replication more parallel ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#205 New (by Monty): DELETE with result set
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: DELETE with result set CREATION DATE..: Thu, 30 Jun 2011, 14:13 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 205 (http://askmonty.org/worklog/?tid=205) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 40 (hours remain) ORIG. ESTIMATE.: 40 PROGRESS NOTES: DESCRIPTION: Add a DELETE operations that returns a result set of the deleted rows to the client. Suggested syntax: The DB2 syntax: DELETE from (SELECT column_list from single_table WHERE ... ORDER BY) another option would be DELETE FROM table_name WHERE ... [LIMIT #]] SELECT expression_list but I think that the first syntax is more clear. It's also easier to expand it to handle multiple tables. Oracle supports the following syntax: DELETE <table or expression> <alias> WHERE <where_clause> RETURNING <exprs> INTO <data_items> but this is not useful as it can only be used to record single row deletes. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#204 New (by Monty): Add audit information to the bnary log
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Add audit information to the bnary log CREATION DATE..: Thu, 30 Jun 2011, 13:06 SUPERVISOR.....: Monty IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 204 (http://askmonty.org/worklog/?tid=204) VERSION........: WorkLog-4.0 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: Add audit information to the binary log. As the audit information takes extra place, this should be done conditionally on the master. The audit information should be printed by mysqlbinlog -v -v The slave should just skip the audit information. ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] WL#203 New (by Monty): Add efficient support for BLOB and VARCHAR to HEAP/MEMORY
by worklog-noreply＠askmonty.org 30 Jun '11

30 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Add efficient support for BLOB and VARCHAR to HEAP/MEMORY CREATION DATE..: Thu, 30 Jun 2011, 11:41 SUPERVISOR.....: Monty IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 203 (http://askmonty.org/worklog/?tid=203) VERSION........: Server-5.3 STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 60 (hours remain) ORIG. ESTIMATE.: 60 PROGRESS NOTES: DESCRIPTION: Add efficient support for BLOB and VARCHAR to the HEAP/MEMORY engine. Requirements: * Should work for all MEMORY tables (no requirement of field order) * Should work for internal memory tables. * Low overhead for not changed rows. * Fixed storage size (as now) for total size of MEMORY TABLE. Should be optimized for insert and select (most common operations for internal temporary tables). ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] Philip please test: Duplicate Elimination for outer joins + semi joins
by Sergey Petrunya 30 Jun '11

30 Jun '11

Hello Philip, I'd like to get the tree at lp:~maria-captains/maria/5.3-subqueries-mwl90 tested for Duplicate Elimination with outer+semi-join processing. I'm interested in crashes, as well as wrong query result bugs. The code path that needs to be tested is selected with this @@optimizer_switch setting: semijoin=on,materialization=off,firstmatch=off,loosescan=off this set of switches disables all semi-join subquery strategies except DuplicateElimination, so you should have no problem with hitting the If you also set "semijoin=off" then you get the execution path that we assume will always produce correct results. Query pattern SELECT .... FROM complex_join WHERE top_where AND (SELECT ... FROM complex_join WHERE ...) where - subqueries must be "mergeable semi-joins": = no aggregates, unions, or ORDER BYs - both correlated and ucorrelated subqueries are OK. - complex_join is arbitrary join structure (comma join, "t1 JOIN t2", various kinds of outer joins - everything should work) - multiple sibling subqueries, as well as nested subqueries are covered by what you're testing. EXPLAIN - Should have id=='1' && select_type='PRIMARY' on all lines. - Should use Start Temporary/End temporary. BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

2 2

Re: [Maria-developers] [Commits] Rev 2983: WL#77 - INSTALL PLUGIN * in http://bazaar.launchpad.net/~maria-captains/maria/5.2/
by Alexey Botchkov 29 Jun '11

29 Jun '11

I'm fine with this last patch. One thing i can think of is if we should add a new error instead of adding static english texts to the ER_CANT_OPEN_LIBRARY like 'API version for ... plugin ... not supported'. Second question if we should have INSTALL PLUGIN ... IF NOT INSTALLED; to be even more user-friendly. Regards HF 17.06.2011 21:49, serg(a)askmonty.org wrote: > At http://bazaar.launchpad.net/~maria-captains/maria/5.2/ >

1 0

[Maria-developers] MariaDB 5.3 docs
by Daniel Bartholomew 29 Jun '11

29 Jun '11

All, We're getting closer to the first beta release of MariaDB 5.3 and several of the new features have been documented in the Knowledgebase and linked to from this page: http://kb.askmonty.org/en/what-is-mariadb-53 What I don't know is if there are any features which have either: 1. not been documented in the Knowledgebase at all, -or- 2. been incompletely documented in the Knowledgebase but not added to the above page, -or- 3. been added to the page but incompletely documented. If you have worked on 5.3, please review the above page to make sure the items you worked on are present and fully documented. If they aren't please document them in the Knowledgebase and add them to the above page (or send me enough information about them so that I can document them). If they are present, but inadequately documented, please add what is missing or let me know what is missing. Don't worry about your documentation being perfect, I will clean it up. If you need any help, please contact me via email or on IRC. Thanks. -- Daniel Bartholomew MariaDB - http://mariadb.org Monty Program - http://montyprogram.com AskMonty Knowledgebase - http://kb.askmonty.org

2 2

[Maria-developers] Proposal to split @@optimizer_switch
by Sergey Petrunya 28 Jun '11

28 Jun '11

Hello, Please find below descriptions of problems with current @@optimizer_switch variable, as well as a proposal on how to fix it. <contents> Problems with @@optimizer_switch Proposed solution Details about hooking this into parser Alternate approach1: grouping </contents> Problems with @@optimizer_switch -------------------------------- @@optimizer_switch variable use has outgrown its syntax. There are too many settings to fit on the single line: MariaDB [(none)]> select @@optimizer_switch; +-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | @@optimizer_switch | +-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | index_merge=on,index_merge_union=on,index_merge_sort_union=on,index_merge_intersection=on,index_merge_sort_intersection=off,index_condition_pushdown=on,firstmatch=on,loosescan=on,materialization=off,in_to_exists=on,semijoin=on,partial_match_rowid_merge=on,partial_match_table_scan=on,subquery_cache=on,mrr=on,mrr_cost_based=off,mrr_sort_keys=on,outer_join_with_cache=off,semijoin_with_cache=off,join_cache_incremental=on,join_cache_hashed=on,join_cache_bka=on,optimize_join_buffer_size=on,table_elimination=on | +-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.00 sec) The line is now 510 characters long. It's hard to find the flag you're looking for, and one needs to write regular expressions if they want to check the value of a particular flag in some program. There is no easy way to get settings for a subset of flags (which means we've banned "select @@optimizer_switch" from almost all .test files, because one had to change .result file all the time) The extra-long line also gets into "SHOW VARIABLES" output, and makes it hard-to-read, too. The situation is going to get worse, as we've already committed to adding even to add even more switches (Igor's patch adds some, then we've decided that two semi-join optimizations that do not have their switches, should have them) The benefits of having all settings grouped together are: - It was easy to implement - One can easily see all optimizer switches without having to fish them out of the list of all server variables. - One can reset all optimizer settings with a single statement: SET @@optimizer_switch=default Proposed solution ----------------- Break optimizer_switch into multiple variables, with names having the dots in them. That is, current @@optimizer_switch flags will change into this set of variables: optimizer.index_merge=on optimizer.index_merge.union=on optimizer.index_merge.sort_union=on optimizer.index_merge.intersection=on optimizer.index_merge.sort_intersection=off optimizer.index_condition_pushdown=on optimizer.join_cache.bka=on optimizer.join_cache.hashed=on optimizer.join_cache.incremental=on optimizer.join_cache.optimize_buffer_size=on optimizer.join_cache.outer_join=off optimizer.join_cache.semijoin=off optimizer.mrr=on optimizer.mrr.cost_based=off optimizer.mrr.sort_keys=on optimizer.semijoin=on optimizer.semijoin.firstmatch=on optimizer.semijoin.loosescan=on optimizer.subquery.cache=on optimizer.subquery.in_to_exists=on optimizer.subquery.materialization=off optimizer.subquery.partial_match_rowid_merge=on optimizer.subquery.partial_match_table_scan=on optimizer.table_elimination=on The dots are there so that - the structuring is more apparent - it is possible to reset groups of variables to their defaults. Current idea is to use syntax like this: SET optimizer.semijoin.*= default; - in the future we may also allow to select and set groups of settings. Details about hooking this into parser ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Currently, dotted syntax is allowed to some extent: we allow - GLOBAL/SESSION/DEFAULT prefix for any variable - key_cache_name prefix for multiple named key caches. There is one key cache named default, it is not possible to make a key cache named "session". To make variable lookup rules easy, we will diallow creation/use of key caches named 'optimizer'. Overall, system variables can be encountered - as part of @@variable syntax when their value is selected - as part of SET statement. in both cases, bison can easily see it's parsing a system variable name, so I was able to add support for dotted variable syntax into the parser without introducing any extra conflicts. Alternate approach1: grouping ----------------------------- (Suggested by Igor (or was it Timour?)) Replace one @@optimizer_switch variable with multiple: @@optimizer_switch_semijoin @@optimizer_switch_mrr .. and so forth. The advantage of this approach is that it's easy and we don't need to change the parser. The disadavantage is that it may turn out that groups of flags may be still too big, and so either look ugly or require further splits. BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

4 9

Re: [Maria-developers] [Commits] Rev 3062: Fixed bug lp:800679 in file:///home/tsk/mprog/src/5.3-mwl89/
by Sergey Petrunya 28 Jun '11

28 Jun '11

Hi Timour, Ok to push. On Mon, Jun 27, 2011 at 05:40:25PM +0300, timour(a)askmonty.org wrote: > At file:///home/tsk/mprog/src/5.3-mwl89/ > > ------------------------------------------------------------ > revno: 3062 > revision-id: timour(a)askmonty.org-20110627144014-r14ahro6uzf77423 > parent: igor(a)askmonty.org-20110625210227-kdneawayskx5jl4q > fixes bug(s): https://launchpad.net/bugs/800679 > committer: timour(a)askmonty.org > branch nick: 5.3-mwl89 > timestamp: Mon 2011-06-27 17:40:14 +0300 > message: > Fixed bug lp:800679 > > Analysis: > The failed assert ensured that the choice of subquery strategy > is performed only for queries with at least one table. If there > is a LIMIT 0 clause all tables are removed, and the subquery is > neither optimized, nor executed during actual optimization. However, > if the query is EXPLAIN-ed, the EXPLAIN execution path doesn't remove > the query tables if there is a LIMIT 0 clause. As a result, the > subquery optimization code is called, which violates the ASSERT > condition. > > Solution: > Transform the assert into a condition, and if the outer query > has no tables assume that there will be at most one subquery > execution. > > There is potentially a better solution by reengineering the > EXPLAIN/optimize code, so that subquery optimization is not > done if not needed. Such a solution would be a lot bigger and > more complex than a bug fix. > === modified file 'mysql-test/r/subselect_mat_cost_bugs.result' > --- a/mysql-test/r/subselect_mat_cost_bugs.result 2011-06-05 02:56:06 +0000 > +++ b/mysql-test/r/subselect_mat_cost_bugs.result 2011-06-27 14:40:14 +0000 > @@ -295,3 +295,24 @@ id select_type table type possible_keys > select c1 from t1 where c1 in (select kp1 from t2 where kp2 = 10 and c2 = 4) or c1 > 7; > c1 > drop table t1, t2; > +# > +# LP BUG#800679: Assertion `outer_join->table_count > 0' failed in > +# JOIN::choose_subquery_plan() with materialization=on,semijoin=off > +# > +CREATE TABLE t1 ( f1 int); > +insert into t1 values (1),(2); > +CREATE TABLE t2 ( f1 int); > +insert into t2 values (1),(2); > +SET @@optimizer_switch='materialization=on,semijoin=off'; > +EXPLAIN > +SELECT * FROM t1 > +WHERE (f1) IN (SELECT f1 FROM t2) > +LIMIT 0; > +id select_type table type possible_keys key key_len ref rows Extra > +1 PRIMARY NULL NULL NULL NULL NULL NULL NULL Impossible WHERE > +2 DEPENDENT SUBQUERY t2 ALL NULL NULL NULL NULL 2 Using where > +SELECT * FROM t1 > +WHERE (f1) IN (SELECT f1 FROM t2) > +LIMIT 0; > +f1 > +drop table t1, t2; > > === modified file 'mysql-test/t/subselect_mat_cost_bugs.test' > --- a/mysql-test/t/subselect_mat_cost_bugs.test 2011-05-23 07:56:05 +0000 > +++ b/mysql-test/t/subselect_mat_cost_bugs.test 2011-06-27 14:40:14 +0000 > @@ -326,3 +326,26 @@ select c1 from t1 where c1 in (select kp > select c1 from t1 where c1 in (select kp1 from t2 where kp2 = 10 and c2 = 4) or c1 > 7; > > drop table t1, t2; > + > +--echo # > +--echo # LP BUG#800679: Assertion `outer_join->table_count > 0' failed in > +--echo # JOIN::choose_subquery_plan() with materialization=on,semijoin=off > +--echo # > + > +CREATE TABLE t1 ( f1 int); > +insert into t1 values (1),(2); > +CREATE TABLE t2 ( f1 int); > +insert into t2 values (1),(2); > + > +SET @@optimizer_switch='materialization=on,semijoin=off'; > + > +EXPLAIN > +SELECT * FROM t1 > +WHERE (f1) IN (SELECT f1 FROM t2) > +LIMIT 0; > + > +SELECT * FROM t1 > +WHERE (f1) IN (SELECT f1 FROM t2) > +LIMIT 0; > + > +drop table t1, t2; > > === modified file 'sql/opt_subselect.cc' > --- a/sql/opt_subselect.cc 2011-06-21 13:00:41 +0000 > +++ b/sql/opt_subselect.cc 2011-06-27 14:40:14 +0000 > @@ -4358,7 +4358,7 @@ bool JOIN::choose_subquery_plan(table_ma > by the IN predicate. > */ > outer_join= unit->outer_select() ? unit->outer_select()->join : NULL; > - if (outer_join) > + if (outer_join && outer_join->table_count > 0) > { > /* > The index of the last JOIN_TAB in the outer JOIN where in_subs is > @@ -4371,7 +4371,6 @@ bool JOIN::choose_subquery_plan(table_ma > JOIN_TAB, and their join_tab_idx remains MAX_TABLES. Such predicates > are evaluated for each complete row of the outer join. > */ > - DBUG_ASSERT(outer_join->table_count > 0); > max_outer_join_tab_idx= (in_subs->get_join_tab_idx() == MAX_TABLES) ? > outer_join->table_count - 1: > in_subs->get_join_tab_idx(); > > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits -- BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

1 0

[Maria-developers] can "set read_only" be non-blocking?
by MARK CALLAGHAN 27 Jun '11

27 Jun '11

It can be dangerous for us to run "set read_only" on a production server because it can block in close_cached_tables. More details about the pain this caused at a previous job are at: http://mysqlha.blogspot.com/2008/07/what-exactly-does-flush-tables-with.html Per the code in set_var.cc: /* Perform a 'FLUSH TABLES WITH READ LOCK'. This is a 3 step process: - [1] lock_global_read_lock() - [2] close_cached_tables() - [3] make_global_read_lock_block_commit() [1] prevents new connections from obtaining tables locked for write. [2] waits until all existing connections close their tables. [3] prevents transactions from being committed. */ Can there be a variant that doesn't do #2? My workload doesn't use MyISAM and I don't know if #2 is done because of MyISAM. Calling close_cached_tables seems like a heavy way to force LOCK TABLEs to be unlocked. Any long running queries will cause #2 to block. -- Mark Callaghan mdcallag(a)gmail.com

2 4

Re: [Maria-developers] [Commits] Rev 3062: Fixed LP bug #801536. in file:///home/igor/maria/maria-5.3-merge-tmp/
by Timour Katchaounov 27 Jun '11

27 Jun '11

Igor, Ok to push in the sense that the new patch cannot any more result in overflow. Both the old and new code are not equivalent. Given there is no comment, I cannot fully understand whether the change produces at least as good estimate of the record length as the old patch. Could you please add some general comment to the whole function how do we compute the field length. Timour On 27.06.2011 07:55, Igor Babaev wrote: > At file:///home/igor/maria/maria-5.3-merge-tmp/ > > ------------------------------------------------------------ > revno: 3062 > revision-id: igor(a)askmonty.org-20110627045532-663o9eih0flql0n6 > parent: igor(a)askmonty.org-20110625210227-kdneawayskx5jl4q > committer: Igor Babaev<igor(a)askmonty.org> > branch nick: maria-5.3-merge-tmp > timestamp: Sun 2011-06-26 21:55:32 -0700 > message: > Fixed LP bug #801536. > Ensured valid calculations of the estimates stored in JOIN_TAB::used_fieldlength. >

1 0

[Maria-developers] WL#201 New (by Knielsen): Multi-source replication
by worklog-noreply＠askmonty.org 23 Jun '11

23 Jun '11

----------------------------------------------------------------------- WORKLOG TASK -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- TASK...........: Multi-source replication CREATION DATE..: Thu, 23 Jun 2011, 12:50 SUPERVISOR.....: IMPLEMENTOR....: COPIES TO......: CATEGORY.......: Server-RawIdeaBin TASK ID........: 201 (http://askmonty.org/worklog/?tid=201) VERSION........: Server-9.x STATUS.........: Un-Assigned PRIORITY.......: 60 WORKED HOURS...: 0 ESTIMATE.......: 0 (hours remain) ORIG. ESTIMATE.: 0 PROGRESS NOTES: DESCRIPTION: This worklog is about implementing a way for a MariaDB replication slave to replicate from more than one master simultaneously. Each master is handled by a specific replicator instance in the slave server. Each replicator instance consists of separate I/O thread, SQL thread, and associated state and configuration. In efffect, several replication slaves are running at the same time, each replicating from a separate master, but all replicating into a common data store (typically, but not necessarily to separate databases/tables). A replicator instance is identified with a user-chosen name used in replication SQL statements such as CHANGE MASTER TO ... This name is also included in file names to distinguish the files that keep the replication state (relay logs, master.info, relay-log.info). This way, each separate instance can be configured separately, but otherwise the same way as existing single-source replication. In order to remain backwards-compatible with existing third-party scripts etc., the replicator instance name is made optional in all existing replication statements. If it is omitted, the name "default" is used, and for this particular name, master.info and the other files retain their old names to allow seamless upgrades of slaves. In this worklog, there is no extra conflict resolution proposed. The effect of updates from one master on replication from another master will be the same as the effect of direct user SQL queries on the slave server, ie. it is the responsibility of the user/DBA to ensure no conflicts occur. If a conflict causes replication of an event to fail (with duplicate key violation eg.), the corresponding slave SQL thread will stop, requiring manual intervention to fix and start. An easy and typical way to avoid conflicts would be to eg. to use separate databases for each master->slave replication channel. RBR idempotent slave application can also be used to help resolve conflicts, for example. See also MySQL WL#1697: http://forge.mysql.com/worklog/task.php?id=1697 ESTIMATED WORK TIME ESTIMATED COMPLETION DATE ----------------------------------------------------------------------- WorkLog (v4.0.0)

1 0

[Maria-developers] 5.5 merge: sql_select.cc
by Sergei Golubchik 23 Jun '11

23 Jun '11

Hi. Here I'll list changesets that cause conflicts and ask what to do. 1. http://tinyurl.com/63tey39 vs. http://tinyurl.com/5v2pluf it's a fix for bug#49322. both changes are similar, return is moved down. But Igor put it after the while() loop, while Ole John - in the loop, as soon a non-match is found. What difference does it make, I mean the earlier return, what consequences? 2. http://tinyurl.com/69lwrp9 - a big chunk is moved around in test_if_skip_sort_order() that's all, the rest of the file I've merged already. Regards, Sergei

3 2

[Maria-developers] forwarded message from Kristian Köhntopp
by Michael Widenius 22 Jun '11

22 Jun '11

Hi! Here is booking.com's wish list! Regards, Monty

3 2

[Maria-developers] MariaDB limits
by Marian Marinov 21 Jun '11

21 Jun '11

Hello guys, I have a lot of clients requesting some kind of per user limiting based on the information from the STATISTICS tables. I'm thinking of creating a patch that will add this functionality by creating two more tables in the INFORMATION_SCHEMA: USER_LIMITS CLIENT_LIMITS They will have some parts of the structure of USER_STATISTICS and CLIENT_STATISTICS and will keep only values for limits. By default a 0 would mean no limit. Do you have any comments about my aproach? Would you be willing to accept a patch that adds such functionality? I want to know before I start work on this project if the community is interested in such enhancement of MariaDB. Regards, Marian

3 4

Re: [Maria-developers] Notes from the two IT Day Sessions
by Michael Widenius 20 Jun '11

20 Jun '11

Hi! Follow up to last email. I will hope to have the worklog items for all the wishes done by Thursday. Regards, Monty

1 0

[Maria-developers] MariaDB in EPEL
by Marian Marinov 20 Jun '11

20 Jun '11

Hello, I wish to package MariaDB for the EPEL repository. I have searched a bit to see if there were any efforts in that direction but I saw none. In 2009 there was some talk about MariaDB and Fedora, but that was it, only some talk. I have the time to prepare and test the MariaDB RPMs and to continue support them later. My idea is to have MariaDB RPMs as replacements of the default mysql installation. In order to do so, I first want the approval of the MariaDB developers. Best regards, Marian Marinov

2 3

Re: [Maria-developers] Rev 2994: BUG#790513: MariaDB crashes on startup
by Sergei Golubchik 17 Jun '11

17 Jun '11

Hi, Sergey! On Jun 17, Sergey Petrunya wrote: > Hi Sergei, > > Could you please review the below: > > ------------------------------------------------------------ > revno: 2994 > committer: Sergey Petrunya <psergey(a)askmonty.org> > timestamp: Fri 2011-06-17 01:05:20 +0400 > message: > BUG#790513: MariaDB crashes on startup please use lp:790513 abbreviation for bugs. see 'bzr help bugs' for details. > - Let ha_resolve_by_name() print error in case it could locate > the needed plugin but the plugin hasn't yet been initialized. > One can hit this problem by having mysql.plugin of type=innodb. Okay, I see the problem. But why couldn't we just initialize *all* built-in plugins earlier, before accessing mysql.plugin table ? > === modified file 'sql/handler.cc' > --- a/sql/handler.cc 2011-05-03 16:10:10 +0000 > +++ b/sql/handler.cc 2011-06-16 21:05:20 +0000 > @@ -135,6 +135,12 @@ > if ((plugin= my_plugin_lock_by_name(thd, name, MYSQL_STORAGE_ENGINE_PLUGIN))) > { > handlerton *hton= plugin_data(plugin, handlerton *); > + if (!hton) > + { > + sql_print_error("Attempt to use a built-in plugin %*s before it " > + "has been initialized", name->length, name->str); > + return NULL; > + } > if (!(hton->flags & HTON_NOT_USER_SELECTABLE)) > return plugin; > Regards, Sergei

1 0

Re: [Maria-developers] [Commits] Rev 3049: BUG#778406: Crash in hp_movelink with Aria engine and subqueries in file:///home/psergey/dev2/5.3-push3/
by Timour Katchaounov 17 Jun '11

17 Jun '11

Sergey, Ok to push. I'd rather add a comment to the block of code starting with: " // 1. Store the length " At least to me it was not obvious why it is the way it is. Timour > At file:///home/psergey/dev2/5.3-push3/ > > ------------------------------------------------------------ > revno: 3049 > revision-id: psergey(a)askmonty.org-20110615143701-cgzzcr5l4ot2cxjy > parent: psergey(a)askmonty.org-20110615134018-5g5jbhqhce43onz4 > committer: Sergey Petrunya<psergey(a)askmonty.org> > branch nick: 5.3-push3 > timestamp: Wed 2011-06-15 18:37:01 +0400 > message: > BUG#778406: Crash in hp_movelink with Aria engine and subqueries > -In do_sj_dups_weedout(), set nulls_ptr to point to NULL bytes (and not to length bytes) of the DuplicateWeedout column. > === modified file 'mysql-test/r/subselect_sj.result' > --- a/mysql-test/r/subselect_sj.result 2011-06-15 09:43:04 +0000 > +++ b/mysql-test/r/subselect_sj.result 2011-06-15 14:37:01 +0000 > @@ -1305,4 +1305,25 @@ > GROUP BY field2 ; > field2 > drop table t1, t2, t3; > +# > +# BUG#778406 Crash in hp_movelink with Aria engine and subqueries > +# > +CREATE TABLE t4 (f10 varchar(32) , KEY (f10)) ENGINE=Aria; > +INSERT INTO t4 VALUES ('x'),('m'),('c'); > +CREATE TABLE t1 (f11 int) ENGINE=Aria; > +INSERT INTO t1 VALUES (0),(0),(0); > +CREATE TABLE t2 ( f10 int) ENGINE=Aria; > +INSERT INTO t2 VALUES (0),(0),(0); > +CREATE TABLE t3 ( f10 int, f11 int) ENGINE=Aria; > +SELECT * > +FROM t4 > +WHERE f10 IN > +( SELECT t1.f11 > +FROM t1 > +LEFT JOIN t2 JOIN t3 ON t3.f10 = t2.f10 ON t3.f11 != 0 ); > +f10 > +x > +m > +c > +drop table t1,t2,t3,t4; > set @@optimizer_switch=@save_optimizer_switch; > > === modified file 'mysql-test/r/subselect_sj_jcl6.result' > --- a/mysql-test/r/subselect_sj_jcl6.result 2011-06-15 09:43:04 +0000 > +++ b/mysql-test/r/subselect_sj_jcl6.result 2011-06-15 14:37:01 +0000 > @@ -1313,6 +1313,27 @@ > GROUP BY field2 ; > field2 > drop table t1, t2, t3; > +# > +# BUG#778406 Crash in hp_movelink with Aria engine and subqueries > +# > +CREATE TABLE t4 (f10 varchar(32) , KEY (f10)) ENGINE=Aria; > +INSERT INTO t4 VALUES ('x'),('m'),('c'); > +CREATE TABLE t1 (f11 int) ENGINE=Aria; > +INSERT INTO t1 VALUES (0),(0),(0); > +CREATE TABLE t2 ( f10 int) ENGINE=Aria; > +INSERT INTO t2 VALUES (0),(0),(0); > +CREATE TABLE t3 ( f10 int, f11 int) ENGINE=Aria; > +SELECT * > +FROM t4 > +WHERE f10 IN > +( SELECT t1.f11 > +FROM t1 > +LEFT JOIN t2 JOIN t3 ON t3.f10 = t2.f10 ON t3.f11 != 0 ); > +f10 > +x > +m > +c > +drop table t1,t2,t3,t4; > set @@optimizer_switch=@save_optimizer_switch; > # > # BUG#49129: Wrong result with IN-subquery with join_cache_level=6 and firstmatch=off > > === modified file 'mysql-test/t/subselect_sj.test' > --- a/mysql-test/t/subselect_sj.test 2011-06-15 09:43:04 +0000 > +++ b/mysql-test/t/subselect_sj.test 2011-06-15 14:37:01 +0000 > @@ -1189,5 +1189,28 @@ > > drop table t1, t2, t3; > > +--echo # > +--echo # BUG#778406 Crash in hp_movelink with Aria engine and subqueries > +--echo # > +CREATE TABLE t4 (f10 varchar(32) , KEY (f10)) ENGINE=Aria; > +INSERT INTO t4 VALUES ('x'),('m'),('c'); > + > +CREATE TABLE t1 (f11 int) ENGINE=Aria; > +INSERT INTO t1 VALUES (0),(0),(0); > + > +CREATE TABLE t2 ( f10 int) ENGINE=Aria; > +INSERT INTO t2 VALUES (0),(0),(0); > + > +CREATE TABLE t3 ( f10 int, f11 int) ENGINE=Aria; > + > +SELECT * > +FROM t4 > +WHERE f10 IN > +( SELECT t1.f11 > +FROM t1 > +LEFT JOIN t2 JOIN t3 ON t3.f10 = t2.f10 ON t3.f11 != 0 ); > + > +drop table t1,t2,t3,t4; > + > # The following command must be the last one the file > set @@optimizer_switch=@save_optimizer_switch; > > === modified file 'sql/opt_subselect.cc' > --- a/sql/opt_subselect.cc 2011-06-06 22:50:46 +0000 > +++ b/sql/opt_subselect.cc 2011-06-15 14:37:01 +0000 > @@ -3515,7 +3515,6 @@ > } > > ptr= sjtbl->tmp_table->record[0] + 1; > - nulls_ptr= ptr; > > /* Put the the rowids tuple into table->record[0]: */ > > @@ -3531,6 +3530,7 @@ > ptr += 2; > } > > + nulls_ptr= ptr; > // 2. Zero the null bytes > if (sjtbl->null_bytes) > { > > _______________________________________________ > commits mailing list > commits(a)mariadb.org > https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits

1 0

[Maria-developers] MariaDB 5.2.7
by Daniel Bartholomew 15 Jun '11

15 Jun '11

Hello all, Just writing to let you know that MariaDB 5.2.7 is now almost completely mirrored worldwide, so I've activated the downloads page and the release notes and changelog. Here are the links: http://kb.askmonty.org/en/mariadb-527-release-notes http://kb.askmonty.org/en/mariadb-527-changelog http://downloads.askmonty.org/mariadb/5.2.7/ If any of you have a moment, please review the release notes and make (or suggest) any necessary changes. I tried to incorporate everything that I was told about this release, but I may have missed something. Now turning things over to the community team to announce and promote. Thanks. -- Daniel Bartholomew MariaDB - http://mariadb.org Monty Program - http://montyprogram.com AskMonty Knowledgebase - http://kb.askmonty.org

1 0

[Maria-developers] Preparing to release MariaDB 5.2.7
by Daniel Bartholomew 14 Jun '11

14 Jun '11

Monty, I saw your note about the new MariaDB 5.2.7 release being ready, but it looks like the "mariadb-5.2.7" tag has not been added to the 5.2 tree on launchpad. Can you or one of the other developers add it? I need the tag as part of my process for creating the changelog. Apart from that, I just need to determine which buildbot build is the correct one. Kristian, You sent me some instructions a while back for how to do this but I can't remember them. I guess you've spoiled me by usually just telling me the build number. :) Can you send the instructions to me again? Thanks. -- Daniel Bartholomew MariaDB - http://mariadb.org Monty Program - http://montyprogram.com AskMonty Knowledgebase - http://kb.askmonty.org

3 4

[Maria-developers] tmp-table-tests MariaDB 5.2.6 vs. 5.5.12 vs. 5.1.57
by erkan yanar 09 Jun '11

09 Jun '11

Moin, I did some tmp-table tests. As it is told MariaDB is faster on tmp-tables because of the Aria-Engine. Therefore Ive got 3 Severs running: onyx:/data/dbod # for i in 6051 6053 6060; do mysql -u erkan -h 10.255.128.4 -P $i -e 'select version()'; done +------------+ | version() | +------------+ | 5.5.12-log | +------------+ +-------------------+ | version() | +-------------------+ | 5.2.6-MariaDB-log | +-------------------+ +------------+ | version() | +------------+ | 5.1.57-log | key_buffer_size is 16MB. For MariaDB there is also: mysql> show global variables like 'aria_pagecache_buffer_size'; +----------------------------+----------+ | Variable_name | Value | +----------------------------+----------+ | aria_pagecache_buffer_size | 16777216 | +----------------------------+----------+ To provoke tmp-tables I did: onyx:/data/dbod # for i in 6051 6053 6060; do mysql -u erkan -h 10.255.128.4 -P $i -e 'show global variables like "tmp_table_size"'; done +----------------+-------+ | Variable_name | Value | +----------------+-------+ | tmp_table_size | 1024 | +----------------+-------+ +----------------+-------+ | Variable_name | Value | +----------------+-------+ | tmp_table_size | 1024 | +----------------+-------+ +----------------+-------+ | Variable_name | Value | +----------------+-------+ | tmp_table_size | 1024 | +----------------+-------+ We got two tables: mysql> desc sort_id; +-------+---------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-----+---------+-------+ | id | int(11) | YES | | NULL | | +-------+---------+------+-----+---------+-------+ 1 row in set (0.00 sec) mysql> desc sort_1; +-------+---------+------+-----+---------+-------+ | Field | Type | Null | Key | Default | Extra | +-------+---------+------+-----+---------+-------+ | id | int(11) | YES | | NULL | | | tea | text | YES | | NULL | | +-------+---------+------+-----+---------+-------+ 2 rows in set (0.00 sec) With 10000 Rows each. Tests: onyx:/var/tmp # for i in 6051 6053 6060; do mysqlslap -u erkan -P $i -h 10.255.128.4 --create-schema=sbtest -q "SELECT * from sbtest.sort_1 group by id;" --number-of-queries=20 -i 3; done Benchmark [[5.5.12]] Average number of seconds to run all queries: 1.803 seconds Minimum number of seconds to run all queries: 1.791 seconds Maximum number of seconds to run all queries: 1.826 seconds Number of clients running queries: 1 Average number of queries per client: 20 Benchmark [[MariaDB]] Average number of seconds to run all queries: 5.547 seconds Minimum number of seconds to run all queries: 5.542 seconds Maximum number of seconds to run all queries: 5.556 seconds Number of clients running queries: 1 Average number of queries per client: 20 Benchmark [[5.1.57]] Average number of seconds to run all queries: 1.605 seconds Minimum number of seconds to run all queries: 1.603 seconds Maximum number of seconds to run all queries: 1.606 seconds Number of clients running queries: 1 Average number of queries per client: 20 onyx:/var/tmp # for i in 6051 6053 6060; do mysqlslap -u erkan -P $i -h 10.255.128.4 --create-schema=sbtest -q "SELECT * from sbtest.sort_id group by id;" --number-of-queries=20 -i 3; done Benchmark [[5.5.12]] Average number of seconds to run all queries: 1.146 seconds Minimum number of seconds to run all queries: 1.135 seconds Maximum number of seconds to run all queries: 1.170 seconds Number of clients running queries: 1 Average number of queries per client: 20 Benchmark [[MariaDB]] Average number of seconds to run all queries: 4.359 seconds Minimum number of seconds to run all queries: 4.352 seconds Maximum number of seconds to run all queries: 4.366 seconds Number of clients running queries: 1 Average number of queries per client: 20 Benchmark [[5.1.57]] Average number of seconds to run all queries: 1.049 seconds Minimum number of seconds to run all queries: 1.032 seconds Maximum number of seconds to run all queries: 1.068 seconds Number of clients running queries: 1 Average number of queries per client: 20 So MariaDb doesn't perform in this test. So I wonder I did something wrong ... Regards Erkan -- über den grenzen muß die freiheit wohl wolkenlos sein

3 2

[Maria-developers] Reqeust for SHOW FULL FIELDS FROM and virtual tables in MariaDB
by Peter Laursen 06 Jun '11

06 Jun '11

Refer http://kb.askmonty.org/v/virtual-columns - the example CREATE TABLE table1 ( a INT NOT NULL, b VARCHAR(32), c INT AS (a MOD 10) virtual, d VARCHAR(5) AS (LEFT(b,5)) persistent); now SHOW FULL FIELDS FROM table1; Field Type Collation Null Key Default Extra Privileges Comment ------ ----------- ----------------- ------ ------ ------- ------- ------------------------------- ------- a int(11) (NULL) NO (NULL) select,insert,update,references b varchar(32) latin1_swedish_ci YES (NULL) select,insert,update,references c int(11) (NULL) YES (NULL) VIRTUAL select,insert,update,references d varchar(5) latin1_swedish_ci YES (NULL) VIRTUAL select,insert,update,references I request that 'extra' column should return either "PERSISTENT" or " VIRTUAL, PERSISTENT" for column `d`. The reason is that the output from SHOW FULL FIELDS returns an *array* (that will not need to be parsed) as opposite to SHOW CREATE TABLE. Accordingly SHOW FULL FIELDS is much easier to use for an 'unintelligent client' as opposed to an 'intelligent (or ignorant for that sake :-) ) human user to decide on special properties for a column. Peter Webyog

3 4

[Maria-developers] Buildbot failures: Microsecond-related changes break innodb_plugin but not xtradb
by Sergey Petrunya 06 Jun '11

06 Jun '11

Hi! All of the recent 5.3 builds in buildbot have two failures: innodb_plugin.innodb_bug54044 'innodb_plugin' innodb_plugin.innodb_information_schema 'innodb_plugin' The failure happens only with innodb_plugin. XtraDB is fine. I've investigated the first problem. Its cause is in storage/xtradb/handler/ha_innodb.cc:get_innobase_type_from_mysql_type(): - On 2010-08-04, Kristian did a merge from XtraDB in Percona-Server-5.1.47-11 and among everything else pulled in the code that will produce error when the function's argument is Field_null. This seems to be the bugfix for BUG#54044 - On 2011-03-29, Sergei was making fix for lp:743017 in 5.1-micro, switched the function from analyzing field->type() to analyzing field->key_type() and in the process removed the part of code that Kristian has added. For some reason, he did that storage/innodb_plugin and storage/innobase but not to storage/xtradb. - On May, 28th Monty has merged in Sergei's change into 5.3-main and we started to get the failure. I see two problems here: P1: (the apparent one) Sergei's new code doesn't produce error when passed a Field_null object. P2: (less apparent one) Why do we have Microsecond changes in innodb_plugin but not in xtradb? Could there be more fixes missing in a similar way? Sergei, could you please take a look? BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

4 4

Re: [Maria-developers] [Commits] Rev 2983: WL#77 - INSTALL PLUGIN * in http://bazaar.launchpad.net/~maria-captains/maria/5.2/
by Vladislav Vaintroub 03 Jun '11

03 Jun '11

> -----Original Message----- > From: commits-bounces(a)mariadb.org [mailto:commits- > bounces(a)mariadb.org] On Behalf Of serg(a)askmonty.org > Sent: Mittwoch, 1. Juni 2011 22:27 > To: commits(a)mariadb.org > Subject: [Commits] Rev 2983: WL#77 - INSTALL PLUGIN * in > http://bazaar.launchpad.net/~maria-captains/maria/5.2/ > > At http://bazaar.launchpad.net/~maria-captains/maria/5.2/ > > ------------------------------------------------------------ > revno: 2983 > revision-id: sergii(a)pisem.net-20110601202627-mcgxt0c3fgxoxxrq > parent: wlad(a)montyprogram.com-20110527170940-vl12r4mni30valsh > committer: Sergei Golubchik <sergii(a)pisem.net> > branch nick: 5.2 > timestamp: Wed 2011-06-01 22:26:27 +0200 > message: > WL#77 - INSTALL PLUGIN * > > new statements INSTALL PLUGIN * SONAME 'xxx' > and UNINSTALL PLUGIN * SONAME 'xxx' Serg, while simplifying "install plugin", do you think it could be even better to get rid of PLUGIN * SONAME altogether and just have INSTALL 'xxx' ? What do you think? Perhaps even more, make shared module/dynamic load library extension optional. It will simplify documentation greatly (so one would not have to mentally translate .so in examples to .dll) . It would also simplify test cases, we can get rid of obligatory --replace_regex /\.dll/.so/ and of $HA_EXAMPLE_SO. Wlad

2 1

[Maria-developers] Buildbot failure in filesort.cc:make_sortkey
by Sergey Petrunya 03 Jun '11

03 Jun '11

Hi Sergei, Current 5.3 fails as follows: http://buildbot.askmonty.org/buildbot/builders/mac-mini-x86-dbg/builds/771/… g++ -DMYSQL_SERVER -DDEFAULT_MYSQL_HOME='"/usr/local/mysql"' -DMYSQL_DATADIR='"/usr/local/mysql/var"' -DSHAREDIR='"/usr/local/mysql/share/mysql"' -DPLUGINDIR='"/usr/local/mysql/lib/mysql/plugin"' -DHAVE_EVENT_SCHEDULER -DHAVE_CONFIG_H -I. -I../include -I../include -I../include -I../regex -I. -I../extra/libevent -Wall -Wextra -Wunused -Wwrite-strings -Wno-strict-aliasing -Werror -DFORCE_INIT_OF_VARS -Wno-unused-parameter -g -Wall -Wextra -Wunused -Wwrite-strings -Wno-uninitialized -Wno-unused-parameter -Wnon-virtual-dtor -felide-constructors -fno-exceptions -fno-rtti -mtune=native -DUNIV_MUST_NOT_INLINE -DEXTRA_DEBUG -DSAFEMALLOC -DPEDANTIC_SAFEMALLOC -O0 -g3 -gdwarf-2 -O2 -Wuninitialized -DFORCE_INIT_OF_VARS -fno-implicit-templates -fno-exceptions -fno-rtti -D_P1003_1B_VISIBLE -DSIGNAL_WITH_VIO_CLOSE -DSIGNALS_DONT_BREAK_READ -DIGNORE_SIGHUP_SIGQUIT -DDONT_DECLARE_CXA_PURE_VIRTUAL -MT debug_sync.o -MD -MP -MF .deps/debug_sync.Tpo -c -o debug_sync.o debug_sync.cc cc1plus: warnings being treated as errors filesort.cc: In function 'void make_sortkey(SORTPARAM*, uchar*, uchar*)': filesort.cc:878: warning: 'value' may be used uninitialized in this function make[3]: *** [filesort.o] Error 1 make[3]: *** Waiting for unfinished jobs.... It is not apparent for me whether this is a real error or not, bazaar history shows that the failure is in your code of MWL#173. Could you please take a look? BR Sergey -- Sergey Petrunia, Software Developer Monty Program AB, http://askmonty.org Blog: http://s.petrunia.net/blog

2 1