revision-id: c4777e0c0284d7d255a6ca9eabca84c041103915 (mariadb-10.3.10-121-gc4777e0c028) parent(s): f6266f19d453b37c94b660a5d00c1a7234f48931 author: Andrei Elkin committer: Andrei Elkin timestamp: 2018-12-20 22:27:28 +0200 message: MDEV-16272 rpl.rpl_semisync_ali_issues failed in buildbot with wrong result The failure was caused by race between an event acknowledgment by the IO thread and its execution by the SQL thread. Rarely the latter may win, which was confirmed by BB. Fixed with turning to wait for the status expected value. --- mysql-test/suite/rpl/r/rpl_semisync_ali_issues.result | 3 --- mysql-test/suite/rpl/t/rpl_semisync_ali_issues.test | 7 ++++++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/mysql-test/suite/rpl/r/rpl_semisync_ali_issues.result b/mysql-test/suite/rpl/r/rpl_semisync_ali_issues.result index 9607e8a7998..05af93e3a3b 100644 --- a/mysql-test/suite/rpl/r/rpl_semisync_ali_issues.result +++ b/mysql-test/suite/rpl/r/rpl_semisync_ali_issues.result @@ -177,9 +177,6 @@ connection con1; show status like 'Rpl_semi_sync_master_clients'; Variable_name Value Rpl_semi_sync_master_clients 1 -show status like 'Rpl_semi_sync_master_status'; -Variable_name Value -Rpl_semi_sync_master_status ON connection slave; STOP SLAVE IO_THREAD; include/wait_for_slave_io_to_stop.inc diff --git a/mysql-test/suite/rpl/t/rpl_semisync_ali_issues.test b/mysql-test/suite/rpl/t/rpl_semisync_ali_issues.test index 52cd9e31753..e231c7d9ab5 100644 --- a/mysql-test/suite/rpl/t/rpl_semisync_ali_issues.test +++ b/mysql-test/suite/rpl/t/rpl_semisync_ali_issues.test @@ -191,7 +191,12 @@ INSERT INTO t1 values (2); sync_slave_with_master; connection con1; show status like 'Rpl_semi_sync_master_clients'; -show status like 'Rpl_semi_sync_master_status'; +# The semi_sync master status is turning to ON by the 1st event +# after restart. The event execution and its acknowledgment are in race. +# That's why to wait here. +--let $status_var= Rpl_semi_sync_master_status +--let $status_var_value= ON +--source include/wait_for_status_var.inc connection slave; STOP SLAVE IO_THREAD;