revision-id: 06a7e79c396e21271d4cc015a7d449f4f13ec45c (mariadb-10.2.19-20-g06a7e79c396) parent(s): 3728b11f879634a7ddab39cb951aedceadba80b1 author: Jan Lindström committer: Jan Lindström timestamp: 2018-11-26 12:57:35 +0200 message: MDEV-17811: Add deprecation information for xtrabackup --- storage/innobase/handler/ha_innodb.cc | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/storage/innobase/handler/ha_innodb.cc b/storage/innobase/handler/ha_innodb.cc index e6c57b015a0..80e79b4b90f 100644 --- a/storage/innobase/handler/ha_innodb.cc +++ b/storage/innobase/handler/ha_innodb.cc @@ -154,6 +154,7 @@ innodb_check_deprecated(void); #include "dict0priv.h" #include "ut0byte.h" #include <mysql/service_md5.h> +#include "wsrep_sst.h" extern MYSQL_PLUGIN_IMPORT MYSQL_BIN_LOG mysql_bin_log; @@ -3860,6 +3861,23 @@ innobase_init( ib::info() << "For Galera, using innodb_lock_schedule_algorithm=fcfs"; innodb_lock_schedule_algorithm = INNODB_LOCK_SCHEDULE_ALGORITHM_FCFS; } + + /* Print deprecation info if xtrabackup is used for SST method */ + if (global_system_variables.wsrep_on + && wsrep_sst_method + && (!strcmp(wsrep_sst_method, "xtrabackup") + || !strcmp(wsrep_sst_method, "xtrabackup-v2"))) { + ib::info() << "Galera SST method xtrabackup is deprecated and the " + " support for it may be removed in future releases."; + + /* We can't blindly turn on this as it will cause a + modification of the redo log format identifier. See + MDEV-13564 for more information. */ + if (!srv_safe_truncate) { + ib::info() << "Requested xtrabackup based SST for Galera but" + << "innodb_safe_truncate is disabled."; + } + } #endif /* WITH_WSREP */ #ifndef HAVE_LZ4