revision-id: 18930c002f149de490d69e18d42446bde6020a5f (v5.8-3139-g18930c002) parent(s): 0e30dd985c72b6f11576a2a2e43c62bcea01f9b9 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2020-12-07 16:03:55 +0300 message: Address review input --- include/rocksdb/utilities/transaction.h | 4 ++-- include/rocksdb/utilities/transaction_db.h | 2 +- utilities/transactions/lock/point/point_lock_manager_test.cc | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/rocksdb/utilities/transaction.h b/include/rocksdb/utilities/transaction.h index 2f4804255..dd7dd998a 100644 --- a/include/rocksdb/utilities/transaction.h +++ b/include/rocksdb/utilities/transaction.h @@ -89,10 +89,10 @@ class Endpoint { */ bool inf_suffix; - Endpoint(const Slice& slice_arg, bool inf_suffix_arg = false) + explicit Endpoint(const Slice& slice_arg, bool inf_suffix_arg = false) : slice(slice_arg), inf_suffix(inf_suffix_arg) {} - Endpoint(const char* s, bool inf_suffix_arg = false) + explicit Endpoint(const char* s, bool inf_suffix_arg = false) : slice(s), inf_suffix(inf_suffix_arg) {} Endpoint(const char* s, size_t size, bool inf_suffix_arg = false) diff --git a/include/rocksdb/utilities/transaction_db.h b/include/rocksdb/utilities/transaction_db.h index b9daf84a3..03fbbbeea 100644 --- a/include/rocksdb/utilities/transaction_db.h +++ b/include/rocksdb/utilities/transaction_db.h @@ -112,7 +112,7 @@ class RangeLockManagerHandle : public LockManagerHandle { virtual std::vector<RangeDeadlockPath> GetRangeDeadlockInfoBuffer() = 0; virtual void SetRangeDeadlockInfoBufferSize(uint32_t target_size) = 0; - virtual ~RangeLockManagerHandle(){}; + virtual ~RangeLockManagerHandle(){} }; // A factory function to create a Range Lock Manager. The created object should diff --git a/utilities/transactions/lock/point/point_lock_manager_test.cc b/utilities/transactions/lock/point/point_lock_manager_test.cc index 206a0395a..525fdea71 100644 --- a/utilities/transactions/lock/point/point_lock_manager_test.cc +++ b/utilities/transactions/lock/point/point_lock_manager_test.cc @@ -5,7 +5,7 @@ #ifndef ROCKSDB_LITE -#include "point_lock_manager_test.h" +#include "utilities/transactions/lock/point/point_lock_manager_test.h" namespace ROCKSDB_NAMESPACE {