revision-id: 9bcb6cc1df79535d5923435cfd4f64efe94bcf2a (mariadb-10.1.41-22-g9bcb6cc1df7) parent(s): 91fdb931fa2f734d54acadeb3e9c860a26543f04 author: Sujatha committer: Sujatha timestamp: 2019-08-21 21:23:11 +0530 message: MDEV-20188: binlog.binlog_stm_drop_tmp_tbl fails in buildbot with Unknown table on exec Analysis: ======== As part of BUG#28642318 fix, two new test cases were added. The first test case tests a scenario where two sessions are present, in which the first session has a regular table named 't1' and another session has a temporary table named 't1'. Test executes a DELETE statement on regular table. These statements are captured from binary log and replayed back on new client connection to prove that DELETE statement is applied successfully. Note that the binlog contains only CREATE TEMPORARY TABLE part hence a temporary table gets created in new connection. This replaying logic is implemented by using '--exec $MYSQL' command. If the new connection gets disconnected within the scope of first test case the test passes, i.e the temporary table gets dropped as part thread cleanup. But on slow platforms the connection gets closed at the time of execution of test case 2. When the temporary table is dropped as part thread cleanup a "DROP TEMPORARY TABLE t1" is written into the binary log. In test case two the same sessions continue to exist and and table names are reused to test a new bug scenario. The additional "DROP TEMPORARY TABLE" command drops second test specific tables which results in "Unknown table" error. Fix: ==== Rename the second case specific table to 't2'. Even if the close connection from test case one happens later the drop command with has 'DROP /*!40005 TEMPORARY */ TABLE IF EXISTS `t1`' will not result in an error. --- mysql-test/extra/binlog_tests/drop_temp_table.test | 8 ++++---- mysql-test/suite/binlog/r/binlog_row_drop_tmp_tbl.result | 8 ++++---- mysql-test/suite/binlog/r/binlog_stm_drop_tmp_tbl.result | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/mysql-test/extra/binlog_tests/drop_temp_table.test b/mysql-test/extra/binlog_tests/drop_temp_table.test index 9139ac76017..7c95195eadc 100644 --- a/mysql-test/extra/binlog_tests/drop_temp_table.test +++ b/mysql-test/extra/binlog_tests/drop_temp_table.test @@ -150,16 +150,16 @@ RESET MASTER; --echo # Test case for DROP query. --connection default -CREATE TABLE t1 (a INT) ENGINE=INNODB; +CREATE TABLE t2 (a INT) ENGINE=INNODB; --connection con1 -CREATE TEMPORARY TABLE t1 (b BLOB) ENGINE=INNODB; +CREATE TEMPORARY TABLE t2 (b BLOB) ENGINE=INNODB; --connection default -DROP TABLE t1; +DROP TABLE t2; --connection con1 -DROP TABLE t1; +DROP TABLE t2; --connection default --exec $MYSQL_BINLOG --force-if-open $MYSQLD_DATADIR/master-bin.000001 > $MYSQLTEST_VARDIR/tmp/bug28642318.sql diff --git a/mysql-test/suite/binlog/r/binlog_row_drop_tmp_tbl.result b/mysql-test/suite/binlog/r/binlog_row_drop_tmp_tbl.result index 3d97817161e..1a18aac3997 100644 --- a/mysql-test/suite/binlog/r/binlog_row_drop_tmp_tbl.result +++ b/mysql-test/suite/binlog/r/binlog_row_drop_tmp_tbl.result @@ -71,10 +71,10 @@ DROP TABLE IF EXISTS t1; DROP TABLE IF EXISTS t1; RESET MASTER; # Test case for DROP query. -CREATE TABLE t1 (a INT) ENGINE=INNODB; -CREATE TEMPORARY TABLE t1 (b BLOB) ENGINE=INNODB; -DROP TABLE t1; -DROP TABLE t1; +CREATE TABLE t2 (a INT) ENGINE=INNODB; +CREATE TEMPORARY TABLE t2 (b BLOB) ENGINE=INNODB; +DROP TABLE t2; +DROP TABLE t2; # DROP table query fails with unknown table error without patch. # Clean up SET @@session.binlog_format= @save_binlog_format; diff --git a/mysql-test/suite/binlog/r/binlog_stm_drop_tmp_tbl.result b/mysql-test/suite/binlog/r/binlog_stm_drop_tmp_tbl.result index b13ffea86db..dc4b3bf10c3 100644 --- a/mysql-test/suite/binlog/r/binlog_stm_drop_tmp_tbl.result +++ b/mysql-test/suite/binlog/r/binlog_stm_drop_tmp_tbl.result @@ -99,10 +99,10 @@ DROP TABLE IF EXISTS t1; DROP TABLE IF EXISTS t1; RESET MASTER; # Test case for DROP query. -CREATE TABLE t1 (a INT) ENGINE=INNODB; -CREATE TEMPORARY TABLE t1 (b BLOB) ENGINE=INNODB; -DROP TABLE t1; -DROP TABLE t1; +CREATE TABLE t2 (a INT) ENGINE=INNODB; +CREATE TEMPORARY TABLE t2 (b BLOB) ENGINE=INNODB; +DROP TABLE t2; +DROP TABLE t2; # DROP table query fails with unknown table error without patch. # Clean up SET @@session.binlog_format= @save_binlog_format;