- commits - lists.mariadb.org

[Commits] 08d7bf34b: Add PerfContext::lock_{acquire, release}_count counters
by psergey 01 Apr '20

01 Apr '20

revision-id: 08d7bf34ba792084073a668a22b63f162cc6c0f1 (v5.8-1904-g08d7bf34b) parent(s): 6b3b684f69a5b6ad968f2270e54e92de1a42d468 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2020-04-01 20:41:23 +0300 message: Add PerfContext::lock_{acquire,release}_count counters These are incremented both for point and range locking. --- include/rocksdb/perf_context.h | 3 +++ monitoring/perf_context.cc | 12 ++++++++++++ utilities/transactions/range_locking/locktree/locktree.cc | 3 +++ utilities/transactions/range_locking/locktree/locktree.h | 13 +++++++++++++ utilities/transactions/transaction_lock_mgr.cc | 3 +++ 5 files changed, 34 insertions(+) diff --git a/include/rocksdb/perf_context.h b/include/rocksdb/perf_context.h index a1d803c2c..91f2699ae 100644 --- a/include/rocksdb/perf_context.h +++ b/include/rocksdb/perf_context.h @@ -221,6 +221,9 @@ struct PerfContext { uint64_t iter_prev_cpu_nanos; uint64_t iter_seek_cpu_nanos; + uint64_t lock_acquire_count; + uint64_t lock_release_count; + std::map<uint32_t, PerfContextByLevel>* level_to_perf_context = nullptr; bool per_level_perf_context_enabled = false; }; diff --git a/monitoring/perf_context.cc b/monitoring/perf_context.cc index 5e0d5ac25..78625df0c 100644 --- a/monitoring/perf_context.cc +++ b/monitoring/perf_context.cc @@ -129,6 +129,9 @@ PerfContext::PerfContext(const PerfContext& other) { *level_to_perf_context = *other.level_to_perf_context; } per_level_perf_context_enabled = other.per_level_perf_context_enabled; + + lock_acquire_count = other.lock_acquire_count; + lock_release_count = other.lock_release_count; #endif } @@ -224,6 +227,9 @@ PerfContext::PerfContext(PerfContext&& other) noexcept { other.level_to_perf_context = nullptr; } per_level_perf_context_enabled = other.per_level_perf_context_enabled; + + lock_acquire_count = other.lock_acquire_count; + lock_release_count = other.lock_release_count; #endif } @@ -321,6 +327,9 @@ PerfContext& PerfContext::operator=(const PerfContext& other) { *level_to_perf_context = *other.level_to_perf_context; } per_level_perf_context_enabled = other.per_level_perf_context_enabled; + + lock_acquire_count = other.lock_acquire_count; + lock_release_count = other.lock_release_count; #endif return *this; } @@ -412,6 +421,9 @@ void PerfContext::Reset() { kv.second.Reset(); } } + + lock_acquire_count = 0; + lock_release_count = 0; #endif } diff --git a/utilities/transactions/range_locking/locktree/locktree.cc b/utilities/transactions/range_locking/locktree/locktree.cc index 3c32e1b77..4952fabb9 100644 --- a/utilities/transactions/range_locking/locktree/locktree.cc +++ b/utilities/transactions/range_locking/locktree/locktree.cc @@ -488,6 +488,7 @@ int locktree::acquire_lock(bool is_write_request, // we are only supporting write locks for simplicity //invariant(is_write_request); + PERF_COUNTER_ADD(lock_acquire_count, 1); // acquire and prepare a locked keyrange over the requested range. // prepare is a serialzation point, so we take the opportunity to @@ -634,6 +635,8 @@ void locktree::remove_overlapping_locks_for_txnid(TXNID txnid, keyrange release_range; release_range.create(left_key, right_key); + PERF_COUNTER_ADD(lock_release_count, 1); + // acquire and prepare a locked keyrange over the release range concurrent_tree::locked_keyrange lkr; lkr.prepare(m_rangetree); diff --git a/utilities/transactions/range_locking/locktree/locktree.h b/utilities/transactions/range_locking/locktree/locktree.h index e7c909be0..624e61ec5 100644 --- a/utilities/transactions/range_locking/locktree/locktree.h +++ b/utilities/transactions/range_locking/locktree/locktree.h @@ -67,6 +67,19 @@ struct DICTIONARY_ID { uint64_t dictid; }; +#ifndef ROCKSDB_SUPPORT_THREAD_LOCAL +#error ROCKSDB_SUPPORT_THREAD_LOCALAAAA +#endif + +#include "rocksdb/perf_context.h" +#include "monitoring/perf_level_imp.h" +#include "monitoring/perf_context_imp.h" + +//psergey-new: +using rocksdb::PerfLevel; +using rocksdb::perf_level; +using rocksdb::perf_context; + #include <util/omt.h> #include "txnid_set.h" diff --git a/utilities/transactions/transaction_lock_mgr.cc b/utilities/transactions/transaction_lock_mgr.cc index fa8e49476..6734f03fa 100644 --- a/utilities/transactions/transaction_lock_mgr.cc +++ b/utilities/transactions/transaction_lock_mgr.cc @@ -300,6 +300,8 @@ Status TransactionLockMgr::TryLock(PessimisticTransaction* txn, return Status::InvalidArgument(msg); } + PERF_COUNTER_ADD(lock_acquire_count, 1); + // Need to lock the mutex for the stripe that this key hashes to size_t stripe_num = lock_map->GetStripe(key); assert(lock_map->lock_map_stripes_.size() > stripe_num); @@ -595,6 +597,7 @@ void TransactionLockMgr::UnLockKey(const PessimisticTransaction* txn, #ifdef NDEBUG (void)env; #endif + PERF_COUNTER_ADD(lock_release_count, 1); TransactionID txn_id = txn->GetID(); auto stripe_iter = stripe->keys.find(key);

1 0

[Commits] f49f210: Added support for running the benchmark without secondary index
by psergey 01 Apr '20

01 Apr '20

revision-id: f49f210a200b07195e9280d7866c2c73d3a51e71 () parent(s): 878952d1488d7646d870bd6e6e0752cb69ada1b1 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2020-04-01 20:12:10 +0300 message: Added support for running the benchmark without secondary index --- run-all-one-index.sh | 12 ++++++++++++ run-test.sh | 22 ++++++++++++++++++++-- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/run-all-one-index.sh b/run-all-one-index.sh new file mode 100755 index 0000000..7cc1d42 --- /dev/null +++ b/run-all-one-index.sh @@ -0,0 +1,12 @@ +#!/bin/bash + +#./setup.sh + +echo "rocksdb_use_range_locking=1" >> my-fbmysql-range-locking.cnf + +./run-test.sh -e -m orig 01-orig +./run-test.sh -e -m range-locking 02-range-locking + +./summarize-result.sh 01-orig +./summarize-result.sh 02-range-locking + diff --git a/run-test.sh b/run-test.sh index ef68cb1..248db6b 100755 --- a/run-test.sh +++ b/run-test.sh @@ -1,18 +1,19 @@ #!/bin/bash usage () { -echo "Usage: $0 [-p] [-m] [-c] [-d] server_name test_run_name" +echo "Usage: $0 [-p] [-m] [-c] [-d] [-e] server_name test_run_name" echo " -p - Use perf for profiling" echo " -m - Put datadir on /dev/shm" echo " -c - Assume sysbench uses 4 tables and move them to different CFs." echo " -d - Same but use 2 CFs" +echo " -e - Remove the secondary index" } ### ### Parse options ### -while getopts ":pmcd" opt; do +while getopts ":pmcde" opt; do case ${opt} in p ) USE_PERF=1 ;; @@ -22,6 +23,8 @@ while getopts ":pmcd" opt; do ;; d ) USE_2_CFS=1 ;; + e ) DROP_SECONDARY_INDEX=1 + ;; \? ) usage; exit 1 @@ -178,6 +181,21 @@ if [[ $USE_2_CFS ]] ; then $MYSQL_CMD < make-2-cfs.sql fi +if [[ $DROP_SECONDARY_INDEX ]]; then + if [[ $USE_4_CFS ]]; then + echo "DROP_SECONDARY_INDEX and USE_4_CFS are not supported" + exit 1 + fi + if [[ $USE_2_CFS ]]; then + echo "DROP_SECONDARY_INDEX and USE_2_CFS are not supported" + exit 1 + fi + + echo "Dropping the secondary index" + echo "alter table sbtest.sbtest1 drop key k_1" | $MYSQL_CMD + echo "show create table sbtest.sbtest1" | $MYSQL_CMD +fi + sleep 3 $MYSQL_CMD -e "show variables like 'rocksdb%'" > $RESULT_DIR/variables-rocksdb.txt

1 0

[Commits] af4b2ae8588: MDEV-21887: federatedx crashes on SELECT ... INTO query in select_handler code
by psergey 26 Mar '20

26 Mar '20

revision-id: af4b2ae8588bd51cc17e66cfc8210c3225992fbe (mariadb-10.4.11-126-gaf4b2ae8588) parent(s): 1c8de231a3ea7ef2e08b1a5cfe17c37d733ea6ce author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2020-03-26 15:01:44 +0300 message: MDEV-21887: federatedx crashes on SELECT ... INTO query in select_handler code Backport to 10.4: - Don't try to push down SELECTs that have a side effect - In case the storage engine did support pushdown of SELECT with an INTO clause, write the rows we've got from it into select->join->result, and not thd->protocol. This way, SELECT ... INTO ... FROM smart_engine_table will put the result into where instructed, and NOT send it to the client. --- .../federated/federatedx_create_handlers.result | 22 ++++++++++++++++++- .../federated/federatedx_create_handlers.test | 21 +++++++++++++++++- sql/select_handler.cc | 25 ++++------------------ storage/federatedx/federatedx_pushdown.cc | 13 ++++++++++- 4 files changed, 57 insertions(+), 24 deletions(-) diff --git a/mysql-test/suite/federated/federatedx_create_handlers.result b/mysql-test/suite/federated/federatedx_create_handlers.result index 473972c2cd4..65a9d52803f 100644 --- a/mysql-test/suite/federated/federatedx_create_handlers.result +++ b/mysql-test/suite/federated/federatedx_create_handlers.result @@ -299,7 +299,27 @@ id select_type table type possible_keys key key_len ref rows Extra 1 PRIMARY t3 ALL NULL NULL NULL NULL 7 1 PRIMARY <derived2> ref key0 key0 18 federated.t3.name 2 2 PUSHED DERIVED NULL NULL NULL NULL NULL NULL NULL NULL -DROP TABLE federated.t1, federated.t2, federated.t3; +# +# MDEV-21887: federatedx crashes on SELECT ... INTO query in select_handler code +# +CREATE TABLE federated.t4 ( +id int(20) NOT NULL, +name varchar(16) NOT NULL default '' +) engine=myisam; +insert into federated.t4 select * from federated.t1; +select * from federated.t4; +id name +1 zzz +3 xxx +4 xxx +5 yyy +7 yyy +select name into @var from federated.t1 where id=3 limit 1 ; +select @var; +@var +xxx +select name into outfile 'tmp.txt' from federated.t1; +DROP TABLE federated.t1, federated.t2, federated.t3, federated.t4; connection slave; DROP TABLE federated.t1, federated.t2; connection default; diff --git a/mysql-test/suite/federated/federatedx_create_handlers.test b/mysql-test/suite/federated/federatedx_create_handlers.test index 373b2aaaa33..42a03e60d67 100644 --- a/mysql-test/suite/federated/federatedx_create_handlers.test +++ b/mysql-test/suite/federated/federatedx_create_handlers.test @@ -147,8 +147,27 @@ FROM federated.t3, SELECT * FROM federated.t1 WHERE id >= 5) t WHERE federated.t3.name=t.name; +--echo # +--echo # MDEV-21887: federatedx crashes on SELECT ... INTO query in select_handler code +--echo # -DROP TABLE federated.t1, federated.t2, federated.t3; +CREATE TABLE federated.t4 ( + id int(20) NOT NULL, + name varchar(16) NOT NULL default '' +) engine=myisam; +insert into federated.t4 select * from federated.t1; + +--sorted_result +select * from federated.t4; + +select name into @var from federated.t1 where id=3 limit 1 ; +select @var; +select name into outfile 'tmp.txt' from federated.t1; + +let $path=`select concat(@@datadir, 'test/tmp.txt')`; +remove_file $path; + +DROP TABLE federated.t1, federated.t2, federated.t3, federated.t4; connection slave; DROP TABLE federated.t1, federated.t2; diff --git a/sql/select_handler.cc b/sql/select_handler.cc index b364cb12341..495b6d957b1 100644 --- a/sql/select_handler.cc +++ b/sql/select_handler.cc @@ -77,18 +77,17 @@ bool Pushdown_select::init() bool Pushdown_select::send_result_set_metadata() { - THD *thd= handler->thd; - Protocol *protocol= thd->protocol; DBUG_ENTER("Pushdown_select::send_result_set_metadata"); #ifdef WITH_WSREP + THD *thd= handler->thd; if (WSREP(thd) && thd->wsrep_retry_query) { WSREP_DEBUG("skipping select metadata"); DBUG_RETURN(false); } #endif /* WITH_WSREP */ - if (protocol->send_result_set_metadata(&result_columns, + if (select->join->result->send_result_set_metadata(result_columns, Protocol::SEND_NUM_ROWS | Protocol::SEND_EOF)) DBUG_RETURN(true); @@ -100,23 +99,13 @@ bool Pushdown_select::send_result_set_metadata() bool Pushdown_select::send_data() { THD *thd= handler->thd; - Protocol *protocol= thd->protocol; DBUG_ENTER("Pushdown_select::send_data"); if (thd->killed == ABORT_QUERY) DBUG_RETURN(false); - protocol->prepare_for_resend(); - if (protocol->send_result_set_row(&result_columns)) - { - protocol->remove_last_row(); + if (select->join->result->send_data(result_columns)) DBUG_RETURN(true); - } - - thd->inc_sent_row_count(1); - - if (thd->vio_ok()) - DBUG_RETURN(protocol->write()); DBUG_RETURN(false); } @@ -124,16 +113,10 @@ bool Pushdown_select::send_data() bool Pushdown_select::send_eof() { - THD *thd= handler->thd; DBUG_ENTER("Pushdown_select::send_eof"); - /* - Don't send EOF if we're in error condition (which implies we've already - sent or are sending an error) - */ - if (thd->is_error()) + if (select->join->result->send_eof()) DBUG_RETURN(true); - ::my_eof(thd); DBUG_RETURN(false); } diff --git a/storage/federatedx/federatedx_pushdown.cc b/storage/federatedx/federatedx_pushdown.cc index 2bcee943308..15b0b0d3d4e 100644 --- a/storage/federatedx/federatedx_pushdown.cc +++ b/storage/federatedx/federatedx_pushdown.cc @@ -182,6 +182,16 @@ create_federatedx_select_handler(THD* thd, SELECT_LEX *sel) return 0; } + /* + Currently, ha_federatedx_select_handler::init_scan just takes the + thd->query and sends it to the backend. + This obviously won't work if the SELECT uses an "INTO @var" or + "INTO OUTFILE". It is also unlikely to work if the select has some + other kind of side effect. + */ + if (sel->uncacheable & UNCACHEABLE_SIDEEFFECT) + return NULL; + handler= new ha_federatedx_select_handler(thd, sel); return handler; @@ -286,8 +296,9 @@ int ha_federatedx_select_handler::end_scan() DBUG_RETURN(0); } -void ha_federatedx_select_handler::print_error(int, unsigned long) +void ha_federatedx_select_handler::print_error(int error, myf error_flag) { + select_handler::print_error(error, error_flag); }

1 0

[Commits] 51ef5419426: MDEV-22019: Sig 11 in next_breadth_first_tab | max_sort_length setting + double GROUP BY leads to crash
by Varun 26 Mar '20

26 Mar '20

revision-id: 51ef54194268b07be6cddca83f88c5dcba67b5d9 (mariadb-10.2.30-177-g51ef5419426) parent(s): 5918b17004674f425f2cd1d4f0bac29b3bcecb35 author: Varun Gupta committer: Varun Gupta timestamp: 2020-03-26 16:54:44 +0530 message: MDEV-22019: Sig 11 in next_breadth_first_tab | max_sort_length setting + double GROUP BY leads to crash No need to create a temp table for aggregation if we have encountered some error. --- mysql-test/r/group_by.result | 14 ++++++++++++++ mysql-test/t/group_by.test | 17 +++++++++++++++++ sql/sql_select.cc | 8 ++++++-- sql/sql_show.cc | 7 +++---- 4 files changed, 40 insertions(+), 6 deletions(-) diff --git a/mysql-test/r/group_by.result b/mysql-test/r/group_by.result index cbce6340c47..c996627486c 100644 --- a/mysql-test/r/group_by.result +++ b/mysql-test/r/group_by.result @@ -2861,3 +2861,17 @@ SELECT 1 FROM t1 GROUP BY REPEAT((BINARY pk), v1), AES_DECRYPT((@A := i1), 20852) WITH ROLLUP HAVING LOAD_FILE('a') ; 1 drop table t1; +# +# MDEV-22019: Sig 11 in next_breadth_first_tab | max_sort_length setting + double +# GROUP BY leads to crash +# +CALL mtr.add_suppression("Out of sort memory"); +CALL mtr.add_suppression("Sort aborted"); +SET @save_max_sort_length= @@max_sort_length; +SET max_sort_length=2000000; +SELECT * FROM information_schema.tables t JOIN information_schema.columns c +ON t.table_schema=c.table_schema +WHERE c.table_schema=(SELECT COUNT(*) FROM INFORMATION_SCHEMA.columns GROUP BY column_type) +GROUP BY t.table_name; +ERROR HY001: Out of sort memory, consider increasing server sort buffer size +SET max_sort_length= @save_max_sort_length; diff --git a/mysql-test/t/group_by.test b/mysql-test/t/group_by.test index 0436cd16e7c..324b41ce23c 100644 --- a/mysql-test/t/group_by.test +++ b/mysql-test/t/group_by.test @@ -1979,3 +1979,20 @@ GROUP BY REPEAT((BINARY pk), v1), AES_DECRYPT((@A := i1), 20852) WITH ROLLUP HAV SELECT 1 FROM t1 GROUP BY REPEAT((BINARY pk), v1), AES_DECRYPT((@A := i1), 20852) WITH ROLLUP HAVING LOAD_FILE('a') ; drop table t1; + +--echo # +--echo # MDEV-22019: Sig 11 in next_breadth_first_tab | max_sort_length setting + double +--echo # GROUP BY leads to crash +--echo # + + +CALL mtr.add_suppression("Out of sort memory"); +CALL mtr.add_suppression("Sort aborted"); +SET @save_max_sort_length= @@max_sort_length; +SET max_sort_length=2000000; +--error ER_OUT_OF_SORTMEMORY +SELECT * FROM information_schema.tables t JOIN information_schema.columns c +ON t.table_schema=c.table_schema +WHERE c.table_schema=(SELECT COUNT(*) FROM INFORMATION_SCHEMA.columns GROUP BY column_type) +GROUP BY t.table_name; +SET max_sort_length= @save_max_sort_length; diff --git a/sql/sql_select.cc b/sql/sql_select.cc index 97002ef071f..c601946cfa0 100644 --- a/sql/sql_select.cc +++ b/sql/sql_select.cc @@ -2210,8 +2210,12 @@ JOIN::optimize_inner() having_is_correlated= MY_TEST(having->used_tables() & OUTER_REF_TABLE_BIT); tmp_having= having; - if ((select_lex->options & OPTION_SCHEMA_TABLE)) - optimize_schema_tables_reads(this); + if ((select_lex->options & OPTION_SCHEMA_TABLE) && + optimize_schema_tables_reads(this)) + DBUG_RETURN(TRUE); + + if (unlikely(thd->is_error())) + DBUG_RETURN(TRUE); /* The loose index scan access method guarantees that all grouping or diff --git a/sql/sql_show.cc b/sql/sql_show.cc index 78ca1d09e7a..4e37b53b87e 100644 --- a/sql/sql_show.cc +++ b/sql/sql_show.cc @@ -8299,7 +8299,6 @@ static bool optimize_for_get_all_tables(THD *thd, TABLE_LIST *tables, COND *cond bool optimize_schema_tables_reads(JOIN *join) { THD *thd= join->thd; - bool result= 0; DBUG_ENTER("optimize_schema_tables_reads"); JOIN_TAB *tab; @@ -8334,11 +8333,11 @@ bool optimize_schema_tables_reads(JOIN *join) */ cond= tab->cache_select->cond; } - - optimize_for_get_all_tables(thd, table_list, cond); + if (optimize_for_get_all_tables(thd, table_list, cond)) + DBUG_RETURN(TRUE); // Handle OOM } } - DBUG_RETURN(result); + DBUG_RETURN(FALSE); }

1 0

[Commits] f2b801bd023: Remove the redundant iter->Seek() call in ha_rocksdb::check_and_lock_sk
by psergey 25 Mar '20

25 Mar '20

revision-id: f2b801bd023f169bae5e8a8a88334e5c6f1e788d (fb-prod201907-50-gf2b801bd023) parent(s): 1b7b8f7dcec371dabc74acabaae330146e367c7c author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2020-03-25 11:33:56 +0300 message: Remove the redundant iter->Seek() call in ha_rocksdb::check_and_lock_sk read_key_exact() is called next, and it will mak iter->Seek() call itself. --- storage/rocksdb/ha_rocksdb.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/storage/rocksdb/ha_rocksdb.cc b/storage/rocksdb/ha_rocksdb.cc index 14006d05150..3a58567d05b 100644 --- a/storage/rocksdb/ha_rocksdb.cc +++ b/storage/rocksdb/ha_rocksdb.cc @@ -9792,7 +9792,6 @@ int ha_rocksdb::check_and_lock_sk(const uint key_id, Also need to scan RocksDB and verify the key has not been deleted in the transaction. */ - iter->Seek(new_slice); *found = !read_key_exact(kd, iter, all_parts_used, new_slice, row_info.tx->m_snapshot_timestamp); delete iter;

1 0

[Commits] 4f528bb514c: MDEV-22011: DISTINCT with JSON_ARRAYAGG gives wrong results
by Varun 24 Mar '20

24 Mar '20

revision-id: 4f528bb514c607d848b30119cea135e37e0d9c69 (mariadb-10.5.0-425-g4f528bb514c) parent(s): 1cd8e8213b6019794ca7f01e8276cfd1ba6408cf author: Varun Gupta committer: Varun Gupta timestamp: 2020-03-24 10:13:28 +0530 message: MDEV-22011: DISTINCT with JSON_ARRAYAGG gives wrong results For JSON_ARRAYAGG with DISTINCT also store the null bytes for the record inside the Unique object --- mysql-test/main/func_json.result | 4 +- sql/item_jsonfunc.cc | 36 ++++++++++++-- sql/item_jsonfunc.h | 9 ++-- sql/item_sum.cc | 101 ++++++++++++++++++++++++++++++++++----- sql/item_sum.h | 13 +++-- 5 files changed, 133 insertions(+), 30 deletions(-) diff --git a/mysql-test/main/func_json.result b/mysql-test/main/func_json.result index be6ea1a7b61..9a60f395d0d 100644 --- a/mysql-test/main/func_json.result +++ b/mysql-test/main/func_json.result @@ -1160,13 +1160,13 @@ JSON_ARRAYAGG(DISTINCT a) [1,2,3] SELECT JSON_ARRAYAGG(DISTINCT b) FROM t1; JSON_ARRAYAGG(DISTINCT b) -["Hello","World","This","Will","Work","!",null] +[null,"!","Hello","This","Will","Work","World"] SELECT JSON_ARRAYAGG(DISTINCT a LIMIT 2) FROM t1; JSON_ARRAYAGG(DISTINCT a LIMIT 2) [1,2] SELECT JSON_ARRAYAGG(DISTINCT b LIMIT 2) FROM t1; JSON_ARRAYAGG(DISTINCT b LIMIT 2) -["Hello","World"] +[null,"!"] # # JSON aggregation # diff --git a/sql/item_jsonfunc.cc b/sql/item_jsonfunc.cc index a3b5d3b7fac..ed496df8169 100644 --- a/sql/item_jsonfunc.cc +++ b/sql/item_jsonfunc.cc @@ -1452,6 +1452,31 @@ static int append_json_value(String *str, Item *item, String *tmp_val) } +bool append_json_value(String *str, String *res, Item *item, bool null_value) +{ + if (null_value) + return str->append("null", 4); + + if (item->type_handler()->is_bool_type()) + { + return ((*res)[0] == '1') ? + str->append("true", 4) : + str->append("false", 5); + } + + if (item->is_json_type()) + return str->append(res->ptr(), res->length()); + + if (item->result_type() == STRING_RESULT) + { + return str->append("\"", 1) || + st_append_escaped(str, res) || + str->append("\"", 1); + } + return st_append_escaped(str, res); +} + + static int append_json_keyname(String *str, Item *item, String *tmp_val) { String *sv= item->val_str(tmp_val); @@ -3621,12 +3646,13 @@ int Arg_comparator::compare_e_json_str_basic(Item *j, Item *s) } -String* Item_func_json_arrayagg::convert_to_json(Item *item, String *res) +bool Item_func_json_arrayagg::convert_to_json(String *str, String *res, + Item *item, bool null_value) { - String tmp; - res->length(0); - append_json_value(res, item, &tmp); - return res; + str->length(0); + if (append_json_value(str, res, item, null_value)) + return true; + return false; } diff --git a/sql/item_jsonfunc.h b/sql/item_jsonfunc.h index 44f9e8146c2..c155ed50396 100644 --- a/sql/item_jsonfunc.h +++ b/sql/item_jsonfunc.h @@ -545,6 +545,7 @@ class Item_func_json_arrayagg : public Item_func_group_concat Item_func_group_concat(thd, context_arg, is_distinct, is_select, is_order, is_separator, limit_clause, row_limit, offset_limit) { + exclude_nulls= FALSE; } Item_func_json_arrayagg(THD *thd, Item_func_json_arrayagg *item); bool is_json_type() { return true; } @@ -552,14 +553,10 @@ class Item_func_json_arrayagg : public Item_func_group_concat const char *func_name() const { return "json_arrayagg("; } enum Sumfunctype sum_func() const {return JSON_ARRAYAGG_FUNC;} - String* convert_to_json(Item *item, String *str); + bool convert_to_json(String *str, String *res, Item *item, bool null_value); String* val_str(String *str); - /* Overrides Item_func_group_concat::add() */ - bool add() - { - return Item_func_group_concat::add(false); - } + Item *get_copy(THD *thd) { return get_item_copy<Item_func_json_arrayagg>(thd, this); } }; diff --git a/sql/item_sum.cc b/sql/item_sum.cc index 5c732095573..a04dbdc19e2 100644 --- a/sql/item_sum.cc +++ b/sql/item_sum.cc @@ -3518,7 +3518,7 @@ String *Item_sum_udf_str::val_str(String *str) */ extern "C" -int group_concat_key_cmp_with_distinct(void* arg, const void* key1, +int group_concat_key_cmp_with_distinct(void* arg, const void* key1, const void* key2) { Item_func_group_concat *item_func= (Item_func_group_concat*)arg; @@ -3552,6 +3552,54 @@ int group_concat_key_cmp_with_distinct(void* arg, const void* key1, } +int group_concat_key_cmp_with_distinct_with_nulls(void* arg, + const void* key1_arg, + const void* key2_arg) +{ + Item_func_group_concat *item_func= (Item_func_group_concat*)arg; + + uchar *key1= (uchar*)key1_arg + item_func->table->s->null_bytes; + uchar *key2= (uchar*)key2_arg + item_func->table->s->null_bytes; + + for (uint i= 0; i < item_func->arg_count_field; i++) + { + Item *item= item_func->args[i]; + /* + If item is a const item then either get_tmp_table_field returns 0 + or it is an item over a const table. + */ + if (item->const_item()) + continue; + /* + We have to use get_tmp_table_field() instead of + real_item()->get_tmp_table_field() because we want the field in + the temporary table, not the original field + */ + Field *field= item->get_tmp_table_field(); + + if (!field) + continue; + + if (field->is_null_in_record((uchar*)key1_arg) && + field->is_null_in_record((uchar*)key2_arg)) + continue; + + if (field->is_null_in_record((uchar*)key1_arg)) + return -1; + + if (field->is_null_in_record((uchar*)key2_arg)) + return 1; + + uint offset= (field->offset(field->table->record[0]) - + field->table->s->null_bytes); + int res= field->cmp(key1 + offset, key2 + offset); + if (res) + return res; + } + return 0; +} + + /** function of sort for syntax: GROUP_CONCAT(expr,... ORDER BY col,... ) */ @@ -3621,6 +3669,7 @@ int dump_leaf_key(void* key_arg, element_count count __attribute__((unused)), uint max_length= (uint)table->in_use->variables.group_concat_max_len; String tmp((char *)table->record[1], table->s->reclength, default_charset_info); + const bool exclude_nulls= item->exclude_nulls; String tmp2; uchar *key= (uchar *) key_arg; String *result= &item->result; @@ -3650,9 +3699,11 @@ int dump_leaf_key(void* key_arg, element_count count __attribute__((unused)), result->append(*item->separator); + bool is_null= false; for (; arg < arg_end; arg++) { String *res; + is_null= false; /* We have to use get_tmp_table_field() instead of real_item()->get_tmp_table_field() because we want the field in @@ -3661,7 +3712,11 @@ int dump_leaf_key(void* key_arg, element_count count __attribute__((unused)), because it contains both order and arg list fields. */ if ((*arg)->const_item()) + { res= (*arg)->val_str(&tmp); + if ((*arg)->null_value) + is_null= TRUE; + } else { Field *field= (*arg)->get_tmp_table_field(); @@ -3670,7 +3725,11 @@ int dump_leaf_key(void* key_arg, element_count count __attribute__((unused)), uint offset= (field->offset(field->table->record[0]) - table->s->null_bytes); DBUG_ASSERT(offset < table->s->reclength); - res= field->val_str(&tmp, key + offset); + if (!exclude_nulls && field->is_null_in_record(key)) + is_null= true; + res= field->val_str(&tmp, + key + offset + (exclude_nulls ? 0 : + table->s->null_bytes +offset)); } else res= (*arg)->val_str(&tmp); @@ -3684,10 +3743,12 @@ int dump_leaf_key(void* key_arg, element_count count __attribute__((unused)), appending it to the result */ Item_func_json_arrayagg *arrayagg= (Item_func_json_arrayagg *) item_arg; - res= arrayagg->convert_to_json(*arg, res); + if (arrayagg->convert_to_json(&tmp2, res, *arg, is_null)) + return 1; + result->append(tmp2); } - - result->append(*res); + else + result->append(*res); } } @@ -3753,7 +3814,7 @@ Item_func_group_concat(THD *thd, Name_resolution_context *context_arg, warning_for_row(FALSE), force_copy_fields(0), row_limit(NULL), offset_limit(NULL), limit_clause(limit_clause), - copy_offset_limit(0), copy_row_limit(0), original(0) + copy_offset_limit(0), copy_row_limit(0), original(0), exclude_nulls(TRUE) { Item *item_select; Item **arg_ptr; @@ -3822,7 +3883,8 @@ Item_func_group_concat::Item_func_group_concat(THD *thd, force_copy_fields(item->force_copy_fields), row_limit(item->row_limit), offset_limit(item->offset_limit), limit_clause(item->limit_clause),copy_offset_limit(item->copy_offset_limit), - copy_row_limit(item->copy_row_limit), original(item) + copy_row_limit(item->copy_row_limit), original(item), + exclude_nulls(item->exclude_nulls) { quick_group= item->quick_group; result.set_charset(collation.collation); @@ -3994,7 +4056,7 @@ bool Item_func_group_concat::repack_tree(THD *thd) */ #define GCONCAT_REPACK_FACTOR (1 << 10) -bool Item_func_group_concat::add(bool exclude_nulls) +bool Item_func_group_concat::add() { if (always_null && exclude_nulls) return 0; @@ -4020,6 +4082,14 @@ bool Item_func_group_concat::add(bool exclude_nulls) if (tree && (res= field->val_str(&buf))) row_str_len+= res->length(); } + else + { + /* + should not reach here, we create temp table for all the arguments of + the group_concat function + */ + DBUG_ASSERT(0); + } } null_value= FALSE; @@ -4029,7 +4099,9 @@ bool Item_func_group_concat::add(bool exclude_nulls) { /* Filter out duplicate rows. */ uint count= unique_filter->elements_in_tree(); - unique_filter->unique_add(table->record[0] + table->s->null_bytes); + unique_filter->unique_add(exclude_nulls ? + table->record[0] + table->s->null_bytes : + table->record[0]); if (count == unique_filter->elements_in_tree()) row_eligible= FALSE; } @@ -4055,7 +4127,9 @@ bool Item_func_group_concat::add(bool exclude_nulls) row to the output buffer here. That will be done in val_str. */ if (row_eligible && !warning_for_row && (!tree && !distinct)) - dump_leaf_key(table->record[0] + table->s->null_bytes, 1, this); + dump_leaf_key(exclude_nulls ? + table->record[0] + table->s->null_bytes : + table->record[0], 1, this); return 0; } @@ -4258,9 +4332,12 @@ bool Item_func_group_concat::setup(THD *thd) } if (distinct) - unique_filter= new Unique(group_concat_key_cmp_with_distinct, + unique_filter= new Unique((exclude_nulls ? + group_concat_key_cmp_with_distinct : + group_concat_key_cmp_with_distinct_with_nulls), (void*)this, - tree_key_length, + tree_key_length + (exclude_nulls ? 0: + table->s->null_bytes), ram_limitation(thd)); if ((row_limit && row_limit->cmp_type() != INT_RESULT) || (offset_limit && offset_limit->cmp_type() != INT_RESULT)) diff --git a/sql/item_sum.h b/sql/item_sum.h index b10d9f5974d..908dbe3cce9 100644 --- a/sql/item_sum.h +++ b/sql/item_sum.h @@ -1841,6 +1841,8 @@ class Item_sum_udf_str :public Item_sum_double C_MODE_START int group_concat_key_cmp_with_distinct(void* arg, const void* key1, const void* key2); +int group_concat_key_cmp_with_distinct_with_nulls(void* arg, const void* key1, + const void* key2); int group_concat_key_cmp_with_order(void* arg, const void* key1, const void* key2); int dump_leaf_key(void* key_arg, @@ -1897,14 +1899,19 @@ class Item_func_group_concat : public Item_sum */ Item_func_group_concat *original; + bool exclude_nulls; + /* Used by Item_func_group_concat and Item_func_json_arrayagg. The latter needs null values but the former doesn't. */ - bool add(bool exclude_nulls); + bool add(); friend int group_concat_key_cmp_with_distinct(void* arg, const void* key1, const void* key2); + friend int group_concat_key_cmp_with_distinct_with_nulls(void* arg, + const void* key1, + const void* key2); friend int group_concat_key_cmp_with_order(void* arg, const void* key1, const void* key2); friend int dump_leaf_key(void* key_arg, @@ -1940,10 +1947,6 @@ class Item_func_group_concat : public Item_sum return &type_handler_varchar; } void clear(); - bool add() - { - return add(true); - } void reset_field() { DBUG_ASSERT(0); } // not used void update_field() { DBUG_ASSERT(0); } // not used bool fix_fields(THD *,Item **);

1 0

[Commits] 7c56f46: MDEV-21883 Server crashes when joining a subselect with 32 tables and GROUP BY
by IgorBabaev 24 Mar '20

24 Mar '20

revision-id: 7c56f46d611eda7dadde83fa4049c2121d42382d (mariadb-10.3.18-190-g7c56f46) parent(s): 44298e4dea39280187c587c6e776ce8d04e350de author: Igor Babaev committer: Igor Babaev timestamp: 2020-03-23 19:20:48 -0700 message: MDEV-21883 Server crashes when joining a subselect with 32 tables and GROUP BY This bug could cause a crash for any query that used a derived table/view/CTE whose specification was a SELECT with a GROUP BY clause and a FROM list containing 32 or more table references. The problem appeared only in the cases when the splitting optimization could be applied to such derived table/view/CTE. --- mysql-test/main/derived_cond_pushdown.result | 85 ++++++++++++++++++++++++++++ mysql-test/main/derived_cond_pushdown.test | 51 +++++++++++++++++ sql/opt_split.cc | 2 +- 3 files changed, 137 insertions(+), 1 deletion(-) diff --git a/mysql-test/main/derived_cond_pushdown.result b/mysql-test/main/derived_cond_pushdown.result index 1ae78ae..532a6cc 100644 --- a/mysql-test/main/derived_cond_pushdown.result +++ b/mysql-test/main/derived_cond_pushdown.result @@ -16918,4 +16918,89 @@ Warnings: Note 1003 /* select#1 */ select `test`.`t1`.`id` AS `id`,`test`.`t1`.`a` AS `a` from `test`.`t1` semi join ((/* select#3 */ select `test`.`t1`.`id` AS `id`,`test`.`t1`.`a` AS `a` from `test`.`t1` left join `test`.`t2` on(`test`.`t2`.`ro_id` = `test`.`t1`.`id` and `test`.`t2`.`flag` = 1) where `test`.`t1`.`id` = `test`.`t1`.`id` group by `test`.`t1`.`id`) `dt`) where `dt`.`id` = `test`.`t1`.`id` drop view v1; drop table t1,t2; +# +# MDEV-21883: potentially splittable materialized derived +# that uses a join of 32 tables +# +CREATE TABLE t (id INT NOT NULL PRIMARY KEY); +INSERT INTO t values (1),(2),(3); +set statement optimizer_switch='split_materialized=off' for SELECT t.id FROM t +LEFT JOIN ( +SELECT t0.id FROM t AS t0 +LEFT JOIN t AS t1 ON 0=1 +LEFT JOIN t AS t2 ON 0=1 +LEFT JOIN t AS t3 ON 0=1 +LEFT JOIN t AS t4 ON 0=1 +LEFT JOIN t AS t5 ON 0=1 +LEFT JOIN t AS t6 ON 0=1 +LEFT JOIN t AS t7 ON 0=1 +LEFT JOIN t AS t8 ON 0=1 +LEFT JOIN t AS t9 ON 0=1 +LEFT JOIN t AS t10 ON 0=1 +LEFT JOIN t AS t11 ON 0=1 +LEFT JOIN t AS t12 ON 0=1 +LEFT JOIN t AS t13 ON 0=1 +LEFT JOIN t AS t14 ON 0=1 +LEFT JOIN t AS t15 ON 0=1 +LEFT JOIN t AS t16 ON 0=1 +LEFT JOIN t AS t17 ON 0=1 +LEFT JOIN t AS t18 ON 0=1 +LEFT JOIN t AS t19 ON 0=1 +LEFT JOIN t AS t20 ON 0=1 +LEFT JOIN t AS t21 ON 0=1 +LEFT JOIN t AS t22 ON 0=1 +LEFT JOIN t AS t23 ON 0=1 +LEFT JOIN t AS t24 ON 0=1 +LEFT JOIN t AS t25 ON 0=1 +LEFT JOIN t AS t26 ON 0=1 +LEFT JOIN t AS t27 ON 0=1 +LEFT JOIN t AS t28 ON 0=1 +LEFT JOIN t AS t29 ON 0=1 +LEFT JOIN t AS t30 ON 0=1 +LEFT JOIN t AS t31 ON 0=1 +GROUP BY t0.id) AS dt ON dt.id = t.id; +id +1 +2 +3 +set statement optimizer_switch='split_materialized=on' for SELECT t.id FROM t +LEFT JOIN ( +SELECT t0.id FROM t AS t0 +LEFT JOIN t AS t1 ON 0=1 +LEFT JOIN t AS t2 ON 0=1 +LEFT JOIN t AS t3 ON 0=1 +LEFT JOIN t AS t4 ON 0=1 +LEFT JOIN t AS t5 ON 0=1 +LEFT JOIN t AS t6 ON 0=1 +LEFT JOIN t AS t7 ON 0=1 +LEFT JOIN t AS t8 ON 0=1 +LEFT JOIN t AS t9 ON 0=1 +LEFT JOIN t AS t10 ON 0=1 +LEFT JOIN t AS t11 ON 0=1 +LEFT JOIN t AS t12 ON 0=1 +LEFT JOIN t AS t13 ON 0=1 +LEFT JOIN t AS t14 ON 0=1 +LEFT JOIN t AS t15 ON 0=1 +LEFT JOIN t AS t16 ON 0=1 +LEFT JOIN t AS t17 ON 0=1 +LEFT JOIN t AS t18 ON 0=1 +LEFT JOIN t AS t19 ON 0=1 +LEFT JOIN t AS t20 ON 0=1 +LEFT JOIN t AS t21 ON 0=1 +LEFT JOIN t AS t22 ON 0=1 +LEFT JOIN t AS t23 ON 0=1 +LEFT JOIN t AS t24 ON 0=1 +LEFT JOIN t AS t25 ON 0=1 +LEFT JOIN t AS t26 ON 0=1 +LEFT JOIN t AS t27 ON 0=1 +LEFT JOIN t AS t28 ON 0=1 +LEFT JOIN t AS t29 ON 0=1 +LEFT JOIN t AS t30 ON 0=1 +LEFT JOIN t AS t31 ON 0=1 +GROUP BY t0.id) AS dt ON dt.id = t.id; +id +1 +2 +3 +DROP TABLE t; # End of 10.3 tests diff --git a/mysql-test/main/derived_cond_pushdown.test b/mysql-test/main/derived_cond_pushdown.test index 525122e..592f23d 100644 --- a/mysql-test/main/derived_cond_pushdown.test +++ b/mysql-test/main/derived_cond_pushdown.test @@ -3371,4 +3371,55 @@ eval explain extended $q2; drop view v1; drop table t1,t2; +--echo # +--echo # MDEV-21883: potentially splittable materialized derived +--echo # that uses a join of 32 tables +--echo # + +CREATE TABLE t (id INT NOT NULL PRIMARY KEY); +INSERT INTO t values (1),(2),(3); + +let $q= +SELECT t.id FROM t +LEFT JOIN ( + SELECT t0.id FROM t AS t0 + LEFT JOIN t AS t1 ON 0=1 + LEFT JOIN t AS t2 ON 0=1 + LEFT JOIN t AS t3 ON 0=1 + LEFT JOIN t AS t4 ON 0=1 + LEFT JOIN t AS t5 ON 0=1 + LEFT JOIN t AS t6 ON 0=1 + LEFT JOIN t AS t7 ON 0=1 + LEFT JOIN t AS t8 ON 0=1 + LEFT JOIN t AS t9 ON 0=1 + LEFT JOIN t AS t10 ON 0=1 + LEFT JOIN t AS t11 ON 0=1 + LEFT JOIN t AS t12 ON 0=1 + LEFT JOIN t AS t13 ON 0=1 + LEFT JOIN t AS t14 ON 0=1 + LEFT JOIN t AS t15 ON 0=1 + LEFT JOIN t AS t16 ON 0=1 + LEFT JOIN t AS t17 ON 0=1 + LEFT JOIN t AS t18 ON 0=1 + LEFT JOIN t AS t19 ON 0=1 + LEFT JOIN t AS t20 ON 0=1 + LEFT JOIN t AS t21 ON 0=1 + LEFT JOIN t AS t22 ON 0=1 + LEFT JOIN t AS t23 ON 0=1 + LEFT JOIN t AS t24 ON 0=1 + LEFT JOIN t AS t25 ON 0=1 + LEFT JOIN t AS t26 ON 0=1 + LEFT JOIN t AS t27 ON 0=1 + LEFT JOIN t AS t28 ON 0=1 + LEFT JOIN t AS t29 ON 0=1 + LEFT JOIN t AS t30 ON 0=1 + LEFT JOIN t AS t31 ON 0=1 + GROUP BY t0.id) AS dt ON dt.id = t.id; + +eval set statement optimizer_switch='split_materialized=off' for $q; + +eval set statement optimizer_switch='split_materialized=on' for $q; + +DROP TABLE t; + --echo # End of 10.3 tests diff --git a/sql/opt_split.cc b/sql/opt_split.cc index 6f8248c..c70fac4 100644 --- a/sql/opt_split.cc +++ b/sql/opt_split.cc @@ -968,7 +968,7 @@ SplM_plan_info * JOIN_TAB::choose_best_splitting(double record_count, The plan for the chosen key has not been found in the cache. Build a new plan and save info on it in the cache */ - table_map all_table_map= (1 << join->table_count) - 1; + table_map all_table_map= (((table_map) 1) << join->table_count) - 1; reset_validity_vars_for_keyuses(best_key_keyuse_ext_start, best_table, best_key, remaining_tables, true); choose_plan(join, all_table_map & ~join->const_table_map);

1 0

[Commits] 03c1b08f0f9: Fix compile error on Windows
by psergey 22 Mar '20

22 Mar '20

revision-id: 03c1b08f0f96f55cc4ff06f7eb237d172875e063 (mariadb-10.5.0-427-g03c1b08f0f9) parent(s): 0da66e563076e9675a545757b76215c43258ad99 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2020-03-22 17:59:53 +0300 message: Fix compile error on Windows --- sql/sql_select.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sql/sql_select.cc b/sql/sql_select.cc index 0a2af55326a..5eabdc74f45 100644 --- a/sql/sql_select.cc +++ b/sql/sql_select.cc @@ -7196,7 +7196,7 @@ double matching_candidates_in_table(JOIN_TAB *s, bool with_found_constraint, { TABLE *table= s->table; double sel= table->cond_selectivity; - double table_records= s->records; + double table_records= rows2double(s->records); dbl_records= table_records * sel; return dbl_records; }

1 0

[Commits] 0da66e56307: MDEV-21992: queries in innodb_ext_keys use sub-optimal plan with rowid filter
by psergey 22 Mar '20

22 Mar '20

revision-id: 0da66e563076e9675a545757b76215c43258ad99 (mariadb-10.5.0-426-g0da66e56307) parent(s): 8955a27cb0915f6f8a11e10575d5b382e1c2d8c4 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2020-03-22 17:05:15 +0300 message: MDEV-21992: queries in innodb_ext_keys use sub-optimal plan with rowid filter Don't construct rowid filter from indexes on which we do index-only scans. The idea is that in this case we can just use the scan that we've used to construct the filter. --- mysql-test/main/innodb_ext_key.result | 18 +++++++++--------- sql/rowid_filter.cc | 16 ++++++++++++++++ 2 files changed, 25 insertions(+), 9 deletions(-) diff --git a/mysql-test/main/innodb_ext_key.result b/mysql-test/main/innodb_ext_key.result index f29f81c0ee4..ff92b4506ba 100644 --- a/mysql-test/main/innodb_ext_key.result +++ b/mysql-test/main/innodb_ext_key.result @@ -13,7 +13,7 @@ set optimizer_switch='extended_keys=off'; explain select count(*) from lineitem where l_orderkey=130 and l_shipdate='1992-07-01'; id select_type table type possible_keys key key_len ref rows Extra -1 SIMPLE lineitem ref|filter PRIMARY,i_l_shipdate,i_l_orderkey,i_l_orderkey_quantity i_l_orderkey_quantity|i_l_shipdate 4|4 const 5 (0%) Using where; Using rowid filter +1 SIMPLE lineitem ref PRIMARY,i_l_shipdate,i_l_orderkey,i_l_orderkey_quantity PRIMARY 4 const 5 Using where flush status; select count(*) from lineitem where l_orderkey=130 and l_shipdate='1992-07-01'; count(*) @@ -21,9 +21,9 @@ count(*) show status like 'handler_read%'; Variable_name Value Handler_read_first 0 -Handler_read_key 2 +Handler_read_key 1 Handler_read_last 0 -Handler_read_next 7 +Handler_read_next 5 Handler_read_prev 0 Handler_read_retry 0 Handler_read_rnd 0 @@ -33,7 +33,7 @@ set optimizer_switch='extended_keys=on'; explain select count(*) from lineitem where l_orderkey=130 and l_shipdate='1992-07-01'; id select_type table type possible_keys key key_len ref rows Extra -1 SIMPLE lineitem ref|filter PRIMARY,i_l_shipdate,i_l_orderkey,i_l_orderkey_quantity i_l_orderkey|i_l_shipdate 4|8 const 5 (0%) Using where; Using rowid filter +1 SIMPLE lineitem ref PRIMARY,i_l_shipdate,i_l_orderkey,i_l_orderkey_quantity i_l_shipdate 8 const,const 1 Using index flush status; select count(*) from lineitem where l_orderkey=130 and l_shipdate='1992-07-01'; count(*) @@ -41,9 +41,9 @@ count(*) show status like 'handler_read%'; Variable_name Value Handler_read_first 0 -Handler_read_key 2 +Handler_read_key 1 Handler_read_last 0 -Handler_read_next 2 +Handler_read_next 1 Handler_read_prev 0 Handler_read_retry 0 Handler_read_rnd 0 @@ -274,7 +274,7 @@ explain select max(l_linenumber) from lineitem where l_shipdate='1992-07-01' and l_orderkey=130; id select_type table type possible_keys key key_len ref rows Extra -1 SIMPLE lineitem ref|filter PRIMARY,i_l_shipdate,i_l_orderkey,i_l_orderkey_quantity i_l_orderkey_quantity|i_l_shipdate 4|4 const 5 (0%) Using where; Using rowid filter +1 SIMPLE lineitem ref PRIMARY,i_l_shipdate,i_l_orderkey,i_l_orderkey_quantity PRIMARY 4 const 5 Using where flush status; select max(l_linenumber) from lineitem where l_shipdate='1992-07-01' and l_orderkey=130; @@ -283,9 +283,9 @@ max(l_linenumber) show status like 'handler_read%'; Variable_name Value Handler_read_first 0 -Handler_read_key 2 +Handler_read_key 1 Handler_read_last 0 -Handler_read_next 7 +Handler_read_next 5 Handler_read_prev 0 Handler_read_retry 0 Handler_read_rnd 0 diff --git a/sql/rowid_filter.cc b/sql/rowid_filter.cc index 865f22b431a..6fb7035a460 100644 --- a/sql/rowid_filter.cc +++ b/sql/rowid_filter.cc @@ -350,7 +350,19 @@ void TABLE::init_cost_info_for_usable_range_rowid_filters(THD *thd) From all indexes that can be used for range accesses select only such that - range filter pushdown is supported by the engine for them (1) - they are not clustered primary (2) + - they are not covering (2a) - the range filter containers for them are not too large (3) + + (2a) is based on this logic: if the index $IDX is covering, and we are + going to do a scan on it to build the filter, we can just use $IDX for + reading rows, and not as a filter for some other index. + In ideal world, we would not need to use this condition explicilty because + + cost(scan on $IDX) < cost(scan on $IDX)+cost(build the filter)+ ... + + cost(doing a scan on other index) + + however in reality cost formulas in different parts of the optimizer do not + agree with each other so this is needed. */ while ((key_no= it++) != key_map::Iterator::BITMAP_END) { @@ -358,6 +370,10 @@ void TABLE::init_cost_info_for_usable_range_rowid_filters(THD *thd) continue; if (key_no == s->primary_key && file->primary_key_is_clustered()) // !2 continue; + + if (covering_keys.is_set(key_no)) // !2a + continue; + if (quick_rows[key_no] > get_max_range_rowid_filter_elems_for_table(thd, this, SORTED_ARRAY_CONTAINER)) // !3

1 0

[Commits] a180dac: MDEV-17177 Crash in Item_func_in::cleanup() for SELECT executed via
by IgorBabaev 20 Mar '20

20 Mar '20

revision-id: a180dac22deedf6cae7ef026255102af37737d67 (mariadb-10.2.31-64-ga180dac) parent(s): a0ce62f804dc1a0073688bea46dc2e6728cf55e3 author: Igor Babaev committer: Igor Babaev timestamp: 2020-03-19 21:52:52 -0700 message: MDEV-17177 Crash in Item_func_in::cleanup() for SELECT executed via prepared statement The method Item_func_in::build_clone() that builds a clone item for an Item_func_in item first calls a generic method Item_func::build_item() that builds the the clones for the arguments of the Item_func_in item to be cloned, creates a copy of the Item_func_in object and attaches the clones for the arguments to this copy. Then the method Item_func_in::build_clone() makes the copy fully independent on the copied object in order to guarantee a proper destruction of the clone. The fact is the copy of the Item_func_in object is registered as any other item object and should be destructed as any other item object. If the method Item_func::build_item fails to build a clone of an argument then it returns 0. In this case no copy of the Item_func_in object should be created. Otherwise the finalizing actions for this copy would not be performed and the copy would remain in a state that would prevent its proper destruction. The code of Item_func_in::build_clone() before this patch created the copy of the Item_func_in object before cloning the argument items. If this cloning failed the server crashed when trying to destruct the copy item. The code of Item_row::build_clone() was changed similarly to the code of Item_func::build_clone though this code could not cause any problems. --- mysql-test/r/derived_cond_pushdown.result | 12 +++++++++++ mysql-test/t/derived_cond_pushdown.test | 16 ++++++++++++++ sql/item.cc | 35 +++++++++++++++++-------------- sql/item_row.cc | 11 ++++++---- 4 files changed, 54 insertions(+), 20 deletions(-) diff --git a/mysql-test/r/derived_cond_pushdown.result b/mysql-test/r/derived_cond_pushdown.result index 1010ed6..e2c2463 100644 --- a/mysql-test/r/derived_cond_pushdown.result +++ b/mysql-test/r/derived_cond_pushdown.result @@ -10581,4 +10581,16 @@ a b max_c a b dayname(v1.b) DROP VIEW v1; DROP TABLE t1, t2; SET optimizer_switch=DEFAULT; +# +# MDEV-17177: an attempt to push down IN predicate when one of +# the arguments is too complex to be cloned +# +CREATE TABLE t1 (a VARCHAR(8)); +INSERT INTO t1 VALUES ('abc'),('def'); +CREATE VIEW v1 AS SELECT * FROM t1 GROUP BY a; +SELECT * FROM v1 WHERE IF( a REGEXP 'def', 'foo', a ) IN ('abc', 'foobar'); +a +abc +DROP VIEW v1; +DROP TABLE t1; # End of 10.2 tests diff --git a/mysql-test/t/derived_cond_pushdown.test b/mysql-test/t/derived_cond_pushdown.test index ec15791..a7df65f 100644 --- a/mysql-test/t/derived_cond_pushdown.test +++ b/mysql-test/t/derived_cond_pushdown.test @@ -2168,4 +2168,20 @@ DROP TABLE t1, t2; SET optimizer_switch=DEFAULT; + + +--echo # +--echo # MDEV-17177: an attempt to push down IN predicate when one of +--echo # the arguments is too complex to be cloned +--echo # + +CREATE TABLE t1 (a VARCHAR(8)); +INSERT INTO t1 VALUES ('abc'),('def'); +CREATE VIEW v1 AS SELECT * FROM t1 GROUP BY a; + +SELECT * FROM v1 WHERE IF( a REGEXP 'def', 'foo', a ) IN ('abc', 'foobar'); + +DROP VIEW v1; +DROP TABLE t1; + --echo # End of 10.2 tests diff --git a/sql/item.cc b/sql/item.cc index 4f8433c..ab7340a 100644 --- a/sql/item.cc +++ b/sql/item.cc @@ -2389,37 +2389,40 @@ bool Item_func_or_sum::agg_item_set_converter(const DTCollation &coll, @param mem_root part of the memory for the clone @details - This method gets copy of the current item and also - build clones for its referencies. For the referencies - build_copy is called again. + This method fisrt builds clones of the arguments. If it is successful with + buiding the clones then it constructs a copy of this Item_func_or_sum object + and attaches to it the built clones of the arguments. @retval - clone of the item - 0 if an error occured + clone of the item on success + 0 on a failure */ Item* Item_func_or_sum::build_clone(THD *thd, MEM_ROOT *mem_root) { - Item_func_or_sum *copy= (Item_func_or_sum *) get_copy(thd, mem_root); - if (!copy) - return 0; + Item *copy_tmp_args[2]= {0,0}; + Item **copy_args= copy_tmp_args; if (arg_count > 2) { - copy->args= - (Item**) alloc_root(mem_root, sizeof(Item*) * arg_count); - if (!copy->args) + if (!(copy_args= (Item**) alloc_root(mem_root, sizeof(Item*) * arg_count))) return 0; } - else if (arg_count > 0) - copy->args= copy->tmp_arg; - - for (uint i= 0; i < arg_count; i++) { Item *arg_clone= args[i]->build_clone(thd, mem_root); if (!arg_clone) return 0; - copy->args[i]= arg_clone; + copy_args[i]= arg_clone; + } + Item_func_or_sum *copy= (Item_func_or_sum *) get_copy(thd, mem_root); + if (!copy) + return 0; + if (arg_count > 2) + copy->args= copy_args; + else if (arg_count > 0) + { + copy->args= copy->tmp_arg; + memcpy(copy->args, copy_args, sizeof(Item *) * arg_count); } return copy; } diff --git a/sql/item_row.cc b/sql/item_row.cc index 000253e..6ae049d 100644 --- a/sql/item_row.cc +++ b/sql/item_row.cc @@ -166,17 +166,20 @@ void Item_row::bring_value() Item* Item_row::build_clone(THD *thd, MEM_ROOT *mem_root) { - Item_row *copy= (Item_row *) get_copy(thd, mem_root); - if (!copy) + Item **copy_args= 0; + if (!(copy_args= (Item**) alloc_root(mem_root, sizeof(Item*) * arg_count))) return 0; - copy->args= (Item**) alloc_root(mem_root, sizeof(Item*) * arg_count); for (uint i= 0; i < arg_count; i++) { Item *arg_clone= args[i]->build_clone(thd, mem_root); if (!arg_clone) return 0; - copy->args[i]= arg_clone; + copy_args[i]= arg_clone; } + Item_row *copy= (Item_row *) get_copy(thd, mem_root); + if (!copy) + return 0; + copy->args= copy_args; return copy; }

1 0