- commits - lists.mariadb.org

[Commits] 5cae53b4bde: MDEV-25397: JSON_TABLE: Unexpected ER_MIX_OF_GROUP_FUNC_AND_FIELDS
by psergey 13 Apr '21

13 Apr '21

revision-id: 5cae53b4bde6b5736633a34eee5e509c0637f99e (mariadb-10.5.2-582-g5cae53b4bde) parent(s): eab2d0bb7ea31e2b4d468516c44d84c3e7768fab author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-13 12:34:14 +0300 message: MDEV-25397: JSON_TABLE: Unexpected ER_MIX_OF_GROUP_FUNC_AND_FIELDS When doing name resolution, do the same what WHERE/ON clauses do: they don't count in select_lex->non_agg_field_used(). --- mysql-test/suite/json/r/json_table.result | 11 +++++++++++ mysql-test/suite/json/t/json_table.test | 11 +++++++++++ sql/json_table.cc | 6 ++++++ 3 files changed, 28 insertions(+) diff --git a/mysql-test/suite/json/r/json_table.result b/mysql-test/suite/json/r/json_table.result index 619aeea985e..998dc84ca35 100644 --- a/mysql-test/suite/json/r/json_table.result +++ b/mysql-test/suite/json/r/json_table.result @@ -803,5 +803,16 @@ SELECT * FROM v; b DROP VIEW v; # +# MDEV-25397: JSON_TABLE: Unexpected ER_MIX_OF_GROUP_FUNC_AND_FIELDS upon query with JOIN +# +set @save_sql_mode= @@sql_mode; +SET sql_mode='ONLY_FULL_GROUP_BY'; +CREATE TABLE t1 (a TEXT); +SELECT SUM(o) FROM t1 JOIN JSON_TABLE(t1.a, '$' COLUMNS(o FOR ORDINALITY)) jt; +SUM(o) +NULL +set sql_mode=@save_sql_mode; +drop table t1; +# # End of 10.6 tests # diff --git a/mysql-test/suite/json/t/json_table.test b/mysql-test/suite/json/t/json_table.test index 9b31ddeb3b6..636ba2ca2de 100644 --- a/mysql-test/suite/json/t/json_table.test +++ b/mysql-test/suite/json/t/json_table.test @@ -698,6 +698,17 @@ SELECT * FROM v; DROP VIEW v; +--echo # +--echo # MDEV-25397: JSON_TABLE: Unexpected ER_MIX_OF_GROUP_FUNC_AND_FIELDS upon query with JOIN +--echo # +set @save_sql_mode= @@sql_mode; +SET sql_mode='ONLY_FULL_GROUP_BY'; +CREATE TABLE t1 (a TEXT); +SELECT SUM(o) FROM t1 JOIN JSON_TABLE(t1.a, '$' COLUMNS(o FOR ORDINALITY)) jt; + +set sql_mode=@save_sql_mode; +drop table t1; + --echo # --echo # End of 10.6 tests --echo # diff --git a/sql/json_table.cc b/sql/json_table.cc index fe76f9c44f0..000af50c391 100644 --- a/sql/json_table.cc +++ b/sql/json_table.cc @@ -1055,9 +1055,15 @@ int Table_function_json_table::setup(THD *thd, TABLE_LIST *sql_table, // table function reference m_context->ignored_tables= get_disallowed_table_deps(s_lex->join, t->map); + // Do the same what setup_without_group() does: do not count the referred + // fields in non_agg_field_used: + const bool saved_non_agg_field_used= s_lex->non_agg_field_used(); + res= m_json->fix_fields_if_needed(thd, &m_json); thd->lex->current_select->is_item_list_lookup= save_is_item_list_lookup; + s_lex->set_non_agg_field_used(saved_non_agg_field_used); + if (res) return TRUE; }

1 0

[Commits] 6dfeeee6fd3: MDEV-25381: JSON_TABLE: ER_WRONG_OUTER_JOIN upon query with LEFT and RIGHT joins and view
by psergey 12 Apr '21

12 Apr '21

revision-id: 6dfeeee6fd3f60c53d9afaef13cdf4bc1fa1f6da (mariadb-10.5.2-576-g6dfeeee6fd3) parent(s): a534d27a1c110a868d434741910eafb678a2a0ea author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-12 16:43:45 +0300 message: MDEV-25381: JSON_TABLE: ER_WRONG_OUTER_JOIN upon query with LEFT and RIGHT joins and view Table_function_json_table::m_dep_tables attempts to cache the value of m_json->used_tables(), poorly. Remove the cache and use the value directly. --- mysql-test/suite/json/r/json_table.result | 43 +++++++++++++++++++++++++++++++ mysql-test/suite/json/t/json_table.test | 41 +++++++++++++++++++++++++++++ sql/json_table.cc | 20 +------------- sql/json_table.h | 19 +++++++------- 4 files changed, 95 insertions(+), 28 deletions(-) diff --git a/mysql-test/suite/json/r/json_table.result b/mysql-test/suite/json/r/json_table.result index d913da18c50..8789f4ced8d 100644 --- a/mysql-test/suite/json/r/json_table.result +++ b/mysql-test/suite/json/r/json_table.result @@ -750,5 +750,48 @@ id select_type table type possible_keys key key_len ref rows Extra 1 PRIMARY jt ALL NULL NULL NULL NULL 40 Table function: json_table; Using where; FirstMatch(t1) drop table t1; # +# MDEV-25381: JSON_TABLE: ER_WRONG_OUTER_JOIN upon query with LEFT and RIGHT joins and view +# +CREATE TABLE t1 (a INT); +INSERT INTO t1 VALUES (1),(2); +CREATE TABLE t2 (b INT, c TEXT); +INSERT INTO t2 VALUES (1,'{}'),(2,'[]'); +CREATE VIEW v2 AS SELECT * FROM t2; +SELECT * +FROM +t1 RIGHT JOIN +t2 AS tt +LEFT JOIN +JSON_TABLE(tt.c, '$' COLUMNS(o FOR ORDINALITY)) AS jt +ON tt.b = jt.o +ON t1.a = tt.b; +a b c o +1 1 {} 1 +2 2 [] NULL +SELECT * +FROM +t1 RIGHT JOIN +v2 AS tt +LEFT JOIN +JSON_TABLE(tt.c, '$' COLUMNS(o FOR ORDINALITY)) AS jt +ON tt.b = jt.o +ON t1.a = tt.b; +a b c o +1 1 {} 1 +2 2 [] NULL +SELECT * +FROM +t1 RIGHT JOIN +v2 AS tt +LEFT JOIN +JSON_TABLE(CONCAT(tt.c,''), '$' COLUMNS(o FOR ORDINALITY)) AS jt +ON tt.b = jt.o +ON t1.a = tt.b; +a b c o +1 1 {} 1 +2 2 [] NULL +DROP VIEW v2; +DROP TABLE t1, t2; +# # End of 10.6 tests # diff --git a/mysql-test/suite/json/t/json_table.test b/mysql-test/suite/json/t/json_table.test index 83cbe61b6ef..e91e89ab72f 100644 --- a/mysql-test/suite/json/t/json_table.test +++ b/mysql-test/suite/json/t/json_table.test @@ -644,6 +644,47 @@ WHERE drop table t1; +--echo # +--echo # MDEV-25381: JSON_TABLE: ER_WRONG_OUTER_JOIN upon query with LEFT and RIGHT joins and view +--echo # + +CREATE TABLE t1 (a INT); +INSERT INTO t1 VALUES (1),(2); + +CREATE TABLE t2 (b INT, c TEXT); +INSERT INTO t2 VALUES (1,'{}'),(2,'[]'); +CREATE VIEW v2 AS SELECT * FROM t2; + +SELECT * +FROM + t1 RIGHT JOIN + t2 AS tt + LEFT JOIN + JSON_TABLE(tt.c, '$' COLUMNS(o FOR ORDINALITY)) AS jt + ON tt.b = jt.o + ON t1.a = tt.b; + +SELECT * +FROM + t1 RIGHT JOIN + v2 AS tt + LEFT JOIN + JSON_TABLE(tt.c, '$' COLUMNS(o FOR ORDINALITY)) AS jt + ON tt.b = jt.o + ON t1.a = tt.b; + +SELECT * +FROM + t1 RIGHT JOIN + v2 AS tt + LEFT JOIN + JSON_TABLE(CONCAT(tt.c,''), '$' COLUMNS(o FOR ORDINALITY)) AS jt + ON tt.b = jt.o + ON t1.a = tt.b; + +DROP VIEW v2; +DROP TABLE t1, t2; + --echo # --echo # End of 10.6 tests --echo # diff --git a/sql/json_table.cc b/sql/json_table.cc index b89f6fecbd6..e8e50347fa7 100644 --- a/sql/json_table.cc +++ b/sql/json_table.cc @@ -1324,20 +1324,6 @@ int Table_function_json_table::setup(THD *thd, TABLE_LIST *sql_table, jc->m_field->charset= jc->m_explicit_cs; } } - - m_dep_tables= m_json->used_tables(); - - if (m_dep_tables) - { - t->no_cache= TRUE; - if (unlikely(m_dep_tables & sql_table->get_map())) - { - /* Table itself is used in the argument. */ - my_error(ER_WRONG_USAGE, MYF(0), "JSON_TABLE", "argument"); - return TRUE; - } - } - return FALSE; } @@ -1475,12 +1461,8 @@ int Table_function_json_table::print(THD *thd, TABLE_LIST *sql_table, void Table_function_json_table::fix_after_pullout(TABLE_LIST *sql_table, st_select_lex *new_parent, bool merge) { - sql_table->dep_tables&= ~m_dep_tables; - m_json->fix_after_pullout(new_parent, &m_json, merge); - m_dep_tables= m_json->used_tables(); - - sql_table->dep_tables|= m_dep_tables; + sql_table->dep_tables= used_tables(); } diff --git a/sql/json_table.h b/sql/json_table.h index 90fc667731f..04b0e6c07d2 100644 --- a/sql/json_table.h +++ b/sql/json_table.h @@ -208,8 +208,16 @@ class Table_function_json_table : public Sql_alloc st_select_lex *new_parent, bool merge); void update_used_tables() { m_json->update_used_tables(); } - table_map used_tables() const { return m_dep_tables; } - bool join_cache_allowed() const { return !m_dep_tables; } + table_map used_tables() const { return m_json->used_tables(); } + bool join_cache_allowed() const + { + /* + Can use join cache when we have an outside reference. + If there's dependency on any other table or randomness, + cannot use it. + */ + return !(used_tables() & ~OUTER_REF_TABLE_BIT); + } void get_estimates(ha_rows *out_rows, double *scan_time, double *startup_cost); @@ -242,13 +250,6 @@ class Table_function_json_table : public Sql_alloc /* Context to be used for resolving the first argument. */ Name_resolution_context *m_context; - /* - the JSON argument can be taken from other tables. - We have to mark these tables as dependent so the - mask of these dependent tables is calculated in ::setup(). - */ - table_map m_dep_tables; - /* Current NESTED PATH level being parsed */ Json_table_nested_path *cur_parent;

1 0

[Commits] a534d27a1c1: MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails
by psergey 12 Apr '21

12 Apr '21

revision-id: a534d27a1c110a868d434741910eafb678a2a0ea (mariadb-10.5.2-575-ga534d27a1c1) parent(s): f5f6af6bee4271f48c76a5b3724a974e426a5c70 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-12 16:22:18 +0300 message: MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails The query used a subquery of this form: SELECT ... WHERE EXISTS( SELECT ... FROM JSON_TABLE(outer_ref, ..) as JT WHERE trivial_correlation_cond) EXISTS-to-IN conversion code was unable to see that the subquery will still be correlated after the trivial_correlation is removed, which eventually caused a crash due to inability to construct a query plan. Fixed by making Item_subselect::walk() also walk arguments of Table Functions. --- mysql-test/suite/json/r/json_table.result | 16 +++++++++++++++ mysql-test/suite/json/t/json_table.test | 17 ++++++++++++++++ sql/item_subselect.cc | 33 +++++++++++++++++++++++++++++++ sql/json_table.cc | 6 ++++++ sql/json_table.h | 3 +++ 5 files changed, 75 insertions(+) diff --git a/mysql-test/suite/json/r/json_table.result b/mysql-test/suite/json/r/json_table.result index 9f1d1bce99e..d913da18c50 100644 --- a/mysql-test/suite/json/r/json_table.result +++ b/mysql-test/suite/json/r/json_table.result @@ -734,5 +734,21 @@ Shirt blue 20 Shirt white 20 drop table t1; # +# MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails +# +CREATE TABLE t1 (a INT, b TEXT); +INSERT INTO t1 VALUES (1,'{}'),(2,'[]'); +explain +SELECT * +FROM t1 +WHERE +EXISTS(SELECT * +FROM JSON_TABLE(b, '$' COLUMNS(o FOR ORDINALITY)) AS jt +WHERE jt.o = t1.a); +id select_type table type possible_keys key key_len ref rows Extra +1 PRIMARY t1 ALL NULL NULL NULL NULL 2 +1 PRIMARY jt ALL NULL NULL NULL NULL 40 Table function: json_table; Using where; FirstMatch(t1) +drop table t1; +# # End of 10.6 tests # diff --git a/mysql-test/suite/json/t/json_table.test b/mysql-test/suite/json/t/json_table.test index aa4e7397a6a..83cbe61b6ef 100644 --- a/mysql-test/suite/json/t/json_table.test +++ b/mysql-test/suite/json/t/json_table.test @@ -627,6 +627,23 @@ select t.item_name, jt.* from (select t1.item_name, concat(concat(concat("{\"col drop table t1; +--echo # +--echo # MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails +--echo # + +CREATE TABLE t1 (a INT, b TEXT); +INSERT INTO t1 VALUES (1,'{}'),(2,'[]'); + +explain +SELECT * +FROM t1 +WHERE + EXISTS(SELECT * + FROM JSON_TABLE(b, '$' COLUMNS(o FOR ORDINALITY)) AS jt + WHERE jt.o = t1.a); + +drop table t1; + --echo # --echo # End of 10.6 tests --echo # diff --git a/sql/item_subselect.cc b/sql/item_subselect.cc index 76b09efec17..e4e8bf2a1e8 100644 --- a/sql/item_subselect.cc +++ b/sql/item_subselect.cc @@ -719,6 +719,34 @@ bool Item_subselect::unknown_splocal_processor(void *argument) } +static +int walk_table_functions_for_list(Item_processor processor, + bool walk_subquery, void *argument, + List<TABLE_LIST>& join_list) +{ + List_iterator<TABLE_LIST> li(join_list); + int res; + while (TABLE_LIST *table= li++) + { + if (Table_function_json_table *tf= table->table_function) + { + if ((res= tf->walk_items(processor, walk_subquery, argument))) + { + return res; + } + } + if (table->nested_join) + { + if ((res= walk_table_functions_for_list(processor, walk_subquery, + argument, + table->nested_join->join_list))) + return res; + } + } + return 0; +} + + bool Item_subselect::walk(Item_processor processor, bool walk_subquery, void *argument) { @@ -751,6 +779,11 @@ bool Item_subselect::walk(Item_processor processor, bool walk_subquery, argument)) return 1; /* TODO: why does this walk WHERE/HAVING but not ON expressions of outer joins? */ + /* Consider walking ON epxression in walk_table_functions_for_list */ + + if (walk_table_functions_for_list(processor, walk_subquery, argument, + *lex->join_list)) + return 1; while ((item=li++)) { diff --git a/sql/json_table.cc b/sql/json_table.cc index dae1c694d78..b89f6fecbd6 100644 --- a/sql/json_table.cc +++ b/sql/json_table.cc @@ -1341,6 +1341,12 @@ int Table_function_json_table::setup(THD *thd, TABLE_LIST *sql_table, return FALSE; } +int Table_function_json_table::walk_items(Item_processor processor, + bool walk_subquery, void *argument) +{ + return m_json->walk(processor, walk_subquery, argument); +} + void Table_function_json_table::get_estimates(ha_rows *out_rows, double *scan_time, double *startup_cost) diff --git a/sql/json_table.h b/sql/json_table.h index 07d53c55638..90fc667731f 100644 --- a/sql/json_table.h +++ b/sql/json_table.h @@ -200,6 +200,9 @@ class Table_function_json_table : public Sql_alloc /*** Name resolution functions ***/ int setup(THD *thd, TABLE_LIST *sql_table, SELECT_LEX *s_lex); + int walk_items(Item_processor processor, bool walk_subquery, + void *argument); + /*** Functions for interaction with the Query Optimizer ***/ void fix_after_pullout(TABLE_LIST *sql_table, st_select_lex *new_parent, bool merge);

1 0

[Commits] 00be4236ebb: MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails
by psergey 12 Apr '21

12 Apr '21

revision-id: 00be4236ebb2ee64bf0438842164616cfb349ae8 (mariadb-10.5.2-575-g00be4236ebb) parent(s): f5f6af6bee4271f48c76a5b3724a974e426a5c70 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-12 16:18:21 +0300 message: MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails The query used subquery of this form: SELECT ... WHERE EXISTS( SELECT ... FROM JSON_TABLE(outer_ref, ..) as JT WHERE trivial_correlation_cond) EXISTS-to-IN conversion code was unable to see that the subquery will still be correlated after the trivial_correlation is removed, which eventually caused a crash due to unability to construct a query plan. Fixed by making Item_subselect::walk() also walk Table Functions's arguments. --- mysql-test/suite/json/r/json_table.result | 16 +++++++++++++++ mysql-test/suite/json/t/json_table.test | 17 ++++++++++++++++ sql/item_subselect.cc | 33 +++++++++++++++++++++++++++++++ sql/json_table.cc | 6 ++++++ sql/json_table.h | 3 +++ 5 files changed, 75 insertions(+) diff --git a/mysql-test/suite/json/r/json_table.result b/mysql-test/suite/json/r/json_table.result index 9f1d1bce99e..ed9f5f01026 100644 --- a/mysql-test/suite/json/r/json_table.result +++ b/mysql-test/suite/json/r/json_table.result @@ -734,5 +734,21 @@ Shirt blue 20 Shirt white 20 drop table t1; # +# MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails +# +CREATE TABLE t1 (a INT, b TEXT); +INSERT INTO t1 VALUES (1,'{}'),(2,'[]'); +explain +SELECT * +FROM t1 +WHERE +EXISTS(SELECT * +FROM JSON_TABLE(b, '$' COLUMNS(o FOR ORDINALITY)) AS jt +WHERE jt.o = t1.a); +id select_type table type possible_keys key key_len ref rows Extra +1 PRIMARY t1 ALL NULL NULL NULL NULL 2 +1 PRIMARY jt ALL NULL NULL NULL NULL 40 Table function: json_table; Using where; FirstMatch(t1) +drop table t1; +# # End of 10.6 tests # diff --git a/mysql-test/suite/json/t/json_table.test b/mysql-test/suite/json/t/json_table.test index aa4e7397a6a..83cbe61b6ef 100644 --- a/mysql-test/suite/json/t/json_table.test +++ b/mysql-test/suite/json/t/json_table.test @@ -627,6 +627,23 @@ select t.item_name, jt.* from (select t1.item_name, concat(concat(concat("{\"col drop table t1; +--echo # +--echo # MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails +--echo # + +CREATE TABLE t1 (a INT, b TEXT); +INSERT INTO t1 VALUES (1,'{}'),(2,'[]'); + +explain +SELECT * +FROM t1 +WHERE + EXISTS(SELECT * + FROM JSON_TABLE(b, '$' COLUMNS(o FOR ORDINALITY)) AS jt + WHERE jt.o = t1.a); + +drop table t1; + --echo # --echo # End of 10.6 tests --echo # diff --git a/sql/item_subselect.cc b/sql/item_subselect.cc index 76b09efec17..e4e8bf2a1e8 100644 --- a/sql/item_subselect.cc +++ b/sql/item_subselect.cc @@ -719,6 +719,34 @@ bool Item_subselect::unknown_splocal_processor(void *argument) } +static +int walk_table_functions_for_list(Item_processor processor, + bool walk_subquery, void *argument, + List<TABLE_LIST>& join_list) +{ + List_iterator<TABLE_LIST> li(join_list); + int res; + while (TABLE_LIST *table= li++) + { + if (Table_function_json_table *tf= table->table_function) + { + if ((res= tf->walk_items(processor, walk_subquery, argument))) + { + return res; + } + } + if (table->nested_join) + { + if ((res= walk_table_functions_for_list(processor, walk_subquery, + argument, + table->nested_join->join_list))) + return res; + } + } + return 0; +} + + bool Item_subselect::walk(Item_processor processor, bool walk_subquery, void *argument) { @@ -751,6 +779,11 @@ bool Item_subselect::walk(Item_processor processor, bool walk_subquery, argument)) return 1; /* TODO: why does this walk WHERE/HAVING but not ON expressions of outer joins? */ + /* Consider walking ON epxression in walk_table_functions_for_list */ + + if (walk_table_functions_for_list(processor, walk_subquery, argument, + *lex->join_list)) + return 1; while ((item=li++)) { diff --git a/sql/json_table.cc b/sql/json_table.cc index dae1c694d78..b89f6fecbd6 100644 --- a/sql/json_table.cc +++ b/sql/json_table.cc @@ -1341,6 +1341,12 @@ int Table_function_json_table::setup(THD *thd, TABLE_LIST *sql_table, return FALSE; } +int Table_function_json_table::walk_items(Item_processor processor, + bool walk_subquery, void *argument) +{ + return m_json->walk(processor, walk_subquery, argument); +} + void Table_function_json_table::get_estimates(ha_rows *out_rows, double *scan_time, double *startup_cost) diff --git a/sql/json_table.h b/sql/json_table.h index 07d53c55638..90fc667731f 100644 --- a/sql/json_table.h +++ b/sql/json_table.h @@ -200,6 +200,9 @@ class Table_function_json_table : public Sql_alloc /*** Name resolution functions ***/ int setup(THD *thd, TABLE_LIST *sql_table, SELECT_LEX *s_lex); + int walk_items(Item_processor processor, bool walk_subquery, + void *argument); + /*** Functions for interaction with the Query Optimizer ***/ void fix_after_pullout(TABLE_LIST *sql_table, st_select_lex *new_parent, bool merge);

1 0

[Commits] f5f6af6bee4: MDEV-25346: JSON_TABLE: Server crashes in Item_field::fix_outer_field ...
by psergey 12 Apr '21

12 Apr '21

revision-id: f5f6af6bee4271f48c76a5b3724a974e426a5c70 (mariadb-10.5.2-574-gf5f6af6bee4) parent(s): 0f14bc492c4409b61705b9c6a7a5bdb55301eefc author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-12 16:18:12 +0300 message: MDEV-25346: JSON_TABLE: Server crashes in Item_field::fix_outer_field ... Use a function instead of lambda (TODO: squash this with previous patch for MDEV-25346) --- sql/sql_derived.cc | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/sql/sql_derived.cc b/sql/sql_derived.cc index 90e0b6068f9..29741cb1adb 100644 --- a/sql/sql_derived.cc +++ b/sql/sql_derived.cc @@ -23,7 +23,6 @@ #include "mariadb.h" /* NO_EMBEDDED_ACCESS_CHECKS */ -#include <functional> #include "sql_priv.h" #include "unireg.h" #include "sql_derived.h" @@ -597,6 +596,25 @@ bool mysql_derived_init(THD *thd, LEX *lex, TABLE_LIST *derived) } +/* + @brief + Reset the Name_resolution_context::outer_context for all ON expression + contexts in the given nested join. Do this recursively for all nested joins + it contains. +*/ + +static void reset_on_clauses_context(List<TABLE_LIST>& join_list) +{ + List_iterator<TABLE_LIST> li(join_list); + while (TABLE_LIST *table= li++) + { + if (table->on_context) + table->on_context->outer_context= NULL; + if (table->nested_join) + reset_on_clauses_context(table->nested_join->join_list); + } +} + /* Create temporary table structure (but do not fill it) @@ -765,19 +783,7 @@ bool mysql_derived_prepare(THD *thd, LEX *lex, TABLE_LIST *derived) sl->context.outer_context= 0; // And for ON clauses, if there are any - std::function<void(List<TABLE_LIST>&)> reset_context= - [&](List<TABLE_LIST> &join_list) - { - List_iterator<TABLE_LIST> li(join_list); - while (TABLE_LIST *table= li++) - { - if (table->on_context) - table->on_context->outer_context= NULL; - if (table->nested_join) - reset_context(table->nested_join->join_list); - } - }; - reset_context(*sl->join_list); + reset_on_clauses_context(*sl->join_list); if (!derived->is_with_table_recursive_reference() || (!derived->with->with_anchor &&

1 0

[Commits] 1f6c8044ec1: MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails
by psergey 12 Apr '21

12 Apr '21

revision-id: 1f6c8044ec1e775585f82ee338948c6863e1e854 (mariadb-10.5.2-575-g1f6c8044ec1) parent(s): d220334dd9683386e4596591b778894e8e5d4919 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-12 14:11:37 +0300 message: MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails The query used subquery of this form: SELECT ... WHERE EXISTS( SELECT ... FROM JSON_TABLE(outer_ref, ..) as JT WHERE trivial_correlation_cond) EXISTS-to-IN conversion code was unable to see that the subquery will still be correlated after the trivial_correlation is removed, which eventually caused a crash due to unability to construct a query plan. Fixed by making Item_subselect::walk() also walk Table Functions's arguments. --- mysql-test/suite/json/r/json_table.result | 16 +++++++++++++++ mysql-test/suite/json/t/json_table.test | 17 ++++++++++++++++ sql/item_subselect.cc | 33 +++++++++++++++++++++++++++++++ sql/json_table.cc | 6 ++++++ sql/json_table.h | 3 +++ 5 files changed, 75 insertions(+) diff --git a/mysql-test/suite/json/r/json_table.result b/mysql-test/suite/json/r/json_table.result index 9f1d1bce99e..ed9f5f01026 100644 --- a/mysql-test/suite/json/r/json_table.result +++ b/mysql-test/suite/json/r/json_table.result @@ -734,5 +734,21 @@ Shirt blue 20 Shirt white 20 drop table t1; # +# MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails +# +CREATE TABLE t1 (a INT, b TEXT); +INSERT INTO t1 VALUES (1,'{}'),(2,'[]'); +explain +SELECT * +FROM t1 +WHERE +EXISTS(SELECT * +FROM JSON_TABLE(b, '$' COLUMNS(o FOR ORDINALITY)) AS jt +WHERE jt.o = t1.a); +id select_type table type possible_keys key key_len ref rows Extra +1 PRIMARY t1 ALL NULL NULL NULL NULL 2 +1 PRIMARY jt ALL NULL NULL NULL NULL 40 Table function: json_table; Using where; FirstMatch(t1) +drop table t1; +# # End of 10.6 tests # diff --git a/mysql-test/suite/json/t/json_table.test b/mysql-test/suite/json/t/json_table.test index aa4e7397a6a..83cbe61b6ef 100644 --- a/mysql-test/suite/json/t/json_table.test +++ b/mysql-test/suite/json/t/json_table.test @@ -627,6 +627,23 @@ select t.item_name, jt.* from (select t1.item_name, concat(concat(concat("{\"col drop table t1; +--echo # +--echo # MDEV-25380: JSON_TABLE: Assertion `join->best_read < double(1.797...) fails +--echo # + +CREATE TABLE t1 (a INT, b TEXT); +INSERT INTO t1 VALUES (1,'{}'),(2,'[]'); + +explain +SELECT * +FROM t1 +WHERE + EXISTS(SELECT * + FROM JSON_TABLE(b, '$' COLUMNS(o FOR ORDINALITY)) AS jt + WHERE jt.o = t1.a); + +drop table t1; + --echo # --echo # End of 10.6 tests --echo # diff --git a/sql/item_subselect.cc b/sql/item_subselect.cc index 76b09efec17..e4e8bf2a1e8 100644 --- a/sql/item_subselect.cc +++ b/sql/item_subselect.cc @@ -719,6 +719,34 @@ bool Item_subselect::unknown_splocal_processor(void *argument) } +static +int walk_table_functions_for_list(Item_processor processor, + bool walk_subquery, void *argument, + List<TABLE_LIST>& join_list) +{ + List_iterator<TABLE_LIST> li(join_list); + int res; + while (TABLE_LIST *table= li++) + { + if (Table_function_json_table *tf= table->table_function) + { + if ((res= tf->walk_items(processor, walk_subquery, argument))) + { + return res; + } + } + if (table->nested_join) + { + if ((res= walk_table_functions_for_list(processor, walk_subquery, + argument, + table->nested_join->join_list))) + return res; + } + } + return 0; +} + + bool Item_subselect::walk(Item_processor processor, bool walk_subquery, void *argument) { @@ -751,6 +779,11 @@ bool Item_subselect::walk(Item_processor processor, bool walk_subquery, argument)) return 1; /* TODO: why does this walk WHERE/HAVING but not ON expressions of outer joins? */ + /* Consider walking ON epxression in walk_table_functions_for_list */ + + if (walk_table_functions_for_list(processor, walk_subquery, argument, + *lex->join_list)) + return 1; while ((item=li++)) { diff --git a/sql/json_table.cc b/sql/json_table.cc index dae1c694d78..b89f6fecbd6 100644 --- a/sql/json_table.cc +++ b/sql/json_table.cc @@ -1341,6 +1341,12 @@ int Table_function_json_table::setup(THD *thd, TABLE_LIST *sql_table, return FALSE; } +int Table_function_json_table::walk_items(Item_processor processor, + bool walk_subquery, void *argument) +{ + return m_json->walk(processor, walk_subquery, argument); +} + void Table_function_json_table::get_estimates(ha_rows *out_rows, double *scan_time, double *startup_cost) diff --git a/sql/json_table.h b/sql/json_table.h index 07d53c55638..90fc667731f 100644 --- a/sql/json_table.h +++ b/sql/json_table.h @@ -200,6 +200,9 @@ class Table_function_json_table : public Sql_alloc /*** Name resolution functions ***/ int setup(THD *thd, TABLE_LIST *sql_table, SELECT_LEX *s_lex); + int walk_items(Item_processor processor, bool walk_subquery, + void *argument); + /*** Functions for interaction with the Query Optimizer ***/ void fix_after_pullout(TABLE_LIST *sql_table, st_select_lex *new_parent, bool merge);

1 0

[Commits] d220334dd96: MDEV-25346: JSON_TABLE: Server crashes in Item_field::fix_outer_field ...
by psergey 12 Apr '21

12 Apr '21

revision-id: d220334dd9683386e4596591b778894e8e5d4919 (mariadb-10.5.2-574-gd220334dd96) parent(s): 32c8059f11e7dcdf0ace538d10b6d7fb5d251807 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-12 13:16:20 +0300 message: MDEV-25346: JSON_TABLE: Server crashes in Item_field::fix_outer_field ... Use a function instead of lambda (TODO: squash this with previous patch for MDEV-25346) --- sql/sql_derived.cc | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/sql/sql_derived.cc b/sql/sql_derived.cc index 90e0b6068f9..29741cb1adb 100644 --- a/sql/sql_derived.cc +++ b/sql/sql_derived.cc @@ -23,7 +23,6 @@ #include "mariadb.h" /* NO_EMBEDDED_ACCESS_CHECKS */ -#include <functional> #include "sql_priv.h" #include "unireg.h" #include "sql_derived.h" @@ -597,6 +596,25 @@ bool mysql_derived_init(THD *thd, LEX *lex, TABLE_LIST *derived) } +/* + @brief + Reset the Name_resolution_context::outer_context for all ON expression + contexts in the given nested join. Do this recursively for all nested joins + it contains. +*/ + +static void reset_on_clauses_context(List<TABLE_LIST>& join_list) +{ + List_iterator<TABLE_LIST> li(join_list); + while (TABLE_LIST *table= li++) + { + if (table->on_context) + table->on_context->outer_context= NULL; + if (table->nested_join) + reset_on_clauses_context(table->nested_join->join_list); + } +} + /* Create temporary table structure (but do not fill it) @@ -765,19 +783,7 @@ bool mysql_derived_prepare(THD *thd, LEX *lex, TABLE_LIST *derived) sl->context.outer_context= 0; // And for ON clauses, if there are any - std::function<void(List<TABLE_LIST>&)> reset_context= - [&](List<TABLE_LIST> &join_list) - { - List_iterator<TABLE_LIST> li(join_list); - while (TABLE_LIST *table= li++) - { - if (table->on_context) - table->on_context->outer_context= NULL; - if (table->nested_join) - reset_context(table->nested_join->join_list); - } - }; - reset_context(*sl->join_list); + reset_on_clauses_context(*sl->join_list); if (!derived->is_with_table_recursive_reference() || (!derived->with->with_anchor &&

1 0

[Commits] a9620392134: MDEV-25346: JSON_TABLE: Server crashes in Item_field::fix_outer_field ...
by psergey 08 Apr '21

08 Apr '21

revision-id: a9620392134390344307ac7c832a5b8a1555d622 (mariadb-10.5.2-572-ga9620392134) parent(s): d81668299770cbe7c70af0030f25ca4242af5bb6 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-09 00:37:57 +0300 message: MDEV-25346: JSON_TABLE: Server crashes in Item_field::fix_outer_field ... mysql_derived_prepare() sets Name_resolution_context::outer_context=NULL for the WHERE clause's context. Do the same for all ON expressions, too. --- mysql-test/suite/json/r/json_table.result | 11 +++++++++++ mysql-test/suite/json/t/json_table.test | 14 ++++++++++++++ sql/sql_derived.cc | 18 ++++++++++++++++++ 3 files changed, 43 insertions(+) diff --git a/mysql-test/suite/json/r/json_table.result b/mysql-test/suite/json/r/json_table.result index 3910a5977a2..9f1d1bce99e 100644 --- a/mysql-test/suite/json/r/json_table.result +++ b/mysql-test/suite/json/r/json_table.result @@ -704,6 +704,17 @@ RIGHT JOIN JSON_TABLE('[]', '$' COLUMNS(o3 FOR ORDINALITY)) AS jt3 ON(1) WHERE 0; ERROR 42S22: Unknown column 'jt1.a' in 'JSON_TABLE argument' +# +# MDEV-25346: JSON_TABLE: Server crashes in Item_field::fix_outer_field upon subquery with unknown column +# +CREATE TABLE t1 (a INT); +CREATE TABLE t2 (b INT); +SELECT * FROM ( SELECT * FROM t1 JOIN t2 ON (b IN(SELECT x FROM (SELECT 1 AS c) AS sq1))) AS sq2; +ERROR 42S22: Unknown column 'x' in 'field list' +DROP TABLE t1, t2; +# +# Another testcase +# create table t1 (item_name varchar(32), item_props varchar(1024)); insert into t1 values ('Jeans', '{"color": ["green", "brown"], "price": 50}'); insert into t1 values ('Shirt', '{"color": ["blue", "white"], "price": 20}'); diff --git a/mysql-test/suite/json/t/json_table.test b/mysql-test/suite/json/t/json_table.test index f8198322d7d..aa4e7397a6a 100644 --- a/mysql-test/suite/json/t/json_table.test +++ b/mysql-test/suite/json/t/json_table.test @@ -601,6 +601,20 @@ JSON_TABLE('[]', '$' COLUMNS(a TEXT PATH '$[*]')) AS jt1 ON(1) WHERE 0; +--echo # +--echo # MDEV-25346: JSON_TABLE: Server crashes in Item_field::fix_outer_field upon subquery with unknown column +--echo # +CREATE TABLE t1 (a INT); +CREATE TABLE t2 (b INT); + +--error ER_BAD_FIELD_ERROR +SELECT * FROM ( SELECT * FROM t1 JOIN t2 ON (b IN(SELECT x FROM (SELECT 1 AS c) AS sq1))) AS sq2; + +DROP TABLE t1, t2; + +--echo # +--echo # Another testcase +--echo # create table t1 (item_name varchar(32), item_props varchar(1024)); insert into t1 values ('Jeans', '{"color": ["green", "brown"], "price": 50}'); insert into t1 values ('Shirt', '{"color": ["blue", "white"], "price": 20}'); diff --git a/sql/sql_derived.cc b/sql/sql_derived.cc index 35b4294707f..90e0b6068f9 100644 --- a/sql/sql_derived.cc +++ b/sql/sql_derived.cc @@ -23,6 +23,7 @@ #include "mariadb.h" /* NO_EMBEDDED_ACCESS_CHECKS */ +#include <functional> #include "sql_priv.h" #include "unireg.h" #include "sql_derived.h" @@ -760,7 +761,24 @@ bool mysql_derived_prepare(THD *thd, LEX *lex, TABLE_LIST *derived) /* prevent name resolving out of derived table */ for (SELECT_LEX *sl= first_select; sl; sl= sl->next_select()) { + // Prevent it for the WHERE clause sl->context.outer_context= 0; + + // And for ON clauses, if there are any + std::function<void(List<TABLE_LIST>&)> reset_context= + [&](List<TABLE_LIST> &join_list) + { + List_iterator<TABLE_LIST> li(join_list); + while (TABLE_LIST *table= li++) + { + if (table->on_context) + table->on_context->outer_context= NULL; + if (table->nested_join) + reset_context(table->nested_join->join_list); + } + }; + reset_context(*sl->join_list); + if (!derived->is_with_table_recursive_reference() || (!derived->with->with_anchor && !derived->with->is_with_prepared_anchor()))

1 0

[Commits] d8166829977: MDEV-25352: JSON_TABLE: Inconsistent name resolution and ER_VIEW_INVALID
by psergey 08 Apr '21

08 Apr '21

revision-id: d81668299770cbe7c70af0030f25ca4242af5bb6 (mariadb-10.5.2-571-gd8166829977) parent(s): 7cd264346f188cad6e781d87f379b1145000f28e author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-08 20:46:49 +0300 message: MDEV-25352: JSON_TABLE: Inconsistent name resolution and ER_VIEW_INVALID Add testcase --- mysql-test/suite/json/r/json_table.result | 19 +++++++++++++++++++ mysql-test/suite/json/t/json_table.test | 25 +++++++++++++++++++++++++ 2 files changed, 44 insertions(+) diff --git a/mysql-test/suite/json/r/json_table.result b/mysql-test/suite/json/r/json_table.result index da4eed6150e..3910a5977a2 100644 --- a/mysql-test/suite/json/r/json_table.result +++ b/mysql-test/suite/json/r/json_table.result @@ -675,6 +675,25 @@ json_table(JT.d, '$' COLUMNS (d for ordinality)) as JT2 ERROR 42S22: Unknown column 'JT2.d' in 'JSON_TABLE argument' drop table t1, t2; # +# MDEV-25352: JSON_TABLE: Inconsistent name resolution and ER_VIEW_INVALID ... +# (Just the testcase) +# +CREATE TABLE t1 (a INT, b VARCHAR(8)); +INSERT INTO t1 VALUES (1,'{}'),(2,'[]'); +CREATE TABLE t2 (a INT); +INSERT INTO t2 VALUES (2),(3); +SELECT t1.* +FROM +t1 NATURAL JOIN t2 +RIGHT JOIN +JSON_TABLE (t1.b, '$' COLUMNS(o FOR ORDINALITY)) AS jt ON (t1.a = jt.o) +WHERE t1.a = 1; +ERROR 42S22: Unknown column 't1.b' in 'JSON_TABLE argument' +CREATE OR REPLACE VIEW v AS +SELECT t1.* FROM t1 NATURAL JOIN t2 RIGHT JOIN JSON_TABLE (t1.b, '$' COLUMNS(o FOR ORDINALITY)) AS jt ON (t1.a = jt.o) WHERE t1.a = 1; +ERROR 42S22: Unknown column 't1.b' in 'JSON_TABLE argument' +drop table t1,t2; +# # MDEV-25256: JSON_TABLE: Error ER_VIEW_INVALID upon running query via view # SELECT * FROM diff --git a/mysql-test/suite/json/t/json_table.test b/mysql-test/suite/json/t/json_table.test index 37a88f1d1ee..f8198322d7d 100644 --- a/mysql-test/suite/json/t/json_table.test +++ b/mysql-test/suite/json/t/json_table.test @@ -563,6 +563,31 @@ select * from drop table t1, t2; +--echo # +--echo # MDEV-25352: JSON_TABLE: Inconsistent name resolution and ER_VIEW_INVALID ... +--echo # (Just the testcase) +--echo # + +CREATE TABLE t1 (a INT, b VARCHAR(8)); +INSERT INTO t1 VALUES (1,'{}'),(2,'[]'); + +CREATE TABLE t2 (a INT); +INSERT INTO t2 VALUES (2),(3); + +--error ER_BAD_FIELD_ERROR +SELECT t1.* +FROM + t1 NATURAL JOIN t2 + RIGHT JOIN + JSON_TABLE (t1.b, '$' COLUMNS(o FOR ORDINALITY)) AS jt ON (t1.a = jt.o) +WHERE t1.a = 1; + +--error ER_BAD_FIELD_ERROR +CREATE OR REPLACE VIEW v AS +SELECT t1.* FROM t1 NATURAL JOIN t2 RIGHT JOIN JSON_TABLE (t1.b, '$' COLUMNS(o FOR ORDINALITY)) AS jt ON (t1.a = jt.o) WHERE t1.a = 1; + +drop table t1,t2; + --echo # --echo # MDEV-25256: JSON_TABLE: Error ER_VIEW_INVALID upon running query via view --echo #

1 0

[Commits] 7cd264346f1: MDEV-25202: JSON_TABLE: Early table reference leads to unexpected result set
by psergey 08 Apr '21

08 Apr '21

revision-id: 7cd264346f188cad6e781d87f379b1145000f28e (mariadb-10.5.2-570-g7cd264346f1) parent(s): afada16d0bdaac63e514ea963104a67dd21ae644 author: Sergei Petrunia committer: Sergei Petrunia timestamp: 2021-04-08 20:21:34 +0300 message: MDEV-25202: JSON_TABLE: Early table reference leads to unexpected result set Followup: also handle NATURAL JOIN, extend the new approach with Name_resolution_context::ignored_tables --- mysql-test/suite/json/r/json_table.result | 17 +++++++++++++++++ mysql-test/suite/json/t/json_table.test | 21 +++++++++++++++++++++ sql/sql_acl.cc | 2 +- sql/sql_base.cc | 21 +++++++++++++-------- sql/sql_base.h | 4 ++-- 5 files changed, 54 insertions(+), 11 deletions(-) diff --git a/mysql-test/suite/json/r/json_table.result b/mysql-test/suite/json/r/json_table.result index de93d55087d..da4eed6150e 100644 --- a/mysql-test/suite/json/r/json_table.result +++ b/mysql-test/suite/json/r/json_table.result @@ -658,6 +658,23 @@ json_table((select concat(a,js) from t2), ERROR 42S22: Unknown column 'js' in 'field list' drop table t1,t2; # +# Now, a testcase with JSON_TABLEs inside NATURAL JOIN +# +create table t1 (a int, b int); +create table t2 (a int, c int); +select * from +t1, +( t2 +natural join +( +json_table(JT2.d, '$' COLUMNS (d for ordinality)) as JT +natural join +json_table(JT.d, '$' COLUMNS (d for ordinality)) as JT2 +) +); +ERROR 42S22: Unknown column 'JT2.d' in 'JSON_TABLE argument' +drop table t1, t2; +# # MDEV-25256: JSON_TABLE: Error ER_VIEW_INVALID upon running query via view # SELECT * FROM diff --git a/mysql-test/suite/json/t/json_table.test b/mysql-test/suite/json/t/json_table.test index 2520c1c97ba..37a88f1d1ee 100644 --- a/mysql-test/suite/json/t/json_table.test +++ b/mysql-test/suite/json/t/json_table.test @@ -542,6 +542,27 @@ from drop table t1,t2; +--echo # +--echo # Now, a testcase with JSON_TABLEs inside NATURAL JOIN +--echo # + +create table t1 (a int, b int); +create table t2 (a int, c int); + +--error ER_BAD_FIELD_ERROR +select * from + t1, + ( t2 + natural join + ( + json_table(JT2.d, '$' COLUMNS (d for ordinality)) as JT + natural join + json_table(JT.d, '$' COLUMNS (d for ordinality)) as JT2 + ) + ); + +drop table t1, t2; + --echo # --echo # MDEV-25256: JSON_TABLE: Error ER_VIEW_INVALID upon running query via view --echo # diff --git a/sql/sql_acl.cc b/sql/sql_acl.cc index 3785732b6a8..8f096f4074d 100644 --- a/sql/sql_acl.cc +++ b/sql/sql_acl.cc @@ -6966,7 +6966,7 @@ int mysql_table_grant(THD *thd, TABLE_LIST *table_list, Field *f=find_field_in_table_ref(thd, table_list, column->column.ptr(), column->column.length(), column->column.ptr(), NULL, NULL, - NULL, TRUE, FALSE, + table_map(0), NULL, TRUE, FALSE, &unused_field_idx, FALSE, &dummy); if (unlikely(f == (Field*)0)) { diff --git a/sql/sql_base.cc b/sql/sql_base.cc index c30c94fb799..a859f83c5f7 100644 --- a/sql/sql_base.cc +++ b/sql/sql_base.cc @@ -6097,7 +6097,8 @@ Field * find_field_in_table_ref(THD *thd, TABLE_LIST *table_list, const char *name, size_t length, const char *item_name, const char *db_name, - const char *table_name, Item **ref, + const char *table_name, table_map ignored_tables, + Item **ref, bool check_privileges, bool allow_rowid, uint *cached_field_index_ptr, bool register_tree_change, TABLE_LIST **actual_table) @@ -6189,9 +6190,11 @@ find_field_in_table_ref(THD *thd, TABLE_LIST *table_list, TABLE_LIST *table; while ((table= it++)) { + if (table->table && (table->table->map & ignored_tables)) + continue; if ((fld= find_field_in_table_ref(thd, table, name, length, item_name, - db_name, table_name, ref, - check_privileges, allow_rowid, + db_name, table_name, ignored_tables, + ref, check_privileges, allow_rowid, cached_field_index_ptr, register_tree_change, actual_table))) DBUG_RETURN(fld); @@ -6400,8 +6403,9 @@ find_field_in_tables(THD *thd, Item_ident *item, } else found= find_field_in_table_ref(thd, table_ref, name, length, item->name.str, - NULL, NULL, ref, check_privileges, - TRUE, &(item->cached_field_index), + NULL, NULL, ignored_tables, ref, + check_privileges, TRUE, + &(item->cached_field_index), register_tree_change, &actual_table); if (found) @@ -6471,7 +6475,8 @@ find_field_in_tables(THD *thd, Item_ident *item, continue; Field *cur_field= find_field_in_table_ref(thd, cur_table, name, length, - item->name.str, db, table_name, ref, + item->name.str, db, table_name, + ignored_tables, ref, (thd->lex->sql_command == SQLCOM_SHOW_FIELDS) ? false : check_privileges, @@ -6488,8 +6493,8 @@ find_field_in_tables(THD *thd, Item_ident *item, thd->clear_error(); cur_field= find_field_in_table_ref(thd, cur_table, name, length, - item->name.str, db, table_name, ref, - false, + item->name.str, db, table_name, + ignored_tables, ref, false, allow_rowid, &(item->cached_field_index), register_tree_change, diff --git a/sql/sql_base.h b/sql/sql_base.h index 765bf426b45..1836c07497a 100644 --- a/sql/sql_base.h +++ b/sql/sql_base.h @@ -202,8 +202,8 @@ Field * find_field_in_table_ref(THD *thd, TABLE_LIST *table_list, const char *name, size_t length, const char *item_name, const char *db_name, - const char *table_name, Item **ref, - bool check_privileges, bool allow_rowid, + const char *table_name, table_map ignored_tables, + Item **ref, bool check_privileges, bool allow_rowid, uint *cached_field_index_ptr, bool register_tree_change, TABLE_LIST **actual_table); Field *

1 0